Re: [PATCH 1/1] drm/amdkfd: Add missing NULL check in svm_range_map_to_gpu

2022-04-04 Thread Christian König
Am 05.04.22 um 08:45 schrieb Paul Menzel: Dear Philip, Am 04.04.22 um 23:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU. Fixes: 05fe8eeca92 (drm/amdgpu: fix TLB flushing during eviction) Sorry, where can I find that commit? Well that's expected, the development b

Re: [PATCH 1/1] drm/amdkfd: Add missing NULL check in svm_range_map_to_gpu

2022-04-04 Thread Paul Menzel
Dear Philip, Am 04.04.22 um 23:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU. Fixes: 05fe8eeca92 (drm/amdgpu: fix TLB flushing during eviction) Sorry, where can I find that commit? I do not see it in drm-next from agd5f git archive g...@gitlab.freedesktop.org:agd5

Re: [PATCH v2] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Christian König
Am 05.04.22 um 00:57 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state' was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_default_size' was not declared. Should it be static? Both symbols are only used

Re: [PATCH 1/1] drm/amdkfd: Add missing NULL check in svm_range_map_to_gpu

2022-04-04 Thread Christian König
Am 04.04.22 um 23:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU. Fixes: 05fe8eeca92 (drm/amdgpu: fix TLB flushing during eviction) Signed-off-by: Philip Yang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- 1 file changed, 1 insert

Re: [PATCH 1/1] drm/amdkfd: Add missing NULL check in svm_range_map_to_gpu

2022-04-04 Thread Felix Kuehling
Am 2022-04-04 um 17:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU. Fixes: 05fe8eeca92 (drm/amdgpu: fix TLB flushing during eviction) Signed-off-by: Philip Yang Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- 1 file changed, 1 inse

[PATCH 1/1] drm/amdkfd: Add missing NULL check in svm_range_map_to_gpu

2022-04-04 Thread Philip Yang
bo_adev is NULL for system memory mapping to GPU. Fixes: 05fe8eeca92 (drm/amdgpu: fix TLB flushing during eviction) Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/driv

Re: [PATCH 1/1] drm/amdgpu: Flush TLB after mapping for VG20+XGMI

2022-04-04 Thread philip yang
On 2022-04-04 15:46, Tomasz Moń wrote: On Mon, 2022-04-04 at 15:18 -0400, Alex Deucher wrote: On Mon, Apr 4, 2022 at 3:03 PM Tomasz Moń wrote: On top of what commit does this work? It does not apply at top of v5.18-rc1.

Re: [PATCH 1/1] drm/amdgpu: Flush TLB after mapping for VG20+XGMI

2022-04-04 Thread Tomasz Moń
On Mon, 2022-04-04 at 15:18 -0400, Alex Deucher wrote: > On Mon, Apr 4, 2022 at 3:03 PM Tomasz Moń wrote: > > On top of what commit does this work? > > > > It does not apply at top of v5.18-rc1. > > This is stuff for drm-next > (https://gitlab.freedesktop.org/agd5f/linux/-/commits/drm-next). > E

Re: AMDGPU: regression on 5.17.1

2022-04-04 Thread Michele Ballabio
On Mon, 4 Apr 2022 13:03:41 -0400 Alex Deucher wrote: > On Sun, Apr 3, 2022 at 10:19 AM Michele Ballabio > wrote: > > > > Hi, > > I've hit a regression on 5.17.1 (haven't tested 5.17.0, but > > 5.16-stable didn't have this problem). > > > > The machine is a Ryzen 5 1600 with AMD graphics

Re: [pull] amdgpu, amdkfd drm-next-5.18

2022-04-04 Thread Alex Deucher
On Fri, Mar 25, 2022 at 2:36 PM Alex Deucher wrote: > > Hi Dave, Daniel, > > Fixes for 5.18. Just wanted to make sure this didn't get missed. This fixes some warning splat reported by Linus, et al. Alex > > The following changes since commit c6e90a1c660874736bd09c1fec6312b4b4c2ff7b: > > Merg

Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only

2022-04-04 Thread Sierra Guiza, Alejandro (Alex)
On 4/4/2022 12:38 PM, Jason Gunthorpe wrote: On Fri, Apr 01, 2022 at 04:08:35PM -0400, Felix Kuehling wrote: In general I find the vm_normal_lru_page vs vm_normal_page API highly confusing. An explicit check for zone device pages in the dozen or so spots that care has a much better documenta

Re: [PATCH 1/1] drm/amdgpu: Flush TLB after mapping for VG20+XGMI

2022-04-04 Thread Alex Deucher
On Mon, Apr 4, 2022 at 3:03 PM Tomasz Moń wrote: > > On 4/1/22 21:57, Philip Yang wrote: > > For VG20 + XGMI bridge, all mappings PTEs cache in TC, this may have > > stall invalid PTEs in TC because one cache line has 8 pages. Need always > > flush_tlb after updating mapping. > > > > Signed-off-by

Re: [PATCH 1/1] drm/amdgpu: Flush TLB after mapping for VG20+XGMI

2022-04-04 Thread Tomasz Moń
On 4/1/22 21:57, Philip Yang wrote: For VG20 + XGMI bridge, all mappings PTEs cache in TC, this may have stall invalid PTEs in TC because one cache line has 8 pages. Need always flush_tlb after updating mapping. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++

Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only

2022-04-04 Thread Jason Gunthorpe
On Fri, Apr 01, 2022 at 04:08:35PM -0400, Felix Kuehling wrote: > > In general I find the vm_normal_lru_page vs vm_normal_page > > API highly confusing. An explicit check for zone device pages > > in the dozen or so spots that care has a much better documentation > > value, especially if accompan

Re: [PATCH 1/1] drm/amdgpu: Flush TLB after mapping for VG20+XGMI

2022-04-04 Thread Paul Menzel
Dear Philip, Thank you for your response. Am 04.04.22 um 18:52 schrieb philip yang: On 2022-04-04 12:19, Paul Menzel wrote: Am 01.04.22 um 21:57 schrieb Philip Yang: For VG20 + XGMI bridge, all mappings PTEs cache in TC, this may have stall invalid PTEs in TC because one cache line has 8

Re: [PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Tom Rix
On 4/4/22 8:22 AM, Harry Wentland wrote: On 2022-04-03 10:21, Tom Rix wrote: Smatch reports this issue hdcp1_execution.c:500:29: warning: function 'mod_hdcp_hdcp1_dp_execution' with external linkage has definition Which branch are you using? linux-next from 4/1 Tom I don't see t

Re: AMDGPU: regression on 5.17.1

2022-04-04 Thread Alex Deucher
On Sun, Apr 3, 2022 at 10:19 AM Michele Ballabio wrote: > > Hi, > I've hit a regression on 5.17.1 (haven't tested 5.17.0, but > 5.16-stable didn't have this problem). > > The machine is a Ryzen 5 1600 with AMD graphics (RX 560). > > The regression I hit seems to trigger when the machine is

Re: [PATCH 1/1] drm/amdgpu: Flush TLB after mapping for VG20+XGMI

2022-04-04 Thread Felix Kuehling
Am 2022-04-04 um 12:19 schrieb Paul Menzel: Dear Philip, Thank you for your patch. Am 01.04.22 um 21:57 schrieb Philip Yang: For VG20 + XGMI bridge, all mappings PTEs cache in TC, this may have stall invalid PTEs in TC because one cache line has 8 pages. Need always Can you please rephras

Re: [PATCH 1/1] drm/amdgpu: Flush TLB after mapping for VG20+XGMI

2022-04-04 Thread philip yang
On 2022-04-04 12:19, Paul Menzel wrote: Dear Philip, Thank you for your patch. Am 01.04.22 um 21:57 schrieb Philip Yang: For VG20 + XGMI bridge, all mappings PTEs cache in TC, this may have

[linux-next:master] BUILD REGRESSION 696206280c5e5c028caf9fd259999cb72b1f6127

2022-04-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 696206280c5e5c028caf9fd25cb72b1f6127 Add linux-next specific files for 20220404 Error/Warning reports: https://lore.kernel.org/linux-media/202203170501.ahquekof-...@intel.com https

Re: [PATCH 1/1] drm/amdgpu: Flush TLB after mapping for VG20+XGMI

2022-04-04 Thread Paul Menzel
Dear Philip, Thank you for your patch. Am 01.04.22 um 21:57 schrieb Philip Yang: For VG20 + XGMI bridge, all mappings PTEs cache in TC, this may have stall invalid PTEs in TC because one cache line has 8 pages. Need always Can you please rephrase. “may have stall …” is really hard to underst

Re: [PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Harry Wentland
On 2022-04-04 11:43, Tom Rix wrote: > > On 4/4/22 8:22 AM, Harry Wentland wrote: >> >> On 2022-04-03 10:21, Tom Rix wrote: >>> Smatch reports this issue >>> hdcp1_execution.c:500:29: warning: function >>>    'mod_hdcp_hdcp1_dp_execution' with external linkage >>>    has definition >>> >> Which

Re: [PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Harry Wentland
On 2022-04-03 10:21, Tom Rix wrote: > Smatch reports this issue > hdcp1_execution.c:500:29: warning: function > 'mod_hdcp_hdcp1_dp_execution' with external linkage > has definition > Which branch are you using? I don't see the 'extern' on https://gitlab.freedesktop.org/agd5f/linux/-/blob/

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Tom Rix
On 4/4/22 6:32 AM, Christian König wrote: Am 04.04.22 um 15:01 schrieb Tom Rix: On 4/4/22 5:34 AM, Christian König wrote: Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:1

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Christian König
Am 04.04.22 um 15:01 schrieb Tom Rix: On 4/4/22 5:34 AM, Christian König wrote: Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Tom Rix
On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_default_size'    was not declared. Sho

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Tom Rix
On 4/4/22 5:34 AM, Christian König wrote: Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was not declared. Should it be static? s

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Christian König
Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_

Regression: No signal when loading amdgpu, and system lockup (was: [PATCH V4 17/17] drm/amd/pm: unified lock protections in amdgpu_dpm.c)

2022-04-04 Thread Paul Menzel
#regzbot introduced: 3712e7a494596b26861f4dc9b81676d1d0272eaf #regzbot title: No signal when loading amdgpu, and system lockup #regzbot monitor: https://gitlab.freedesktop.org/drm/amd/-/issues/1957 Dear Arthur, Thank you for your message. Too bad you didn’t update the subject, and didn’t inclu

Re: [Bug][5.18-rc0] Between commits ed4643521e6a and 34af78c4e616, appears warning "WARNING: CPU: 31 PID: 51848 at drivers/dma-buf/dma-fence-array.c:191 dma_fence_array_create+0x101/0x120" and some ga

2022-04-04 Thread Christian König
Am 04.04.22 um 10:22 schrieb Paul Menzel: Dear Christian, Am 04.04.22 um 08:30 schrieb Christian König: those are two independent and already known problems. The warning triggered from the sync_file is already fixed in drm-misc-next-fixes, but so far I couldn't figure out why the games sud

Re: [Bug][5.18-rc0] Between commits ed4643521e6a and 34af78c4e616, appears warning "WARNING: CPU: 31 PID: 51848 at drivers/dma-buf/dma-fence-array.c:191 dma_fence_array_create+0x101/0x120" and some ga

2022-04-04 Thread Paul Menzel
Dear Christian, Am 04.04.22 um 08:30 schrieb Christian König: those are two independent and already known problems. The warning triggered from the sync_file is already fixed in drm-misc-next-fixes, but so far I couldn't figure out why the games suddenly doesn't work any more. There is a b

Re: AMDGPU: regression on 5.17.1

2022-04-04 Thread Thorsten Leemhuis
[TLDR: I'm adding the regression report below to regzbot, the Linux kernel regression tracking bot; all text you find below is compiled from a few templates paragraphs you might have encountered already already from similar mails.] Hi, this is your Linux kernel regression tracker. On 03.04.22 13:

[PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Tom Rix
Smatch reports this issue hdcp1_execution.c:500:29: warning: function 'mod_hdcp_hdcp1_dp_execution' with external linkage has definition The storage-class-specifier extern is not needed in a definition, so remove it. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_

AMDGPU: regression on 5.17.1

2022-04-04 Thread Michele Ballabio
Hi, I've hit a regression on 5.17.1 (haven't tested 5.17.0, but 5.16-stable didn't have this problem). The machine is a Ryzen 5 1600 with AMD graphics (RX 560). The regression I hit seems to trigger when the machine is left idle at boot (I don't boot straight to X, I boot to a tty, login

[PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Tom Rix
Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state' was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_default_size' was not declared. Should it be static? Both symbols are only used in si.c. Single file symbols should be s

[PATCH] drm/radeon/combios: Prepare cleanup of powerpc's asm/prom.h

2022-04-04 Thread Christophe Leroy
powerpc's asm/prom.h brings some headers that it doesn't need itself. In order to clean it up, first add missing headers in users of asm/prom.h Signed-off-by: Christophe Leroy --- drivers/gpu/drm/radeon/radeon_combios.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/r