Am 21.04.22 um 04:15 schrieb Wang, Yang(Kevin):
[AMD Official Use Only]
*From:* Kuehling, Felix
*Sent:* Thursday, April 21, 2022 5:21 AM
*To:* Lazar, Lijo ; Koenig, Christian
; Wang, Yang(Kevin)
; Christian König
;
Dear Richard,
Am 21.04.22 um 03:12 schrieb Gong, Richard:
On 4/20/2022 3:29 PM, Paul Menzel wrote:
Am 19.04.22 um 23:46 schrieb Gong, Richard:
On 4/14/2022 2:52 AM, Paul Menzel wrote:
[Cc: -kernel test robot ]
[…]
Am 13.04.22 um 15:00 schrieb Alex Deucher:
On Wed, Apr 13, 2022 at 3:
On Wed, Apr 20, 2022 at 5:48 PM Alice Wong wrote:
>
> If at any point psp_hw_init failed, psp_hw_fini would not be called
> during unload due to ip_blocks[PSP].status.hw not being set to true.
> This could cause a memory leak when the driver unloads.
> As a rule of thumb, each IP block should clea
[AMD Official Use Only]
Reviewed-by: Evan Quan
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Thursday, April 21, 2022 11:16 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Michele Ballabio
>
> Subject: [PATCH] drm/amdgpu: don't runtime suspe
Should be v3, fixed locally.
Alex
On Wed, Apr 20, 2022 at 11:16 PM Alex Deucher wrote:
>
> We normally runtime suspend when there are displays attached if they
> are in the DPMS off state, however, if something wakes the GPU
> we send a hotplug event on resume (in case any displays were connecte
We normally runtime suspend when there are displays attached if they
are in the DPMS off state, however, if something wakes the GPU
we send a hotplug event on resume (in case any displays were connected
while the GPU was in suspend) which can cause userspace to light
up the displays again soon afte
On Wed, Apr 20, 2022 at 10:54 PM Quan, Evan wrote:
>
> [AMD Official Use Only]
>
>
>
> > -Original Message-
> > From: amd-gfx On Behalf Of Alex
> > Deucher
> > Sent: Thursday, April 14, 2022 4:15 AM
> > To: amd-gfx@lists.freedesktop.org
> > Cc: Deucher, Alexander ; Michele Ballabio
> >
>
[AMD Official Use Only]
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Thursday, April 14, 2022 4:15 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Michele Ballabio
>
> Subject: [PATCH] drm/amdgpu: don't runtime suspend if there are displays
[AMD Official Use Only]
From: Kuehling, Felix
Sent: Thursday, April 21, 2022 5:21 AM
To: Lazar, Lijo ; Koenig, Christian
; Wang, Yang(Kevin) ;
Christian König ;
dri-de...@lists.freedesktop.org ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: fi
The smu_v1X_0_set_allowed_mask() uses bitmap_copy() to convert
bitmap to 32-bit array. This may be wrong due to endianness issues.
Fix it by switching to bitmap_{from,to}_arr32.
Signed-off-by: Yury Norov
---
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 2 +-
drivers/gpu/drm/amd/pm/swsmu/smu1
Hi Paul,
On 4/20/2022 3:29 PM, Paul Menzel wrote:
Dear Richard,
Am 19.04.22 um 23:46 schrieb Gong, Richard:
On 4/14/2022 2:52 AM, Paul Menzel wrote:
[Cc: -kernel test robot ]
[…]
Am 13.04.22 um 15:00 schrieb Alex Deucher:
On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel wrote:
Thank you
Hey! Figured I'd check if there's been any status updates here since it's been
a while, just to make sure I haven't dropped this issue from my radar. No
problem if you're busy :)
On Wed, 2022-03-16 at 10:46 +, Lin, Wayne wrote:
> [Public]
>
> > -Original Message-
> > From: Lyude Paul
- In the latest version of the header, there is a variable name change.
This should not cause any backward compatibility since the variable is
at the same offset in the struct.
Signed-off-by: Bokun Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgv
- Clean up the identation in the header file
Signed-off-by: Bokun Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 70 ++---
1 file changed, 34 insertions(+), 36 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
b/drivers/gpu/drm/amd/amdgpu/amdgv_srio
- Update MIT license header
Signed-off-by: Bokun Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 25 ++---
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
index 7326
If at any point psp_hw_init failed, psp_hw_fini would not be called
during unload due to ip_blocks[PSP].status.hw not being set to true.
This could cause a memory leak when the driver unloads.
As a rule of thumb, each IP block should cleanup themselves when
their hw_init fails. Only previously inti
On 2022-04-20 09:23, Lazar, Lijo wrote:
On 4/20/2022 6:26 PM, Christian König wrote:
Am 20.04.22 um 14:54 schrieb Wang, Yang(Kevin):
[AMD Official Use Only]
Hi Chris,
1) Change the test case to use something larger than 1TiB.
sure, we can increase the size of BO and make test pass,
but
[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Wednesday, April 20, 2022 16:14
> To: Paul Menzel
> Cc: Gong, Richard ; Dave Airlie ;
> Pan, Xinhui ; LKML ;
> Maling list - DRI developers ; amd-gfx list
> ; Daniel Vetter ; Deucher,
> Alexander ; Koenig, Christian
> ; Limonci
On Wed, Apr 20, 2022 at 5:13 PM Gong, Richard wrote:
>
>
> On 4/20/2022 4:02 PM, Paul Menzel wrote:
> > Dear Richard,
> >
> >
> > Am 20.04.22 um 22:56 schrieb Gong, Richard:
> >
> >> On 4/20/2022 3:48 PM, Paul Menzel wrote:
> >
> >>> Am 20.04.22 um 22:40 schrieb Alex Deucher:
> On Wed, Apr 20
On Wed, Apr 20, 2022 at 5:02 PM Paul Menzel wrote:
>
> Dear Richard,
>
>
> Am 20.04.22 um 22:56 schrieb Gong, Richard:
>
> > On 4/20/2022 3:48 PM, Paul Menzel wrote:
>
> >> Am 20.04.22 um 22:40 schrieb Alex Deucher:
> >>> On Wed, Apr 20, 2022 at 4:29 PM Paul Menzel
> >>> wrote:
> >>
> Am 19.
On 4/20/2022 4:02 PM, Paul Menzel wrote:
Dear Richard,
Am 20.04.22 um 22:56 schrieb Gong, Richard:
On 4/20/2022 3:48 PM, Paul Menzel wrote:
Am 20.04.22 um 22:40 schrieb Alex Deucher:
On Wed, Apr 20, 2022 at 4:29 PM Paul Menzel
wrote:
Am 19.04.22 um 23:46 schrieb Gong, Richard:
On
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: f1244c81da13009dbf61cb807f45881501c44789 Add linux-next specific
files for 20220420
Error/Warning reports:
https://lore.kernel.org/linux-mm/202204081656.6x4pfen4-...@intel.com
https
Hi Evan and Mukul,
You both made changes recently involving the pm.mutex and the
topology_lock respectively. I'm now seeing a circular lock dependency
between those locks (see below) that could potentially lead to a
deadlock. This cycle also involves the mmap_lock and some file-system
related
Dear Richard,
Am 20.04.22 um 22:56 schrieb Gong, Richard:
On 4/20/2022 3:48 PM, Paul Menzel wrote:
Am 20.04.22 um 22:40 schrieb Alex Deucher:
On Wed, Apr 20, 2022 at 4:29 PM Paul Menzel
wrote:
Am 19.04.22 um 23:46 schrieb Gong, Richard:
On 4/14/2022 2:52 AM, Paul Menzel wrote:
[Cc:
Hi Paul,
On 4/20/2022 3:48 PM, Paul Menzel wrote:
Dear Alex,
Am 20.04.22 um 22:40 schrieb Alex Deucher:
On Wed, Apr 20, 2022 at 4:29 PM Paul Menzel
wrote:
Am 19.04.22 um 23:46 schrieb Gong, Richard:
On 4/14/2022 2:52 AM, Paul Menzel wrote:
[Cc: -kernel test robot ]
[…]
Am 13.04.22
Dear Alex,
Am 20.04.22 um 22:40 schrieb Alex Deucher:
On Wed, Apr 20, 2022 at 4:29 PM Paul Menzel wrote:
Am 19.04.22 um 23:46 schrieb Gong, Richard:
On 4/14/2022 2:52 AM, Paul Menzel wrote:
[Cc: -kernel test robot ]
[…]
Am 13.04.22 um 15:00 schrieb Alex Deucher:
On Wed, Apr 13, 2022
On Wed, Apr 20, 2022 at 4:29 PM Paul Menzel wrote:
>
> Dear Richard,
>
>
> Am 19.04.22 um 23:46 schrieb Gong, Richard:
>
> > On 4/14/2022 2:52 AM, Paul Menzel wrote:
> >> [Cc: -kernel test robot ]
>
> […]
>
> >> Am 13.04.22 um 15:00 schrieb Alex Deucher:
> >>> On Wed, Apr 13, 2022 at 3:43 AM Paul
Dear Richard,
Am 19.04.22 um 23:46 schrieb Gong, Richard:
On 4/14/2022 2:52 AM, Paul Menzel wrote:
[Cc: -kernel test robot ]
[…]
Am 13.04.22 um 15:00 schrieb Alex Deucher:
On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel wrote:
Thank you for sending out v4.
Am 12.04.22 um 23:50 schrieb Ri
Dear Alice,
Thank you for your patch.
Am 20.04.22 um 21:37 schrieb Alice Wong:
Call psp_hw_fini when psp_hw_init failed.
Please amend the commit message, and add the motivation/reasoning too [1].
I think it’s common, if a patch (series) is rerolled to list the changes
between the versions.
Call psp_hw_fini when psp_hw_init failed.
Signed-off-by: Alice Wong
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 57 +
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index
On Wed, 2022-04-20 at 20:56 +0200, Christian König wrote:
> ⚠ External Email
>
> Am 20.04.22 um 20:49 schrieb Christian König:
> > Am 20.04.22 um 20:41 schrieb Zack Rusin:
> > > On Wed, 2022-04-20 at 19:40 +0200, Christian König wrote:
> > > > Am 20.04.22 um 19:38 schrieb Zack Rusin:
> > > > > On
Call psp_hw_fini when psp_hw_init failed.
BUG:SWDEV-332449
Signed-off-by: Alice Wong
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 57 +
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/drivers/gpu/drm/amd/amdgpu/a
Am 20.04.22 um 20:49 schrieb Christian König:
Am 20.04.22 um 20:41 schrieb Zack Rusin:
On Wed, 2022-04-20 at 19:40 +0200, Christian König wrote:
Am 20.04.22 um 19:38 schrieb Zack Rusin:
On Wed, 2022-04-20 at 09:37 +0200, Christian König wrote:
⚠ External Email
Hi Zack,
Am 20.04.22 um 05:56
Am 20.04.22 um 20:41 schrieb Zack Rusin:
On Wed, 2022-04-20 at 19:40 +0200, Christian König wrote:
Am 20.04.22 um 19:38 schrieb Zack Rusin:
On Wed, 2022-04-20 at 09:37 +0200, Christian König wrote:
⚠ External Email
Hi Zack,
Am 20.04.22 um 05:56 schrieb Zack Rusin:
On Thu, 2022-04-07 at 10:5
I retested hot plug tests at the commit I mentioned bellow - looks ok,
my ASIC is Navi 10, I also tested using Vega 10 and older Polaris ASICs
(whatever i had at home at the time). It's possible there are extra
issues in ASICs like ur which I didn't cover during tests.
andrey@andrey-test:~/drm
On Wed, 2022-04-20 at 19:40 +0200, Christian König wrote:
>
> Am 20.04.22 um 19:38 schrieb Zack Rusin:
> > On Wed, 2022-04-20 at 09:37 +0200, Christian König wrote:
> > > ⚠ External Email
> > >
> > > Hi Zack,
> > >
> > > Am 20.04.22 um 05:56 schrieb Zack Rusin:
> > > > On Thu, 2022-04-07 at 10:5
Am 20.04.22 um 19:38 schrieb Zack Rusin:
On Wed, 2022-04-20 at 09:37 +0200, Christian König wrote:
⚠ External Email
Hi Zack,
Am 20.04.22 um 05:56 schrieb Zack Rusin:
On Thu, 2022-04-07 at 10:59 +0200, Christian König wrote:
Rework the internals of the dma_resv object to allow adding more
tha
On Wed, 2022-04-20 at 09:37 +0200, Christian König wrote:
> ⚠ External Email
>
> Hi Zack,
>
> Am 20.04.22 um 05:56 schrieb Zack Rusin:
> > On Thu, 2022-04-07 at 10:59 +0200, Christian König wrote:
> > > Rework the internals of the dma_resv object to allow adding more
> > > than
> > > one
> > > wr
On 2022-04-19 22:32, Lang Yu wrote:
This reverts commit a129dbca92edaeb5a515a0e5b63ada71cf9b981a.
It causes SVM regressions on Vega10 with XNACK-ON. Just revert it
at the moment.
./kfdtest --gtest_filter=KFDSVMRangeTest.MigratePolicyTest
Reviewed-by: Phi
The only one in Radeon 7 I see is the same sysfs crash we already fixed
so you can use the same fix. The MI 200 issue i haven't seen yet but I
also haven't tested MI200 so never saw it before. Need to test when i
get the time.
So try that fix with Radeon 7 again to see if you pass the tests (t
I could ack it, but I'm absolutely not an expert on that stuff.
Our DC team maybe? Or anybody working more on the PM code?
Christian.
Am 20.04.22 um 15:57 schrieb Alex Deucher:
Ping? Anyone care to review this?
Alex
On Tue, Apr 19, 2022 at 9:47 AM Alex Deucher wrote:
Ping?
On Wed, Apr 13
Ping? Anyone care to review this?
Alex
On Tue, Apr 19, 2022 at 9:47 AM Alex Deucher wrote:
>
> Ping?
>
> On Wed, Apr 13, 2022 at 4:15 PM Alex Deucher
> wrote:
> >
> > We normally runtime suspend when there are displays attached if they
> > are in the DPMS off state, however, if something wake
On 4/20/2022 6:26 PM, Christian König wrote:
Am 20.04.22 um 14:54 schrieb Wang, Yang(Kevin):
[AMD Official Use Only]
Hi Chris,
1) Change the test case to use something larger than 1TiB.
sure, we can increase the size of BO and make test pass,
but if user really want to allocate 1TB GTT BO
[AMD Official Use Only]
From: Koenig, Christian
Sent: Wednesday, April 20, 2022 8:56 PM
To: Wang, Yang(Kevin) ; Christian König
; dri-de...@lists.freedesktop.org
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: fix ttm tt init fail when size exc
[AMD Official Use Only]
Hi Chris,
1) Change the test case to use something larger than 1TiB.
sure, we can increase the size of BO and make test pass,
but if user really want to allocate 1TB GTT BO, we have no reason to let it
fail? right?
the system availed memory about 2T, but it will still fai
[AMD Official Use Only]
Hi Chirs,
yes, right, the amdgpu drive rwill use amdgpu_bo_validate_size() function to
verify bo size,
but when driver try to allocate VRAM domain bo fail, the amdgpu driver will
fall back to allocate domain = (GTT | VRAM) bo.
please check following code, it will cause
Hi Kevin,
no, the test case should already fail in amdgpu_bo_validate_size().
If we have a system with 2TiB of memory where the test case could
succeed then we should increase the requested size to something larger.
And if the underlying core Linux kernel functions don't allow
allocations as
[AMD Official Use Only]
Hi Chris,
you misunderstood background about this case.
although we expect this test case to fail, it should fail at the location where
the Bo actual memory is actually allocated. now the code logic will cause the
failure to allocate memory to store DMA address.
e.g: t
The fatal error handler is independent from general ras interrupt
handler since there is no related IH ring.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 15 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 20
drivers/gpu/drm/amd/amdgpu/amd
Add support for general RAS poison consumption handler.
v2: remove callback function for poison consumption.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 34 +
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 1 +
2 files changed, 35 insertions(+)
dif
Prepare for the implementation of poison consumption handler.
v2: separate umc handler from poison creation.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 70 -
1 file changed, 44 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/amd/am
v1:
Add debugfs support to load/unload/invoke TA in runtime.
v2:
1. Update some variables to static.
2. Use PAGE_ALIGN to calculate shared buf size directly.
3. Remove fp check.
4. Update debugfs from read to write.
Signed-off-by: John Clements
Signed-off-by: Candice Li
---
drivers/gpu/drm/amd
The upcoming TA debugfs interface needs to use indirect buffer
when performing TA invoke and check psp response status for TA
load and invoke.
Signed-off-by: John Clements
Signed-off-by: Candice Li
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 54 +
drivers/gpu/drm/amd/a
Am 20.04.22 um 11:07 schrieb Wang, Yang(Kevin):
[AMD Official Use Only]
*From:* Koenig, Christian
*Sent:* Wednesday, April 20, 2022 5:00 PM
*To:* Wang, Yang(Kevin) ;
dri-de...@lists.freedesktop.org ;
amd-gfx@lists.fre
[AMD Official Use Only]
From: Koenig, Christian
Sent: Wednesday, April 20, 2022 5:00 PM
To: Wang, Yang(Kevin) ; dri-de...@lists.freedesktop.org
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: fix ttm tt init fail when size exceeds kmalloc
limit
Am 20.04.22 um 10:56 schrieb Yang Wang:
if the __GFP_ZERO is set, the kvmalloc() can't fallback to use vmalloc()
Hui what? Why should kvmalloc() not be able to fallback to vmalloc()
when __GFP_ZERO is set?
And even that is really the case then that sounds like a bug in kvmalloc().
Regards,
if the __GFP_ZERO is set, the kvmalloc() can't fallback to use vmalloc()
to allocate memory, when request size is exceeds kmalloc limit, it will
cause allocate memory fail.
e.g: when ttm want to create a BO with 1TB size, it maybe fail.
Signed-off-by: Yang Wang
---
drivers/gpu/drm/ttm/ttm_tt.c
[Public]
> -Original Message-
> From: Lazar, Lijo
> Sent: Wednesday, April 20, 2022 11:39 AM
> To: Liang, Prike ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Huang, Ray
>
> Subject: Re: [PATCH] drm/amdgpu: keep mmhub clock gating being enabled
> during s2idle suspend
>
>
>
>
Am 19.04.22 um 21:59 schrieb Alex Deucher:
On Tue, Apr 19, 2022 at 3:38 PM Alice Wong wrote:
amdgpu_device_ip_hw_init_phase1 and amdgpu_device_ip_hw_init_phase2
call IP blocks' respective hw_fini when hw_init failed.
I don't think we should call hw_fini() if hw_init() failed. If there
are thi
Hi Zack,
Am 20.04.22 um 05:56 schrieb Zack Rusin:
On Thu, 2022-04-07 at 10:59 +0200, Christian König wrote:
Rework the internals of the dma_resv object to allow adding more than
one
write fence and remember for each fence what purpose it had.
This allows removing the workaround from amdgpu whi
60 matches
Mail list logo
