Hi Tao,
I'm thinking of checking ip block first because we might want to leverage this
interrupt handler as a common entry for other RAS interrupt as well. In such
case, it looks more clearer if we check the ip block first.
I agree with you either way looks good.
You can have my RB for
[AMD Official Use Only]
Hi Hawking,
The logic in my patch is:
if (poison)
if (umc)
poison_creation_handler
else
poison_consumption_handler
else
if (umc)
umc_handler
else
not supported
I think your suggestion is:
if (umc)
if (poison)
[AMD Official Use Only]
From: Kuehling, Felix
Sent: Thursday, April 21, 2022 10:55 PM
To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdkfd: use kvcalloc() instead of kvmalloc() in
kfd_migrate
Am 2022-04-21 um 08:33 schrieb
On Thu, 2022-04-21 at 12:17 +0200, Christian König wrote:
> ⚠ External Email
>
> Am 20.04.22 um 21:28 schrieb Zack Rusin:
> > [SNIP]
> > > To figure out what it is could you try the following code
> > > fragment:
> > >
> > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c
> > >
MEC firmware sometimes sends signal interrupts without a valid context ID
on end of pipe events that don't intend to signal any HSA signals.
This triggers the slow path in kfd_signal_event_interrupt that scans the
entire event page for signaled events. Detect these signals in the top
half
Am 2022-04-19 um 20:47 schrieb Philip Yang:
Change SVM range mapping flags or access attributes don't trigger
migration, if range is already mapped on GPUs we should update GPU
mapping, and pass flush_tlb flag to amdgpu vm.
Signed-off-by: Philip Yang
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c
On 04/21, Harry Wentland wrote:
>
>
> On 2022-04-21 10:37, Melissa Wen wrote:
> > Hi all,
> >
> > I'm examining how DRM color management properties (degamma, ctm, gamma)
> > are applied to AMD display drivers. As far I could understand thanks
> > Nicholas documentation on
On 2022-04-21 10:10, Alex Deucher wrote:
It's not used outside of dcn31_hubp.c.
Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
---
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
On Wed, Apr 20, 2022 at 6:47 PM Bokun Zhang wrote:
>
> - Clean up the identation in the header file
>
> Signed-off-by: Bokun Zhang
> ---
> drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 70 ++---
> 1 file changed, 34 insertions(+), 36 deletions(-)
>
> diff --git
Am 2022-04-21 um 08:33 schrieb Yang Wang:
simplify programming with existing functions.
Signed-off-by: Yang Wang
Reviewed-by: Felix Kuehling
There is one more kvmalloc_array call with GFP_ZERO that could be
replaced with kvcalloc in svm_range_dma_map_dev in kfd_svm.c. Maybe fix
that one
[AMD Official Use Only]
Hi Tao,
I was thinking more aggressive change - current amdgpu_ras_interrupt_handler
only serves as umc poison (poison mode) or uncorrectable error handler (fue
mode).
We can still keep it as a unified entry point, but how about check ip block
first, then if it is
On Thu, Apr 21, 2022 at 8:33 AM Yang Wang wrote:
>
> simplify programming with existing functions.
>
> Signed-off-by: Yang Wang
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 15 +++
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git
Hi all,
I'm examining how DRM color management properties (degamma, ctm, gamma)
are applied to AMD display drivers. As far I could understand thanks
Nicholas documentation on amdgpu_dm/amdgpu_dm_color, DC drivers have
per-plane color correction features:
* - Input gamma LUT (de-normalized)
* -
[Public]
Thanks,
Candice
-Original Message-
From: Lazar, Lijo
Sent: Thursday, April 21, 2022 7:01 PM
To: Li, Candice ; amd-gfx@lists.freedesktop.org
Cc: Clements, John
Subject: Re: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke
support
On 4/21/2022 4:08 PM, Li,
Applied. Thanks!
Alex
On Thu, Apr 21, 2022 at 5:03 AM Miaoqian Lin wrote:
>
> When dcn20_clk_src_construct() fails, we need to release clk_src.
>
> Fixes: 6f4e6361c3ff ("drm/amd/display: Add Renoir resource (v2)")
> Signed-off-by: Miaoqian Lin
> ---
>
On Thu, Apr 21, 2022 at 9:06 AM Thorsten Leemhuis
wrote:
>
> On 21.04.22 05:16, Alex Deucher wrote:
> > We normally runtime suspend when there are displays attached if they
> > are in the DPMS off state, however, if something wakes the GPU
> > we send a hotplug event on resume (in case any
Applied. Thanks!
Alex
On Thu, Apr 21, 2022 at 6:29 AM Haowen Bai wrote:
>
> aux_rep only memset but no use at all, so we drop it.
>
> Signed-off-by: Haowen Bai
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git
It's not used outside of dcn31_hubp.c.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubp.c
b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubp.c
aux_rep only memset but no use at all, so we drop it.
Signed-off-by: Haowen Bai
---
drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
index
On 21.04.22 05:16, Alex Deucher wrote:
> We normally runtime suspend when there are displays attached if they
> are in the DPMS off state, however, if something wakes the GPU
> we send a hotplug event on resume (in case any displays were connected
> while the GPU was in suspend) which can cause
When dcn20_clk_src_construct() fails, we need to release clk_src.
Fixes: 6f4e6361c3ff ("drm/amd/display: Add Renoir resource (v2)")
Signed-off-by: Miaoqian Lin
---
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 11.04.22 10:54, Evan Quan wrote:
> The adev->pm.mutx is already held at the beginning of
> amdgpu_dpm_compute_clocks/amdgpu_dpm_enable_uvd/amdgpu_dpm_enable_vce.
> But on their calling path, amdgpu_display_bandwidth_update will be
> called and thus its sub functions amdgpu_dpm_get_sclk/mclk.
[AMD Official Use Only]
From: Koenig, Christian
Sent: Thursday, April 21, 2022 8:48 PM
To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org
; dri-de...@lists.freedesktop.org
Cc: Kuehling, Felix ; Lazar, Lijo
Subject: Re: [PATCH] drm/ttm: use kvcalloc()
Am 21.04.22 um 14:34 schrieb Yang Wang:
simplify programming with existing functions.
Signed-off-by: Yang Wang
With a minimal style change reviewed and pushed to drm-misc-next.
Thanks,
Christian.
---
drivers/gpu/drm/ttm/ttm_tt.c | 21 -
1 file changed, 12
simplify programming with existing functions.
Signed-off-by: Yang Wang
---
drivers/gpu/drm/ttm/ttm_tt.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
index 79c870a3bef8..cbb3d1fb4caf 100644
simplify programming with existing functions.
Signed-off-by: Yang Wang
---
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
index
Hi Dave,
just a gentle ping on that one here since it looks like it was missed
because of the eastern holidays.
I have general DRM/TTM changes I want to publish and need the amdgpu
changes in drm-next so that we don't run into any merge conflicts.
Thanks,
Christian.
Am 15.04.22 um 15:51
On 4/21/2022 4:08 PM, Li, Candice wrote:
[Public]
Thanks,
Candice
-Original Message-
From: Lazar, Lijo
Sent: Thursday, April 21, 2022 6:03 PM
To: Li, Candice ; amd-gfx@lists.freedesktop.org
Cc: Clements, John
Subject: Re: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA
[Public]
Thanks,
Candice
-Original Message-
From: Lazar, Lijo
Sent: Thursday, April 21, 2022 6:03 PM
To: Li, Candice ; amd-gfx@lists.freedesktop.org
Cc: Clements, John
Subject: Re: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke
support
On 4/21/2022 3:28 PM, Li,
Am 20.04.22 um 21:28 schrieb Zack Rusin:
[SNIP]
To figure out what it is could you try the following code fragment:
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c
index f46891012be3..a36f89d3f36d 100644
---
On 4/21/2022 3:28 PM, Li, Candice wrote:
[Public]
Thanks,
Candice
-Original Message-
From: Lazar, Lijo
Sent: Thursday, April 21, 2022 5:23 PM
To: Li, Candice ; amd-gfx@lists.freedesktop.org
Cc: Clements, John
Subject: Re: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA
[Public]
Thanks,
Candice
-Original Message-
From: Lazar, Lijo
Sent: Thursday, April 21, 2022 5:23 PM
To: Li, Candice ; amd-gfx@lists.freedesktop.org
Cc: Clements, John
Subject: Re: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke
support
On 4/20/2022 4:43 PM,
On 4/20/2022 4:43 PM, Candice Li wrote:
v1:
Add debugfs support to load/unload/invoke TA in runtime.
v2:
1. Update some variables to static.
2. Use PAGE_ALIGN to calculate shared buf size directly.
3. Remove fp check.
4. Update debugfs from read to write.
Signed-off-by: John Clements
[AMD Official Use Only]
Series is
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Candice Li
Sent: Wednesday, April 20, 2022 19:14
To: amd-gfx@lists.freedesktop.org
Cc: Li, Candice ; Clements, John
Subject: [PATCH v2 2/2] drm/amdgpu: Add
The series is:
Reviewed-by: Tao Zhou
Make sure the series is checked by checkpatch.pl.
> -Original Message-
> From: amd-gfx On Behalf Of Candice
> Li
> Sent: Wednesday, April 20, 2022 7:14 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Li, Candice ; Clements, John
>
> Subject: [PATCH
Am 21.04.22 um 04:15 schrieb Wang, Yang(Kevin):
[AMD Official Use Only]
*From:* Kuehling, Felix
*Sent:* Thursday, April 21, 2022 5:21 AM
*To:* Lazar, Lijo ; Koenig, Christian
; Wang, Yang(Kevin)
; Christian König
;
36 matches
Mail list logo
