[PATCH 2/2] drm/amdgpu: use the callback function for reset status polling on IMU

2022-05-19 Thread Huang Rui
Switch to use the callback function to poll the reset status on IMU. Because it will have different sequency on other ASICs. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu_imu.h | 1 + drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 35 - 2 files changed, 23

[PATCH 1/2] drm/amdgpu: introduce two work mode for imu

2022-05-19 Thread Huang Rui
IMU has two work mode such as debug mode and mission mode. Current GC v11_0_0 is using the debug mode. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu_imu.h | 6 + drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 1 + drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 30

Re: [PATCH 1/2] drm/amdgpu: remove acc_size from reserve/unreserve mem

2022-05-19 Thread Felix Kuehling
Am 2022-05-19 um 12:21 schrieb Alex Sierra: TTM used to track the "acc_size" of all BOs internally. We needed to keep track of it in our memory reservation to avoid TTM running out of memory in its own accounting. However, that "acc_size" accounting has since been removed from TTM. Therefore

Re: [PATCH 2/2] drm/amdkfd: track unified memory reservation with xnack off

2022-05-19 Thread Felix Kuehling
Am 2022-05-19 um 12:21 schrieb Alex Sierra: [WHY] Unified memory with xnack off should be tracked, as userptr mappings and legacy allocations do. To avoid oversuscribe system memory when xnack off. [How] Exposing functions reserve_mem_limit and unreserve_mem_limit to SVM API and call them on

Re: [PATCH] drm/amdgpu: Off by one in dm_dmub_outbox1_low_irq()

2022-05-19 Thread Harry Wentland
On 2022-05-16 03:05, Dan Carpenter wrote: > The > ARRAY_SIZE() should be >= ARRAY_SIZE() to prevent an out of bounds > access. > > Fixes: e27c41d5b068 ("drm/amd/display: Support for DMUB HPD interrupt > handling") > Signed-off-by: Dan Carpenter Reviewed-by: Harry Wentland Harry > --- >

Re: [PATCH v2] drm/amd/display: add Coverage blend mode for overlay plane

2022-05-19 Thread Harry Wentland
Fixing amd-gfx address. On 2022-05-19 16:42, Harry Wentland wrote: > > > On 2022-05-13 16:22, Sung Joon Kim wrote: >> Issue fixed: Overlay plane alpha channel blending is incorrect >> >> Issue tracker: https://gitlab.freedesktop.org/drm/amd/-/issues/1769 >> >> According to the KMS man page,

Re: [PATCH v2] drm/amd/display: add Coverage blend mode for overlay plane

2022-05-19 Thread Melissa Wen
On 05/13, Sung Joon Kim wrote: > Issue fixed: Overlay plane alpha channel blending is incorrect > > Issue tracker: https://gitlab.freedesktop.org/drm/amd/-/issues/1769 > > According to the KMS man page, there is a > "Coverage" alpha blend mode that assumes the > pixel color values have NOT been

Re: [PATCH 2/2] drm/amdkfd: track unified memory reservation with xnack off

2022-05-19 Thread philip yang
On 2022-05-19 12:21, Alex Sierra wrote: [WHY] Unified memory with xnack off should be tracked, as userptr mappings and legacy allocations do. To avoid oversuscribe system memory when xnack off. [How] Exposing functions reserve_mem_limit and unreserve_mem_limit to

Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3

2022-05-19 Thread Andrew Morton
On Wed, 18 May 2022 20:41:27 -0700 Guenter Roeck wrote: > On 5/18/22 17:55, kernel test robot wrote: > > tree/branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > branch HEAD: 736ee37e2e8eed7fe48d0a37ee5a709514d478b3 Add linux-next > > specific files for

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-19 Thread Alex Deucher
On Thu, May 19, 2022 at 1:15 PM Felix Kuehling wrote: > > > Am 2022-05-19 um 10:34 schrieb Alex Deucher: > > The current somewhat strange logic is in place because certain > > GL unit tests for large textures can cause problems with the > > OOM killer since there is no way to link this memory to

[RFC] drm/amd: Reset ASIC on GPU resume failure

2022-05-19 Thread Mario Limonciello
Is the resume failed, it's unlikely that the GPU will be usable. Reset the ASIC in hopes that it will be able to recover from the problem. Link:

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-19 Thread Felix Kuehling
Am 2022-05-19 um 10:34 schrieb Alex Deucher: The current somewhat strange logic is in place because certain GL unit tests for large textures can cause problems with the OOM killer since there is no way to link this memory to a process. The problem is this limit is often too low for many

[PATCH 2/2] drm/amdkfd: track unified memory reservation with xnack off

2022-05-19 Thread Alex Sierra
[WHY] Unified memory with xnack off should be tracked, as userptr mappings and legacy allocations do. To avoid oversuscribe system memory when xnack off. [How] Exposing functions reserve_mem_limit and unreserve_mem_limit to SVM API and call them on every prange creation and free. Signed-off-by:

[PATCH 1/2] drm/amdgpu: remove acc_size from reserve/unreserve mem

2022-05-19 Thread Alex Sierra
TTM used to track the "acc_size" of all BOs internally. We needed to keep track of it in our memory reservation to avoid TTM running out of memory in its own accounting. However, that "acc_size" accounting has since been removed from TTM. Therefore we don't really need to track it any more.

[PATCH] drm/amdgpu: Adjust logic around GTT size (v2)

2022-05-19 Thread Alex Deucher
Certain GL unit tests for large textures can cause problems with the OOM killer since there is no way to link this memory to a process. This was originally mitigated (but not necessarily eliminated) by limiting the GTT size. The problem is this limit is often too low for many modern games so

Re: [PATCH v2 00/19] DC/DM changes needed for amdgpu PSR-SU

2022-05-19 Thread Harry Wentland
Patches 1-18 are Reviewed-by: Harry Wentland Patch 19 needs a bit more of a patch description. Harry On 5/10/22 16:44, David Zhang wrote: > changes in v2: > --- > - set vsc_packet_rev2 for PSR1 which is safer > - add exposure of AMD specific DPCD regs for PSR-SU-RC

Re: [PATCH v2 19/19] drm/amd/display: PSR-SU rate control support in DC

2022-05-19 Thread Harry Wentland
On 5/10/22 16:45, David Zhang wrote: > [why & how] > We need to add the necessary DC codes to support PSR-SU rate > control (RC). We'll probably want to expand a bit on what rate control is and also note that this is just adding core functionality for RC but not enabling it. Harry > >

Re: [PATCH 2/2] drm/amdkfd: track unified memory reservation with xnack off

2022-05-19 Thread Felix Kuehling
Am 2022-05-19 um 10:01 schrieb philip yang: On 2022-05-18 17:40, Felix Kuehling wrote: On 2022-05-18 14:36, philip yang wrote: On 2022-05-17 19:11, Alex Sierra wrote: [WHY] Unified memory with xnack off should be tracked, as userptr mappings and legacy allocations do. To avoid

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-19 Thread Andrey Grodzovsky
See this patch-set https://www.spinics.net/lists/amd-gfx/msg78514.html, specifically patch 'drm/amdgpu: Switch to delayed work from work_struct. I will just reiterate here - We need to be able to do non blocking cancel pending reset works from within GPU reset. Currently kernel API allows this

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-19 Thread Lai Jiangshan
On Thu, May 19, 2022 at 9:57 PM Andrey Grodzovsky wrote: > > This reverts commit 6417250d3f894e66a68ba1cd93676143f2376a6f > and exports the function. > > We need this funtion in amdgpu driver to fix a bug. Hello, Could you specify the reason why it is needed in amdgpu driver rather than "fix a

[PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-19 Thread Alex Deucher
The current somewhat strange logic is in place because certain GL unit tests for large textures can cause problems with the OOM killer since there is no way to link this memory to a process. The problem is this limit is often too low for many modern games on systems with more memory so limit the

Re: [PATCH 1/2] drm/amdgpu: remove acc_size from reserve/unreserve mem

2022-05-19 Thread philip yang
On 2022-05-18 17:31, Felix Kuehling wrote: On 2022-05-18 13:55, philip yang wrote: On 2022-05-17 19:11, Alex Sierra wrote: TTM used to track the "acc_size" of all BOs internally. We needed to

Re: [PATCH 2/2] drm/amdkfd: track unified memory reservation with xnack off

2022-05-19 Thread philip yang
On 2022-05-18 17:40, Felix Kuehling wrote: On 2022-05-18 14:36, philip yang wrote: On 2022-05-17 19:11, Alex Sierra wrote: [WHY] Unified memory with xnack off should be

[PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-19 Thread Andrey Grodzovsky
This reverts commit 6417250d3f894e66a68ba1cd93676143f2376a6f and exports the function. We need this funtion in amdgpu driver to fix a bug. Signed-off-by: Andrey Grodzovsky --- include/linux/workqueue.h | 1 + kernel/workqueue.c| 9 + 2 files changed, 10 insertions(+) diff

Re: [PATCH v2 0/7] Fix multiple GPU resets in XGMI hive.

2022-05-19 Thread Andrey Grodzovsky
On 2022-05-19 03:58, Christian König wrote: Am 18.05.22 um 16:24 schrieb Andrey Grodzovsky: On 2022-05-18 02:07, Christian König wrote: Am 17.05.22 um 21:20 schrieb Andrey Grodzovsky: Problem: During hive reset caused by command timing out on a ring extra resets are generated by

Re: [PATCH] drm/amdgpu: suppress some compile warnings

2022-05-19 Thread Alex Deucher
On Thu, May 19, 2022 at 5:32 AM Evan Quan wrote: > > Suppress two compile warnings about "no previous prototype". > > Reported-by: kernel test robot > Signed-off-by: Evan Quan Reviewed-by: Alex Deucher > Change-Id: I74d029c6ebd8bf6bc08edada7a992d04786330d8 > --- >

[CI 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-19 Thread Bhanuprakash Modem
As drm_connector already have the display_info, instead of creating "output_bpc" debugfs in vendor specific driver, move the logic to the drm layer. This patch will also move "Current" bpc to the crtc debugfs from connector debugfs, since we are getting this info from crtc_state. Cc: Harry

[CI 2/3] drm/i915/display/debug: Expose crtc current bpc via debugfs

2022-05-19 Thread Bhanuprakash Modem
This new debugfs will expose the currently using bpc by crtc. It is very useful for verifying whether we enter the correct output color depth from IGT. This patch will also add the connector's max supported bpc to "i915_display_info" debugfs. Example: cat

[CI 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-05-19 Thread Bhanuprakash Modem
It's useful to know the connector's max supported bpc for IGT testing. Expose it via a debugfs file on the connector "output_bpc". Example: cat /sys/kernel/debug/dri/0/DP-1/output_bpc V2: * Fix typo in comments (Harry) Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Signed-off-by:

[CI 0/3] Expose max and current bpc via debugfs

2022-05-19 Thread Bhanuprakash Modem
This series will expose the Connector's max supported bpc via connector debugfs and Crtc's current bpc via crtc debugfs. Also move the existing vendor specific "output_bpc" logic to drm. Bhanuprakash Modem (3): drm/debug: Expose connector's max supported bpc via debugfs

[PATCH] drm/amdgpu: suppress some compile warnings

2022-05-19 Thread Evan Quan
Suppress two compile warnings about "no previous prototype". Reported-by: kernel test robot Signed-off-by: Evan Quan Change-Id: I74d029c6ebd8bf6bc08edada7a992d04786330d8 --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +- drivers/gpu/drm/amd/amdgpu/soc21.c| 1 + 2 files

Re: [PATCH 01/14] ACPI: video: Add a native function parameter to acpi_video_get_backlight_type()

2022-05-19 Thread Jani Nikula
On Wed, 18 May 2022, Hans de Goede wrote: > Hi, > > On 5/18/22 10:55, Jani Nikula wrote: >> On Tue, 17 May 2022, Hans de Goede wrote: >>> ATM on x86 laptops where we want userspace to use the acpi_video backlight >>> device we often register both the GPU's native backlight device and >>>

Re: [PATCH v2 0/7] Fix multiple GPU resets in XGMI hive.

2022-05-19 Thread Christian König
Am 18.05.22 um 16:24 schrieb Andrey Grodzovsky: On 2022-05-18 02:07, Christian König wrote: Am 17.05.22 um 21:20 schrieb Andrey Grodzovsky: Problem: During hive reset caused by command timing out on a ring extra resets are generated by triggered by KFD which is unable to accesses registers

Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3

2022-05-19 Thread Guenter Roeck
On 5/18/22 17:55, kernel test robot wrote: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 736ee37e2e8eed7fe48d0a37ee5a709514d478b3 Add linux-next specific files for 20220518 Error/Warning reports:

Re: [PATCH] drm/amd/pm: Fix missing thermal throttler status

2022-05-19 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Reviewed-by Yang Wang Regards, Kevin 发件人: amd-gfx 代表 Lijo Lazar 发送时间: 星期四, 五月 19, 2022 13:28 收件人: amd-gfx@lists.freedesktop.org 抄送: Deucher, Alexander ; Zhang, Hawking 主题: [PATCH] drm/amd/pm: Fix missing thermal throttler