Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-20 Thread Andrey Grodzovsky
On 2022-05-20 03:52, Tejun Heo wrote: On Fri, May 20, 2022 at 08:22:39AM +0200, Christian König wrote: Am 20.05.22 um 02:47 schrieb Lai Jiangshan: On Thu, May 19, 2022 at 11:04 PM Andrey Grodzovsky wrote: See this patch-set https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-20 Thread Marek Olšák
We don't have to care about case 2 here. Broken apps will be handled by app profiles. The problem is that some games don't work with the current limit on the most powerful consumer APU we've ever made (Rembrandt) with precisely the games that the APU was made for, and instead of increasing the limi

Re: [PATCH v2 12/13] tools: add hmm gup tests for device coherent type

2022-05-20 Thread Felix Kuehling
On 2022-05-16 19:14, Alex Sierra wrote: The intention is to test hmm device coherent type under different get user pages paths. Also, test gup with FOLL_LONGTERM flag set in device coherent pages. These pages should get migrated back to system memory. Signed-off-by: Alex Sierra Reviewed-by: A

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-20 Thread Felix Kuehling
On 2022-05-20 05:42, Christian König wrote: In theory we should allow much more than that. The problem is just that we can't. We have the following issues: 1. For swapping out stuff we need to make sure that we can allocate temporary pages.     Because of this TTM has a fixed 50% limit where i

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-20 Thread Christian König
Am 20.05.22 um 19:41 schrieb Bas Nieuwenhuizen: On Fri, May 20, 2022 at 11:42 AM Christian König wrote: In theory we should allow much more than that. The problem is just that we can't. We have the following issues: 1. For swapping out stuff we need to make sure that we can allocate temporary

RE: [PATCH] drm/amdgpu: Adjust logic around GTT size (v3)

2022-05-20 Thread Russell, Kent
[AMD Official Use Only - General] I'll defer to Felix/Christian for the actual change, but a small typo in a comment: > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, May 20, 2022 11:09 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Su

Re: [PATCH v2] drm/amd/display: add Coverage blend mode for overlay plane

2022-05-20 Thread Harry Wentland
> > On 2022-05-19 16:42, Harry Wentland wrote: >> >> >> On 2022-05-13 16:22, Sung Joon Kim wrote: >>> Issue fixed: Overlay plane alpha channel blending is incorrect >>> >>> Issue tracker: https://gitlab.freedesktop.org/drm/amd/-/issues/1769 >>> >>> According to the KMS man page, there is a "Co

RE: [PATCH v2] drm/amd/display: add Coverage blend mode for overlay plane

2022-05-20 Thread Kim, Sung joon
[AMD Official Use Only - General] -Original Message- From: Wentland, Harry Sent: Thursday, May 19, 2022 4:45 PM To: Kim, Sung joon ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Deucher, Alexander ; Koenig, Christian Cc: m...@igalia.com; cont...@emersion.fr; markyac...@chromium.org; amd-g

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-20 Thread Bas Nieuwenhuizen
On Fri, May 20, 2022 at 11:42 AM Christian König wrote: > > In theory we should allow much more than that. The problem is just that we > can't. > > We have the following issues: > 1. For swapping out stuff we need to make sure that we can allocate temporary > pages. > Because of this TTM has

Re: [PATCH 2/2] drm/amdkfd: track unified memory reservation with xnack off

2022-05-20 Thread Sierra Guiza, Alejandro (Alex)
On 5/20/2022 10:12 AM, Felix Kuehling wrote: Am 2022-05-20 um 08:45 schrieb philip yang: On 2022-05-19 19:08, Felix Kuehling wrote: Am 2022-05-19 um 12:21 schrieb Alex Sierra: [WHY] Unified memory with xnack off should be tracked, as userptr mappings and legacy allocations do. To avoid ov

Re: [PATCH 2/2] drm/amdkfd: track unified memory reservation with xnack off

2022-05-20 Thread Felix Kuehling
Am 2022-05-20 um 08:45 schrieb philip yang: On 2022-05-19 19:08, Felix Kuehling wrote: Am 2022-05-19 um 12:21 schrieb Alex Sierra: [WHY] Unified memory with xnack off should be tracked, as userptr mappings and legacy allocations do. To avoid oversuscribe system memory when xnack off. [How]

[PATCH] drm/amdgpu: Adjust logic around GTT size (v3)

2022-05-20 Thread Alex Deucher
Certain GL unit tests for large textures can cause problems with the OOM killer since there is no way to link this memory to a process. This was originally mitigated (but not necessarily eliminated) by limiting the GTT size. The problem is this limit is often too low for many modern games so just

Re: [PATCH] drm/amdgpu: Skip init fbdev if virtual_display is enabled

2022-05-20 Thread Alex Deucher
On Fri, May 20, 2022 at 10:49 AM Slivka, Danijel wrote: > > [AMD Official Use Only - General] > > But for virtual display enabled we are not using display capability so > shouldn't it be considered as hw without DCE. I thought the goal of virtual DCE was for it to be just like real DCE. Why woul

RE: [PATCH] drm/amdgpu: Skip init fbdev if virtual_display is enabled

2022-05-20 Thread Slivka, Danijel
[AMD Official Use Only - General] But for virtual display enabled we are not using display capability so shouldn't it be considered as hw without DCE. BR, Danijel Slivka -Original Message- From: Alex Deucher Sent: Friday, May 20, 2022 4:33 PM To: Slivka, Danijel Cc: amd-gfx list Subj

Re: [PATCH] drm/amdgpu: Off by one in dm_dmub_outbox1_low_irq()

2022-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 19, 2022 at 4:53 PM Harry Wentland wrote: > > On 2022-05-16 03:05, Dan Carpenter wrote: > > The > ARRAY_SIZE() should be >= ARRAY_SIZE() to prevent an out of bounds > > access. > > > > Fixes: e27c41d5b068 ("drm/amd/display: Support for DMUB HPD interrupt > > h

Re: [PATCH] drm/amdgpu: Skip init fbdev if virtual_display is enabled

2022-05-20 Thread Alex Deucher
On Fri, May 20, 2022 at 10:12 AM Slivka, Danijel wrote: > > [AMD Official Use Only - General] > > Hi, > > Based on the code we shouldn't init the fbdev on hw without DCE: That comment means don't init fbdev on chips without display hardware (either real or virtual). E.g., iceland or MI100. Alex

Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-20 Thread Sharma, Shashank
On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Added device coredump information: - Kernel version - Module - Time - VRAM status - Guilty process name and PID - GPU register dumps Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++ drivers/gpu/

RE: [PATCH] drm/amdgpu: Skip init fbdev if virtual_display is enabled

2022-05-20 Thread Slivka, Danijel
[AMD Official Use Only - General] Hi, Based on the code we shouldn't init the fbdev on hw without DCE: /* * 1. don't init fbdev on hw without DCE * 2. don't init fbdev if there are no connectors */ if (adev->mode_info.mode_config_initialized &&

Re: [PATCH v1 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-20 Thread Sharma, Shashank
Hey Amar, On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Allocate memory for register value and use the same values for devcoredump. Remove dump_stack reset register dumps. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/am

[PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-20 Thread Somalapuram Amaranath
Added device coredump information: - Kernel version - Module - Time - VRAM status - Guilty process name and PID - GPU register dumps Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 59 ++

[PATCH v1 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-20 Thread Somalapuram Amaranath
Allocate memory for register value and use the same values for devcoredump. Remove dump_stack reset register dumps. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 9 - drivers/gpu/drm/amd/amdgpu/am

Re: [PATCH] drm/amdgpu: Skip init fbdev if virtual_display is enabled

2022-05-20 Thread Alex Deucher
On Fri, May 20, 2022 at 3:59 AM Danijel Slivka wrote: > > In case virtaul_display is enabled there is no hw DCE so > need to skip setting up fbdev. Wouldn't you theoretically still want fbdev even if it is virtual? Alex > > Signed-off-by: Danijel Slivka > --- > drivers/gpu/drm/amd/amdgpu/amdg

[PATCH] drm/amdgpu: Resolve pcie_bif RAS recovery bug

2022-05-20 Thread Candice Li
Check shared buf instead of init flag for xgmi ta shared buf init during xgmi ta initialization. Signed-off-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/am

Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3

2022-05-20 Thread Geert Uytterhoeven
Hi Günter On Thu, May 19, 2022 at 8:48 AM Guenter Roeck wrote: > On 5/18/22 17:55, kernel test robot wrote: > > tree/branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > branch HEAD: 736ee37e2e8eed7fe48d0a37ee5a709514d478b3 Add linux-next > > specific file

Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3

2022-05-20 Thread Geert Uytterhoeven
On Fri, May 20, 2022 at 2:40 PM Geert Uytterhoeven wrote: > On Thu, May 19, 2022 at 8:48 AM Guenter Roeck wrote: > > On 5/18/22 17:55, kernel test robot wrote: > > > tree/branch: > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > branch HEAD: 736ee37e2e8eed7fe

Re: [PATCH 2/2] drm/amdkfd: track unified memory reservation with xnack off

2022-05-20 Thread philip yang
On 2022-05-19 19:08, Felix Kuehling wrote: Am 2022-05-19 um 12:21 schrieb Alex Sierra: [WHY] Unified memory with xnack off should be tracked, as userptr mappings and legacy allocations do. To avoid oversus

RE: [PATCH] drm/amdgpu: clean up asd on the ta_firmware_header_v2_0

2022-05-20 Thread Huang, Ray
[AMD Official Use Only - General] Acked-by: Huang Rui -Original Message- From: Liang, Prike Sent: Friday, May 20, 2022 2:12 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Liu, Aaron ; Zhang, Yifan ; Liang, Prike Subject: [PATCH] drm/amdgpu: clean up asd o

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-20 Thread Marek Olšák
1. So make gtt = ram/2. There's your 50%. 2. Not our problem. Marek On Fri., May 20, 2022, 05:42 Christian König, < ckoenig.leichtzumer...@gmail.com> wrote: > In theory we should allow much more than that. The problem is just that we > can't. > > We have the following issues: > 1. For swapping

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-20 Thread Christian König
In theory we should allow much more than that. The problem is just that we can't. We have the following issues: 1. For swapping out stuff we need to make sure that we can allocate temporary pages.     Because of this TTM has a fixed 50% limit where it starts to unmap memory from GPUs.     So

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-20 Thread Marek Olšák
Ignore the silly tests. We only need to make sure games work. The current minimum requirement for running modern games is 8GB of GPU memory. Soon it will be 12GB. APUs will need to support that. Marek On Fri., May 20, 2022, 03:52 Christian König, < ckoenig.leichtzumer...@gmail.com> wrote: > Am 1

RE: [PATCH] drm/amdgpu: clean up asd on the ta_firmware_header_v2_0

2022-05-20 Thread Zhang, Yifan
[AMD Official Use Only - General] Reviewed-by: Yifan Zhang -Original Message- From: Liang, Prike Sent: Friday, May 20, 2022 2:12 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Liu, Aaron ; Zhang, Yifan ; Liang, Prike Subject: [PATCH] drm/amdgpu: clean up

[PATCH] drm/amdgpu: Skip init fbdev if virtual_display is enabled

2022-05-20 Thread Danijel Slivka
In case virtaul_display is enabled there is no hw DCE so need to skip setting up fbdev. Signed-off-by: Danijel Slivka --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size (v2)

2022-05-20 Thread Christian König
Am 19.05.22 um 17:57 schrieb Alex Deucher: Certain GL unit tests for large textures can cause problems with the OOM killer since there is no way to link this memory to a process. This was originally mitigated (but not necessarily eliminated) by limiting the GTT size. The problem is this limit i

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-20 Thread Tejun Heo
On Fri, May 20, 2022 at 08:22:39AM +0200, Christian König wrote: > Am 20.05.22 um 02:47 schrieb Lai Jiangshan: > > On Thu, May 19, 2022 at 11:04 PM Andrey Grodzovsky > > wrote: > > > See this patch-set https://www.spinics.net/lists/amd-gfx/msg78514.html, > > > specifically patch > > > 'drm/amdgpu

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-20 Thread Christian König
Am 19.05.22 um 16:34 schrieb Alex Deucher: The current somewhat strange logic is in place because certain GL unit tests for large textures can cause problems with the OOM killer since there is no way to link this memory to a process. The problem is this limit is often too low for many modern gam