[PATCH V2 6/6] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.0/7

2022-06-05 Thread Evan Quan
PMFW will handle that properly. Driver involvement may cause some unexpected issues. Signed-off-by: Evan Quan Change-Id: I77da7d894485a3ac6a1a956e4d2605d0bc730c25 --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH V2 5/6] drm/amd/pm: fix compile warnings about redefined MAX_PCIE_CONF

2022-06-05 Thread Evan Quan
Suppress the compile warnings below: In file included from drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c:37: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.h:31: warning: "MAX_PCIE_CONF" redefined 31 | #define MAX_PCIE_CONF 2 | In file included from drivers/gp

[PATCH V2 4/6] drm/amd/pm: drop redundant declarations

2022-06-05 Thread Evan Quan
Drop those redundant declarations in smu_v13_0.h. Signed-off-by: Evan Quan Change-Id: I54e43d072235f006b937878c126bcd8ef81ea6f7 --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h b/driv

[PATCH V2 3/6] drm/amd/pm: enable mode1 reset support for SMU 13.0.0

2022-06-05 Thread Evan Quan
Fulfill the interfaces for mode1 reset related. Signed-off-by: Evan Quan Change-Id: I03bb1f7f3b88bf304a188bb6939c043805df8f10 -- v1->v2: - drop invalid psp alive check(Lijo) --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 1 + .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 11 ++

[PATCH V2 2/6] drm/amdgpu: avoid to perform undesired clockgating operation

2022-06-05 Thread Evan Quan
Make sure the clockgating feature is supported before action. Otherwise, the feature may be disabled unexpectedly on enablement request. Signed-off-by: Evan Quan Change-Id: Ie20e6c5975c2a0af40dc52189e3df97161300117 --- drivers/gpu/drm/amd/amdgpu/nbio_v4_3.c | 10 -- 1 file changed, 8 ins

[PATCH V2 1/6] drm/amdgpu: enable ASPM support for PCIE 7.4.0/7.6.0

2022-06-05 Thread Evan Quan
Enable ASPM support for PCIE 7.4.0 and 7.6.0. Signed-off-by: Evan Quan Change-Id: Ib3b0e106ff43ad49f0f815e6eeb5c756b6bf4550 --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + drivers/gpu/drm/amd/amdgpu/nbio_v4_3.c| 109 ++

[PATCH v2] drm/amdgpu: fix scratch register access method in SRIOV

2022-06-05 Thread ZhenGuo Yin
The scratch register should be accessed through MMIO instead of RLCG in SRIOV, since it being used in RLCG register access function. Fixes: 0e1314781b9c("drm/amdgpu: nuke dynamic gfx scratch reg allocation") Signed-off-by: ZhenGuo Yin --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 7 --- 1 fil

[PATCH] Revert "drm/amdgpu: Ensure the DMA engine is deactivated during set ups"

2022-06-05 Thread Guchun Chen
This reverts commit da38a66ac46e334f198afcd1b4d4554b4ddca0df. This causes regression in GPU reset related test. Cc: Alexander Deucher Cc: ricet...@gmail.com Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 109 ++--- 1 file changed, 45 insertions(+),

Re: [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-05 Thread Daniel Vetter
On Sun, 5 Jun 2022 at 20:32, Rob Clark wrote: > > On Sun, Jun 5, 2022 at 9:47 AM Daniel Vetter wrote: > > > > On Fri, 27 May 2022 at 01:55, Dmitry Osipenko > > wrote: > > > > > > Introduce a common DRM SHMEM shrinker framework that allows to reduce > > > code duplication among DRM drivers by rep

Re: [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-05 Thread Rob Clark
On Sun, Jun 5, 2022 at 9:47 AM Daniel Vetter wrote: > > On Fri, 27 May 2022 at 01:55, Dmitry Osipenko > wrote: > > > > Introduce a common DRM SHMEM shrinker framework that allows to reduce > > code duplication among DRM drivers by replacing theirs custom shrinker > > implementations with the gene

Re: [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-05 Thread Daniel Vetter
On Fri, 27 May 2022 at 01:55, Dmitry Osipenko wrote: > > Introduce a common DRM SHMEM shrinker framework that allows to reduce > code duplication among DRM drivers by replacing theirs custom shrinker > implementations with the generic shrinker. > > In order to start using DRM SHMEM shrinker driver