Re: [PATCH v2 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-10 Thread Lang Yu
On 06/10/ , Graham Sider wrote: > Starting with GFX11, MES requires wptr BOs to be GTT allocated/mapped to > GART for usermode queues in order to support oversubscription. In the > case that work is submitted to an unmapped queue, MES must have a GART > wptr address to determine whether the queue

[PATCH 1/1] drm/amdkfd: Remove queue sysfs and doorbell after unmapping

2022-06-10 Thread Philip Yang
If destroying/unmapping queue failed, application may destroy queue again, cause below kernel warning backtrace. For outstanding queues, either applications forget to destroy or failed to destroy, kfd_process_notifier_release will remove queue sysfs objects, kfd_process_wq_release will free queue

Re: [PATCH v2 1/3] drm/amdgpu: Fetch MES scheduler/KIQ versions

2022-06-10 Thread Felix Kuehling
Am 2022-06-10 um 13:13 schrieb Graham Sider: Store MES scheduler and MES KIQ version numbers in amdgpu_mes for GFX11. Signed-off-by: Graham Sider Acked-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 3 +++ drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 12

Re: [PATCH v2 3/3] drm/amdgpu: Update mes_v11_api_def.h

2022-06-10 Thread Felix Kuehling
Am 2022-06-10 um 13:13 schrieb Graham Sider: Update MES API to support oversubscription without aggregated doorbell for usermode queues. Signed-off-by: Graham Sider Acked-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 1 +

Re: [PATCH v2 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-10 Thread Felix Kuehling
Am 2022-06-10 um 13:13 schrieb Graham Sider: Starting with GFX11, MES requires wptr BOs to be GTT allocated/mapped to GART for usermode queues in order to support oversubscription. In the case that work is submitted to an unmapped queue, MES must have a GART wptr address to determine whether the

Re: [PATCH v3] drm/amdkfd: Add available memory ioctl

2022-06-10 Thread Felix Kuehling
Am 2022-06-09 um 19:32 schrieb David Yat Sin: From: Daniel Phillips Add a new KFD ioctl to return the largest possible memory size that can be allocated as a buffer object using kfd_ioctl_alloc_memory_of_gpu. It attempts to use exactly the same accept/reject criteria as that function so that

Re: [PATCH v2] drm/amdkfd: fix warning when CONFIG_HSA_AMD_P2P is not set

2022-06-10 Thread Felix Kuehling
Am 2022-06-10 um 11:46 schrieb Alex Deucher: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1542:11: warning: variable 'i' set but not used [-Wunused-but-set-variable] Reported-by: kernel test robot Signed-off-by: Alex Deucher Thank you for taking care of this. Reviewed-by: Felix

Re: [PATCH] drm/amdgpu: Fix error handling in amdgpu_amdkfd_gpuvm_free_memory_of_gpu

2022-06-10 Thread Felix Kuehling
Am 2022-06-10 um 00:04 schrieb Ramesh Errabolu: Following error conditions are fixed: Unpin MMIO and DOORBELL BOs only after map count goes to zero Remove BO from validate list of a KFD process in a safe manner Print a warning message if unreserving GPUVMs encounters an error

[PATCH 23/23] drm/amd/display: Blank for uclk OC in dm instead of dc

2022-06-10 Thread Hamza Mahfooz
From: Joshua Aberback [Why] All displays need to be blanked during the uclk OC interface so that we can guarantee pstate switching support. If the display config doesn't support pstate switching, only using core_link_disable_stream will not enable it as the front-end is untouched. We need to go

[PATCH 20/23] drm/amd/display: Disables dynamic memory clock switching in games

2022-06-10 Thread Hamza Mahfooz
From: Harry VanZyllDeJong [WHY] Game performace may be affected if dynamic memory clock switching is enabled while playing games. [HOW] Propagate the vrr active state to dirty bit so that on mode set it disables dynamic memory clock switching. Acked-by: Alan Liu Signed-off-by: Harry

[PATCH 22/23] drm/amd/display: Add null check to dc_submit_i2c_oem

2022-06-10 Thread Hamza Mahfooz
From: Martin Leung [why] dc_submit_i2c_oem could be called with ddc null [how] add null check and fail the call instead Acked-by: Alan Liu Signed-off-by: Martin Leung --- drivers/gpu/drm/amd/display/dc/core/dc.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[PATCH 21/23] drm/amd/display: FVA timing adjustment

2022-06-10 Thread Hamza Mahfooz
From: Charlene Liu [why] need to add timing adjustment for fva. [how] add hook to optc and hwseq. Acked-by: Alan Liu Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 19/23] drm/amd/display: Pass vrr mode to dcn

2022-06-10 Thread Hamza Mahfooz
From: Felipe [WHY] New features will require knowing the vrr mode for their enablement. [HOW] Pass the state via a member of dc_stream. Acked-by: Alan Liu Signed-off-by: Felipe Clark --- drivers/gpu/drm/amd/display/dc/dc_stream.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 17/23] drm/amd/display: Copy hfvsif_infopacket when stream update

2022-06-10 Thread Hamza Mahfooz
From: Nicholas Kazlauskas [Why & How] Miss to copy hfvsif_infopacket when copying stream updates. Check and copy it. Acked-by: Alan Liu Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/core/dc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 18/23] drm/amd/display: Adding VTEM to dc

2022-06-10 Thread Hamza Mahfooz
From: Ahmad Othman [Why] Video Timing Extended Metadata packet (VTEM) is required for features like VRR and FVA [How] Adding support for VTEM transmission to stream encoders in DCN20 and DCN30 as part of FVA support Acked-by: Alan Liu Signed-off-by: Ahmad Othman ---

[PATCH 16/23] drm/amd/display: Add support for HF-VSIF

2022-06-10 Thread Hamza Mahfooz
From: Ahmad Othman [Why] - Currently there is no support for HF-VSIF - The current support of VSIF is limited to H14b infoframe [How] - refactor VSIF - Added new builder for HF-VSIF - Added the HF-VSIF packet to DisplayTarget - Updates DC to apply HF-VSIF updates when updating streams

[PATCH 15/23] drm/amd/display: Firmware assisted MCLK switch and FS

2022-06-10 Thread Hamza Mahfooz
From: Felipe [WHY] Memory clock switching has great potential for power savings. [HOW] The driver code was modified to notify the DMCUB firmware that it should stretch the vertical blank of frames when a memory clock switch is about to start so that no blackouts happen on the screen due to

[PATCH 14/23] drm/amd/display: DAL ACR, dc part, fix missing dcn30

2022-06-10 Thread Hamza Mahfooz
From: Ian Chen [Why] - missing in dcn30 function - Fix a divide by 0 when ACR trigger [How] - Add IS_SMU_TIMEOUT() to dcn30_smu_send_msg_with_param - Add zero check in dcn20_update_clocks_update_dentist Acked-by: Alan Liu Signed-off-by: Ian Chen ---

[PATCH 13/23] drm/amd/display: Fix comments

2022-06-10 Thread Hamza Mahfooz
From: Samson Tam [Why & how] Fix format and typo of comments. Acked-by: Alan Liu Signed-off-by: Samson Tam --- .../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 1 - drivers/gpu/drm/amd/display/dc/core/dc_link.c | 8 ++-- .../dc/gpio/dcn20/hw_translate_dcn20.c| 17

[PATCH 12/23] drm/amd/display: Drop unused privacy_mask setters and getters

2022-06-10 Thread Hamza Mahfooz
From: Oliver Logush [Why and How] dwbc_funcs.set/get_privacy_mask isn't being used anymore, drop it Reviewed-by: Charlene Liu Acked-by: Alan Liu Signed-off-by: Oliver Logush --- drivers/gpu/drm/amd/display/dc/inc/hw/dwb.h | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 10/23] drm/amd/display: update topology_update_input_v3 struct

2022-06-10 Thread Hamza Mahfooz
From: Qingqing Zhuo [Why] DIO parameters were missing in topology_update_intput_v3 struct. [How] Add DIO parameters in v3 struct and update in functions perspectively. Reviewed-by: Bhawanpreet Lakha Acked-by: Hamza Mahfooz Signed-off-by: Qingqing Zhuo ---

[PATCH 11/23] drm/amd/display: 3.2.190

2022-06-10 Thread Hamza Mahfooz
From: Aric Cyr This version brings along the following: - DP fixes - Reduced frame size in the bouding boxes of a number of ASICs. - Exiting idle optimizations on mouse updates Acked-by: Hamza Mahfooz Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1

[PATCH 09/23] drm/amd/display: Add debug option for exiting idle optimizations on cursor updates

2022-06-10 Thread Hamza Mahfooz
From: "Lee, Alvin" [Description] - Have option to exit idle opt on cursor updates for debug and optimizations purposes Reviewed-by: Samson Tam Acked-by: Hamza Mahfooz Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 5 +++-- drivers/gpu/drm/amd/display/dc/dc.h

[PATCH 07/23] drm/amd/display: Reduce frame size in the bouding box for DCN21

2022-06-10 Thread Hamza Mahfooz
From: Rodrigo Siqueira GCC throw warnings for the function dcn21_update_bw_bounding_box and dcn316_update_bw_bounding_box due to its frame size that looks like this: error: the frame size of 1936 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] For fixing this issue I dropped an

[PATCH 08/23] drm/amd/display: dsc validate fail not pass to atomic check

2022-06-10 Thread Hamza Mahfooz
From: hersen wu [Why] when 4k@144hz dp connect to dp1.4 dsc mst hub, requested bandwidth exceeds caps of dsc hub. but dsc bw valid functions, increase_dsc_bpp, try_disable_dsc, pre_validate_dsc, compute_mst_dsc_configs_for_state, do not return false to atomic check. this cause user mode initiate

[PATCH 05/23] drm/amd/display: Reduce frame size in the bouding box for DCN301

2022-06-10 Thread Hamza Mahfooz
From: Rodrigo Siqueira GCC throw warnings for the function dcn301_fpu_update_bw_bounding_box due to its frame size that looks like this: error: the frame size of 1936 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] For fixing this issue I dropped an intermadiate variable.

[PATCH 06/23] drm/amd/display: Reduce frame size in the bouding box for DCN31/316

2022-06-10 Thread Hamza Mahfooz
From: Rodrigo Siqueira GCC throw warnings for the function dcn31_update_bw_bounding_box and dcn316_update_bw_bounding_box due to its frame size that looks like this: error: the frame size of 1936 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] For fixing this issue I dropped an

[PATCH 04/23] drm/amd/display: Reduce frame size in the bouding box for DCN20

2022-06-10 Thread Hamza Mahfooz
From: Rodrigo Siqueira GCC throw warnings for the function dcn20_update_bounding_box due to its frame size that looks like this: error: the frame size of 1936 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] This commit fixes this issue by eliminating an intermediary variable

[PATCH 03/23] drm/amd/display: Fix monitor flash issue

2022-06-10 Thread Hamza Mahfooz
From: "Shah, Dharati" [Why & How] For a some specific monitors, when connected on boot or hot plug, monitor flash for 1/2 seconds can happen during first HDCP query operation. Ading some delay in the init sequence for these monitors fixes the issue, so it is implemented as monitor specific

[PATCH 00/23] DC Patches June 06, 2022

2022-06-10 Thread Hamza Mahfooz
This DC patchset brings improvements in multiple areas. In summary, we have: * DP fixes * Reduced frame size in the bouding boxes of a number of ASICs. * Exiting idle optimizations * General cleanup * Power management optimizations * HF-VSIF support * VTEM support * FVA timing improvements Ahmad

[PATCH 01/23] drm/amd/display: fix build when CONFIG_DRM_AMD_DC_DCN is not defined

2022-06-10 Thread Hamza Mahfooz
Fixes: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c: In function ‘dc_remove_stream_from_ctx’: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:2010:3: error: implicit declaration of function ‘remove_hpo_dp_link_enc_from_ctx’; did you mean ‘add_hpo_dp_link_enc_to_ctx’?

[PATCH 02/23] drm/amd/display: lower lane count first when CR done partially fails in EQ

2022-06-10 Thread Hamza Mahfooz
From: Wenjing Liu [why] According to DP specs, in EQ DONE phase of link training, we should lower lane count when at least one CR DONE bit is set to 1, while lower link rate when all CR DONE bits are 0s. However in our code, we will treat both cases as latter. This is not exactly correct based

[linux-next:master] BUILD REGRESSION 6d0c806803170f120f8cb97b321de7bd89d3a791

2022-06-10 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 6d0c806803170f120f8cb97b321de7bd89d3a791 Add linux-next specific files for 20220610 Error/Warning reports: https://lore.kernel.org/llvm/202205220805.wrw5woek-...@intel.com Error/Warning

DRM/KMS PWL API Thoughts and Questions

2022-06-10 Thread Harry Wentland
(I'm sending this as an email as lowest common denominator but feel an issue on the color-and-hdr repo would be a better interface for productive discussion. Please pop over to https://gitlab.freedesktop.org/pq/color-and-hdr/-/issues/10 if you agree. Hopefully we can drive the discussion there

Re: [PATCH] drm/amd/display: dml: move some variables to heap

2022-06-10 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Aurabindo Pillai Sent: Friday, June 10, 2022 1:26 PM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander Cc: Siqueira, Rodrigo ; Wentland, Harry Subject: [PATCH] drm/amd/display: dml: move some

[PATCH] drm/amd/display: dml: move some variables to heap

2022-06-10 Thread Aurabindo Pillai
[Why] To reduce stack usage, move some variables into heap in the DML function dml32_ModeSupportAndSystemConfigurationFull() Fixes: d03037269bf2d ("drm/amd/display: DML changes for DCN32/321") Signed-off-by: Aurabindo Pillai --- .../display/dc/dml/dcn32/display_mode_vba_32.c | 17

[PATCH v2 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-10 Thread Graham Sider
Starting with GFX11, MES requires wptr BOs to be GTT allocated/mapped to GART for usermode queues in order to support oversubscription. In the case that work is submitted to an unmapped queue, MES must have a GART wptr address to determine whether the queue should be mapped. This change is

[PATCH v2 1/3] drm/amdgpu: Fetch MES scheduler/KIQ versions

2022-06-10 Thread Graham Sider
Store MES scheduler and MES KIQ version numbers in amdgpu_mes for GFX11. Signed-off-by: Graham Sider --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 3 +++ drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 12 2 files changed, 15 insertions(+) diff --git

[PATCH v2 3/3] drm/amdgpu: Update mes_v11_api_def.h

2022-06-10 Thread Graham Sider
Update MES API to support oversubscription without aggregated doorbell for usermode queues. Signed-off-by: Graham Sider --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 1 + drivers/gpu/drm/amd/amdgpu/mes_v11_0.c

Re: [PATCH 2/2] drm/amd/pm: enable MACO support for SMU 13.0.0

2022-06-10 Thread Alex Deucher
On Fri, Jun 10, 2022 at 2:26 AM Evan Quan wrote: > > Enable BAMACO reset support for SMU 13.0.0. > > Signed-off-by: Evan Quan > Change-Id: I67696671c216790a0b6d5b84f7d4b430d734ac3c > -- > v1->v2: > - maximum code sharing around smu13.0.0 and smu13.0.7 > --- >

Re: [PATCH 1/2] drm/amd/pm: enable UCLK DS feature for SMU 13.0.0

2022-06-10 Thread Alex Deucher
On Fri, Jun 10, 2022 at 2:26 AM Evan Quan wrote: > > The feature is ready with latest PMFW and IFWI. > > Signed-off-by: Evan Quan Reviewed-by: Alex Deucher > Change-Id: I0b1ea6a32bc092eec4b95118a1442597688ee8d0 > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 2 ++ > 1 file

Re: [PATCH] drm/amdgpu: Fix GTT size reporting in amdgpu_ioctl

2022-06-10 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jun 10, 2022 at 10:01 AM Michel Dänzer wrote: > > From: Michel Dänzer > > The commit below changed the TTM manager size unit from pages to > bytes, but failed to adjust the corresponding calculations in > amdgpu_ioctl. > > Fixes: dfa714b88eb0 ("drm/amdgpu: remove

[PATCH v2] drm/amdkfd: fix warning when CONFIG_HSA_AMD_P2P is not set

2022-06-10 Thread Alex Deucher
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1542:11: warning: variable 'i' set but not used [-Wunused-but-set-variable] Reported-by: kernel test robot Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-)

Re: [PATCH] drm/amdkfd: fix warning when CONFIG_HSA_AMD_P2P is not set

2022-06-10 Thread Alex Deucher
On Fri, Jun 10, 2022 at 11:43 AM Alex Deucher wrote: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1542:11: > warning: variable 'i' set but not used [-Wunused-but-set-variable] > > Reported-by: kernel test robot > Signed-off-by: Alex Deucher > --- >

[PATCH] drm/amdgpu/display: make FP handling in Makefiles consistent

2022-06-10 Thread Alex Deucher
Use the same pattern as the DML Makefile and while we are here add a missing x86 guard around the msse flags for DCN3.2.x. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/clk_mgr/Makefile | 3 +-- drivers/gpu/drm/amd/display/dc/dcn201/Makefile | 1 -

[PATCH] drm/amdkfd: fix warning when CONFIG_HSA_AMD_P2P is not set

2022-06-10 Thread Alex Deucher
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1542:11: warning: variable 'i' set but not used [-Wunused-but-set-variable] Reported-by: kernel test robot Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 4 drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 7

Re: [PATCH v6 00/22] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2022-06-10 Thread Dmitry Osipenko
On 5/27/22 02:50, Dmitry Osipenko wrote: > Hello, > > This patchset introduces memory shrinker for the VirtIO-GPU DRM driver > and adds memory purging and eviction support to VirtIO-GPU driver. > > The new dma-buf locking convention is introduced here as well. > > During OOM, the shrinker will

[PATCH] drm/amdgpu: Fix GTT size reporting in amdgpu_ioctl

2022-06-10 Thread Michel Dänzer
From: Michel Dänzer The commit below changed the TTM manager size unit from pages to bytes, but failed to adjust the corresponding calculations in amdgpu_ioctl. Fixes: dfa714b88eb0 ("drm/amdgpu: remove GTT accounting v2") Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1930 Bug:

Re: [PATCH] drm/amd/display: ignore modifiers when checking for format support

2022-06-10 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Thanks for noticing, will fix it in a separate patch since I already merged this. -- Regards, Jay From: Chen, Guchun Sent: Thursday, June 9, 2022 9:28 PM To: Pillai, Aurabindo ; Olsak, Marek ; amd-gfx@lists.freedesktop.org

Re: [PATCH 03/13] mm: shmem: provide oom badness for shmem files

2022-06-10 Thread Christian König
Am 10.06.22 um 13:44 schrieb Michal Hocko: On Fri 10-06-22 12:58:53, Christian König wrote: [SNIP] I do realize this is a long term problem and there is a demand for some solution at least. I am not sure how to deal with shared resources myself. The best approximation I can come up with is to

Re: [PATCH 03/13] mm: shmem: provide oom badness for shmem files

2022-06-10 Thread Christian König
Am 09.06.22 um 17:07 schrieb Michal Hocko: On Thu 09-06-22 16:29:46, Christian König wrote: [...] Is that a show stopper? How should we address this? This is a hard problem to deal with and I am not sure this simple solution is really a good fit. Not only because of the memcg side of things. I

[PATCH 1/2] drm/amd/pm: enable UCLK DS feature for SMU 13.0.0

2022-06-10 Thread Evan Quan
The feature is ready with latest PMFW and IFWI. Signed-off-by: Evan Quan Change-Id: I0b1ea6a32bc092eec4b95118a1442597688ee8d0 --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c

[PATCH 2/2] drm/amd/pm: enable MACO support for SMU 13.0.0

2022-06-10 Thread Evan Quan
Enable BAMACO reset support for SMU 13.0.0. Signed-off-by: Evan Quan Change-Id: I67696671c216790a0b6d5b84f7d4b430d734ac3c -- v1->v2: - maximum code sharing around smu13.0.0 and smu13.0.7 --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 3 +- .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c |