Re: [PATCH 1/5] drm/amdgpu: Fix possible refcount leak for release of external_hw_fence

2022-06-23 Thread Christian König
Am 23.06.22 um 23:18 schrieb Andrey Grodzovsky: On 2022-06-22 11:04, Christian König wrote: Am 22.06.22 um 17:01 schrieb Andrey Grodzovsky: On 2022-06-22 05:00, Christian König wrote: Am 21.06.22 um 21:34 schrieb Andrey Grodzovsky: On 2022-06-21 03:19, Christian König wrote: Am 21.06.22 u

[PATCH -next] drm/amdgpu: Remove duplicated include in amdgpu_dm.c

2022-06-23 Thread Yang Li
Fix following includecheck warning: ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: soc15_common.h is included more than once. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgp

Re: [PATCH 1/2] drm/amdgpu/display: drop set but unused variable

2022-06-23 Thread Harry Wentland
On 6/23/22 12:41, Alex Deucher wrote: > No longer used so drop it. > > Fixes: ec457f837890 ("drm/amd/display: Drop unnecessary detect link code") > Reported-by: kernel test robot > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/d

Re: [PATCH 1/5] drm/amdgpu: Fix possible refcount leak for release of external_hw_fence

2022-06-23 Thread Andrey Grodzovsky
On 2022-06-22 11:04, Christian König wrote: Am 22.06.22 um 17:01 schrieb Andrey Grodzovsky: On 2022-06-22 05:00, Christian König wrote: Am 21.06.22 um 21:34 schrieb Andrey Grodzovsky: On 2022-06-21 03:19, Christian König wrote: Am 21.06.22 um 00:02 schrieb Andrey Grodzovsky: Problem: In

Re: [PATCH] drm/amd/display : Log DP link training failure reason

2022-06-23 Thread Leo
On 2022-06-23 12:48, Alex Deucher wrote: > On Thu, Jun 23, 2022 at 3:33 AM Chandan Vurdigere Nataraj > wrote: >> >> [Why] >> Existing logs doesn't print DP LT failure reason >> >> [How] >> Update the existing log with DP LT failure reason >> >> Signed-off-by: Chandan Vurdigere Nataraj > > Ack

[linux-next:master] BUILD REGRESSION 08897940f458ee55416cf80ab13d2d8b9f20038e

2022-06-23 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 08897940f458ee55416cf80ab13d2d8b9f20038e Add linux-next specific files for 20220623 Error/Warning reports: https://lore.kernel.org/linux-mm/202206212029.yr5m7cd3-...@intel.com https

Re: linux-next: Tree for Jun 23 [drivers/gpu/drm/amd/amdgpu/amdgpu.ko]

2022-06-23 Thread Randy Dunlap
On 6/22/22 23:57, Stephen Rothwell wrote: > Hi all, > > Changes since 20220622: > > > The amdgpu tree lost its build failure. > The amdgpu tree gained a semantic conflict against the driver-core tree. > on i386: ERROR: modpost: "__umoddi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-23 Thread David Hildenbrand
On 23.06.22 20:20, Sierra Guiza, Alejandro (Alex) wrote: > > On 6/23/2022 2:57 AM, David Hildenbrand wrote: >> On 23.06.22 01:16, Sierra Guiza, Alejandro (Alex) wrote: >>> On 6/21/2022 11:16 AM, David Hildenbrand wrote: On 21.06.22 18:08, Sierra Guiza, Alejandro (Alex) wrote: > On 6/21/20

Re: [PATCH] Revert "drm/amd/display: ignore modifiers when checking for format support"

2022-06-23 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 23, 2022 at 9:34 AM Aurabindo Pillai wrote: > > > > On 2022-06-19 20:37, Bas Nieuwenhuizen wrote: > > This reverts commit 5089c4a8ebea3c3ad9eedf038dad7098ebc06131. > > > > This breaks validation and enumeration of display capable modifiers. > > > > The early re

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-23 Thread Sierra Guiza, Alejandro (Alex)
On 6/23/2022 2:57 AM, David Hildenbrand wrote: On 23.06.22 01:16, Sierra Guiza, Alejandro (Alex) wrote: On 6/21/2022 11:16 AM, David Hildenbrand wrote: On 21.06.22 18:08, Sierra Guiza, Alejandro (Alex) wrote: On 6/21/2022 7:25 AM, David Hildenbrand wrote: On 21.06.22 13:55, Alistair Popple

Re: [PATCH] drm/amd/display: Fix indentation in dcn32_get_vco_frequency_from_reg()

2022-06-23 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 23, 2022 at 12:26 PM Leo wrote: > > > > On 2022-06-23 11:30, Nathan Chancellor wrote: > > Clang warns: > > > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:549:4: > > warning: misleading indentation; statement is not part of th

Re: [PATCH][next] drm/amdgpu/display: Fix spelling mistake "supporing" -> "supporting"

2022-06-23 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 23, 2022 at 10:20 AM Harry Wentland wrote: > > > > On 2022-06-23 04:09, Colin Ian King wrote: > > There is a spelling mistake in a dml_print message. Fix it. > > > > Signed-off-by: Colin Ian King > > Reviewed-by: Harry Wentland > > Harry > > > --- > > driver

Re: [PATCH] drm/amdgpu: drop unexpected word 'for' in comments

2022-06-23 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 23, 2022 at 6:15 AM Jiang Jian wrote: > > there is an unexpected word 'for' in the comments that need to be dropped > > file - drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c > line - 245 > > * position and also advance the position for for Vega10 > > changed to: > >

Re: [PATCH][next] drm/amdkfd: Fix spelling mistake "mechanim" -> "mechanism"

2022-06-23 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 23, 2022 at 4:12 AM Colin Ian King wrote: > > There is a spelling mistake in a pr_debug message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

Re: [PATCH] drm/amd/display : Log DP link training failure reason

2022-06-23 Thread Alex Deucher
On Thu, Jun 23, 2022 at 3:33 AM Chandan Vurdigere Nataraj wrote: > > [Why] > Existing logs doesn't print DP LT failure reason > > [How] > Update the existing log with DP LT failure reason > > Signed-off-by: Chandan Vurdigere Nataraj Acked-by: Alex Deucher > > diff --git a/drivers/gpu/drm/amd/d

[PATCH 1/2] drm/amdgpu/display: drop set but unused variable

2022-06-23 Thread Alex Deucher
No longer used so drop it. Fixes: ec457f837890 ("drm/amd/display: Drop unnecessary detect link code") Reported-by: kernel test robot Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/

[PATCH 2/2] drm/amdgpu: fix documentation warning

2022-06-23 Thread Alex Deucher
Fixes this issue: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5094: warning: expecting prototype for amdgpu_device_gpu_recover_imp(). Prototype was for amdgpu_device_gpu_recover() instead Fixes: cf727044144d ("drm/amdgpu: Rename amdgpu_device_gpu_recover_imp back to amdgpu_device_gpu_recover") R

Re: [PATCH] drm/amd/display: Fix indentation in dcn32_get_vco_frequency_from_reg()

2022-06-23 Thread Leo
On 2022-06-23 11:30, Nathan Chancellor wrote: > Clang warns: > > > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:549:4: > warning: misleading indentation; statement is not part of the previous 'else' > [-Wmisleading-indentation] > pll_req

[PATCH] drm/amd/display: Fix indentation in dcn32_get_vco_frequency_from_reg()

2022-06-23 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:549:4: warning: misleading indentation; statement is not part of the previous 'else' [-Wmisleading-indentation] pll_req = dc_fixpt_from_int(pll_req_reg & clk_mgr->clk_mgr_mask->FbMult

Re: [PATCH 5/5] drm/amdgpu: Follow up change to previous drm scheduler change.

2022-06-23 Thread Christian König
Am 23.06.22 um 16:51 schrieb Andrey Grodzovsky: On 2022-06-23 01:52, Christian König wrote: Am 22.06.22 um 19:19 schrieb Andrey Grodzovsky: On 2022-06-22 03:17, Christian König wrote: Am 21.06.22 um 22:00 schrieb Andrey Grodzovsky: On 2022-06-21 03:28, Christian König wrote: Am 21.06.22 u

Re: [PATCH 5/5] drm/amdgpu: Follow up change to previous drm scheduler change.

2022-06-23 Thread Andrey Grodzovsky
On 2022-06-23 01:52, Christian König wrote: Am 22.06.22 um 19:19 schrieb Andrey Grodzovsky: On 2022-06-22 03:17, Christian König wrote: Am 21.06.22 um 22:00 schrieb Andrey Grodzovsky: On 2022-06-21 03:28, Christian König wrote: Am 21.06.22 um 00:03 schrieb Andrey Grodzovsky: Align refcou

Re: [PATCH][next] drm/amdgpu/display: Fix spelling mistake "supporing" -> "supporting"

2022-06-23 Thread Harry Wentland
On 2022-06-23 04:09, Colin Ian King wrote: > There is a spelling mistake in a dml_print message. Fix it. > > Signed-off-by: Colin Ian King Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-23 Thread David Hildenbrand
On 23.06.22 01:16, Sierra Guiza, Alejandro (Alex) wrote: > > On 6/21/2022 11:16 AM, David Hildenbrand wrote: >> On 21.06.22 18:08, Sierra Guiza, Alejandro (Alex) wrote: >>> On 6/21/2022 7:25 AM, David Hildenbrand wrote: On 21.06.22 13:55, Alistair Popple wrote: > David Hildenbrand writes

[PATCH][next] drm/amdgpu/display: Fix spelling mistake "supporing" -> "supporting"

2022-06-23 Thread Colin Ian King
There is a spelling mistake in a dml_print message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c b/drive

[PATCH] drm/amdgpu: drop unexpected word 'for' in comments

2022-06-23 Thread Jiang Jian
there is an unexpected word 'for' in the comments that need to be dropped file - drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c line - 245 * position and also advance the position for for Vega10 changed to: * position and also advance the position for Vega10 Signed-off-by: Jiang Jian --- drivers/g

[PATCH][next] drm/amdkfd: Fix spelling mistake "mechanim" -> "mechanism"

2022-06-23 Thread Colin Ian King
There is a spelling mistake in a pr_debug message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_

Re: [PATCH] Revert "drm/amdgpu/display: set vblank_disable_immediate for DC"

2022-06-23 Thread Harry Wentland
On 2022-06-20 18:38, Alex Deucher wrote: > This reverts commit 92020e81ddbeac351ea4a19bcf01743f32b9c800. > > This causes stuttering and timeouts with DMCUB for some users > so revert it until we understand why and and safely enable it > to save power. > > Bug: https://gitlab.freedesktop.org/drm/a

Re: [PATCH] Revert "drm/amd/display: ignore modifiers when checking for format support"

2022-06-23 Thread Aurabindo Pillai
On 2022-06-19 20:37, Bas Nieuwenhuizen wrote: This reverts commit 5089c4a8ebea3c3ad9eedf038dad7098ebc06131. This breaks validation and enumeration of display capable modifiers. The early return true means the rest of the validation code never gets executed, and we need that to enumerate the

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-06-23 Thread Mike Lothian
Hi The buddy allocator is still causing me issues in 5.19-rc3 (https://gitlab.freedesktop.org/drm/amd/-/issues/2059) I'm no longer seeing null pointers though, so I think the bulk move fix did it's bit Let me know if there's anything I can help with, now there aren't freezes I can offer remote a

[PATCH] drm/amd/display : Log DP link training failure reason

2022-06-23 Thread Chandan Vurdigere Nataraj
[Why] Existing logs doesn't print DP LT failure reason [How] Update the existing log with DP LT failure reason Signed-off-by: Chandan Vurdigere Nataraj diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index 4027f439a5a4..c8355acd3

Re: [PATCH v4 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-23 Thread Christian König
Am 22.06.22 um 17:36 schrieb Graham Sider: Starting with GFX11, MES requires wptr BOs to be GTT allocated/mapped to GART for usermode queues in order to support oversubscription. In the case that work is submitted to an unmapped queue, MES must have a GART wptr address to determine whether the qu