[linux-next:master] BUILD REGRESSION 2a2aa3f05338270aecbe2492fda910d6c17e0102

2022-07-05 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 2a2aa3f05338270aecbe2492fda910d6c17e0102 Add linux-next specific files for 20220705 Error/Warning reports: https://lore.kernel.org/linux-doc/202207051821.3f0erisl-...@intel.com Error/Warning

[pull] amdgpu, amdkfd, radeon drm-next-5.20

2022-07-05 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 5.20. The following changes since commit bf23729c7a5f44f0e863666b9364a64741fd3241: Merge tag 'amd-drm-next-5.19-2022-05-26-2' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-06-01 10:56:11 +1000) are available in the Git repository at: htt

Re: [PATCH] drm/amd: Add debug mask for subviewport mclk switch

2022-07-05 Thread Harry Wentland
On 7/5/22 16:24, Aurabindo Pillai wrote: > > > On 2022-07-05 15:53, Harry Wentland wrote: >> >> >> On 2022-06-28 17:26, Aurabindo Pillai wrote: >>> [Why&How] >>> Expose a new debugfs enum to force a subviewport memory clock switch >>> to facilitate easy testing. >>> >> >> Does this force a sin

Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-07-05 Thread Maíra Canal
On 7/5/22 15:43, Errabolu, Ramesh wrote: > [AMD Official Use Only - General] > > Maira, > > Thanks for taking time to review. I understand the request to tag the patch > as version 2. However I don't follow your comments on "Fixes" block. Looking > at the git log of the branch I see many "Fix

Re: [PATCH] drm/amd: Add debug mask for subviewport mclk switch

2022-07-05 Thread Aurabindo Pillai
On 2022-07-05 15:53, Harry Wentland wrote: On 2022-06-28 17:26, Aurabindo Pillai wrote: [Why&How] Expose a new debugfs enum to force a subviewport memory clock switch to facilitate easy testing. Does this force a single switch? Or at regular intervals? If this debug option is set, each

Re: [PATCH] drm/amd: Add debug mask for subviewport mclk switch

2022-07-05 Thread Harry Wentland
On 2022-06-28 17:26, Aurabindo Pillai wrote: > [Why&How] > Expose a new debugfs enum to force a subviewport memory clock switch > to facilitate easy testing. > Does this force a single switch? Or at regular intervals? It would be useful to describe a bit better what it does. > Signed-off-by:

Re: [PATCH 1/1] drm/amdkfd: Remove queue sysfs and doorbell after unmapping

2022-07-05 Thread philip yang
On 2022-07-05 15:12, Felix Kuehling wrote: On 2022-07-05 15:02, philip yang wrote: On 2022-07-05 14:48, Felix Kuehling wrote: On 2022-06-10 21:03, Philip Yang wrote: If destroying/un

Re: [PATCH 1/1] drm/amdkfd: Remove queue sysfs and doorbell after unmapping

2022-07-05 Thread Felix Kuehling
On 2022-07-05 15:02, philip yang wrote: On 2022-07-05 14:48, Felix Kuehling wrote: On 2022-06-10 21:03, Philip Yang wrote: If destroying/unmapping queue failed, application may destroy queue again, cause below kernel warning backtrace. For outstanding queues, either applications forget to de

Re: [PATCH 1/1] drm/amdkfd: Remove queue sysfs and doorbell after unmapping

2022-07-05 Thread philip yang
On 2022-07-05 14:48, Felix Kuehling wrote: On 2022-06-10 21:03, Philip Yang wrote: If destroying/unmapping queue failed, application may destroy queue again, cause below kernel warning backtrace.

Re: [PATCH 1/1] drm/amdkfd: Remove queue sysfs and doorbell after unmapping

2022-07-05 Thread Felix Kuehling
On 2022-06-10 21:03, Philip Yang wrote: If destroying/unmapping queue failed, application may destroy queue again, cause below kernel warning backtrace. For outstanding queues, either applications forget to destroy or failed to destroy, kfd_process_notifier_release will remove queue sysfs object

RE: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-07-05 Thread Errabolu, Ramesh
[AMD Official Use Only - General] Maira, Thanks for taking time to review. I understand the request to tag the patch as version 2. However I don't follow your comments on "Fixes" block. Looking at the git log of the branch I see many "Fixes" block that precede the "Signed-off-by" statement. C

Re: [PATCH 2/3] drm/amdkfd: track unified memory reservation with xnack off

2022-07-05 Thread Felix Kuehling
On 2022-07-05 12:09, philip yang wrote: On 2022-06-27 20:23, Alex Sierra wrote: [WHY] Unified memory with xnack off should be tracked, as userptr mappings and legacy allocations do. To avoid oversuscribe system memory when xnack off. I think this also apply to XNACK ON (remove p->xnack_enabl

Re: [PATCH 3/3] drm/amdgpu: add debugfs for kfd system and ttm mem used

2022-07-05 Thread philip yang
On 2022-06-27 20:23, Alex Sierra wrote: This keeps track of kfd system mem used and kfd ttm mem used. We could also dump vram used by checking topology_device_list per dev->vram_used, but it can add later if needed. Reviewed-by: Philip Yang

Re: [PATCH 2/3] drm/amdkfd: track unified memory reservation with xnack off

2022-07-05 Thread philip yang
On 2022-06-27 20:23, Alex Sierra wrote: [WHY] Unified memory with xnack off should be tracked, as userptr mappings and legacy allocations do. To avoid oversuscribe system memory when xnack off. I think this also apply to XNACK ON (remove p->xnack_enabled

Re: [PATCH RESEND V2 1/3] drm/amdgpu: fix checkpatch warnings

2022-07-05 Thread Mukunda,Vijendar
On 7/5/22 4:51 PM, Christian König wrote: > > > Am 04.07.22 um 15:54 schrieb Vijendar Mukunda: >> From: vijendar >> >> Fixed below checkpatch warnings and errors >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL >> could be written "apd" >> drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH] drm/amd/display: Remove unused variables from vba_vars_st

2022-07-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 30, 2022 at 5:53 PM Maíra Canal wrote: > > Some variables from the struct vba_vars_st are not referenced in any > other place on the codebase. As they are not used, this commit removes > those variables. > > Signed-off-by: Maíra Canal > --- > > Unused variable

Re: [PATCH] drm/amd/display: Remove duplicate code across dcn30 and dcn31

2022-07-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 30, 2022 at 4:18 PM Maíra Canal wrote: > > The function CalculateBytePerPixelAnd256BBlockSizes was defined four > times: on display_mode_vba_30.c, display_rq_dlg_calc_30.c, > display_mode_vba_31.c and display_rq_dlg_calc_31.c. In order to avoid > code duplicati

Re: [PATCH -next] drm/amd/display: clean up some inconsistent indenting

2022-07-05 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jul 1, 2022 at 5:24 AM Yang Li wrote: > > Eliminate the follow smatch warning: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3151 > commit_planes_for_stream() warn: inconsistent indenting > > Signed-off-by: Yang Li > --- > drivers/gpu/drm/amd/display/dc/c

Re: [PATCH] drm/amd/display: Remove return value of Calculate256BBlockSizes

2022-07-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 30, 2022 at 2:50 PM Maíra Canal wrote: > > The function Calculate256BBlockSizes always returns true, regardless of > the parameters. As any file checks the return of the function, this > commit changes the return value to void. > > Signed-off-by: Maíra Canal >

Re: [PATCH] drm/amdpgu/debugfs: Simplify some exit paths

2022-07-05 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 4, 2022 at 12:23 PM Christian König wrote: > > Am 04.07.22 um 15:45 schrieb André Almeida: > > To avoid code repetition, unify the function exit path when possible. No > > functional changes. > > > > Signed-off-by: André Almeida > > Acked-by: Christian König > > >

Re: [PATCH] drm/amdgpu/mes: Fix an error handling path in amdgpu_mes_self_test()

2022-07-05 Thread Alex Deucher
Applied. Thanks! On Tue, Jul 5, 2022 at 9:46 AM Jianglei Nie wrote: > > if amdgpu_mes_ctx_alloc_meta_data() fails, we should call amdgpu_vm_fini() > to handle amdgpu_vm_init(). > > Add a new lable before amdgpu_vm_init() and goto this lable when > amdgpu_mes_ctx_alloc_meta_data() fails. > > Sign

RE: [PATCH] drm/amdgpu: Fix GTT size reporting in amdgpu_ioctl

2022-07-05 Thread Chen, Guchun
Hi Alex, I think we need to revert this patch on amd-staging-drm-next branch, as its base commit like " drm/amdgpu: remove GTT accounting v2" does not present on 5.16. Instead, the series is part of upcoming 5.18 based amd-staging-drm-next branch. Otherwise, incorrect GTT size reporting switche

[PATCH] drm/amdgpu/mes: Fix an error handling path in amdgpu_mes_self_test()

2022-07-05 Thread Jianglei Nie
if amdgpu_mes_ctx_alloc_meta_data() fails, we should call amdgpu_vm_fini() to handle amdgpu_vm_init(). Add a new lable before amdgpu_vm_init() and goto this lable when amdgpu_mes_ctx_alloc_meta_data() fails. Signed-off-by: Jianglei Nie --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 4 +++- 1 fil

RE: [PATCH 00/40] DC Patches Jun 30, 2022

2022-07-05 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following displ

Re: [PATCH v6 14/22] dma-buf: Introduce new locking convention

2022-07-05 Thread Dmitry Osipenko
On 7/5/22 01:38, Dmitry Osipenko wrote: ... >>> Also i915 will run into trouble with attach. In particular since i915 >>> starts a full ww transaction in its attach callback to be able to lock >>> other objects if migration is needed. I think i915 CI would catch this >>> in a selftest. >> Seems it

Re: [Linaro-mm-sig] Re: [PATCH v6 02/22] drm/gem: Move mapping of imported dma-bufs to drm_gem_mmap_obj()

2022-07-05 Thread Dmitry Osipenko
On 7/4/22 15:33, Christian König wrote: > Am 30.06.22 um 01:06 schrieb Dmitry Osipenko: >> On 6/29/22 11:43, Thomas Hellström (Intel) wrote: >>> On 6/29/22 10:22, Dmitry Osipenko wrote: On 6/29/22 09:40, Thomas Hellström (Intel) wrote: > On 5/27/22 01:50, Dmitry Osipenko wrote: >> Driv

Re: [PATCH v6 14/22] dma-buf: Introduce new locking convention

2022-07-05 Thread Dmitry Osipenko
On 7/1/22 13:43, Dmitry Osipenko wrote: > On 6/29/22 00:26, Thomas Hellström (Intel) wrote: >> On 5/30/22 15:57, Dmitry Osipenko wrote: >>> On 5/30/22 16:41, Christian König wrote: Hi Dmitry, Am 30.05.22 um 15:26 schrieb Dmitry Osipenko: > Hello Christian, > > On 5/30/22

RE: [PATCH] drm/amdgpu/mes11: fix to unmap legacy queue

2022-07-05 Thread Zhang, Hawking
[Public] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Jack Xiao Sent: Tuesday, July 5, 2022 11:24 To: amd-gfx@lists.freedesktop.org Cc: Xiao, Jack Subject: [PATCH] drm/amdgpu/mes11: fix to unmap legacy queue MES fw updated to support unmapp

RE: [RESEND RFC 15/18] drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected

2022-07-05 Thread Lin, Wayne
[Public] > -Original Message- > From: Lyude Paul > Sent: Wednesday, June 8, 2022 3:30 AM > To: dri-de...@lists.freedesktop.org; nouv...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org > Cc: Lin, Wayne ; Ville Syrjälä > ; Zuo, Jerry ; Jani Nikula > ; Imre Deak ; Daniel Vetter >

RE: [RESEND RFC 18/18] drm/display/dp_mst: Move all payload info into the atomic state

2022-07-05 Thread Lin, Wayne
[Public] > -Original Message- > From: Lyude Paul > Sent: Wednesday, June 8, 2022 3:30 AM > To: dri-de...@lists.freedesktop.org; nouv...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org > Cc: Lin, Wayne ; Ville Syrjälä > ; Zuo, Jerry ; Jani Nikula > ; Imre Deak ; Daniel Vetter >

Re: [PATCH RESEND V2 1/3] drm/amdgpu: fix checkpatch warnings

2022-07-05 Thread Christian König
Am 04.07.22 um 15:54 schrieb Vijendar Mukunda: From: vijendar Fixed below checkpatch warnings and errors drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL could be written "apd" drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:150: CHECK: Comparison to NULL could be written "a

[PATCH] drm/amdgpu/mes11: fix to unmap legacy queue

2022-07-05 Thread Jack Xiao
MES fw updated to support unmapping legacy gfx/compute queue. Signed-off-by: Jack Xiao --- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c| 9 - drivers/gpu/drm/amd/include/mes_v11_api_def.h | 6 +- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amd