RE: [PATCH] drm/amd/display: correct idle_power_optimizations disablement return value

[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Thursday, July 7, 2022 11:01 AM > To: Quan, Evan > Cc: amd-gfx list ; Deucher, Alexander > ; Pillai, Aurabindo > ; for 3.8 > Subject: Re: [PATCH] drm/amd/display: correct idle_power_optimizations >

[PATCH V2] drm/amd/display: correct idle_power_optimizations disablement return value

[Why] The return value indicates whether the operation(disable/enable) succeeded or not. The existing logic reports wrong result even if the disablement was performed successfully. That will make succeeding reenablement abandoned as dc->idle_optimizations_allowed is always true. [How] Correct the

RE: [PATCH] drm/amd/display: remove stale debug setting

[AMD Official Use Only - General] Reviewed-and-tested-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Aurabindo Pillai > Sent: Wednesday, July 6, 2022 11:25 PM > To: amd-gfx@lists.freedesktop.org > Cc: Siqueira, Rodrigo ; Pillai, Aurabindo > ; Wentland, Harry >

Re: [PATCH] drm/amd/display: correct idle_power_optimizations disablement return value

On Wed, Jul 6, 2022 at 10:46 PM Evan Quan wrote: > > [Why] > The return value indicates whether the operation(disable/enable) succeeded > or not. The existing logic reports wrong result even if the disablement was > performed successfully. That will make succeeding reenablement abandoned > as

[PATCH] drm/amd/display: correct idle_power_optimizations disablement return value

[Why] The return value indicates whether the operation(disable/enable) succeeded or not. The existing logic reports wrong result even if the disablement was performed successfully. That will make succeeding reenablement abandoned as dc->idle_optimizations_allowed is always true. [How] Correct the

[pull] amdgpu drm-fixes-5.19

Hi Dave, Daniel, Fixes for 5.19. The following changes since commit b8f0009bc9edf9186b20ae2a9e442ef0af93040e: Merge tag 'drm-misc-fixes-2022-06-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2022-07-01 09:27:55 +1000) are available in the Git repository at:

[PATCH -next] drm/amd/display: clean up some inconsistent indenting

Eliminate the follow smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:405 get_bios_object_from_path_v3() warn: inconsistent indenting drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:611 bios_parser_get_hpd_info() warn: inconsistent indenting

Re: [Bug][5.19-rc0] Between commits fdaf9a5840ac and babf0bb978e3 GPU stopped entering in graphic mode.

On Tue, Jun 28, 2022 at 2:21 PM Mikhail Gavrilov wrote: > Christian can you look why drm_aperture_remove_conflicting_pci_framebuffers cause this kernel bug on my machine? [6.822385] amdgpu: Ignoring ACPI CRAT on non-APU system [6.822462] amdgpu: Virtual CRAT table created for CPU [

Re: [PATCH] drm/radeon: avoid bogus "vram limit (0) must be a power of 2" warning

Applied. Thanks! Alex On Wed, Jul 6, 2022 at 5:40 PM Mateusz Jończyk wrote: > > I was getting the following message on boot on Linux 5.19-rc5: > radeon :01:05.0: vram limit (0) must be a power of 2 > (I didn't use any radeon.vramlimit commandline parameter). > > This is caused by >

[PATCH] drm/amd/display: fix non-x86/PPC64 compilation

Need to protect FP DMCUB code with CONFIG_DRM_AMD_DC_DCN. Fixes build failures like the following on arm64: ERROR: modpost: "__floatunsidf" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "__divdf3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "fma"

[PATCH] drm/radeon: avoid bogus "vram limit (0) must be a power of 2" warning

I was getting the following message on boot on Linux 5.19-rc5: radeon :01:05.0: vram limit (0) must be a power of 2 (I didn't use any radeon.vramlimit commandline parameter). This is caused by commit 8c2d34eb53b9 ("drm/radeon: use kernel is_power_of_2 rather than local version")

Re: CONFIG_ANDROID (was: rcu_sched detected expedited stalls in amdgpu after suspend)

On Wed, Jul 06, 2022 at 08:09:49PM +0200, Uladzislau Rezki wrote: > On Wed, Jul 06, 2022 at 10:58:36AM -0700, Paul E. McKenney wrote: > > On Wed, Jul 06, 2022 at 07:48:20PM +0200, Uladzislau Rezki wrote: > > > Hello. > > > > > > On Mon, Jul 04, 2022 at 01:30:50PM +0200, Christian König wrote: > >

Re: [PATCH 02/40] drm/amd/display: Add SubVP required code

~~~ > > 605 | (double)phantom_timing->h_total; > > | ~~~ > > > > I initially reproduced this with Fedora's configuration [1] but i

Re: CONFIG_ANDROID (was: rcu_sched detected expedited stalls in amdgpu after suspend)

On Wed, Jul 06, 2022 at 10:58:36AM -0700, Paul E. McKenney wrote: > On Wed, Jul 06, 2022 at 07:48:20PM +0200, Uladzislau Rezki wrote: > > Hello. > > > > On Mon, Jul 04, 2022 at 01:30:50PM +0200, Christian König wrote: > > > Hi guys, > > > > > > Am 28.06.22 um 22:11 schrieb Uladzislau Rezki: > >

Re: CONFIG_ANDROID (was: rcu_sched detected expedited stalls in amdgpu after suspend)

Hello. On Mon, Jul 04, 2022 at 01:30:50PM +0200, Christian König wrote: > Hi guys, > > Am 28.06.22 um 22:11 schrieb Uladzislau Rezki: > > > Excerpts from Paul E. McKenney's message of June 28, 2022 2:54 pm: > > > > All you need to do to get the previous behavior is to add something like > > > >

Re: [PATCH 02/40] drm/amd/display: Add SubVP required code

n [1] but it > appears that allmodconfig should show it as well. Our CI also shows > problems for ARCH=riscv allmodconfig [2]. > > I am happy to test patches as necessary. > > [1]: > https://src.fedoraproject.org/rpms/kernel/raw/rawhide/f/kernel-aarch64-fedora.config > [2

[PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

The patch fixes warnings/error as reported by Smatch a static analyzer drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1428 kfd_create_indirect_link_prop() warn: iterator used outside loop: 'cpu_link' drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1462 kfd_create_indirect_link_prop()

Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

Am 2022-07-06 um 12:47 schrieb Ramesh Errabolu: The patch fixes warnings/error as reported by Smatch a static analyzer drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1428 kfd_create_indirect_link_prop() warn: iterator used outside loop: 'cpu_link'

Re: CONFIG_ANDROID (was: rcu_sched detected expedited stalls in amdgpu after suspend)

On Wed, Jul 06, 2022 at 07:48:20PM +0200, Uladzislau Rezki wrote: > Hello. > > On Mon, Jul 04, 2022 at 01:30:50PM +0200, Christian König wrote: > > Hi guys, > > > > Am 28.06.22 um 22:11 schrieb Uladzislau Rezki: > > > > Excerpts from Paul E. McKenney's message of June 28, 2022 2:54 pm: > > > > >

Re: [PATCH 02/40] drm/amd/display: Add SubVP required code

/src.fedoraproject.org/rpms/kernel/raw/rawhide/f/kernel-aarch64-fedora.config [2]: https://builds.tuxbuild.com/2BZS5HPSuDdoMFw6mxjG2ZmT441/build.log Cheers, Nathan # bad: [088b9c375534d905a4d337c78db3b3bfbb52c4a0] Add linux-next specific files for 20220706 # good: [e35e5b6f695d241ffb1d223207da58a1fbcdff4b] Merge tag 'xsa-5.19-ta

[PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

The patch fixes warnings/error as reported by Smatch a static analyzer drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1428 kfd_create_indirect_link_prop() warn: iterator used outside loop: 'cpu_link' drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1462 kfd_create_indirect_link_prop()

Re: [PATCH] drm/amd/display: remove repeated includes

Applied. Thanks! On Wed, Jul 6, 2022 at 9:49 AM Harry Wentland wrote: > > On 2022-07-06 05:13, Guo Zhengkui wrote: > > Remove a repeated "#include " > > > > Signed-off-by: Guo Zhengkui > > Reviewed-by: Harry Wentland > > Harry > > > --- > > drivers/gpu/drm/amd/display/dc/os_types.h | 2 -- >

Re: [PATCH] drm/amdgpu/display: Remove duplicated argument to ||

Applied. Thanks! On Wed, Jul 6, 2022 at 3:41 AM Zhongjun Tan wrote: > > From: Zhongjun Tan > > Remove duplicated argument to || > > Signed-off-by: Zhongjun Tan > --- > .../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] drm/amd/display: remove stale debug setting

[Public] Thanks, will merge with Cc and fixes tag -- Regards, Jay From: Deucher, Alexander Sent: Wednesday, July 6, 2022 11:33 AM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org Cc: Siqueira, Rodrigo ; Wentland, Harry Subject: Re: [PATCH]

Re: [PATCH] drm/amd/display: remove stale debug setting

[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Aurabindo Pillai Sent: Wednesday, July 6, 2022 11:25 AM To: amd-gfx@lists.freedesktop.org Cc: Siqueira, Rodrigo ; Pillai, Aurabindo ; Wentland, Harry Subject: [PATCH] drm/amd/display: remove stale

[PATCH] drm/amd/display: remove stale debug setting

[Why] The debug option to disable idle power optimization can be dropped Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c

Re: [PATCH 2/2] drm/amd/display: make get_refresh_rate() static

On 2022-07-06 10:08, Alex Deucher wrote: > It's not used outside of dcn30_resource.c. > > Reported-by: kernel test robot > Signed-off-by: Alex Deucher > --- Both patches are Reviewed-by: Harry Wentland Harry > drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +- > 1 file

[PATCH 2/2] drm/amd/display: make get_refresh_rate() static

It's not used outside of dcn30_resource.c. Reported-by: kernel test robot Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c

[PATCH 1/2] drm/amd/display: remove set but unused variable

Fixes the following: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_hwseq.c:428:33: warning: variable 'old_pipe' set but not used Reported-by: kernel test robot Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH] drm/amd/display: Add missing header

nit: "Add missing function definition" On 2022-07-06 10:05, Rodrigo Siqueira wrote: > Kernel test robot reported this GCC error: > > warning: no previous prototype for 'dc_reset_state' [-Wmissing-prototypes] > 2720 | void dc_reset_state(struct dc *dc, struct dc_state *context) > > This

[PATCH] drm/amd/display: Add missing header

Kernel test robot reported this GCC error: warning: no previous prototype for 'dc_reset_state' [-Wmissing-prototypes] 2720 | void dc_reset_state(struct dc *dc, struct dc_state *context) This commit adds the missing prototype. Reported-by: kernel test robot Signed-off-by: Rodrigo Siqueira

Re: [PATCH] drm/amd/display: remove repeated includes

On 2022-07-06 05:13, Guo Zhengkui wrote: > Remove a repeated "#include " > > Signed-off-by: Guo Zhengkui Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/os_types.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h

[PATCH] drm/amd/display: remove repeated includes

Remove a repeated "#include " Signed-off-by: Guo Zhengkui --- drivers/gpu/drm/amd/display/dc/os_types.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h b/drivers/gpu/drm/amd/display/dc/os_types.h index 795dd486b6d6..6b88ae14f1f9 100644 ---

Re: (subset) [PATCH V2 0/5] I2S driver changes for Jadeite platform

On Fri, 1 Jul 2022 17:11:02 +0530, Vijendar Mukunda wrote: > Jadeite(JD) platform is Stoney APU varaint which uses I2S MICSP > instance and ES8336 Codec. > This patch series creates I2S platform devices for JD platform, > adds I2S MICSP instance support and Machine driver support > > This patch

Re: [PATCH v3 1/3] drm/amdgpu: fix for coding style issues

Am 06.07.22 um 12:28 schrieb Vijendar Mukunda: Fixed below checkpatch warnings and errors drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL could be written "apd" drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:150: CHECK: Comparison to NULL could be written "apd"

[PATCH v2 3/3] drm/amdgpu: create I2S platform devices for Jadeite platform

Jadeite platform uses I2S MICSP instance. Create platform devices for DMA controller and I2S controller for Jadeite platform. Signed-off-by: Vijendar Mukunda Acked-by: Alex Deucher --- changes since v1: - Modified commit lable as drm/amdgpu drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 293

[PATCH v2 2/3] drm/amdgpu: add dmi check for jadeite platform

DMI check is required to distinguish Jadeite platform from Stoney base variant. Add DMI check logic for Jadeite platform. Signed-off-by: Vijendar Mukunda Acked-by: Alex Deucher --- changes since v1: - Modified commit label as drm/amdgpu drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 36

[PATCH v3 1/3] drm/amdgpu: fix for coding style issues

Fixed below checkpatch warnings and errors drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL could be written "apd" drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:150: CHECK: Comparison to NULL could be written "apd" drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:196: CHECK: Prefer

[PATCH] drm/amdgpu/display: Remove duplicated argument to ||

From: Zhongjun Tan Remove duplicated argument to || Signed-off-by: Zhongjun Tan --- .../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c

[PATCH] drm/amd/display: Fix unsigned expression compared with zero

From: Zhongjun Tan Fix unsigned expression compared with zero Signed-off-by: Zhongjun Tan --- .../gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c