[AMD Official Use Only - General]
> -Original Message-
> From: Chen, Guchun
> Sent: Wednesday, July 13, 2022 11:53 PM
> To: Alex Deucher
> Cc: amd-gfx list ; Deucher, Alexander
> ; Zhang, Hawking
> ; Lazar, Lijo ; Quan, Evan
> ; Feng, Kenneth
> Subject: RE: [PATCH 1/2] drm/amdgpu: skip
Sounds good, Alex. Let me update it soon.
Also, after a discussion with Lijo, once we introduce rpm mode, we think it's
fine to drop adev->runpm indicator by rpm mode, as it's a bit overlapped with
latter one.
So for the check like adev->runpm, we can use 'rpm_mode != AMDGPU_RUNPM_NONE'
instead
On Wed, Jul 13, 2022 at 11:15 PM Chen, Guchun wrote:
>
> Re: I think this would be better as:
> if (adev->in_runpm && (adev->pm.rpm_mode != AMDGPU_RUNPM_BOCO)) or something
> like that.
>
> Yes, patch 2 in this series addresses it. Patch 1 intends to fix SMU
> reloading, while patch 2 focus on f
Re: I think this would be better as:
if (adev->in_runpm && (adev->pm.rpm_mode != AMDGPU_RUNPM_BOCO)) or something
like that.
Yes, patch 2 in this series addresses it. Patch 1 intends to fix SMU reloading,
while patch 2 focus on fixing race issue when getting feature mask during
runtime cycle.
feel free to add
Reviewed-by: Jingwen Chen
On 7/14/22 10:31 AM, lin cao wrote:
> In the case of SRIOV, the register smnMp1_PMI_3_FIFO will get an invalid
> value which will cause the "shift out of bound". In Ubuntu22.04, this
> issue will be checked an related call trace will be reported in dmes
From: Kees Cook
GCC 12 correctly reports a potential use-after-free condition in the
xrealloc helper. Fix the warning by avoiding an implicit "free(ptr)"
when size == 0:
In file included from help.c:12:
In function 'xrealloc',
inlined from 'add_cmdname' at help.c:24:2: subcmd-util.h:56:23: e
From: Sergei Trofimovich
On GCC 12, the build fails due to a possible truncated string:
check.c: In function 'validate_call':
check.c:2865:58: error: '%d' directive output may be truncated writing
between 1 and 10 bytes into a region of size 9 [-Werror=format-truncation=]
2865 |
Hello Alex,
I believe you are already working on a rebase right now, but could you please
cherry-pick these two commits from torvalds/master to fix compilation errors
raised by
GCC12 in the meantime?
SHA-1:82880283d7fcd0a1d20964a56d6d1a5cc0df0713
patch-id: 684ed745d944c90c2aae3c9eda5a4f5aa9c
In the case of SRIOV, the register smnMp1_PMI_3_FIFO will get an invalid
value which will cause the "shift out of bound". In Ubuntu22.04, this
issue will be checked an related call trace will be reported in dmesg.
Signed-off-by: lin cao
---
drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
On Wed, Jul 13, 2022 at 7:09 PM Guenter Roeck wrote:
>
> On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote:
> > >
> > > The problem is not the FPU operations, but the fact that soft-float
> > > and hard-float compiled code is linked together. The soft-float and
> > > hard-float ABIs on
On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote:
> >
> > The problem is not the FPU operations, but the fact that soft-float
> > and hard-float compiled code is linked together. The soft-float and
> > hard-float ABIs on powerpc are not compatible, so one ends up with
> > an object file
On Thu, Jul 14, 2022 at 12:12 AM Guenter Roeck wrote:
>
> On Thu, Jul 14, 2022 at 12:09:24AM +0100, Sudip Mukherjee wrote:
> > On Wed, Jul 13, 2022 at 11:56 PM Guenter Roeck wrote:
> > >
> > > On Wed, Jul 13, 2022 at 10:50:06PM +0100, Sudip Mukherjee wrote:
> > > > On Wed, Jul 13, 2022 at 10:45 P
On Wed, Jul 13, 2022 at 10:50:06PM +0100, Sudip Mukherjee wrote:
> On Wed, Jul 13, 2022 at 10:45 PM Linus Torvalds
> wrote:
> >
> > On Wed, Jul 13, 2022 at 2:36 PM Sudip Mukherjee
> > wrote:
> > >
> > > > >
> > > > > https://lore.kernel.org/all/20220524025139.40212-1-wangkefeng.w...@huawei.com/
>
On Thu, Jul 14, 2022 at 12:26:27AM +0100, Sudip Mukherjee wrote:
> On Thu, Jul 14, 2022 at 12:12 AM Guenter Roeck wrote:
> >
> > On Thu, Jul 14, 2022 at 12:09:24AM +0100, Sudip Mukherjee wrote:
> > > On Wed, Jul 13, 2022 at 11:56 PM Guenter Roeck wrote:
> > > >
> > > > On Wed, Jul 13, 2022 at 10:
On Wed, Jul 13, 2022 at 11:56 PM Guenter Roeck wrote:
>
> On Wed, Jul 13, 2022 at 10:50:06PM +0100, Sudip Mukherjee wrote:
> > On Wed, Jul 13, 2022 at 10:45 PM Linus Torvalds
> > wrote:
> > >
> > > On Wed, Jul 13, 2022 at 2:36 PM Sudip Mukherjee
> > > wrote:
> > > >
> > > > > >
> > > > > > https
On Thu, Jul 14, 2022 at 12:09:24AM +0100, Sudip Mukherjee wrote:
> On Wed, Jul 13, 2022 at 11:56 PM Guenter Roeck wrote:
> >
> > On Wed, Jul 13, 2022 at 10:50:06PM +0100, Sudip Mukherjee wrote:
> > > On Wed, Jul 13, 2022 at 10:45 PM Linus Torvalds
> > > wrote:
> > > >
> > > > On Wed, Jul 13, 2022
On Wed, Jul 13, 2022 at 10:50:06PM +0100, Sudip Mukherjee wrote:
> On Wed, Jul 13, 2022 at 10:45 PM Linus Torvalds
> wrote:
> >
> > On Wed, Jul 13, 2022 at 2:36 PM Sudip Mukherjee
> > wrote:
> > >
> > > > >
> > > > > https://lore.kernel.org/all/20220524025139.40212-1-wangkefeng.w...@huawei.com/
>
On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote:
[ ... ]
> > The problem is not the FPU operations, but the fact that soft-float
> > and hard-float compiled code is linked together. The soft-float and
> > hard-float ABIs on powerpc are not compatible, so one ends up with
> > an object
On Wed, Jul 13, 2022 at 10:45 PM Linus Torvalds
wrote:
>
> On Wed, Jul 13, 2022 at 2:36 PM Sudip Mukherjee
> wrote:
> >
> > > >
> > > > https://lore.kernel.org/all/20220524025139.40212-1-wangkefeng.w...@huawei.com/
> > >
> > > That patch looks sane to me, but I guess Guenter would need to check
>
On Wed, Jul 13, 2022 at 2:36 PM Sudip Mukherjee
wrote:
>
> > >
> > > https://lore.kernel.org/all/20220524025139.40212-1-wangkefeng.w...@huawei.com/
> >
> > That patch looks sane to me, but I guess Guenter would need to check
>
> I still see the failure in my builds with this patch. But surprisingl
On Wed, Jul 13, 2022 at 9:42 PM Linus Torvalds
wrote:
>
> On Wed, Jul 13, 2022 at 12:49 PM Russell King (Oracle)
> wrote:
> >
> > There may be a patch that solves that, but it's never been submitted to
> > my patch system:
> >
> > https://lore.kernel.org/all/20220524025139.40212-1-wangkefeng.w...
On Wed, Jul 13, 2022 at 2:01 PM Alex Deucher wrote:
>
> If you want to apply Guenter's patch original patch:
> https://patchwork.freedesktop.org/patch/490184/
> That's fine with me.
Honestly, by this time I feel that it's too little, too late.
The ppc people apparently didn't care at all about t
On 7/13/22 13:57, Alex Deucher wrote:
On Thu, Jun 30, 2022 at 5:01 PM Rodrigo Siqueira Jordao
wrote:
On 2022-06-18 19:27, Guenter Roeck wrote:
ppc:allmodconfig builds fail with the following error.
powerpc64-linux-ld:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o
On Wed, Jul 13, 2022 at 5:18 PM Guenter Roeck wrote:
>
> On 7/13/22 13:57, Alex Deucher wrote:
> > On Thu, Jun 30, 2022 at 5:01 PM Rodrigo Siqueira Jordao
> > wrote:
> >>
> >>
> >>
> >> On 2022-06-18 19:27, Guenter Roeck wrote:
> >>> ppc:allmodconfig builds fail with the following error.
> >>>
>
On Wed, Jul 13, 2022 at 4:46 PM Guenter Roeck wrote:
>
> On 7/13/22 12:36, Linus Torvalds wrote:
> > On Tue, Jul 12, 2022 at 10:07 PM Guenter Roeck wrote:
> >>
> >> Same problems as every week.
> >>
> >> Building powerpc:allmodconfig ... failed
> >
> > Ok, this has been going on since -rc1, which
On Wed, Jul 13, 2022 at 1:46 PM Guenter Roeck wrote:
>
> It does, but I can't imagine that the drm or ppc people would be happy
> about it.
When something has been reported as not building for five weeks?
I have zero f's to give at that point about their "happiness".
Linus
On Thu, Jun 30, 2022 at 5:01 PM Rodrigo Siqueira Jordao
wrote:
>
>
>
> On 2022-06-18 19:27, Guenter Roeck wrote:
> > ppc:allmodconfig builds fail with the following error.
> >
> > powerpc64-linux-ld:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o
> > uses h
On 7/13/22 12:36, Linus Torvalds wrote:
On Tue, Jul 12, 2022 at 10:07 PM Guenter Roeck wrote:
Same problems as every week.
Building powerpc:allmodconfig ... failed
Ok, this has been going on since -rc1, which is much too long.
From your patch submission that that was rejected:
The prob
On 7/13/22 13:22, Linus Torvalds wrote:
On Wed, Jul 13, 2022 at 12:53 PM Alex Deucher wrote:
Does this patch fix it?
https://patchwork.freedesktop.org/patch/493799/
Guenter? Willing to check this one too for your setup, and we can
hopefully close down both issues?
No, that fixes a differe
On Wed, Jul 13, 2022 at 1:40 PM Guenter Roeck wrote:
>
> That patch is (and has been) in linux-next for a long time,
> as commit d2ca1fd2bc70, and with the following tags.
>
> Fixes: 7719a68b2fa4 ("ARM: 9192/1: amba: fix memory leak in
> amba_device_try_add()")
> Reported-by: Guenter Ro
On 7/13/22 13:21, Linus Torvalds wrote:
On Wed, Jul 13, 2022 at 12:49 PM Russell King (Oracle)
wrote:
There may be a patch that solves that, but it's never been submitted to
my patch system:
https://lore.kernel.org/all/20220524025139.40212-1-wangkefeng.w...@huawei.com/
That patch looks sane
On Wed, Jul 13, 2022 at 12:53 PM Alex Deucher wrote:
>
> Does this patch fix it?
> https://patchwork.freedesktop.org/patch/493799/
Guenter? Willing to check this one too for your setup, and we can
hopefully close down both issues?
Linus
On Wed, Jul 13, 2022 at 12:49 PM Russell King (Oracle)
wrote:
>
> There may be a patch that solves that, but it's never been submitted to
> my patch system:
>
> https://lore.kernel.org/all/20220524025139.40212-1-wangkefeng.w...@huawei.com/
That patch looks sane to me, but I guess Guenter would ne
On 2022-07-12 18:42, Guenter Roeck wrote:
> The new display engine uses floating point math, which is not supported
> by KCOV. Commit 9d1d02ff3678 ("drm/amd/display: Don't build DCN1 when kcov
> is enabled") tried to work around the problem by disabling
> CONFIG_DRM_AMD_DC_DCN if KCOV_INSTRUMENT_AL
On Wed, Jul 13, 2022 at 12:36:50PM -0700, Linus Torvalds wrote:
> On Tue, Jul 12, 2022 at 10:07 PM Guenter Roeck wrote:
> > OF: amba_device_add() failed (-19) for /amba/smc@1010
> > [ cut here ]
> > WARNING: CPU: 0 PID: 1 at lib/refcount.c:28
> > of_platform_bus_create
On Wed, Jul 13, 2022 at 3:42 PM Linus Torvalds
wrote:
>
> On Tue, Jul 12, 2022 at 10:07 PM Guenter Roeck wrote:
> >
> > Same problems as every week.
> >
> > Building powerpc:allmodconfig ... failed
>
> Ok, this has been going on since -rc1, which is much too long.
>
> From your patch submission t
On Tue, Jul 12, 2022 at 10:07 PM Guenter Roeck wrote:
>
> Same problems as every week.
>
> Building powerpc:allmodconfig ... failed
Ok, this has been going on since -rc1, which is much too long.
>From your patch submission that that was rejected:
> The problem was introduced with commit 41b7a34
On 2022-07-13 13:33, Christian König wrote:
Am 13.07.22 um 19:13 schrieb Andrey Grodzovsky:
This is a follow-up cleanup to [1]. See bellow refcount balancing
for calling amdgpu_job_submit_direct after this cleanup as far
as I calculated.
amdgpu_fence_emit
dma_fence_init 1
dma_fence_ge
[AMD Official Use Only - General]
Series is Reviewed-by: Kent Russell
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Wednesday, July 13, 2022 2:01 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH 2/2] drm/amdgpu: use the sam
Align aldebaran with all other asics. One HDP bit per
SDMA instance, aligned with firmware. This is effectively
a revert of
commit a0f9f8546668 ("drm/amdgpu/nbio7.4: don't use GPU_HDP_FLUSH bit 12").
On further discussions with the relevant hardware teams,
re-align the bits for SDMA.
Signed-off-
Align RDNA2.x with other asics. One HDP bit per SDMA instance,
aligned with firmware. This is effectively a revert of
commit 369b7d04baf3 ("drm/amdgpu/nbio2.3: don't use GPU_HDP_FLUSH bit 12").
On further discussions with the relevant hardware teams,
re-align the bits for SDMA.
Signed-off-by: Al
Am 13.07.22 um 19:13 schrieb Andrey Grodzovsky:
This is a follow-up cleanup to [1]. See bellow refcount balancing
for calling amdgpu_job_submit_direct after this cleanup as far
as I calculated.
amdgpu_fence_emit
dma_fence_init 1
dma_fence_get(fence) 2
rcu_assign_pointer(*
Hi Dave, Daniel,
Fixes for 5.19.
The following changes since commit 3590b44b9434af1b9c81c3f40189087ed4fe3635:
Merge tag 'drm-misc-fixes-2022-07-07-1' of
ssh://git.freedesktop.org/git/drm/drm-misc into drm-fixes (2022-07-12 10:44:40
+1000)
are available in the Git repository at:
https://g
[Public]
> -Original Message-
> From: Werner Sembach
> Sent: Wednesday, July 13, 2022 12:08
> To: Hans de Goede ; Ben Skeggs
> ; Karol Herbst ; Lyude
> ; Daniel Dadap ; Maarten
> Lankhorst ; Maxime Ripard
> ; Thomas Zimmermann ;
> Jani Nikula ; Joonas Lahtinen
> ; Rodrigo Vivi ;
> Tvrtk
Hi,
On 7/12/22 21:39, Hans de Goede wrote:
acpi_backlight=native is the default for these, but as the comment
explains the quirk was still necessary because even briefly registering
the acpi_video0 backlight; and then unregistering it once the native
driver showed up, was leading to issues.
Aft
This is a follow-up cleanup to [1]. See bellow refcount balancing
for calling amdgpu_job_submit_direct after this cleanup as far
as I calculated.
amdgpu_fence_emit
dma_fence_init 1
dma_fence_get(fence) 2
rcu_assign_pointer(*ptr, dma_fence_get(fence) 3
---> amdgpu_job_submi
[AMD Official Use Only - General]
This patch is Reviewed-by: James Zhu
From: amd-gfx on behalf of Sonny Jiang
Sent: Wednesday, July 13, 2022 11:59 AM
To: amd-gfx@lists.freedesktop.org
Cc: Jiang, Sonny
Subject: [PATCH v2] drm/amdgpu: limiting AV1 to first in
AV1 is only supported on first instance.
Signed-off-by: Sonny Jiang
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 131 ++
1 file changed, 131 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
index 84ac2401895a..a91ff
On Tue, Jul 12, 2022 at 11:18 PM Guchun Chen wrote:
>
> SMU is always alive, so it's fine to skip SMU FW reloading
> when runpm resumed from BACO, this can avoid some race issues
> when resuming SMU FW.
>
> v2: Exclude boco case if an ASIC supports both boco and baco
>
> Suggested-by: Evan Quan
>
It's not used outside of amdgpu_dm.c.
Reported-by: kernel test robot
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/dis
GFXOFF has two different "state" values: one to define if the GPU is
allowed/disallowed to enter GFXOFF, usually called state; and another
one to define if currently GFXOFF is being used, usually called status.
Even when GFXOFF is allowed, GPU firmware can decide to not used it
accordingly to the G
On 2022-07-08 19:17, Ramesh Errabolu wrote:
- Update defconfig for PCI_P2PDMA
- Update defconfig for DMABUF_MOVE_NOTIFY
- Update defconfig for HSA_AMD_P2P
---
The patch is missing a Signed-off-by. With that fixed
Reviewed-by: Felix Kuehling
Notes:
Following procedure w
Am 2022-07-13 um 05:14 schrieb shikai guo:
From: Shikai Guo
While executing KFDMemoryTest.MMBench, test case will allocate 4KB size memory
1000 times.
Every time, user space will get 2M memory.APU VRAM is 512M, there is not enough
memory to be allocated.
So the 2M aligned feature is not sui
On Wed, Jul 13, 2022 at 5:14 AM shikai guo wrote:
>
> From: Shikai Guo
>
> While executing KFDMemoryTest.MMBench, test case will allocate 4KB size
> memory 1000 times.
> Every time, user space will get 2M memory.APU VRAM is 512M, there is not
> enough memory to be allocated.
> So the 2M aligned
On Sat, Jul 9, 2022 at 5:10 PM Mikhail Gavrilov
wrote:
> Hi Christian,
> if you read my initial post. You should see that I tried to bisect the issue.
> But it is very problematic because on each step I see different symptomes.
> And if mark different symptoms with skip step we got at end lot of
Smatch complains that:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3369
commit_planes_for_stream()
warn: variable dereferenced before check 'stream' (see line 3114)
The 'stream' pointer cannot be NULL and the check can be removed.
Signed-off-by: Dan Carpenter
---
drivers/gpu/dr
Am 12.07.22 um 18:30 schrieb sunpeng...@amd.com:
From: Leo Li
When pinning a buffer, we should check to see if there are any
additional restrictions imposed by bo->preferred_domains. This will
prevent the BO from being moved to an invalid domain when pinning.
For example, this can happen if th
From: Shikai Guo
While executing KFDMemoryTest.MMBench, test case will allocate 4KB size memory
1000 times.
Every time, user space will get 2M memory.APU VRAM is 512M, there is not enough
memory to be allocated.
So the 2M aligned feature is not suitable for APU.
guoshikai@guoshikai-MayanKD-RMB
58 matches
Mail list logo
