RE: [PATCH v2 1/6] drm/amdgpu: add mode2 reset for sienna_cichlid

2022-07-29 Thread Zhao, Victor
[AMD Official Use Only - General] Thanks for catching. Thanks, Victor -Original Message- From: Quan, Evan Sent: Friday, July 29, 2022 2:06 PM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Zhao, Victor ; Grodzovsky, Andrey Subject: RE: [PATCH v2 1/6] drm/amdgpu

RE: [PATCH v2 6/6] drm/amdgpu: reduce reset time

2022-07-29 Thread Zhao, Victor
[AMD Official Use Only - General] Hi Lijo, Can you be more specific why other gpus can be affected? I don’t have a xgmi system on my side. I thought reset_domain is per device. Thanks, Victor -Original Message- From: Lazar, Lijo Sent: Friday, July 29, 2022 2:11 PM To: Zhao, Victor

RE: [PATCH v2 6/6] drm/amdgpu: reduce reset time

2022-07-29 Thread Lazar, Lijo
[AMD Official Use Only - General] XGMI connected GPUs share the same reset domain software object. If the devices are not connected with each other, there is one domain per device. Thanks, Lijo -Original Message- From: Zhao, Victor Sent: Friday, July 29, 2022 2:58 PM To: Lazar, Lijo ;

Please consider Open-source OpenCL support in amdgpu/mesa

2022-07-29 Thread Luís Mendes
Hi, I am an Aparapi project developer that has been struggling for two years to get an RX 5700 properly running OpenCL applications. First of all, as an end consumer, I would like to congratulate the open-source amdgpu driver for its stability and performance, as well as the team behind it! Unfor

Re: [PATCH] drm/amd/display: Fix a compilation failure on PowerPC caused by FPU code

2022-07-29 Thread Maíra Canal
Hi Siqueira On 7/28/22 17:33, Rodrigo Siqueira wrote: > We got a report from Stephen/Michael that the PowerPC build was failing > with the following error: > > ld: drivers/gpu/drm/amd/display/dc/dml/display_mode_lib.o uses hard float, > drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.o uses soft

Re: Please consider Open-source OpenCL support in amdgpu/mesa

2022-07-29 Thread Mike Lothian
I've recently gotten ROCm 5.1.3 working on Gentoo with the open drivers and using upstream llvm 14.0.6, it's enough to get LuxMark 3 running (well with fast math disabled) You might want to look for a distro that packages ROCm for you as Clover is nowhere near ready On Fri, 29 Jul 2022 at 11:06,

Re: [PATCH] drm/amd/display: Fix a compilation failure on PowerPC caused by FPU code

2022-07-29 Thread Michael Ellerman
Rodrigo Siqueira writes: > We got a report from Stephen/Michael that the PowerPC build was failing > with the following error: > > ld: drivers/gpu/drm/amd/display/dc/dml/display_mode_lib.o uses hard float, > drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.o uses soft float > ld: failed to merge t

[PATCH] drm/amd/display: Remove useless else if

2022-07-29 Thread Jiapeng Chong
The assignment of the else and else if branches is the same, so the else if here is redundant, so we remove it and add a comment to make the code here readable. Eliminate the follow coccicheck warning: ./drivers/comedi/drivers/das1800.c:1300:8-10: WARNING: possible condition with no effect (if ==

Re: Please consider Open-source OpenCL support in amdgpu/mesa

2022-07-29 Thread Luís Mendes
Thanks for the info! There is also this Mesa candidate RustiCL which is already more feature complete than the Mesa Clover: https://www.phoronix.com/news/Mesa-OpenCL-3.0-CTS-Passes https://www.phoronix.com/news/Rusticl-Darktable-Milestone and it would be great if this OpenCL implementation materia

Re: [PATCH 2/2] drm/amdgpu: Pessimistic availability based on rounded up allocations

2022-07-29 Thread Felix Kuehling
Your patches are missing Signed-off-by lines. If you use "git commit -s", git should add those automatically for your convenience. Other than that, the patches look good to me. With Signed-off-by added, the series is Reviewed-by: Felix Kuehling Am 2022-07-28 um 23:16 schrieb Daniel Phillips:

[PATCH] drm/amd/display: Add a missing register field for HPO DP stream encoder

2022-07-29 Thread Aurabindo Pillai
[Why&How] Add the missing definition to set the register field HBLANK_MINIMUM_SYMBOL_WIDTH Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn31

Re: [PATCH] drm/amd/display: Add a missing register field for HPO DP stream encoder

2022-07-29 Thread Alex Deucher
Acked-by: Alex Deucher On Fri, Jul 29, 2022 at 1:42 PM Aurabindo Pillai wrote: > > [Why&How] > Add the missing definition to set the register field > HBLANK_MINIMUM_SYMBOL_WIDTH > > Signed-off-by: Aurabindo Pillai > --- > .../gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.h | 3 ++- >

[pull] amdgpu, amdkfd drm-next-5.20

2022-07-29 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.20. Mainly for new IPs. The following changes since commit 2bc7ea71a73747a77e7f83bc085b0d2393235410: Merge tag 'topic/nouveau-misc-2022-07-27' of git://anongit.freedesktop.org/drm/drm into drm-next (2022-07-27 11:34:07 +1000) are available in the Git repository

[PATCH] drm/amd/display: Increase frame-larger-than to 4096 in dml Makefile

2022-07-29 Thread Praful Swarnakar
When enabling kcov and debug kernel configuration, stack frame size exceeds set limit, resulting into build error. Fixes the following build warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_mode_vba_31.c:3955:6: error: stack frame size (2344) exceeds limit (2048) in 'dml31_Mode

[PATCH v2 1/3] drm/amd/display: make variables static

2022-07-29 Thread Magali Lemes
As "dcn3_1_soc", "dcn3_15_soc", and "dcn3_16_soc" are not used outside of their corresponding "dcn3*_fpu.c", make them static and remove their extern declaration. Fixes: 26f4712aedbd ("drm/amd/display: move FPU related code from dcn31 to dml/dcn31 folder") Fixes: fa896297b31b ("drm/amd/display: m

[PATCH v2 2/3] drm/amd/display: remove header from source file

2022-07-29 Thread Magali Lemes
Since "rn_clk_mgr.h" needs ‘struct clk_mgr_internal’ which is declared in "clk_mgr_internal.h", include "clk_mgr_internal.h" in "rn_clk_mgr.h" instead of in its source file. Because of the change above, change the order of '#include "rn_clk_mgr.h"', so that the necessary structs are visible to dcn2

[PATCH v2 3/3] drm/amd/display: include missing headers

2022-07-29 Thread Magali Lemes
Add missing headers to solve the following warnings from sparse: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:656:17: warning: symbol 'ddr4_wm_table_gs' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:693:17: warning: symbol

Stack-frame warnings in display_mode_vba_32.c

2022-07-29 Thread Paul E. McKenney
Hello! I am seeing the following in allmodconfig builds of recent -next on x86: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function ‘DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerformanceCalculation’: drivers/gpu/drm/amd/amdgpu/../display/dc/dml

Re: Stack-frame warnings in display_mode_vba_32.c

2022-07-29 Thread André Almeida
Hi Paul, Às 23:25 de 29/07/22, Paul E. McKenney escreveu: > Hello! > > I am seeing the following in allmodconfig builds of recent -next on x86: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In > function > ‘DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermark

Re: Stack-frame warnings in display_mode_vba_32.c

2022-07-29 Thread Paul E. McKenney
On Fri, Jul 29, 2022 at 11:41:55PM -0300, André Almeida wrote: > Hi Paul, > > Às 23:25 de 29/07/22, Paul E. McKenney escreveu: > > Hello! > > > > I am seeing the following in allmodconfig builds of recent -next on x86: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_3