RE: [RESEND RFC 15/18] drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected

2022-08-09 Thread Lin, Wayne
[Public] > -Original Message- > From: Lyude Paul > Sent: Wednesday, August 3, 2022 6:12 AM > To: Lin, Wayne ; dri-de...@lists.freedesktop.org; > nouv...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Cc: Ville Syrjälä ; Zuo, Jerry > ; Jani Nikula ; Imre Deak > ; Daniel Vetter ;

[PATCH 3/3] drm/amd/pm: add missing ->fini_xxxx interfaces for some SMU13 asics

2022-08-09 Thread Evan Quan
Without these, potential memory leak may be induced. Signed-off-by: Evan Quan Change-Id: Ied7cd204d44d739dece11774c9d29e7a192fd341 --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 2 ++ drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 2 ++ 2 files changed, 4 insertions(+) diff

[PATCH 2/3] drm/amd/pm: add missing ->fini_microcode interface for Sienna Cichlid

2022-08-09 Thread Evan Quan
To avoid any potential memory leak. Signed-off-by: Evan Quan Change-Id: Ide94e85d862c10aae93e04e3ce64c0451e5e1570 --- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu

[PATCH 1/3] drm/amdgpu: disable 3DCGCG/CGLS temporarily due to stability issue

2022-08-09 Thread Evan Quan
Some stability issues were reported with these features. Signed-off-by: Evan Quan Change-Id: I5fccae63bd530d6ff9e4167bb1c44319830806f9 --- drivers/gpu/drm/amd/amdgpu/soc21.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc

[RFC v3] drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions

2022-08-09 Thread Lyude Paul
There's another kind of situation where we could potentially race with nonblocking modesets and MST, especially if we were to only use the locking provided by atomic modesetting: * Display 1 begins as enabled on DP-1 in SST mode * Display 1 switches to MST mode, exposes one sink in MST mode * User

Re: [PATCH v2 1/3] drm/dp_mst: add passthrough_aux to struct drm_dp_mst_port

2022-08-09 Thread Lyude Paul
Ah yes of course! Probably should have asked when I gave the r-b :). Also, just so patchwork actually catches it I will say the magic incantation: Reviewed-by: Lyude Paul Do we want to merge just this patch to drm-misc-next, or do you want to merge the whole series through there? If you'd rather

RE: [PATCH] drm/amdkfd: Handle restart of kfd_ioctl_wait_events

2022-08-09 Thread Chen, Xiaogang
[AMD Official Use Only - General] This patch is: Reviewed-and-Tested-by: Xiaogang Chen -Original Message- From: Kuehling, Felix Sent: Thursday, August 4, 2022 5:29 PM To: amd-gfx@lists.freedesktop.org Cc: Chen, Xiaogang ; Curtis, Nicholas Subject: [PATCH] drm/amdkfd: Handle restart

Re: [PATCH] Increase tlb flush timeout for sriov

2022-08-09 Thread Deucher, Alexander
[AMD Official Use Only - General] Please add these details to the patch description when you respin. From: amd-gfx on behalf of Liu, Shaoyun Sent: Monday, August 8, 2022 6:30 PM To: Alex Deucher ; Milinkovic, Dusica Cc: amd-gfx@lists.freedesktop.org Subject:

Re: [PATCH 0/4] Fix S3 and S4 issues related to fbdev

2022-08-09 Thread Limonciello, Mario
On 8/9/2022 10:50, Alex Deucher wrote: On Tue, Aug 9, 2022 at 11:10 AM Mario Limonciello wrote: Moving to the generic fbdev helper introduced a regression in S4 support on Hawaii PRO graphics cards. A workaround commit was introduced to avoid this S4 regression until the root cause could be f

Re: [PATCH v5 00/33] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-08-09 Thread Daniel Vetter
[Catching up on mails] Did you see the feedback form Steven from tracing side of things? Does this version have that taken into account already? I think once we have that and acks from dyndbg maintainers then I think we should just land this and polish from there? Maybe some acks from drm drivrer

Re: [PATCH 0/4] Fix S3 and S4 issues related to fbdev

2022-08-09 Thread Alex Deucher
On Tue, Aug 9, 2022 at 11:10 AM Mario Limonciello wrote: > > Moving to the generic fbdev helper introduced a regression in S4 support > on Hawaii PRO graphics cards. A workaround commit was introduced to > avoid this S4 regression until the root cause could be found, but that > workaround commit

Re: [PATCH v2 1/3] drm/dp_mst: add passthrough_aux to struct drm_dp_mst_port

2022-08-09 Thread Hamza Mahfooz
Hey Lyude, On 2022-08-05 17:17, Lyude Paul wrote: lgtm! Any chance you can apply this to drm-misc-next? Reviewed-by: Lyude Paul On Fri, 2022-08-05 at 17:13 -0400, Hamza Mahfooz wrote: Currently, there is no way to identify if DSC pass-through can be enabled and what aux DSC pass-through

[PATCH 3/4] Revert "drm/amdgpu: drop amdgpu_display_gem_fb_init()"

2022-08-09 Thread Mario Limonciello
This reverts commit 60da2f7440f22dba48944602c2a0373068f13880. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216119 Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of setting up AMD own's.") Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2

[PATCH 4/4] Revert "drm/amdgpu: use generic fb helpers instead of setting up AMD own's."

2022-08-09 Thread Mario Limonciello
Although preferable to use the generic fb helpers there is an underlying issue that causes problems for S4 that isn't yet identified. As the workaround for the S4 issue caused other problems for S3, revert the change to generic fb helpers. If/when that underlying issue is identified switching ba

[PATCH 0/4] Fix S3 and S4 issues related to fbdev

2022-08-09 Thread Mario Limonciello
Moving to the generic fbdev helper introduced a regression in S4 support on Hawaii PRO graphics cards. A workaround commit was introduced to avoid this S4 regression until the root cause could be found, but that workaround commit introduced a completely separate regression on S3 on a WX3200. This

[PATCH 2/4] Revert "drm/amdgpu: keep fbdev buffers pinned during suspend"

2022-08-09 Thread Mario Limonciello
This reverts commit da427a501e9b5e2cac8c8042df12eb203726903c. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216119 Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of setting up AMD own's.") Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2

[PATCH 1/4] Revert "drm/amdgpu/display: disable prefer_shadow for generic fb helpers"

2022-08-09 Thread Mario Limonciello
Switching to the generic fb helpers caused a regression for S4, but the workaround for this regression on S4 caused another regression for S3 on a WX3200. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216119 Fixes: 3a4b1cc28fbd ("drm/amdgpu/display: disable prefer_shadow for generic fb helper

Re: [PATCH] drivers:gpu:drm:amd:amdgpu:amdgpu_cs.c:fix a potential use-after-free

2022-08-09 Thread Christian König
Am 28.07.22 um 14:12 schrieb Wentao_Liang: in line 1535, "dma_fence_put(fence);" drop the reference to fence and may cause fence to be released. However, fence is used subsequently in line 1542 "fence->error". This may result in an use-after-free bug. It can be fixed by recording fence->error in

Re: [PATCH v2 1/2] drm/amdgpu: enable GFX Power Gating for GC IP v11.0.1

2022-08-09 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher On Mon, Aug 8, 2022 at 11:20 PM Tim Huang wrote: > > Enable GFX Power Gating control for GC IP v11.0.1. > > Signed-off-by: Tim Huang > --- > drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 38 ++ > 1 file changed, 38 insertions(+) > > diff

Re: [PATCH v2] drm/amd/display: set panel orientation before drm_dev_register

2022-08-09 Thread Hans de Goede
Hi, On 8/8/22 20:53, Melissa Wen wrote: > On 08/04, Melissa Wen wrote: >> To set the panel orientation property with quirk, we need the mode size >> provided by EDID. This info is available after EDID is read by >> dc_link_detect() >> and updated by amdgpu_dm_update_connector_after_detect(). The

Re: [Patch v2] drm/amdgpu: Avoid direct cast to amdgpu_ttm_tt

2022-08-09 Thread Christian König
Am 27.07.22 um 21:51 schrieb Rajneesh Bhardwaj: For typesafety, use container_of() instead of implicit cast from struct ttm_tt to struct amdgpu_ttm_tt. Cc: Christian König Signed-off-by: Rajneesh Bhardwaj Reviewed-by: Christian König --- Changes in v2: * Fixed a bug that Felix pointed o

Re: [Linaro-mm-sig] [PATCH v2 2/5] drm/gem: Take reservation lock for vmap/vunmap operations

2022-08-09 Thread Christian König
Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: The new common dma-buf locking convention will require buffer importers to hold the reservation lock around mapping operations. Make DRM GEM core to take the lock around the vmapping operations and update QXL and i915 drivers to use the locked functio

Re: [Linaro-mm-sig] [PATCH v2 1/5] dma-buf: Add _unlocked postfix to function names

2022-08-09 Thread Christian König
Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: Add _unlocked postfix to the dma-buf API function names in a preparation to move all non-dynamic dma-buf users over to the dynamic locking specification. This patch only renames API functions, preparing drivers to the common locking convention. Later

RE: [PATCH] Increase tlb flush timeout for sriov

2022-08-09 Thread Milinkovic, Dusica
[AMD Official Use Only - General] Hello all, I just checked this with 1200ms for timeout, test case successfully passed 10 loops. If all of you agree, I will change a value in the patch. Regards, Dusica From: Liu, Shaoyun Sent: Tuesday, August 9, 2022 12:31 AM To: Alex Deucher ; Milinkovic, D

[PATCH v2] drm/ttm: Fix dummy res NULL ptr deref bug

2022-08-09 Thread Arunpravin Paneer Selvam
Check the bo->resource value before accessing the resource mem_type. v2: Fix commit description unwrapped warning [ 40.191227][ T184] general protection fault, probably for non-canonical address 0xdc02: [#1] SMP KASAN PTI [ 40.192995][ T184] KASAN: null-ptr-deref in range

Re: [PATCH v5 6/6] drm/ttm: Switch to using the new res callback

2022-08-09 Thread Christian König
Am 09.08.22 um 11:22 schrieb Arunpravin Paneer Selvam: Apply new intersect and compatible callback instead of having a generic placement range verfications. v2: Added a separate callback for compatiblilty checks (Christian) We need to move parts of this patch earlier or the i915 will temp

[PATCH v5 6/6] drm/ttm: Switch to using the new res callback

2022-08-09 Thread Arunpravin Paneer Selvam
Apply new intersect and compatible callback instead of having a generic placement range verfications. v2: Added a separate callback for compatiblilty checks (Christian) Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 45 +

[PATCH v5 4/6] drm/i915: Implement intersect/compatible functions

2022-08-09 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching start offset from drm buddy allocator. v3: move the bits that are specific to buddy_man (Matthew) v4: consider the block size /range (Matthew) Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam Reviewed-by

[PATCH v5 5/6] drm/nouveau: Implement intersect/compatible functions

2022-08-09 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching the start offset from struct ttm_resource. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/nouveau/nouveau_mem.c | 29 +++ drivers/gpu/drm/nouveau/nouveau_mem

[PATCH v5 3/6] drm/amdgpu: Implement intersect/compatible functions

2022-08-09 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching start offset from backend drm buddy allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 38 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vram_m

[PATCH v5 2/6] drm/ttm: Implement intersect/compatible functions

2022-08-09 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback functions to ttm range manager fetching start offset from drm mm range allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/ttm/ttm_range_manager.c | 33 + 1 file changed

[PATCH v5 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-09 Thread Arunpravin Paneer Selvam
We are adding two new callbacks to ttm resource manager function to handle intersection and compatibility of placement and resources. v2: move the amdgpu and ttm_range_manager changes to separate patches (Christian) v3: rename "intersect" to "intersects" (Matthew) v4: move !place check to the

RE: [PATCH 1/2] drm/amdgpu: modify mcbp implement for gfx9(v2)

2022-08-09 Thread Zhu, Jiadong
[AMD Official Use Only - General] Hi, This patch is to correct the mcbp package for gfx9, which is the basic function used for debugfs. There are no logic about when to trigger mcbp. Shall we get this reviewed? Thanks, Jiadong -Original Message- From: Zhu, Jiadong Sent: Tuesday, Augus

[PATCH 1/2] drm/amdgpu: modify mcbp implement for gfx9(v2)

2022-08-09 Thread jiadong.zhu
From: "Jiadong.Zhu" 1. Use unmap_queue package to trigger preemption on gfx9 Add trailing fence to track the preemption done. 2. Modify emit_ce_meta emit_de_meta functions for the resumed ibs. --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c|

[PATCH 2/2] drm/amdgpu: add mcbp support for sdma v4.0

2022-08-09 Thread jiadong.zhu
From: "Jiadong.Zhu" Set register to enable mcbp according to amdgpu_mcbp. Add sdma preempt_ib function used for debugfs test. --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drive

Re: [PATCH v2 2/6] drm/ttm: Implement intersect/compatible functions

2022-08-09 Thread Arunpravin Paneer Selvam
On 8/8/2022 5:00 PM, Christian König wrote: Am 25.07.22 um 13:42 schrieb Arunpravin Paneer Selvam: Implemented a new intersect and compatible callback functions to ttm range manager fetching start offset from drm mm range allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin

RE: [PATCH] drm/amd/pm: skip pptable override for smu_v13_0_7

2022-08-09 Thread Xu, Feifei
[AMD Official Use Only - General] Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Tuesday, August 9, 2022 3:22 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/pm: skip pptable override for smu_v13_0_7 skip ppt

[PATCH] drm/amd/pm: skip pptable override for smu_v13_0_7

2022-08-09 Thread Kenneth Feng
skip pptable override for smu_v13_0_7 secure boards only. Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/s