Re: [Bug 216373] New: Uncorrected errors reported for AMD GPU

2022-08-19 Thread Christian König
Hi Bjorn, Am 18.08.22 um 22:38 schrieb Bjorn Helgaas: [Adding amdgpu folks] On Wed, Aug 17, 2022 at 11:45:15PM +, bugzilla-dae...@kernel.org wrote: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D216373&data=05%7C01%7Cchristian.ko

[PATCH] gpu: move from strlcpy with unused retval to strscpy

2022-08-19 Thread Wolfram Sang
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Wolfram Sang --

Re: [PATCH v3 09/31] ACPI: video: Make backlight class device registration a separate step (v2)

2022-08-19 Thread Daniel Dadap
On 8/18/22 1:42 PM, Hans de Goede wrote: On x86/ACPI boards the acpi_video driver will usually initialize before the kms driver (except i915). This causes /sys/class/backlight/acpi_video0 to show up and then the kms driver registers its own native backlight device after which the drivers/acpi/v

Re: [Bug 216373] New: Uncorrected errors reported for AMD GPU

2022-08-19 Thread Lazar, Lijo
On 8/19/2022 12:35 PM, Christian König wrote: Hi Bjorn, Am 18.08.22 um 22:38 schrieb Bjorn Helgaas: [Adding amdgpu folks] On Wed, Aug 17, 2022 at 11:45:15PM +, bugzilla-dae...@kernel.org wrote: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow

Re: [PATCH] drm/radeon: add a force flush to delay work when radeon

2022-08-19 Thread Christian König
Am 19.08.22 um 11:34 schrieb 李真能: 在 2022/8/17 19:40, Christian König 写道: Am 17.08.22 um 09:31 schrieb 李真能: 在 2022/8/15 21:12, Christian König 写道: Am 15.08.22 um 09:34 schrieb 李真能: 在 2022/8/12 18:55, Christian König 写道: Am 11.08.22 um 09:25 schrieb Zhenneng Li: Although radeon card fence

Re: Radeon HD 2600 XT, DVI outputs

2022-08-19 Thread Andriy Gapon
On 2022-08-18 20:54, Alex Deucher wrote: On Thu, Aug 18, 2022 at 8:29 AM Andriy Gapon wrote: On 2022-08-16 12:01, Christian König wrote: Hi Andriy, well first of all can you please test that with Linux? If this works on Linux then there is probably just something missing on the FreeBSD port.

Re: [Bug 216373] New: Uncorrected errors reported for AMD GPU

2022-08-19 Thread Bjorn Helgaas
On Fri, Aug 19, 2022 at 02:03:59PM +0530, Lazar, Lijo wrote: > Or, it could be amdgpu or some other software component - > > register mmio base: 0x95E0 > Address 0x95e7f000 > > 0x95e7f000 indicates access from CPU to a register offset 0x7FE000. This > doesn't look like a valid register

Re: [PATCH] drm/amd/display: fix i386 frame size warning

2022-08-19 Thread Maíra Canal
Hi Hamza, On 8/18/22 13:48, Hamza Mahfooz wrote: > Addresses the following warning: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:3596:6: > error: stack frame size (2092) exceeds limit (2048) in > 'dml30_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-

Re: [BUG][5.20] refcount_t: underflow; use-after-free

2022-08-19 Thread Maíra Canal
On 8/17/22 17:57, Mikhail Gavrilov wrote: > On Wed, Aug 17, 2022 at 11:43 PM Maíra Canal wrote: >> >> Hi Mikhail, >> >> Looks like 45ecaea738830b9d521c93520c8f201359dcbd95 ("drm/sched: Partial >> revert of 'drm/sched: Keep s_fence->parent pointer'") introduced the >> error. Try reverting it and

Re: [PATCH v3 09/31] ACPI: video: Make backlight class device registration a separate step (v2)

2022-08-19 Thread Hans de Goede
Hi, On 8/18/22 22:07, Daniel Dadap wrote: > > On 8/18/22 1:42 PM, Hans de Goede wrote: >> On x86/ACPI boards the acpi_video driver will usually initialize before >> the kms driver (except i915). This causes /sys/class/backlight/acpi_video0 >> to show up and then the kms driver registers its own n

Re: [PATCH v3 15/31] platform/x86: nvidia-wmi-ec-backlight: Move fw interface definitions to a header

2022-08-19 Thread Hans de Goede
Hi, On 8/18/22 21:38, Daniel Dadap wrote: > > On 8/18/22 1:42 PM, Hans de Goede wrote: >> Move the WMI interface definitions to a header, so that the definitions >> can be shared with drivers/acpi/video_detect.c . >> >> Suggested-by: Daniel Dadap >> Signed-off-by: Hans de Goede >> --- >>   MAIN

Re: [PATCH -next] drm/amd/display: remove unneeded semicolon

2022-08-19 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 17, 2022 at 10:59 PM Yang Li wrote: > > Semicolon is not required after curly braces. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1918 > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk

Re: [PATCH] drm/amd/display: Include missing header

2022-08-19 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 18, 2022 at 9:28 AM Maíra Canal wrote: > > The file amdgpu_dm_plane.c missed the header amdgpu_dm_plane.h, which > resulted on the following warning: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1046:5: > warning: no previous prototype

Re: [PATCH] drm/amd/display: remove unused header

2022-08-19 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 18, 2022 at 9:53 PM Magali Lemes wrote: > > dml_wrapper* files were removed in commit 724449e30433 > ("drm/amd/display: Remove unused code"), as they are not used anywhere. > However, the header file wasn't removed, so remove the header as well. > > Signed-off-

Re: [PATCH] drm/radeon: add a force flush to delay work when radeon

2022-08-19 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Aug 19, 2022 at 6:07 AM Christian König wrote: > > Am 19.08.22 um 11:34 schrieb 李真能: > > 在 2022/8/17 19:40, Christian König 写道: > > Am 17.08.22 um 09:31 schrieb 李真能: > > > 在 2022/8/15 21:12, Christian König 写道: > > Am 15.08.22 um 09:34 schrieb 李真能: > > > 在 2022/8/1

RE: [PATCH] drm/amdgpu: skip set_topology_info for VF

2022-08-19 Thread Liu, Shaoyun
[AMD Official Use Only - General] Looks good to me . Reviewed-By : shaoyun.liu -Original Message- From: Chander, Vignesh Sent: Thursday, August 18, 2022 1:38 PM To: amd-gfx@lists.freedesktop.org Cc: Kim, Jonathan ; Liu, Shaoyun ; Chander, Vignesh Subject: [PATCH] drm/amdgpu: skip set_

[linux-next:master] BUILD REGRESSION 8755ae45a9e8ae883fa7f4eb0162830c55aacf14

2022-08-19 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 8755ae45a9e8ae883fa7f4eb0162830c55aacf14 Add linux-next specific files for 20220819 Error/Warning reports: https://lore.kernel.org/linux-doc/202208192207.a0ram0nj-...@intel.com Error/Warning

Re: [Bug 216373] New: Uncorrected errors reported for AMD GPU

2022-08-19 Thread Bjorn Helgaas
On Thu, Aug 18, 2022 at 03:38:12PM -0500, Bjorn Helgaas wrote: > [Adding amdgpu folks] > > On Wed, Aug 17, 2022 at 11:45:15PM +, bugzilla-dae...@kernel.org wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=216373 > > > > Bug ID: 216373 > >Summary: Uncorrected erro

Re: build failure of next-20220817 for amdgpu due to 7bc913085765 ("drm/amdkfd: Try to schedule bottom half on same core")

2022-08-19 Thread Felix Kuehling
On 2022-08-18 15:34, Randy Dunlap wrote: Hi-- On 8/18/22 12:15, Sudip Mukherjee wrote: On Thu, Aug 18, 2022 at 4:10 PM Randy Dunlap wrote: On 8/18/22 03:43, Sudip Mukherjee wrote: On Thu, Aug 18, 2022 at 3:09 AM Randy Dunlap wrote: On 8/17/22 19:01, Alex Deucher wrote: On Wed, Aug 17, 2

Re: [Bug 216373] New: Uncorrected errors reported for AMD GPU

2022-08-19 Thread Bjorn Helgaas
On Fri, Aug 19, 2022 at 12:13:03PM -0500, Bjorn Helgaas wrote: > On Thu, Aug 18, 2022 at 03:38:12PM -0500, Bjorn Helgaas wrote: > > [Adding amdgpu folks] > > > > On Wed, Aug 17, 2022 at 11:45:15PM +, bugzilla-dae...@kernel.org wrote: > > > https://bugzilla.kernel.org/show_bug.cgi?id=216373 > >

Re: [PATCH] powerpc: export cpu_smallcore_map for modules

2022-08-19 Thread Felix Kuehling
On 2022-08-19 17:01, Randy Dunlap wrote: Fix build error when CONFIG_DRM_AMDGPU=m: ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! by exporting 'cpu_smallcore_map' just as other per_cpu symbols are exported. drivers/gpu/drm/amd/amdkfd/kfd_device.c calls

[PATCH] powerpc: export cpu_smallcore_map for modules

2022-08-19 Thread Randy Dunlap
Fix build error when CONFIG_DRM_AMDGPU=m: ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! by exporting 'cpu_smallcore_map' just as other per_cpu symbols are exported. drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask(). This is an inline function o

RE: [PATCH] drm/amd/display: fix i386 frame size warning

2022-08-19 Thread David Laight
From: Hamza Mahfooz > Sent: 18 August 2022 17:49 > > Addresses the following warning: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:3596:6: > error: stack frame > size (2092) exceeds limit (2048) in > 'dml30_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe- >

Re: [PATCH] powerpc: export cpu_smallcore_map for modules

2022-08-19 Thread Alex Deucher
On Fri, Aug 19, 2022 at 6:18 PM Randy Dunlap wrote: > > Fix build error when CONFIG_DRM_AMDGPU=m: > > ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] > undefined! > > by exporting 'cpu_smallcore_map' just as other per_cpu > symbols are exported. > > drivers/gpu/drm/amd/