Re: [PATCH 13/14] drm/amd/display: Adding log clock table from SMU

2022-08-22 Thread Lazar, Lijo
On 8/22/2022 3:27 PM, brichang wrote: From: Leo Chen [Why & How] Adding log for clock table from SMU helps with the debugging process. Implemented using DC_LOG_SMU to output log. Most of this info is already available through *_print_clk_levels. Additional info like voltage may be added

Re: [PATCH] drm/amd/pm: improve BAMACO code for smu_v13_0

2022-08-22 Thread Lazar, Lijo
On 8/23/2022 7:32 AM, Kenneth Feng wrote: For runtime pm case: 1. prompt in dmesg for BAMACO feature test 2. set BACO by defatul and the user can select BAMACO Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++

RE: [PATCH] drm/amd/pm: improve BAMACO code for smu_v13_0

2022-08-22 Thread Chen, Guchun
* Skip SMU FW reloading in case of using BACO for runpm only, * as SMU is always alive. Above comment needs to be updated to cover BAMACO. Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Tuesday, August 23, 2022 10:03 AM To:

[PATCH] drm/amd/pm: improve BAMACO code for smu_v13_0

2022-08-22 Thread Kenneth Feng
For runtime pm case: 1. prompt in dmesg for BAMACO feature test 2. set BACO by defatul and the user can select BAMACO Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 7 ++

[PATCH] drm/amd/pm: update SMU 13.0.0 driver_if header

2022-08-22 Thread Evan Quan
To fit the latest 78.53 PMFW. Signed-off-by: Evan Quan Change-Id: I16b36a3c209c82fc2d48325f7e6ef5a702678782 --- .../inc/pmfw_if/smu13_driver_if_v13_0_0.h | 31 +++ drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 2 +- 2 files changed, 19 insertions(+), 14 deletions(-) diff

[PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-22 Thread Andrey Grodzovsky
Poblem: Given many entities competing for same rq on same scheduler an uncceptabliy long wait time for some jobs waiting stuck in rq before being picked up are observed (seen using GPUVis). The issue is due to Round Robin policy used by scheduler to pick up the next entity for execution. Under

Re: [PATCH] drm/amd/display: enable PCON support for dcn314

2022-08-22 Thread Hamza Mahfooz
On 2022-08-22 15:38, roman...@amd.com wrote: From: Roman Li [Why] DCN314 supports PCON. [How] Explicitly enable it in dcn314 resources. Signed-off-by: Roman Li Reviewed-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 + 1 file changed, 1

[PATCH] drm/amd/display: enable PCON support for dcn314

2022-08-22 Thread Roman.Li
From: Roman Li [Why] DCN314 supports PCON. [How] Explicitly enable it in dcn314 resources. Signed-off-by: Roman Li --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c

Re: [PATCH 1/1] drm/amdgpu: Use kfd_lock_pdd_by_id helper in more places

2022-08-22 Thread Felix Kuehling
Am 2022-08-22 um 11:30 schrieb Daniel Phillips: Convert most of the "mutex_lock; kfd_process_device_data_by_id" occurrences in kfd_chardev to use the kfd_lock_pdd_by_id. These will now consistently log debug output if the lookup fails. Sites where kfd_process_device_data_by_id is used without

RE: [PATCH 1/1] drm/amdgpu: Use kfd_lock_pdd_by_id helper in more places

2022-08-22 Thread Deucher, Alexander
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Daniel Phillips > Sent: Monday, August 22, 2022 11:30 AM > To: amd-gfx@lists.freedesktop.org > Cc: Phillips, Daniel ; Kuehling, Felix > > Subject: [PATCH 1/1] drm/amdgpu: Use kfd_lock_pdd_by_id helper

[PATCH] drm/amdgpu: Fix page table setup on Arcturus

2022-08-22 Thread Mukul Joshi
When translate_further is enabled, page table depth needs to be updated. This was missing on Arcturus MMHUB init. This was causing address translations to fail for SDMA user-mode queues. Fixes: 2abf2573b1c69 ("drm/amdgpu: Enable translate_further to extend UTCL2 reach" Signed-off-by: Mukul Joshi

[PATCH 1/1] drm/amdgpu: Use kfd_lock_pdd_by_id helper in more places

2022-08-22 Thread Daniel Phillips
Convert most of the "mutex_lock; kfd_process_device_data_by_id" occurrences in kfd_chardev to use the kfd_lock_pdd_by_id. These will now consistently log debug output if the lookup fails. Sites where kfd_process_device_data_by_id is used without locking are not converted for now. Signed-off-by:

RE: [PATCH] drm/amdkfd: Allocate doorbells only when needed

2022-08-22 Thread Russell, Kent
[AMD Official Use Only - General] I can throw an Acked-by: Kent Russell since we don't have an RB yet. Kent > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Wednesday, August 3, 2022 2:56 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdkfd:

[PATCH 13/14] drm/amd/display: Adding log clock table from SMU

2022-08-22 Thread brichang
From: Leo Chen [Why & How] Adding log for clock table from SMU helps with the debugging process. Implemented using DC_LOG_SMU to output log. Reviewed-by: Charlene Liu Acked-by: Brian Chang Signed-off-by: Leo Chen --- .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 46 ++

[PATCH 12/14] drm/amd/display: Uncomment SubVP scaling case

2022-08-22 Thread brichang
From: Alvin Lee [Description] Uncomment scaling cmd assignment since FW headers are now promoted. Reviewed-by: Martin Leung Acked-by: Brian Chang Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 14/14] drm/amd/display: Remove redundant check in atomic_check

2022-08-22 Thread brichang
From: Roman Li [Why] We have 2 back-to-back checks for skipping connectors. Logically one of them will do the job. [How] Remove redundant check. Reviewed-by: Hersen Wu > Acked-by: Brian Chang Signed-off-by: Roman Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 --- 1 file

[PATCH 11/14] drm/amd/display: Add interface to track PHY state

2022-08-22 Thread brichang
From: Taimur Hassan [Why] Sometimes pixel clock needs to remain active after transmitter disable. [How] Use update_phy_state to track PHY state after stream enable/disable and program pixel clock as needed. Reviewed-by: Alvin Lee Acked-by: Brian Chang Signed-off-by: Taimur Hassan ---

[PATCH 06/14] drm/amd/display: change to runtime initialization for reg offsets for DCN32

2022-08-22 Thread brichang
From: Aurabindo Pillai DC was using compile time initialization of register addresses using SR_* macros and their variants. These have been converted to use runtime initialization. The REG_STRUCT macro is a definition that is added to SR_* macros. During initialization, this must be defined

[PATCH 05/14] drm/amd/display: Change AUX NACK behavior

2022-08-22 Thread brichang
From: Ilya Bakoulin [Why] Retrying on receiving a NACK can result in long overall EDID read times in some cases. [How] Retry only on DEFER and return immediately on NACK. Reviewed-by: Aric Cyr Acked-by: Brian Chang Signed-off-by: Ilya Bakoulin ---

[PATCH 07/14] drm/amd/display: change to runtime initialization for reg offsets for DCN321

2022-08-22 Thread brichang
From: Aurabindo Pillai DC was using compile time initialization of register addresses using SR_* macros and their variants. These have been converted to use runtime initialization. The REG_STRUCT macro is a definition that is added to SR_* macros. During initialization, this must be defined

[PATCH 09/14] drm/amd/display: program k1/k2 divider for virtual signal for DCN32

2022-08-22 Thread brichang
From: Aurabindo Pillai [Why] When using IGT, kms_bw multi display tests trigger an assert since we ignore virtual signal type. k1/k2 dividers should be correctly programmed if VSYNC needs to be correct. Add the appropriate condition to the if arm to fix this. Reviewed-by: Rodrigo Siqueira

[PATCH 08/14] drm/amd/display: Cursor flicker when entering PSRSU

2022-08-22 Thread brichang
From: Robin Chen [Why] The DAL driver may transmit the wrong cursor position to PSRSU DMUB driver when there are multiple planes. [How] Currently the driver apply the HW cursor on the top plane. So we should only transmit the cursor position on the top plane to PSRSU DMUB driver. Reviewed-by:

[PATCH 03/14] drm/amd/display: fix odm 2:1 policy not being applied consistently in 4k144 modes

2022-08-22 Thread brichang
From: Samson Tam [Why] odm 2:1 policy is splitting the pipes in 4k144. then in subvp code, we merge the pipes. but since the configuration is unsupported, we keep the pipes split [How] for unsupported subvp configuration, redo the dml and pipe split calls Reviewed-by: Alvin Lee Reviewed-by:

[PATCH 02/14] drm/amd/display: do not change pipe split policy for RV2

2022-08-22 Thread brichang
From: Derek Lai [Why] RV2 do not change pipe split policy in the minimal pipe split transition state. This will unblock mode support on some parts that limit to DPM0 for power reason. [How] Do not change pipe split policy in the minimal pipe split transition state to allow 4k multi display

[PATCH 01/14] drm/amd/display: 3.2.199

2022-08-22 Thread brichang
From: Aric Cyr This verion brings along following fixes: -Add scaling factor for SubVP -Modify stop_dbg_mode return value -Add gfx_off members and document -Add GFXOFF function for vangogh -Add GFXOFF stats to debug -Fix codestyle problems -Fix overflow on MIN_I64 -Fix Unneeded semicolon -Fix

[PATCH 00/14] DC Patches August 22, 2022

2022-08-22 Thread brichang
This DC patchset brings improvements in multiple areas. In summary, we have: * Remove redundant check in atomic_check. * Add log clock table for SMU. * Add SubVP scaling. * Add interface to track PHY state. * Free phantom plane after removing from the context. * Add k1/k2 driver for virtual

Re: [PATCH v6 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-22 Thread Christian König
Am 20.08.22 um 09:32 schrieb Arunpravin Paneer Selvam: We are adding two new callbacks to ttm resource manager function to handle intersection and compatibility of placement and resources. v2: move the amdgpu and ttm_range_manager changes to separate patches (Christian) v3: rename

Re: [PATCH] powerpc: export cpu_smallcore_map for modules

2022-08-22 Thread Alex Deucher
On Mon, Aug 22, 2022 at 9:16 AM Christoph Hellwig wrote: > > On Mon, Aug 22, 2022 at 01:40:23PM +1000, Michael Ellerman wrote: > > Randy Dunlap writes: > > > drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask(). > > > This is an inline function on powerpc which references > > >

Re: No Audio from AMDGPU HDMI on 5.19.2

2022-08-22 Thread Alex Deucher
+ Martin, Rodrigo On Mon, Aug 22, 2022 at 3:18 AM 菜叶 wrote: > > Hello, > > I experienced this issue on Arch Linux 5.19.2-arch1-1 kernel on an HP > laptop with AMD Ryzen 6850HS CPU (detailed spec below), that the audio > is completely silent on the HDMI connected monitor. KDE audio settings >

Re: [PATCH] powerpc: export cpu_smallcore_map for modules

2022-08-22 Thread Christoph Hellwig
On Mon, Aug 22, 2022 at 01:40:23PM +1000, Michael Ellerman wrote: > Randy Dunlap writes: > > drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask(). > > This is an inline function on powerpc which references > > cpu_smallcore_map. > > > > Fixes: 425752c63b6f ("powerpc: Detect the presence

Re: [PATCH] powerpc: export cpu_smallcore_map for modules

2022-08-22 Thread Randy Dunlap
On 8/21/22 20:40, Michael Ellerman wrote: > Randy Dunlap writes: >> Fix build error when CONFIG_DRM_AMDGPU=m: >> >> ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] >> undefined! >> >> by exporting 'cpu_smallcore_map' just as other per_cpu >> symbols are exported. >>

Re: [PATCH] powerpc: export cpu_smallcore_map for modules

2022-08-22 Thread Michael Ellerman
Randy Dunlap writes: > Fix build error when CONFIG_DRM_AMDGPU=m: > > ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] > undefined! > > by exporting 'cpu_smallcore_map' just as other per_cpu > symbols are exported. > > drivers/gpu/drm/amd/amdkfd/kfd_device.c calls

No Audio from AMDGPU HDMI on 5.19.2

2022-08-22 Thread 菜叶
Hello, I experienced this issue on Arch Linux 5.19.2-arch1-1 kernel on an HP laptop with AMD Ryzen 6850HS CPU (detailed spec below), that the audio is completely silent on the HDMI connected monitor. KDE audio settings says everything works normally, HDMI audio shows up and can be selected as the

Re: [PATCH] drm/amdgpu: add sdma instance check for gfx11 CGCG

2022-08-22 Thread Zhang, Yifan
[AMD Official Use Only - General] This series is: Reviewed-by: Yifan Zhang 发件人: Huang, Tim 发送时间: Monday, August 22, 2022 2:36:41 PM 收件人: amd-gfx@lists.freedesktop.org 抄送: Deucher, Alexander ; Zhang, Yifan ; Du, Xiaojian ; Zhang, Hawking ;

[PATCH] drm/amdgpu: add sdma instance check for gfx11 CGCG

2022-08-22 Thread Tim Huang
For some ASICs, like GFX IP v11.0.1, only have one SDMA instance, so not need to configure SDMA1_RLC_CGCG_CTRL for this case. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git