Re: [Bug 216373] New: Uncorrected errors reported for AMD GPU

2022-08-23 Thread Lazar, Lijo
On 8/23/2022 10:34 PM, Tom Seewald wrote: On Sat, Aug 20, 2022 at 2:53 AM Lazar, Lijo wrote: Missed the remap part, the offset is here -

[PATCH v4] drm/amd/display: Fix vblank refcount in vrr transition

2022-08-23 Thread Yunxiang Li
manage_dm_interrupts disable/enable vblank using drm_crtc_vblank_off/on which causes drm_crtc_vblank_get in vrr_transition to fail, and later when drm_crtc_vblank_put is called the refcount on vblank will be messed up. Therefore move the call to after manage_dm_interrupts. Signed-off-by: Yunxiang

Re: [PATCH 0/6] amdgpu: Allow explicitly synchronized submissions.

2022-08-23 Thread Bas Nieuwenhuizen
On Tue, Aug 23, 2022 at 12:16 PM Christian König wrote: > > Hi Bas, > > I've just pushed an updated drm-exec branch to fdo which should now > include the bo_list bug fix. Still getting the same thing: [ 103.598784] [ cut here ] [ 103.598787] WARNING: CPU: 2 PID: 2505

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-23 Thread Luben Tuikov
On 2022-08-23 14:57, Andrey Grodzovsky wrote: > On 2022-08-23 14:30, Luben Tuikov wrote: > >> >> On 2022-08-23 14:13, Andrey Grodzovsky wrote: >>> On 2022-08-23 12:58, Luben Tuikov wrote: Inlined: On 2022-08-22 16:09, Andrey Grodzovsky wrote: > Poblem: Given many entities

Re: [RFC v4 00/17] drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only

2022-08-23 Thread Lyude Paul
Actually, talked with airlied and they suggested at this point I should just go ahead and push. So, pushed! Have fun getting nice DSC support everyone :) On Tue, 2022-08-23 at 13:26 -0400, Lyude Paul wrote: > Would anyone have any issues if I merged this today? The whole series is > acked, but

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-23 Thread Andrey Grodzovsky
On 2022-08-23 14:30, Luben Tuikov wrote: On 2022-08-23 14:13, Andrey Grodzovsky wrote: On 2022-08-23 12:58, Luben Tuikov wrote: Inlined: On 2022-08-22 16:09, Andrey Grodzovsky wrote: Poblem: Given many entities competing for same rq on ^Problem same scheduler an uncceptabliy long wait

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-23 Thread Luben Tuikov
On 2022-08-23 14:13, Andrey Grodzovsky wrote: > > On 2022-08-23 12:58, Luben Tuikov wrote: >> Inlined: >> >> On 2022-08-22 16:09, Andrey Grodzovsky wrote: >>> Poblem: Given many entities competing for same rq on >> ^Problem >> >>> same scheduler an uncceptabliy long wait time for some >>

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-23 Thread Andrey Grodzovsky
On 2022-08-23 12:58, Luben Tuikov wrote: Inlined: On 2022-08-22 16:09, Andrey Grodzovsky wrote: Poblem: Given many entities competing for same rq on ^Problem same scheduler an uncceptabliy long wait time for some ^unacceptably jobs waiting stuck in rq before being picked up are

Re: [RFC v4 00/17] drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only

2022-08-23 Thread Lyude Paul
Would anyone have any issues if I merged this today? The whole series is acked, but I'm not sure if we would like to wait for R-b's? On Wed, 2022-08-17 at 15:38 -0400, Lyude Paul wrote: > For quite a while we've been carrying around a lot of legacy modesetting > code in the MST helpers that has

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-23 Thread Luben Tuikov
Inlined: On 2022-08-22 16:09, Andrey Grodzovsky wrote: > Poblem: Given many entities competing for same rq on ^Problem > same scheduler an uncceptabliy long wait time for some ^unacceptably > jobs waiting stuck in rq before being picked up are > observed (seen using GPUVis). > The issue is due

Re: [PATCH] drm/amdgpu: Fix page table setup on Arcturus

2022-08-23 Thread Felix Kuehling
Am 2022-08-22 um 11:52 schrieb Mukul Joshi: When translate_further is enabled, page table depth needs to be updated. This was missing on Arcturus MMHUB init. This was causing address translations to fail for SDMA user-mode queues. Fixes: 2abf2573b1c69 ("drm/amdgpu: Enable translate_further to

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-23 Thread Andrey Grodzovsky
On 2022-08-23 08:15, Christian König wrote: Am 22.08.22 um 22:09 schrieb Andrey Grodzovsky: Poblem: Given many entities competing for same rq on same scheduler an uncceptabliy long wait time for some jobs waiting stuck in rq before being picked up are observed (seen using  GPUVis). The issue

RE: [PATCH 00/14] DC Patches August 22, 2022

2022-08-23 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-23 Thread Christian König
Am 22.08.22 um 22:09 schrieb Andrey Grodzovsky: Poblem: Given many entities competing for same rq on same scheduler an uncceptabliy long wait time for some jobs waiting stuck in rq before being picked up are observed (seen using GPUVis). The issue is due to Round Robin policy used by

Re: [PATCH] drm/amdkfd: Allocate doorbells only when needed

2022-08-23 Thread Russell, Kent
No one else seems to have any thoughts on it, so Reviewed-by: Kent Russell Kent From: amd-gfx on behalf of Russell, Kent Sent: Monday, August 22, 2022 10:10 AM To: Kuehling, Felix ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdkfd: Allocate

Re: [PATCH v2] drm/amd: remove duplicated argument to &

2022-08-23 Thread Maíra Canal
Hi Bernard On 8/23/22 04:14, Bernard Zhao wrote: This patch trf to fis cocci warning: I believe that there are a couple of typos on this description. Maybe you could fixed to s/trf/try and s/fis/fix. drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c: 2349:8-34: duplicated

Re: [PATCH 0/6] amdgpu: Allow explicitly synchronized submissions.

2022-08-23 Thread Christian König
Hi Bas, I've just pushed an updated drm-exec branch to fdo which should now include the bo_list bug fix. Can you please test that with Forza? I'm still fighting getting a new kernel on my Steamdeck. Thanks, Christian. Am 22.08.22 um 01:08 schrieb Bas Nieuwenhuizen: On Thu, Aug 18, 2022

Re: [PATCH] drm/amdgpu: Fix page table setup on Arcturus

2022-08-23 Thread Christian König
Am 22.08.22 um 17:52 schrieb Mukul Joshi: When translate_further is enabled, page table depth needs to be updated. This was missing on Arcturus MMHUB init. This was causing address translations to fail for SDMA user-mode queues. Fixes: 2abf2573b1c69 ("drm/amdgpu: Enable translate_further to

[PATCH] drm/amd: remove possible condition with no effect (if == else)

2022-08-23 Thread Bernard Zhao
This patch fix cocci warning: drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c:1816:6-8: WARNING: possible condition with no effect (if == else). Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH] drm/amd: remove duplicated argument to &

2022-08-23 Thread Bernard Zhao
This patch trf to fis cocci warning: drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c: 2349:8-34: duplicated argument to && or || drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c: 3680:8-55: duplicated argument to && or || Signed-off-by: Bernard Zhao ---

[PATCH] drm/amd: fix potential memory leak

2022-08-23 Thread Bernard Zhao
This patch fix potential memory leak (clk_src) when function run into last return NULL. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c

[PATCH] drm/amdgpu: mmVM_L2_CNTL3 register not initialized correctly

2022-08-23 Thread jinsdb
From: Qu Huang The mmVM_L2_CNTL3 register is not assigned an initial value Signed-off-by: Qu Huang --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c index

[PATCH v2] drm/amd: remove duplicated argument to &

2022-08-23 Thread Bernard Zhao
This patch trf to fis cocci warning: drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c: 2349:8-34: duplicated argument to && or || drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c: 3680:8-55: duplicated argument to && or || Signed-off-by: Bernard Zhao ---

[PATCH] drm/amd: fix potential memory leak

2022-08-23 Thread Bernard Zhao
This patch fix potential memory leak (clk_src) when function run into last return NULL. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c

[PATCH] drm/amd: remove possible condition with no effect (if == else)

2022-08-23 Thread Bernard Zhao
This patch fix cocci warning: drivers/gpu/drm/amd/display/dc/core/dc.c:3335:2-4: WARNING: possible condition with no effect (if == else). Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git