[Public]
Hi Aaron,
Yes, the cache info are different. But this diff is intentional to workaround
the discovery table lacks cache info in GC 11.0.1 issue. The workaround will be
removed after discovery table finishes integrating cache info. Given they
already have a test version, we can pend
[Public]
Hi Yifan,
Yellow carp's cache info cannot be duplicated to GC_11_0_1.
Different point to GC_11_0_1:
TCP L1 Cache size is 32
GL1 Data Cache size per SA is 256
Others looks good to me
--
Best Regards
Aaron Liu
> -Original Message-
> From: amd-gfx On Behalf Of
> Huang,
[Public]
Reviewed-by: Tim Huang
Best Regards,
Tim Huang
-Original Message-
From: Zhang, Yifan
Sent: Thursday, September 1, 2022 3:30 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Huang, Tim
; Du, Xiaojian ; Zhang, Yifan
Subject: [PATCH] drm/amdkfd: Match GC 11.0.1
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8 Add linux-next specific
files for 20220901
Error/Warning reports:
https://lore.kernel.org/linux-media/202209020437.exeodmfe-...@intel.com
https
How about this? We should just move HDP remap to gmc hw_init since
that is mainly what uses it anyway.
Alex
On Tue, Aug 30, 2022 at 2:05 PM Alex Deucher wrote:
>
> On Tue, Aug 30, 2022 at 12:06 PM Lazar, Lijo wrote:
> >
> >
> >
> > On 8/30/2022 8:39 PM, Alex Deucher wrote:
> > > On Tue, Aug
[Why & How]
Fix the instatiation sequence for MPC registers and add a few other
missing register definitions that were ommited erroneously when copying
them over to enable runtime initialization of reigster offsets for
DCN32/321
Signed-off-by: Aurabindo Pillai
---
[AMD Official Use Only - General]
This seems to have broken CRIU restore. After I revert this, I can get CRIU
restore working.
From: amd-gfx On Behalf Of Russell, Kent
Sent: Tuesday, August 23, 2022 8:07 AM
To: Kuehling, Felix ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdkfd:
On 2022-09-01 10:15, Hamza Mahfooz wrote:
Address the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’
clause does not guard... [-Wmisleading-indentation]
3508 | if (update_type != UPDATE_TYPE_FAST)
| ^~
Missing SetMGpuFanBoostLimitRpm mapping leads to loading failure for SMU
13.0.7.
Signed-off-by: Evan Quan
Reviewed-by: Hawking Zhang
Change-Id: I2ea606ad5089b2612069614349c3a228406ef928
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 1 +
1 file changed, 1 insertion(+)
diff --git
[Public]
Acked-by: Alex Deucher
From: Mahfooz, Hamza
Sent: Thursday, September 1, 2022 10:15 AM
To: linux-ker...@vger.kernel.org
Cc: Mahfooz, Hamza ; Wentland, Harry
; Li, Sun peng (Leo) ; Siqueira,
Rodrigo ; Deucher, Alexander
; Koenig, Christian ; Pan,
Address the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’
clause does not guard... [-Wmisleading-indentation]
3508 | if (update_type != UPDATE_TYPE_FAST)
| ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17:
>-Original Message-
>From: Dmitry Osipenko
>Sent: Wednesday, August 31, 2022 11:38 AM
>To: David Airlie ; Gerd Hoffmann ;
>Gurchetan Singh ; Chia-I Wu
>; Daniel Vetter ; Daniel Almeida
>; Gert Wollny ;
>Gustavo Padovan ; Daniel Stone
>; Tomeu Vizoso ;
>Maarten Lankhorst ; Maxime Ripard
>;
[Public]
Acked-by: Alex Deucher
From: amd-gfx on behalf of Zhang,
Jesse(Jie)
Sent: Wednesday, August 31, 2022 9:11 PM
To: Alex Deucher ; amd-gfx@lists.freedesktop.org
Cc: Zhang, Yifan ; Huang, Ray
Subject: [PATCH] drm/amdgpu: disable the debugger on gfx1036
Prefer the parsed results for is_hdmi and has_audio in display info over
calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(),
respectively.
Cc: Alex Deucher
Cc: Christian König
Cc: "Pan, Xinhui"
Cc: amd-gfx@lists.freedesktop.org
Signed-off-by: Jani Nikula
---
On 9/1/22 09:45, Christian König wrote:
> Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
>> Prepare i915 driver to the common dynamic dma-buf locking convention
>> by starting to use the unlocked versions of dma-buf API functions
>> and handling cases where importer now holds the reservation lock.
Hello Christian,
On 9/1/22 10:49, Christian König wrote:
> Hi Dmitry,
>
> I've gone over this multiple times now and while it is still possible
> that we missed something I think that this should land now.
Thank you very much for the review!
> The whole topic is just to complicated that we can
On 9/1/22 09:50, Christian König wrote:
> Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
>> Prepare Etnaviv driver to the common dynamic dma-buf locking convention
>> by starting to use the unlocked versions of dma-buf API functions.
>>
>> Signed-off-by: Dmitry Osipenko
>
> Interesting, where is
Conditional statements have no effect to next process.So remove it.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2028
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
.../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4
1 file changed, 4 deletions(-)
diff --git
This if statement is the content of the for statement above it. It
should be indented.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2026
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 4 ++--
1 file changed, 2 insertions(+),
The low-hanging fruit of the drm todo item "Replace
drm_detect_hdmi_monitor() with drm_display_info.is_hdmi", with has_audio
changes on top.
I'm afraid not all of these have been even build tested, let alone
actually tested.
BR,
Jani.
Cc: Laurent Pinchart
Cc: Sandy Huang
Cc: Heiko Stübner
The result of relational operation is Boolean, and the question mark
expression is redundant.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2027
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
.../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 2 +-
1 file changed, 1
Yes, exactly. The logic in two successive if checks of "(update_type !=
UPDATE_TYPE_FAST) " is incorrect still.
Possibly we can update code by dropping one if check as below. Anyway, this
needs confirm from display team @Lee, Alvin @Lei, Jun.
if (update_type != UPDATE_TYPE_FAST) {
Am 01.09.22 um 13:11 schrieb Christian König:
Am 01.09.22 um 11:29 schrieb ZhenGuo Yin:
[Why]
Ghost BO is released with non-empty bulk move object. There is a
warning trace:
WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366
ttm_bo_release+0x2e1/0x2f0 [amdttm]
Call Trace:
Am 01.09.22 um 11:29 schrieb ZhenGuo Yin:
[Why]
Ghost BO is released with non-empty bulk move object. There is a
warning trace:
WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0
[amdttm]
Call Trace:
amddma_resv_reserve_fences+0x10d/0x1f0 [amdkcl]
Well please adjust the subject line, that should read something like
"drm/amd/display:..." or "drm/amdgpu:...".
Am 01.09.22 um 11:11 schrieb Asher Song:
To eliminate the following compiling error, guard if clause.
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c: In function
Acked-by: Jingwen Chen
still need confirmation from Christian
On 9/1/22 5:29 PM, ZhenGuo Yin wrote:
> [Why]
> Ghost BO is released with non-empty bulk move object. There is a
> warning trace:
> WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0
> [amdttm]
> Call Trace:
>
[Why]
Ghost BO is released with non-empty bulk move object. There is a
warning trace:
WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0
[amdttm]
Call Trace:
amddma_resv_reserve_fences+0x10d/0x1f0 [amdkcl]
amdttm_bo_put+0x28/0x30 [amdttm]
To eliminate the following compiling error, guard if clause.
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c: In function
'commit_planes_for_stream':
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3521:2: error: this 'if'
clause does not guard... [-Werror=misleading-indentation]
V1:
The psp_cmd_submit_buf function is called by psp_hw_fini to send
TA unload messages to psp to terminate ras, asd and tmr. But when
amdgpu is uninstalled, drm_dev_unplug is called earlier than
psp_hw_fini in amdgpu_pci_remove, the calling order as follows:
static void amdgpu_pci_remove(struct
Hi Dmitry,
I've gone over this multiple times now and while it is still possible
that we missed something I think that this should land now.
The whole topic is just to complicated that we can 100% sure guarantee
that there isn't anything wrong with the locking, but lockdep and driver
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
The internal dma-buf lock isn't needed anymore because the updated
locking specification claims that dma-buf reservation must be locked
by importers, and thus, the internal data is already protected by the
reservation lock. Remove the obsoleted
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
All drivers that use dma-bufs have been moved to the updated locking
specification and now dma-buf reservation is guaranteed to be locked
by importers during the mapping operations. There is no need to take
the internal dma-buf lock anymore. Remove
Current discovery table doesn't have cache info for GC 11.0.1, thus
can't be parsed like other GC 11, this patch to match GC 11.0.1
cache info to yellow carp
Signed-off-by: Yifan Zhang
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Add documentation for the dynamic locking convention. The documentation
tells dma-buf API users when they should take the reservation lock and
when not.
Signed-off-by: Dmitry Osipenko
Reviewed-by: Christian König
---
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Move dma-buf attachment mapping functions to the dynamic locking
specification by asserting that the reservation lock is held.
Signed-off-by: Dmitry Osipenko
Reviewed-by: Christian König
---
drivers/dma-buf/dma-buf.c | 10 ++
1 file
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Move dma-buf attachment API functions to the dynamic locking specification
by taking the reservation lock around the mapping operations. The strict
locking convention prevents deadlock situations for dma-buf importers and
exporters.
Signed-off-by:
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare Tegra video decoder driver to the common dynamic dma-buf
locking convention by starting to use the unlocked versions of dma-buf
API functions.
Signed-off-by: Dmitry Osipenko
Acked-by: Christian König
---
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare V4L2 memory allocators to the common dynamic dma-buf locking
convention by starting to use the unlocked versions of dma-buf API
functions.
Acked-by: Tomasz Figa
Signed-off-by: Dmitry Osipenko
Acked-by: Christian König
---
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare gntdev driver to the common dynamic dma-buf locking convention
by starting to use the unlocked versions of dma-buf API functions.
Signed-off-by: Dmitry Osipenko
Acked-by: Christian König
---
drivers/xen/gntdev-dmabuf.c | 8
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare fastrpc to the common dynamic dma-buf locking convention by
starting to use the unlocked versions of dma-buf API functions.
Signed-off-by: Dmitry Osipenko
Acked-by: Christian König
---
drivers/misc/fastrpc.c | 6 +++---
1 file
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare InfiniBand drivers to the common dynamic dma-buf locking
convention by starting to use the unlocked versions of dma-buf API
functions.
Signed-off-by: Dmitry Osipenko
Acked-by: Christian König
---
drivers/infiniband/core/umem_dmabuf.c
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare Etnaviv driver to the common dynamic dma-buf locking convention
by starting to use the unlocked versions of dma-buf API functions.
Signed-off-by: Dmitry Osipenko
Interesting, where is the matching vmap()?
Anyway, this patch is Acked-by:
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare Tegra DRM driver to the common dynamic dma-buf locking convention
by starting to use the unlocked versions of dma-buf API functions.
Signed-off-by: Dmitry Osipenko
Acked-by: Christian König
---
drivers/gpu/drm/tegra/gem.c | 17
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare OMAP DRM driver to the common dynamic dma-buf locking convention
by starting to use the unlocked versions of dma-buf API functions.
Signed-off-by: Dmitry Osipenko
Acked-by: Christian König
---
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare i915 driver to the common dynamic dma-buf locking convention
by starting to use the unlocked versions of dma-buf API functions
and handling cases where importer now holds the reservation lock.
Signed-off-by: Dmitry Osipenko
Acked-by:
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare Armada driver to the common dynamic dma-buf locking convention
by starting to use the unlocked versions of dma-buf API functions.
Signed-off-by: Dmitry Osipenko
Acked-by: Christian König
---
drivers/gpu/drm/armada/armada_gem.c | 8
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
Prepare DRM prime core to the common dynamic dma-buf locking convention
by starting to use the unlocked versions of dma-buf API functions.
Signed-off-by: Dmitry Osipenko
Reviewed-by: Christian König
---
drivers/gpu/drm/drm_prime.c | 6 +++---
47 matches
Mail list logo
