Re: [PATCH] Revert "drm/amdgpu: drop runtime pm disablement quirk on several sienna cichlid cards"

2022-09-06 Thread Lazar, Lijo
On 9/7/2022 10:23 AM, Guchun Chen wrote: This reverts commit e2994d23d8afa2fb465fdb8cf544b736f67ab8ba. Frequent BACO enter/exit will cause EMI failure, so disable runtime PM on these server SKUs. Apart from this, any BACO entry/exit in quick succession could cause the same failure. If

RE: [PATCH V2] drm/amdgpu: Adjust removal control flow for smu v13_0_2

2022-09-06 Thread Chai, Thomas
[AMD Official Use Only - General] Yes, I will add the sequence adjustment to the comment. - Best Regards, Thomas From: Zhang, Hawking Sent: Wednesday, September 7, 2022 11:42 AM To: Chai, Thomas ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Wang, Yang(Kevin) Subject: Re:

RE: [PATCH] Revert "drm/amdgpu: drop runtime pm disablement quirk on several sienna cichlid cards"

2022-09-06 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Chen, Guchun > Sent: Wednesday, September 7, 2022 12:53 PM > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Zhang, Hawking > ; Lazar, Lijo ; Quan, Evan > ; Feng, Kenneth > Cc: Chen, Guchun

[PATCH] Revert "drm/amdgpu: drop runtime pm disablement quirk on several sienna cichlid cards"

2022-09-06 Thread Guchun Chen
This reverts commit e2994d23d8afa2fb465fdb8cf544b736f67ab8ba. Frequent BACO enter/exit will cause EMI failure, so disable runtime PM on these server SKUs. Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 13 + 1 file changed, 13 insertions(+) diff --git

RE: [PATCH] drm/amdgpu: getting fan speed pwm for vega10 properly

2022-09-06 Thread Quan, Evan
[Public] Thanks Alex and Yury. The changes seem reasonable to me. Feel free to add my RB: Reviewed-by: Evan Quan BR Evan From: Deucher, Alexander Sent: Tuesday, September 6, 2022 11:05 PM To: Yury Zhuravlev ; amd-gfx@lists.freedesktop.org; Quan, Evan ; Feng, Kenneth Subject: Re: [PATCH]

Re: [PATCH V2] drm/amdgpu: Adjust removal control flow for smu v13_0_2

2022-09-06 Thread Zhang, Hawking
Thanks. Can you please share more details to help me understand the sequence adjustment in suspend? Regards, Hawking From: Chai, Thomas Date: Wednesday, September 7, 2022 at 11:29 To: Zhang, Hawking , amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao , Wang, Yang(Kevin) Subject: RE: [PATCH V2]

RE: [PATCH V2] drm/amdgpu: Adjust removal control flow for smu v13_0_2

2022-09-06 Thread Chai, Thomas
[AMD Official Use Only - General] OK, I will update patch. - Best Regards, Thomas From: Zhang, Hawking Sent: Wednesday, September 7, 2022 10:40 AM To: Chai, Thomas ; amd-gfx@lists.freedesktop.org Cc: Chai, Thomas ; Zhou1, Tao ; Wang, Yang(Kevin) Subject: Re: [PATCH V2]

Re: [PATCH V2] drm/amdgpu: Adjust removal control flow for smu v13_0_2

2022-09-06 Thread Zhang, Hawking
[AMD Official Use Only - General] +static void amdgpu_device_gpu_reset(struct amdgpu_device *adev) +{ + struct amdgpu_reset_context reset_context; + + memset(_context, 0, sizeof(reset_context)); + reset_context.method = AMD_RESET_METHOD_NONE; + reset_context.reset_req_dev

RE: [PATCH] drm/amdgpu: correct doorbell range/size value for CSDMA_DOORBELL_RANGE

2022-09-06 Thread Du, Xiaojian
[AMD Official Use Only - General] Reviewed-by: Xiaojian Du Thanks, Xiaojian -Original Message- From: Zhang, Yifan Sent: Tuesday, September 6, 2022 1:45 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Tim ; Du, Xiaojian ; Zhang, Yifan Subject: [PATCH]

[linux-next:master] BUILD REGRESSION 840126e36e8ff272cb63158646433fa1324533d9

2022-09-06 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 840126e36e8ff272cb63158646433fa1324533d9 Add linux-next specific files for 20220906 Error/Warning reports: https://lore.kernel.org/linux-mm/202209021204.dclzollr-...@intel.com https

[RFC PATCH] drm/amdgpu: Set MTYPE in PTE based on BO flags

2022-09-06 Thread Felix Kuehling
The same BO may need different MTYPEs and SNOOP flags in PTEs depending on its current location relative to the mappint GPU. Setting MTYPEs from clients ahead of time is not practical for coherent memory sharing. Instead determine the correct MTYPE for the desired coherence model and current BO

Re: [PATCH 1/1] drm/amdkfd: Remove prefault before migrating to VRAM

2022-09-06 Thread Felix Kuehling
On 2022-09-06 15:34, Philip Yang wrote: If svm range no back system memory pages, migrate the range to GPU VRAM don't need prefault on system pages to migrate pages. Instead we just alloc VRAM pages and setup migrate->dst with the corresponding device page and skip the page migration. The

Re: Build regressions/improvements in v6.0-rc4

2022-09-06 Thread Kees Cook
On Mon, Sep 05, 2022 at 09:46:01AM +0200, Geert Uytterhoeven wrote: > On Mon, 5 Sep 2022, Geert Uytterhoeven wrote: > > JFYI, when comparing v6.0-rc4[1] to v6.0-rc3[3], the summaries are: > > - build errors: +3/-16 > > + /kisskb/src/arch/sh/kernel/machvec.c: error: array subscript 'struct >

Re: [PATCH] drm/amd/display: Fix register definitions for DCN32/321

2022-09-06 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Thank you Siqueira. -- Regards, Jay From: Siqueira, Rodrigo Sent: Tuesday, September 6, 2022 11:56 AM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Deucher, Alexander Subject: Re: [PATCH]

[PATCH] drm/amdgpu: use dirty framebuffer helper

2022-09-06 Thread Hamza Mahfooz
Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs struct. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v6 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-09-06 Thread Daniel Vetter
On Tue, Aug 16, 2022 at 10:33:16AM +0530, Arunpravin Paneer Selvam wrote: > > > On 8/15/2022 4:35 PM, Christian König wrote: > > Am 12.08.22 um 15:30 schrieb Arunpravin Paneer Selvam: > > > We are adding two new callbacks to ttm resource manager > > > function to handle intersection and

[PATCH 1/1] drm/amdkfd: Remove prefault before migrating to VRAM

2022-09-06 Thread Philip Yang
If svm range no back system memory pages, migrate the range to GPU VRAM don't need prefault on system pages to migrate pages. Instead we just alloc VRAM pages and setup migrate->dst with the corresponding device page and skip the page migration. The device page will be inserted to PTE. Then CPU

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-09-06 Thread Daniel Vetter
On Fri, Aug 12, 2022 at 08:03:47AM +0200, Greg KH wrote: > On Thu, Aug 11, 2022 at 06:52:40PM +0200, Daniel Vetter wrote: > > On Wed, Aug 03, 2022 at 04:13:05PM -0400, Jason Baron wrote: > > > > > > > > > On 8/3/22 15:56, jim.cro...@gmail.com wrote: > > > > On Wed, Jul 20, 2022 at 9:32 AM Jim

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c

2022-09-06 Thread Deucher, Alexander
[Public] Yeah, seems to be a mix. I don't have a strong opinion as long as it has MIT. Alex From: Kuehling, Felix Sent: Tuesday, September 6, 2022 9:46 AM To: Jingyu Wang ; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; airl...@linux.ie ;

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_kms.c

2022-09-06 Thread kernel test robot
Hi Jingyu, Thank you for the patch! Yet something to improve: [auto build test ERROR on e47eb90a0a9ae20b82635b9b99a8d0979b757ad8] url: https://github.com/intel-lab-lkp/linux/commits/Jingyu-Wang/drm-amdgpu-cleanup-coding-style-in-amdgpu_kms-c/20220906-104802 base

[RFC PATCH v2 9/9] drm/amd/display: enable DRM shaper and 3D LUT properties

2022-09-06 Thread Melissa Wen
Shaper LUT and 3D LUT programming is done, so make the DRM color properties available. Signed-off-by: Melissa Wen --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c

[RFC PATCH v2 8/9] drm/amd/display: update lut3d and shaper lut to stream

2022-09-06 Thread Melissa Wen
It follows the same path of out_transfer_func for stream updates, since shaper LUT and 3D LUT is programmed in funcs.set_output_transfer_func() and this function is called in the atomic commit_tail when update_flags.bits.out_tf is set. Signed-off-by: Melissa Wen ---

[RFC PATCH v2 7/9] drm/amd/display: add user shaper LUT support to amdgpu_dm color pipeline

2022-09-06 Thread Melissa Wen
Now, we can use shaper LUT to delinearize and/or normalize the color space for a more efficient 3D LUT support (so far, only for DRM atomic color mgmt). If a degamma 1D LUT is passed to linearize the color space, a custom shaper 1D LUT can be used before applying 3D LUT. Signed-off-by: Melissa

[RFC PATCH v2 6/9] drm/amd/display: add user 3D LUT support to the amdgpu_dm color pipeline

2022-09-06 Thread Melissa Wen
Map DRM 3D LUT in the atomic color mgmt pipeline to DC. 3D LUT works better in a non-linear color space, therefore using a degamma to linearize the input space may produce unexpected results. The next patch introduces shaper LUT support that can be used to delinearize the color space before

[RFC PATCH v2 5/9] drm/amd/display: encapsulate atomic regamma operation

2022-09-06 Thread Melissa Wen
We are introducing DRM 3D LUT property to DM color pipeline in the next patch, but so far, only for atomic interface. By checking .set_output_transfer_func in DC drivers with MPC 3D LUT support, we can verify that regamma is only programmed when 3D LUT programming fails. As a groundwork to

[RFC PATCH v2 3/9] drm/drm_color_mgmt: add shaper LUT to color mgmt properties

2022-09-06 Thread Melissa Wen
Shaper LUT is used to shape the contect after blending, i.e., de-linearize space before applying 3D LUT color correction. In the next patch, we are adding 3D LUT property to DRM color mgmt. Signed-off-by: Melissa Wen --- drivers/gpu/drm/drm_atomic_state_helper.c | 4 +++

[RFC PATCH v2 4/9] drm/drm_color_mgmt: add 3D LUT to color mgmt properties

2022-09-06 Thread Melissa Wen
Add 3D LUT for gammar correction using a 3D lookup table. The position in the color correction pipeline where 3D LUT is applied depends on hw design, being after CTM or gamma. If just after CTM, a shaper lut must be set to shape the content for a non-linear space. That details should be handled by

[RFC PATCH v2 2/9] drm/amd/display: add comments to describe DM crtc color mgmt behavior

2022-09-06 Thread Melissa Wen
Describe some expected behavior of the AMD DM color mgmt programming. Signed-off-by: Melissa Wen --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c

[RFC PATCH v2 1/9] drm/amd/display: remove unused regamma condition

2022-09-06 Thread Melissa Wen
The function __set_output_tf is only called by amdgpu_dm_update_crtc_color_mgmt() when using atomic regamma. In this situation, func->tf == TRANSFER_FUNCTION_LINEAR (the original if condition) and it never falls into tf != LINEAR (the else condition). Therefore, remove unused condition to avoid

[RFC PATCH v2 0/9] Enable 3D LUT to AMD display drivers

2022-09-06 Thread Melissa Wen
Hi, >From all feedback at [3DLUT_RFC] and an extensive AMD driver examination, here I am back with a first attempt to wire up a user 3D LUT (post-blending) to DC interface via DM CRTC color mgmt :) I'm following some specific approaches to handle user shaper LUT and user 3D LUT that I would like

Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

2022-09-06 Thread Greg Kroah-Hartman
On Tue, Sep 06, 2022 at 11:39:44AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-09-06 11:06, Greg Kroah-Hartman wrote: > > On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: > > > > > > > > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote: > > > > On Fri, Sep 02,

Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

2022-09-06 Thread Greg Kroah-Hartman
On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote: > > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs_lookup() the result must have dput() called on it, > > > otherwise the

Re: [PATCH] drm/amd/display: Fix register definitions for DCN32/321

2022-09-06 Thread Rodrigo Siqueira Jordao
On 2022-09-01 15:27, Aurabindo Pillai wrote: [Why & How] Fix the instatiation sequence for MPC registers and add a few other missing register definitions that were ommited erroneously when copying them over to enable runtime initialization of reigster offsets for DCN32/321 Signed-off-by:

Re: [PATCH v2 1/2] drm/amdgpu: Move HDP remapping earlier during init

2022-09-06 Thread Lazar, Lijo
On 9/6/2022 8:55 PM, Alex Deucher wrote: On Mon, Sep 5, 2022 at 1:27 AM Lazar, Lijo wrote: On 9/2/2022 1:09 AM, Alex Deucher wrote: How about this? We should just move HDP remap to gmc hw_init since that is mainly what uses it anyway. Sorry, I missed to R-B the previous version. Did

Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable

2022-09-06 Thread Rodrigo Siqueira Jordao
On 2022-09-02 03:54, cgel@gmail.com wrote: From: zhang songyi Return the enable_link_dp() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: zhang songyi --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +- 1 file changed,

Re: amd iommu configuration

2022-09-06 Thread Felix Kuehling
On 2022-09-06 10:52, Robin Murphy wrote: On 2022-09-05 15:13, Vasant Hegde wrote: Steven, [+Felix, amd-fgx list] On 9/3/2022 4:29 AM, Steven J Abner wrote: Hi I was referred to you from linux-ker...@vger.kernel.org about the following issue. Here is as was written: On 9/1/22 11:36, Steven

Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

2022-09-06 Thread Rodrigo Siqueira Jordao
On 2022-09-06 11:06, Greg Kroah-Hartman wrote: On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: On 2022-09-02 09:10, Greg Kroah-Hartman wrote: On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: When calling debugfs_lookup() the result must have

Re: [PATCH] drm/amdgpu: recleanup coding style in amdgpu_fence.c

2022-09-06 Thread Alex Deucher
On Mon, Sep 5, 2022 at 3:40 AM Jingyu Wang wrote: > > Fix everything checkpatch.pl complained about in amdgpu_fence.c, > modified use "} else {", sent it again, thx. > > Signed-off-by: Jingyu Wang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 15 +-- > 1 file changed, 9

Re: [PATCH] drm/amdkfd: print address in hex format rather than decimal

2022-09-06 Thread Felix Kuehling
On 2022-09-06 01:46, Yifan Zhang wrote: Addresses should be printed in hex format. Signed-off-by: Yifan Zhang Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 1/2] drm/amdgpu: Move HDP remapping earlier during init

2022-09-06 Thread Alex Deucher
On Mon, Sep 5, 2022 at 1:27 AM Lazar, Lijo wrote: > > > > On 9/2/2022 1:09 AM, Alex Deucher wrote: > > How about this? We should just move HDP remap to gmc hw_init since > > that is mainly what uses it anyway. > > > > Sorry, I missed to R-B the previous version. Did you find any problem > when

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_atpx_handler.c

2022-09-06 Thread Alex Deucher
On Mon, Sep 5, 2022 at 2:29 AM Jingyu Wang wrote: > > Fix everything checkpatch.pl complained about in amdgpu_atpx_handler.c > > Signed-off-by: Jingyu Wang > --- > .../gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 27 +++ > 1 file changed, 16 insertions(+), 11 deletions(-) > >

Re: [PATCH] drm/amdgpu: getting fan speed pwm for vega10 properly

2022-09-06 Thread Deucher, Alexander
[Public] @Quan, Evan, @Feng, Kenneth can you take a look? Thanks, Alex From: amd-gfx on behalf of Yury Zhuravlev Sent: Friday, September 2, 2022 1:24 PM To: amd-gfx@lists.freedesktop.org Subject:

Re: amd iommu configuration

2022-09-06 Thread Robin Murphy
On 2022-09-05 15:13, Vasant Hegde wrote: Steven, [+Felix, amd-fgx list] On 9/3/2022 4:29 AM, Steven J Abner wrote: Hi I was referred to you from linux-ker...@vger.kernel.org about the following issue. Here is as was written: On 9/1/22 11:36, Steven J Abner wrote: Hi Building a kernel

Re: [PATCH] drm/amdgpu: prevent toc firmware memory leak

2022-09-06 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: Chen, Guchun Sent: Friday, September 2, 2022 2:11 AM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui Cc: Chen, Guchun Subject: [PATCH] drm/amdgpu: prevent toc firmware memory

Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

2022-09-06 Thread Rodrigo Siqueira Jordao
On 2022-09-02 09:10, Greg Kroah-Hartman wrote: On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. Fix this up by properly calling dput(). Cc: Harry Wentland

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c

2022-09-06 Thread Felix Kuehling
Am 2022-09-05 um 04:38 schrieb Jingyu Wang: Fix everything checkpatch.pl complained about in amdgpu_amdkfd_gpuvm.c Signed-off-by: Jingyu Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_drv.c

2022-09-06 Thread Robin Murphy
On 2022-09-04 20:15, Jingyu Wang wrote: [...] @@ -565,8 +566,8 @@ module_param_named(timeout_period, amdgpu_watchdog_timer.period, uint, 0644); */ #ifdef CONFIG_DRM_AMDGPU_SI -#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE) -int amdgpu_si_support = 0; +#if

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_kms.c

2022-09-06 Thread kernel test robot
Hi Jingyu, Thank you for the patch! Yet something to improve: [auto build test ERROR on e47eb90a0a9ae20b82635b9b99a8d0979b757ad8] url: https://github.com/intel-lab-lkp/linux/commits/Jingyu-Wang/drm-amdgpu-cleanup-coding-style-in-amdgpu_kms-c/20220906-104802 base

Re: Gang submit

2022-09-06 Thread Christian König
Hi Monk, If one gfx ib and one compute ib are in a gang, can they run literally in parallel on GPU ? Yes, that is essentially the functionality of gang submit. The driver stack must guarantee that those IBs run at the same time because they use a ring buffer to communicate with each

Re: [PATCH v2] drm/ttm: update bulk move object of ghost BO

2022-09-06 Thread Christian König
Am 06.09.22 um 10:46 schrieb ZhenGuo Yin: [Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 [amdttm] Call Trace: amddma_resv_reserve_fences+0x10d/0x1f0 [amdkcl]

[PATCH v2] drm/ttm: update bulk move object of ghost BO

2022-09-06 Thread ZhenGuo Yin
[Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 [amdttm] Call Trace: amddma_resv_reserve_fences+0x10d/0x1f0 [amdkcl] amdttm_bo_put+0x28/0x30 [amdttm]

[PATCH V2] drm/amdgpu: Adjust removal control flow for smu v13_0_2

2022-09-06 Thread YiPeng Chai
Adjust removal control flow for smu v13_0_2: During amdgpu uninstallation, when removing the first device, the kernel needs to first send a mode1reset message to all gpu devices. Otherwise, smu initialization will fail the next time amdgpu is installed. V2: 1. Update commit comments. 2. Remove

[PATCH] drm/amdgpu: recleanup coding style in amdgpu_fence.c

2022-09-06 Thread Jingyu Wang
Fix everything checkpatch.pl complained about in amdgpu_fence.c, modified use "} else {", sent it again, thx. Signed-off-by: Jingyu Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

Re: Build regressions/improvements in v6.0-rc4

2022-09-06 Thread Geert Uytterhoeven
On Mon, 5 Sep 2022, Geert Uytterhoeven wrote: JFYI, when comparing v6.0-rc4[1] to v6.0-rc3[3], the summaries are: - build errors: +3/-16 + /kisskb/src/arch/sh/kernel/machvec.c: error: array subscript 'struct sh_machine_vector[0]' is partly outside array bounds of 'long int[1]'

[PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c

2022-09-06 Thread Jingyu Wang
Fix everything checkpatch.pl complained about in amdgpu_amdkfd_gpuvm.c Signed-off-by: Jingyu Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c

[PATCH] drm/amdgpu: cleanup coding style in amdgpu_device.c

2022-09-06 Thread Jingyu Wang
Fix some checkpatch.pl complained about in amdgpu_device.c Signed-off-by: Jingyu Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 136 +++-- 1 file changed, 69 insertions(+), 67 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH] drm/amdgpu: cleanup coding style in amdgpu_kms.c

2022-09-06 Thread Jingyu Wang
Fix some checkpatch.pl complained about in amdgpu_kms.c Signed-off-by: Jingyu Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd.c

2022-09-06 Thread Jingyu Wang
Fix everything checkpatch.pl complained about in amdgpu_amdkfd.c Signed-off-by: Jingyu Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c index

[GIT PULL] Immutable backlight-detect-refactor branch between acpi, drm-* and pdx86

2022-09-06 Thread Hans de Goede
Hi All, Now that all patches have been reviewed/acked here is an immutable backlight-detect-refactor branch with 6.0-rc1 + the v5 patch-set, for merging into the relevant (acpi, drm-* and pdx86) subsystems. Please pull this branch into the relevant subsystems. I will merge this into the

回复: Re: [PATCH] drm:Fix the blank screen problem of some 1920x1080 75Hz monitors using R520 graphics card

2022-09-06 Thread 钟沛
Thanks for your reply!We found that in the amdgpu_pll_compute function, when the target_clock is the value contained in the drm_dmt_modes defined in drm_edid.c, the diff is 0. When target_clock is some special value, we cannot find a diff value of 0, so we need to find the smallest diff value to