RE: [PATCH 0/4] support query rlcv/rlcp firmware version

2022-09-15 Thread Xu, Feifei
[AMD Official Use Only - General] Series is Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of Hawking Zhang Sent: Friday, September 16, 2022 1:00 AM To: amd-gfx@lists.freedesktop.org; Gao, Likun ; Deucher, Alexander Cc: Zhang, Hawking Subject: [PATCH 0/4] support

Re: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-15 Thread Christian König
Am 15.09.22 um 22:37 schrieb Andrey Grodzovsky: On 2022-09-15 15:26, Christian König wrote: Am 15.09.22 um 20:29 schrieb Andrey Grodzovsky: On 2022-09-15 06:09, Zhao, Victor wrote: [AMD Official Use Only - General] Hi Christian, The test sequence is executing a compute engine hang while ru

[PATCH] drm/amdgpu: add MES and MES-KIQ version in debugfs

2022-09-15 Thread Yifan Zhang
This patch addes MES and MES-KIQ version in debugfs. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 24 include/uapi/drm/amdgpu_drm.h | 4 2 files changed, 28 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b

Re: [PATCH V3 46/47] drm/amd/display: Fix failures of disabling primary plans

2022-09-15 Thread Rodrigo Siqueira Jordao
Hi Michel, First of all, thanks a lot for your review. I want to take this opportunity to discuss this topic in more depth and learn more from you and others. +(Nick, Leo, Daniel, Mark, Dave, Sean, Simon) On 2022-09-15 04:55, Michel Dänzer wrote: On 2022-09-14 22:08, Alex Hung wrote: On 20

Re: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-15 Thread Andrey Grodzovsky
On 2022-09-15 15:26, Christian König wrote: Am 15.09.22 um 20:29 schrieb Andrey Grodzovsky: On 2022-09-15 06:09, Zhao, Victor wrote: [AMD Official Use Only - General] Hi Christian, The test sequence is executing a compute engine hang while running a lot of containers submitting gfx jobs.

Re: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-15 Thread Christian König
Am 15.09.22 um 20:29 schrieb Andrey Grodzovsky: On 2022-09-15 06:09, Zhao, Victor wrote: [AMD Official Use Only - General] Hi Christian, The test sequence is executing a compute engine hang while running a lot of containers submitting gfx jobs. We have advanced tdr mode and mode2 reset enab

Re: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-15 Thread Andrey Grodzovsky
Had a typo - see bellow On 2022-09-15 14:29, Andrey Grodzovsky wrote: On 2022-09-15 06:09, Zhao, Victor wrote: [AMD Official Use Only - General] Hi Christian, The test sequence is executing a compute engine hang while running a lot of containers submitting gfx jobs. We have advanced tdr mod

Re: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-15 Thread Andrey Grodzovsky
On 2022-09-15 06:09, Zhao, Victor wrote: [AMD Official Use Only - General] Hi Christian, The test sequence is executing a compute engine hang while running a lot of containers submitting gfx jobs. We have advanced tdr mode and mode2 reset enabled on driver. When a compute hang job timeout h

Re: [PATCH] drivers/pci: Decrease VF memory BAR size to Save host memory occupied by PTEs:

2022-09-15 Thread Alex Deucher
On Thu, Sep 15, 2022 at 6:34 AM Rui Ma wrote: > > The VRAM space is fixed, as the number of VFs increases, the actual BAR > memory space used by each VF decreases. However, the BAR memory mapping is > always based on the initial size of the VRAM. So do not map this unneeded > memory can reduce the

Re: [PATCH 00/10] switch to common helper for rlc fw init

2022-09-15 Thread Christian König
Nice cleanup, feel free to add an Acked-by: Christian König to the whole series. Regards, Christian. Am 15.09.22 um 19:01 schrieb Hawking Zhang: Replace IP specific implementation with common rlc helper for rlc firmware initialization. This also helps reduce duplicated code when introduce ne

[PATCH 10/10] drm/amdgpu/gfx11: switch to amdgpu_gfx_rlc_init_microcode

2022-09-15 Thread Hawking Zhang
switch to common helper to initialize rlc firmware for gfx11 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 156 + 1 file changed, 4 insertions(+), 152 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdg

[PATCH 09/10] drm/amdgpu/gfx10: switch to amdgpu_gfx_rlc_init_microcode

2022-09-15 Thread Hawking Zhang
switch to common helper to initialize rlc firmware for gfx10 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 191 + 1 file changed, 4 insertions(+), 187 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdg

[PATCH 07/10] drm/amdgpu/gfx8: switch to amdgpu_gfx_rlc_init_microcode

2022-09-15 Thread Hawking Zhang
switch to common helper to initialize rlc firmware for gfx8 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 60 +-- 1 file changed, 11 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 08/10] drm/amdgpu/gfx9: switch to amdgpu_gfx_rlc_init_microcode

2022-09-15 Thread Hawking Zhang
switch to common helper to initialize rlc firmware for gfx9 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 106 +- 1 file changed, 3 insertions(+), 103 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 06/10] drm/amdgpu: add helper to init rlc firmware

2022-09-15 Thread Hawking Zhang
To initialzie rlc firmware according to rlc firmware header version Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 35 + drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h | 4 ++- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/gp

[PATCH 05/10] drm/amdgpu: add helper to init rlc fw in header v2_4

2022-09-15 Thread Hawking Zhang
To initialize rlc firmware in header v2_4 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 60 + 1 file changed, 60 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c index adbb9bed86fc.

[PATCH 04/10] drm/amdgpu: add helper to init rlc fw in header v2_3

2022-09-15 Thread Hawking Zhang
To initialize rlc firmware in header v2_3 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 35 + 1 file changed, 35 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c index a055818d87f7.

[PATCH 03/10] drm/amdgpu: add helper to init rlc fw in header v2_2

2022-09-15 Thread Hawking Zhang
To initialize rlc firmware in header v2_2 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 30 + 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c index 04bdb885918d.

[PATCH 01/10] drm/amdgpu: add helper to init rlc fw in header v2_0

2022-09-15 Thread Hawking Zhang
To initialize rlc firmware in header v2_0 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 64 + 1 file changed, 64 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c index 6373bfb47d55.

[PATCH 02/10] drm/amdgpu: add helper to init rlc fw in header v2_1

2022-09-15 Thread Hawking Zhang
To initialize rlc firmware in header v2_1 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 40 + 1 file changed, 40 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c index 10b998cae1ba.

[PATCH 00/10] switch to common helper for rlc fw init

2022-09-15 Thread Hawking Zhang
Replace IP specific implementation with common rlc helper for rlc firmware initialization. This also helps reduce duplicated code when introduce new ip block support. Hawking Zhang (10): drm/amdgpu: add helper to init rlc fw in header v2_0 drm/amdgpu: add helper to init rlc fw in header v2_1

[PATCH 3/4] drm/amdgpu: add two new subquery ids

2022-09-15 Thread Hawking Zhang
To support query rlcp and rlcv firmware version from existing AMDGPU_INFO_FW_VERSION interface Signed-off-by: Hawking Zhang Reviewed-by: Likun Gao Reviewed-by: Feifei Xu --- include/uapi/drm/amdgpu_drm.h | 4 1 file changed, 4 insertions(+) diff --git a/include/uapi/drm/amdgpu_drm.h b/in

[PATCH 4/4] drm/amdgpu: add rlcv/rlcp version info to debugfs

2022-09-15 Thread Hawking Zhang
amdgpu_firmware_info debugfs will show rlcv/rlcp ucode version info Signed-off-by: Hawking Zhang Reviewed-by: Likun Gao Reviewed-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/am

[PATCH 2/4] drm/amdgpu: support print rlc v2_x ucode hdr

2022-09-15 Thread Hawking Zhang
add rlc v2_x support to print_rlc_hdr helper Signed-off-by: Hawking Zhang Reviewed-by: Likun Gao Reviewed-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 168 +++--- 1 file changed, 118 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 1/4] drm/amdgpu: save rlcv/rlcp ucode version in amdgpu_gfx

2022-09-15 Thread Hawking Zhang
cache rlcv/rlcvp ucode version info in amdgpu_gfx structure Signed-off-by: Hawking Zhang Reviewed-by: Likun Gao Reviewed-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 4 drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 5 +

[PATCH 0/4] support query rlcv/rlcp firmware version

2022-09-15 Thread Hawking Zhang
To allow query rlcv/rlcp firmware verion info Hawking Zhang (4): drm/amdgpu: save rlcv/rlcp ucode version in amdgpu_gfx drm/amdgpu: support print rlc v2_x ucode hdr drm/amdgpu: add two new subquery ids drm/amdgpu: add rlcv/rlcp version info to debugfs drivers/gpu/drm/amd/amdgpu/amdgpu_gf

Re: [PATCH v5 1/1] drm/amdgpu: Fix amdgpu_vm_pt_free warning

2022-09-15 Thread Christian König
Am 15.09.22 um 16:39 schrieb Philip Yang: On 2022-09-15 02:21, Christian König wrote: Am 14.09.22 um 19:45 schrieb Felix Kuehling: Am 2022-09-14 um 12:08 schrieb Philip Yang: Free page table BO from vm resv unlocked context generate below warnings. Add a pt_free_work in vm to free page table

Re: [PATCH v5 1/1] drm/amdgpu: Fix amdgpu_vm_pt_free warning

2022-09-15 Thread Philip Yang
On 2022-09-15 02:21, Christian König wrote: Am 14.09.22 um 19:45 schrieb Felix Kuehling: Am 2022-09-14 um 12:08 schrieb Philip Yang: Free page table BO from vm resv unlocked context generate below warnings. Add a pt_free_work in vm to free page table BO from vm->pt_freed list. pass vm resv u

RE: [PATCH v5 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-09-15 Thread Ruhl, Michael J
>-Original Message- >From: Dmitry Osipenko >Sent: Tuesday, September 13, 2022 3:28 PM >To: David Airlie ; Gerd Hoffmann ; >Gurchetan Singh ; Chia-I Wu >; Daniel Vetter ; Daniel Almeida >; Gert Wollny ; >Gustavo Padovan ; Daniel Stone >; Tomeu Vizoso ; >Maarten Lankhorst ; Maxime Ripard >;

Re: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-15 Thread Christian König
Hi Victor, the advanced tdr mode is not a feature we want to enable in production and keep for much longer. So would that issue happen without this as well? If not it is rather questionable if we should look into fixing this in the first place. Regards, Christian. Am 15.09.22 um 12:09 schr

[PATCH] drivers/pci: Decrease VF memory BAR size to Save host memory occupied by PTEs:

2022-09-15 Thread Rui Ma
The VRAM space is fixed, as the number of VFs increases, the actual BAR memory space used by each VF decreases. However, the BAR memory mapping is always based on the initial size of the VRAM. So do not map this unneeded memory can reduce the amount of PTEs to save host memory. Signed-off-by: Rui

RE: [PATCH 2/2] drm/amdgpu: move enable irq later to avoid race with ih resume

2022-09-15 Thread Zhao, Victor
[AMD Official Use Only - General] Hi Lijo, Yes, this is what I observed in sienna cichlid. Thanks, Victor -Original Message- From: Lazar, Lijo Sent: Thursday, September 15, 2022 4:00 PM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Grodzovsky, Andrey Subject

RE: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-15 Thread Zhao, Victor
[AMD Official Use Only - General] Hi Christian, The test sequence is executing a compute engine hang while running a lot of containers submitting gfx jobs. We have advanced tdr mode and mode2 reset enabled on driver. When a compute hang job timeout happens, the 2 jobs on the gfx pending list m

[PATCH 4/4] drm/amdgpu: Implement OS triggered MCBP(v4)

2022-09-15 Thread jiadong.zhu
From: "Jiadong.Zhu" Trigger Mid-Command Buffer Preemption according to the priority of the software rings and the hw fence signalling condition. The muxer saves the locations of the indirect buffer frames from the software ring together with the fence sequence number in its fifo queue, and pops

Re: [PATCH 2/2] drm/amdgpu: move enable irq later to avoid race with ih resume

2022-09-15 Thread Lazar, Lijo
On 9/15/2022 12:08 PM, Zhao, Victor wrote: [AMD Official Use Only - General] Hi Lijo, IH resume was added to resolve an issue found during mode2 bring up on sienna cichlid: - close down mode2 reset and do a mode1 reset first - open mode2 reset and do a mode2 reset. Mode2 reset was found fai

[bug report] drm/amd/display: Reverted DSC programming sequence change

2022-09-15 Thread Dan Carpenter
Hello Nagulendran, Iswara, The patch c7783a6ed4fc: "drm/amd/display: Reverted DSC programming sequence change" from Aug 23, 2022, leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:4310 core_link_enable_stream() warn: if