Re: [PATCH] drm/amdgpu: Always align dumb buffer at PAGE_SIZE

2022-09-22 Thread Christian König
Am 23.09.22 um 07:28 schrieb lepton: On Thu, Sep 22, 2022 at 10:14 PM Christian König wrote: Am 23.09.22 um 01:04 schrieb Lepton Wu: Since size has been aligned to PAGE_SIZE already, just align it to PAGE_SIZE so later the buffer can be used as a texture in mesa after

Re: [PATCH] drm/amdgpu: Always align dumb buffer at PAGE_SIZE

2022-09-22 Thread Christian König
Am 23.09.22 um 01:04 schrieb Lepton Wu: Since size has been aligned to PAGE_SIZE already, just align it to PAGE_SIZE so later the buffer can be used as a texture in mesa after https://cgit.freedesktop.org/mesa/mesa/commit/?id=f7a4051b8 Otherwise, si_texture_create_object will fail at line

Re: [PATCH v1] drivers/amd/kv_dpm: check the return value of amdgpu_kv_smc_bapm_enable

2022-09-22 Thread Lazar, Lijo
On 9/23/2022 1:36 AM, Li Zhong wrote: Check the return value of amdgpu_kv_smc_bapm_enable() and log the error when it fails. Signed-off-by: Li Zhong --- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v3] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread Felix Kuehling
Am 2022-09-22 um 17:33 schrieb David Belanger: Enables support for software trap for MES >= 4. Adapted from implementation from Jay Cornwall. v2: Add IP version check in conditions. v3: Remove debugger code changes. Signed-off-by: Jay Cornwall Signed-off-by: David Belanger Reviewed-by: Felix

[PATCH v3] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread David Belanger
Enables support for software trap for MES >= 4. Adapted from implementation from Jay Cornwall. v2: Add IP version check in conditions. v3: Remove debugger code changes. Signed-off-by: Jay Cornwall Signed-off-by: David Belanger Reviewed-by: Felix Kuehling Acked-by: Alex Deucher ---

[PATCH] drm/amdgpu/vcn: update vcn4 fw shared data structure

2022-09-22 Thread Ruijing Dong
update VF_RB_SETUP_FLAG, add SMU_DPM_INTERFACE_FLAG, and corresponding change in VCN4. Signed-off-by: Ruijing Dong --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 8 +++- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 4 2 files changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread Felix Kuehling
Am 2022-09-22 um 13:57 schrieb Belanger, David: [AMD Official Use Only - General] -Original Message- From: Kuehling, Felix Sent: Thursday, September 22, 2022 1:14 PM To: Belanger, David ; amd- g...@lists.freedesktop.org Cc: Cornwall, Jay Subject: Re: [PATCH] drm/amdgpu: Enable SA

RE: [PATCH] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread Sider, Graham
[Public] > -Original Message- > From: Belanger, David > Sent: Thursday, September 22, 2022 2:49 PM > To: Sider, Graham ; amd- > g...@lists.freedesktop.org > Cc: Cornwall, Jay ; Kuehling, Felix > > Subject: RE: [PATCH] drm/amdgpu: Enable SA software trap. > > [Public] > > > > >

Re: [PATCH v2] drm/amdgpu: pass queue size and is_aql_queue to MES

2022-09-22 Thread Felix Kuehling
Am 2022-09-22 um 14:02 schrieb Graham Sider: Update mes_v11_api_def.h add_queue API with is_aql_queue parameter. Also re-use gds_size for the queue size (unused for KFD). MES requires the queue size in order to compute the actual wptr offset within the queue RB since it increases monotonically

RE: [PATCH] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread Belanger, David
[Public] > -Original Message- > From: Sider, Graham > Sent: Thursday, September 22, 2022 1:56 PM > To: Belanger, David ; amd- > g...@lists.freedesktop.org > Cc: Cornwall, Jay ; Kuehling, Felix > ; Belanger, David > Subject: RE: [PATCH] drm/amdgpu: Enable SA software trap. > >

Re: [REGRESSION] Graphical issues on Lenovo Yoga 7 14ARB7 laptop since v6.0-rc1 (bisected)

2022-09-22 Thread August Wikerfors
Hi Alex, On 2022-09-22 15:59, Alex Deucher wrote: On Thu, Sep 22, 2022 at 8:54 AM Thorsten Leemhuis wrote: Hi, this is your Linux kernel regression tracker. Top-posting for once, to make this easily accessible to everyone. @amdgpu developers, what up here? August afaics didn't even get a

[PATCH v2] drm/amdgpu: pass queue size and is_aql_queue to MES

2022-09-22 Thread Graham Sider
Update mes_v11_api_def.h add_queue API with is_aql_queue parameter. Also re-use gds_size for the queue size (unused for KFD). MES requires the queue size in order to compute the actual wptr offset within the queue RB since it increases monotonically for AQL queues. v2: Make is_aql_queue assign

RE: [PATCH] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread Belanger, David
[AMD Official Use Only - General] > -Original Message- > From: Kuehling, Felix > Sent: Thursday, September 22, 2022 1:14 PM > To: Belanger, David ; amd- > g...@lists.freedesktop.org > Cc: Cornwall, Jay > Subject: Re: [PATCH] drm/amdgpu: Enable SA software trap. > > Am 2022-09-22 um

RE: [PATCH] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread Sider, Graham
[Public] > -Original Message- > From: amd-gfx On Behalf Of > David Belanger > Sent: Thursday, September 22, 2022 12:17 PM > To: amd-gfx@lists.freedesktop.org > Cc: Cornwall, Jay ; Kuehling, Felix > ; Belanger, David > Subject: [PATCH] drm/amdgpu: Enable SA software trap. > > Caution:

Re: [PATCH] drm/amdgpu: Fix VRAM eviction issue

2022-09-22 Thread Christian König
Am 22.09.22 um 17:42 schrieb Arunpravin Paneer Selvam: On 9/22/2022 9:01 PM, Christian König wrote: Am 22.09.22 um 17:14 schrieb Arunpravin Paneer Selvam: A user reported that when he starts a game (MTGA) with wine, he observed an error msg failed to pin framebuffer with error -12. Found

Re: [PATCH v2] drm/amdgpu: Fix VRAM BO swap issue

2022-09-22 Thread Christian König
Am 22.09.22 um 19:14 schrieb Christian König: Am 22.09.22 um 17:26 schrieb Arunpravin Paneer Selvam: DRM buddy manager allocates the contiguous memory requests in a single block or multiple blocks. So for the ttm move operation (incase of low vram memory) we should consider all the blocks

Re: [PATCH] drm/amdgpu: pass queue size and is_aql_queue to MES

2022-09-22 Thread Felix Kuehling
Am 2022-09-20 um 10:29 schrieb Graham Sider: Update mes_v11_api_def.h add_queue API with is_aql_queue parameter. Also re-use gds_size for the queue size (unused for KFD). MES requires the queue size in order to compute the actual wptr offset within the queue RB since it increases monotonically

Re: [PATCH] drm/amdkfd: fix MQD init for GFX11 in init_mqd

2022-09-22 Thread Felix Kuehling
Am 2022-09-21 um 14:47 schrieb Graham Sider: Set remaining compute_static_thread_mgmt_se* accordingly. Signed-off-by: Graham Sider Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v11.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH v2] drm/amdgpu: Fix VRAM BO swap issue

2022-09-22 Thread Christian König
Am 22.09.22 um 17:26 schrieb Arunpravin Paneer Selvam: DRM buddy manager allocates the contiguous memory requests in a single block or multiple blocks. So for the ttm move operation (incase of low vram memory) we should consider all the blocks to compute the total memory size which compared

Re: [PATCH] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread Felix Kuehling
Am 2022-09-22 um 12:17 schrieb David Belanger: Enables support for software trap for MES >= 4. Adapted from implementation from Jay Cornwall. v2: Add IP version check in conditions. Signed-off-by: Jay Cornwall Signed-off-by: David Belanger Reviewed-by: Felix Kuehling ---

Re: [PATCH] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread Alex Deucher
On Thu, Sep 22, 2022 at 12:18 PM David Belanger wrote: > > Enables support for software trap for MES >= 4. > Adapted from implementation from Jay Cornwall. > > v2: Add IP version check in conditions. > > Signed-off-by: Jay Cornwall > Signed-off-by: David Belanger > Reviewed-by: Felix Kuehling

[PATCH] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread David Belanger
Enables support for software trap for MES >= 4. Adapted from implementation from Jay Cornwall. v2: Add IP version check in conditions. Signed-off-by: Jay Cornwall Signed-off-by: David Belanger Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c| 6 +-

Re: [PATCH v4] drm/sched: Add FIFO sched policy to run queue v3

2022-09-22 Thread Andrey Grodzovsky
On 2022-09-22 11:03, Luben Tuikov wrote: The title of this patch has "v3", but "v4" in the title prefix. If you're using "-v" to git-format-patch, please remove the "v3" from the title. Inlined: On 2022-09-21 14:28, Andrey Grodzovsky wrote: When many entities competing for same run queue on

Re: [PATCH] drm/amdgpu: Fix VRAM eviction issue

2022-09-22 Thread Arunpravin Paneer Selvam
On 9/22/2022 9:01 PM, Christian König wrote: Am 22.09.22 um 17:14 schrieb Arunpravin Paneer Selvam: A user reported that when he starts a game (MTGA) with wine, he observed an error msg failed to pin framebuffer with error -12. Found an issue with the VRAM mem type eviction decision

Re: [PATCH] drm/amdgpu: Fix VRAM eviction issue

2022-09-22 Thread Christian König
Am 22.09.22 um 17:14 schrieb Arunpravin Paneer Selvam: A user reported that when he starts a game (MTGA) with wine, he observed an error msg failed to pin framebuffer with error -12. Found an issue with the VRAM mem type eviction decision condition logic. This patch will fix the if condition

[PATCH v2] drm/amdgpu: Fix VRAM BO swap issue

2022-09-22 Thread Arunpravin Paneer Selvam
DRM buddy manager allocates the contiguous memory requests in a single block or multiple blocks. So for the ttm move operation (incase of low vram memory) we should consider all the blocks to compute the total memory size which compared with the struct ttm_resource num_pages in order to verify

Re: [PATCH] drm/amdgpu: Fix VRAM BO swap issue

2022-09-22 Thread Arunpravin Paneer Selvam
On 9/22/2022 7:04 PM, Alex Deucher wrote: On Thu, Sep 22, 2022 at 9:19 AM Arunpravin Paneer Selvam wrote: DRM buddy manager allocates the contiguous memory requests in a single block or multiple blocks. So for the ttm move operation (incase of low vram memory) we should consider all the

[PATCH] drm/amdgpu: Fix VRAM eviction issue

2022-09-22 Thread Arunpravin Paneer Selvam
A user reported that when he starts a game (MTGA) with wine, he observed an error msg failed to pin framebuffer with error -12. Found an issue with the VRAM mem type eviction decision condition logic. This patch will fix the if condition code error. Gitlab bug link:

Re: [PATCH v4] drm/sched: Add FIFO sched policy to run queue v3

2022-09-22 Thread Luben Tuikov
The title of this patch has "v3", but "v4" in the title prefix. If you're using "-v" to git-format-patch, please remove the "v3" from the title. Inlined: On 2022-09-21 14:28, Andrey Grodzovsky wrote: > When many entities competing for same run queue on > the same scheduler When many entities

Re: [PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Alex Deucher
Applied. Thanks! On Thu, Sep 22, 2022 at 2:49 AM Christian König wrote: > > Am 22.09.22 um 06:17 schrieb Li Zhong: > > amdgpu_bo_kmap() returns error when fails to map buffer object. Add the > > error check and propagate the error. > > > > Signed-off-by: Li Zhong > > We usually use "r" as

Re: [PATCH v2 0/6] Add support for atomic async page-flips

2022-09-22 Thread André Almeida
Hi Simon, On 8/30/22 14:29, Simon Ser wrote: This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic commits, aka. "immediate flip" (which might result in tearing). The feature was only available via the legacy uAPI, however for gaming use-cases it may be desirable to enable it via the

Re: [PATCH 23/31] Add debug option for exiting idle optimizations on cursor updates

2022-09-22 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Hi Jas, Please add drm/amd/display prefix to the patch title -- Regards, Jay From: Dhillon, Jasdeep Sent: Wednesday, September 21, 2022 8:18 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ;

Re: [PATCH 21/31] Add ABM control to panel_config struct.

2022-09-22 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Hi Jas, Please add drm/amd/display prefix to the patch title. -- Regards, Jay From: Dhillon, Jasdeep Sent: Wednesday, September 21, 2022 8:18 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ;

Re: [REGRESSION] Graphical issues on Lenovo Yoga 7 14ARB7 laptop since v6.0-rc1 (bisected)

2022-09-22 Thread Alex Deucher
On Thu, Sep 22, 2022 at 8:54 AM Thorsten Leemhuis wrote: > > Hi, this is your Linux kernel regression tracker. Top-posting for once, > to make this easily accessible to everyone. > > @amdgpu developers, what up here? August afaics didn't even get a single > reply for his report that even

Re: [PATCH] drm/amdgpu: Fix VRAM BO swap issue

2022-09-22 Thread Alex Deucher
On Thu, Sep 22, 2022 at 9:19 AM Arunpravin Paneer Selvam wrote: > > DRM buddy manager allocates the contiguous memory requests in > a single block or multiple blocks. So for the ttm move operation > (incase of low vram memory) we should consider all the blocks to > compute the total memory size

[PATCH] drm/amdgpu: Fix VRAM BO swap issue

2022-09-22 Thread Arunpravin Paneer Selvam
DRM buddy manager allocates the contiguous memory requests in a single block or multiple blocks. So for the ttm move operation (incase of low vram memory) we should consider all the blocks to compute the total memory size which compared with the struct ttm_resource num_pages in order to verify

Re: [PATCH] gpu: dc: fix enum conversion in display_mode_vba

2022-09-22 Thread Zeng Heng
I just correct the subject line and resend the patch mail. Please refer to: [PATCH resend v2] drm/amdgpu: fix enum conversion in display_mode_vba On 2022/9/19 15:44, Christian König wrote: Am 19.09.22 um 03:41 schrieb Zeng Heng: Fix below compile warning when open enum-conversion option

Re: [REGRESSION] Graphical issues on Lenovo Yoga 7 14ARB7 laptop since v6.0-rc1 (bisected)

2022-09-22 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker. Top-posting for once, to make this easily accessible to everyone. @amdgpu developers, what up here? August afaics didn't even get a single reply for his report that even identifies the change that's causing the problem. We're already late in the

[PATCH resend v2] drm/amdgpu: fix enum conversion in display_mode_vba

2022-09-22 Thread Zeng Heng
Fix below compile warning when open enum-conversion option check (compiled with -Wenum-conversion): drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c: In function ‘dml20_ModeSupportAndSystemConfigurationFull’:

Re: [PATCH AUTOSEL 5.4 3/5] drm/amdgpu: use dirty framebuffer helper

2022-09-22 Thread Michel Dänzer
On 2022-09-21 17:54, Sasha Levin wrote: > From: Hamza Mahfooz > > [ Upstream commit 66f99628eb24409cb8feb5061f78283c8b65f820 ] > > Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use > drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs > struct. > >

RE: [PATCH] drm/amd/amdgpu: solve the issue of allocate continuous pages under xen dom0

2022-09-22 Thread Xiao, Shane
[AMD Official Use Only - General] Hi Christian, So the real question is why are you trying to use userptr with XEN dom0? [Shane] Kfd test KFDMemoryTest.MMBench use userptr. And the test fails on Xen dom0 and succeeds on baremetal. We can also use GTT to allocate coherent buffers by setting

Re: [PATCH] drm/amd/amdgpu: solve the issue of allocate continuous pages under xen dom0

2022-09-22 Thread Christian König
Well this patch is a pretty clear NAK. Using xen_swiotlb with userptr in the first place sounds illegal to me since we need coherent buffers which are incompatible with swiotlb. In other words using userptrs in our driver stack are fundamentally incompatible with swiotlb, so it doesn't make

RE: [PATCH] drm/amd/amdgpu: solve the issue of allocate continuous pages under xen dom0

2022-09-22 Thread Xiao, Shane
[AMD Official Use Only - General] Hi Christian, Why should the resulting sg table be too large? [Shane] sg_alloc_table_from_pages will set max_segment field as default value UINT_MAX to sg_alloc_table_from_pages_segment. The filed max_segment works as follows: “Contiguous ranges of the pages

Re: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Li Zhong
On Wed, Sep 21, 2022 at 7:11 PM Chen, Guchun wrote: > > Perhaps you need to update the prefix of patch subject to 'drm/amd/pm: check > return value ...'. > > With above addressed, it's: Acked-by: Guchun Chen > > Regards, > Guchun > > -Original Message- > From: Li Zhong > Sent:

[PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Li Zhong
amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error. Signed-off-by: Li Zhong --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Li Zhong
amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error. Signed-off-by: Li Zhong --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amd/amdgpu: solve the issue of allocate continuous pages under xen dom0

2022-09-22 Thread Christian König
Am 22.09.22 um 09:11 schrieb Shane Xiao: [Why] sg_alloc_table_from_pages alloc too large continuous PFN pages under xen dom0. Well that sentence doesn't make much sense. Why should the resulting sg table be to large? For what to large? Regards, Christian. However, xen should check

RE: [PATCH] drm/amd/amdgpu: solve the issue of allocate continuous pages under xen dom0

2022-09-22 Thread Liu, Aaron
[AMD Official Use Only - General] Reviewed-by: Aaron Liu -- Best Regards Aaron Liu > -Original Message- > From: amd-gfx On Behalf Of > Shane Xiao > Sent: Thursday, September 22, 2022 3:12 PM > To: amd-gfx@lists.freedesktop.org > Cc: Xiao, Shane > Subject: [PATCH] drm/amd/amdgpu:

[PATCH] drm/amd/amdgpu: solve the issue of allocate continuous pages under xen dom0

2022-09-22 Thread Shane Xiao
[Why] sg_alloc_table_from_pages alloc too large continuous PFN pages under xen dom0. However, xen should check continuous MFN pages in range_straddles_page_boundary. When range_straddles_page_boundary return false, some cases fall back into swiotlb process and the continuous allocable page is not

Re: [PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Christian König
Am 22.09.22 um 06:17 schrieb Li Zhong: amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error. Signed-off-by: Li Zhong We usually use "r" as return and error variables, but that's just a nit. Reviewed-by: Christian König ---