[linux-next:master] BUILD REGRESSION 4d80748d16c82a9c2c4ea5feea96e476de3cd876

2022-10-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 4d80748d16c82a9c2c4ea5feea96e476de3cd876 Add linux-next specific files for 20221004 Error/Warning reports: https://lore.kernel.org/linux-mm/202209150141.wgbakqmx-...@intel.com https

[RFC PATCH 5/5] drm/amd/display: Fill 3D LUT from userspace

2022-10-04 Thread Alex Hung
Implement the 3D LUT interface, convert and pass the data for amdgpu driver. Note: A patchset "IGT tests for pre-blending 3D LUT interfaces" for this proposal is sent to IGT mailing list. Signed-off-by: Alex Hung --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 ++

[RFC PATCH 4/5] drm/amd/display: Enable plane 3DLUT mode

2022-10-04 Thread Alex Hung
Enable the 3D LUT mode supported by amdgpu. Note: A patchset "IGT tests for pre-blending 3D LUT interfaces" for this proposal is sent to IGT mailing list. Signed-off-by: Alex Hung --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++ drivers/gpu/drm/drm_color_mgmt.c | 31

[RFC PATCH 3/5] drm/amd/display: Define 3D LUT struct for HDR planes

2022-10-04 Thread Alex Hung
Add a 3D LUT mode supported by amdgpu driver. Note: A patchset "IGT tests for pre-blending 3D LUT interfaces" for this proposal is sent to IGT mailing list. Signed-off-by: Alex Hung --- .../gpu/drm/amd/display/modules/color/color_gamma.h | 12 1 file changed, 12 insertions(+)

[RFC PATCH 2/5] drm: Add Plane 3DLUT and 3DLUT mode properties

2022-10-04 Thread Alex Hung
Add plane lut_3d mode and lut_3d as blob properties. lut_3d mode is an enum property with values as blob_ids. Userspace can get supported modes and also set one of the modes. Note: A patchset "IGT tests for pre-blending 3D LUT interfaces" for this proposal is sent to IGT mailing list.

[RFC PATCH 1/5] drm: Add 3D LUT mode and its attributes

2022-10-04 Thread Alex Hung
A struct is defined for 3D LUT modes to be supported by hardware. The elements includes lut_isze, lut_stride, bit_depth, color_format and flags. Note: A patchset "IGT tests for pre-blending 3D LUT interfaces" for this proposal is sent to IGT mailing list. Signed-off-by: Alex Hung ---

[RFC PATCH 0/5] Proposal for Pre-blending 3D LUT interfaces

2022-10-04 Thread Alex Hung
This is an proposal and a draft implementation to enable 3D LUT on drm_plane. This proposal defines a new interface for userspace applications to query hardware capabilities and to pass/enable 3D LUT functions via this DRM/KMS APIs. Overviews: ┌─┐┌─┐┌───┐┌──┐

Re: [PATCH] drm/amdgpu/dm/mst: Fix incorrect usage of drm_dp_add_payload_part2()

2022-10-04 Thread Rodrigo Siqueira Jordao
On 2022-10-04 16:24, Lyude Paul wrote: Yikes, it appears somehow I totally made a mistake here. We're currently checking to see if drm_dp_add_payload_part2() returns a non-zero value to indicate success. That's totally wrong though, as this function only returns a zero value on success - not

[PATCH] drm/amdgpu/dm/mst: Fix incorrect usage of drm_dp_add_payload_part2()

2022-10-04 Thread Lyude Paul
Yikes, it appears somehow I totally made a mistake here. We're currently checking to see if drm_dp_add_payload_part2() returns a non-zero value to indicate success. That's totally wrong though, as this function only returns a zero value on success - not the other way around. So, fix that.

Re: [PATCH 1/1] drm/amdgpu: Correct amdgpu_amdkfd_total_mem_size calculation

2022-10-04 Thread Felix Kuehling
I'd prefer a separate patch and code review for the fini-case, because that addresses a different (potential) problem. Thanks,   Felix On 2022-10-04 15:43, Philip Yang wrote: On 2022-10-04 15:16, Felix Kuehling wrote: On 2022-10-04 12:41, Philip Yang wrote: amdkfd_total_mem_size is the

Re: [PATCH 1/1] drm/amdgpu: Correct amdgpu_amdkfd_total_mem_size calculation

2022-10-04 Thread Philip Yang
On 2022-10-04 15:16, Felix Kuehling wrote: On 2022-10-04 12:41, Philip Yang wrote: amdkfd_total_mem_size is the size of total GPUs vram plus system memory to estimate page tables memory usage and leave enough VRAM room for page tables allocation. Calculate amdkfd_total_mem_size in

Re: [PATCH 1/1] drm/amdgpu: Correct amdgpu_amdkfd_total_mem_size calculation

2022-10-04 Thread Felix Kuehling
On 2022-10-04 12:41, Philip Yang wrote: amdkfd_total_mem_size is the size of total GPUs vram plus system memory to estimate page tables memory usage and leave enough VRAM room for page tables allocation. Calculate amdkfd_total_mem_size in amdgpu_amdkfd_device_probe is incorrect because

[PATCH 1/1] drm/amdgpu: Correct amdgpu_amdkfd_total_mem_size calculation

2022-10-04 Thread Philip Yang
amdkfd_total_mem_size is the size of total GPUs vram plus system memory to estimate page tables memory usage and leave enough VRAM room for page tables allocation. Calculate amdkfd_total_mem_size in amdgpu_amdkfd_device_probe is incorrect because adev->gmc.real_vram_size is still 0 called from

Re: [PATCH] Set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-10-04 Thread Christian König
Am 04.10.22 um 16:08 schrieb Danijel Slivka: CPU pagetable updates have issues with HDP flush as VF MMIO access protection is not allowing write during sriov runtime to mmBIF_BX_DEV0_EPF0_VF0_HDP_MEM_COHERENCY_FLUSH_CNTL The subject should have a drm/amdgpu prefix and in general Felix need to

Re: [PATCH] drm/amd/display: Remove unused struct i2c_id_config_access

2022-10-04 Thread Rodrigo Siqueira Jordao
On 2022-09-27 09:39, Yuan Can wrote: After commit 5a8132b9f606("drm/amd/display: remove dead dc vbios code"), no one use struct i2c_id_config_access, so remove it. Signed-off-by: Yuan Can --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 7 --- 1 file changed, 7 deletions(-)

Re: [PATCH -next] drm/amd/display: Removed unused variable 'sdp_stream_enable'

2022-10-04 Thread Rodrigo Siqueira Jordao
On 2022-09-30 02:38, Dong Chenchen wrote: Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c: In function 'dcn31_hpo_dp_stream_enc_update_dp_info_packets':

[PATCH] Set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-10-04 Thread Danijel Slivka
CPU pagetable updates have issues with HDP flush as VF MMIO access protection is not allowing write during sriov runtime to mmBIF_BX_DEV0_EPF0_VF0_HDP_MEM_COHERENCY_FLUSH_CNTL Signed-off-by: Danijel Slivka --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH 2/2] drm/amd/pm: smu7_hwmgr: fix potential off-by-one overflow in 'performance_levels'

2022-10-04 Thread Alexey Kodanev
Since 'hardwareActivityPerformanceLevels' is set to the size of the 'performance_levels' array in smu7_hwmgr_backend_init(), using the '<=' assertion to check for the next index value is incorrect. Replace it with '<'. Detected using the static analysis tool - Svace. Fixes: 599a7e9fe1b6

[PATCH 1/2] drm/amd/pm: vega10_hwmgr: fix potential off-by-one overflow in 'performance_levels'

2022-10-04 Thread Alexey Kodanev
Since 'hardwareActivityPerformanceLevels' is set to the size of the 'performance_levels' array in vega10_hwmgr_backend_init(), using the '<=' assertion to check for the next index value is incorrect. Replace it with '<'. Detected using the static analysis tool - Svace. Fixes: f83a9991648b

[Bug report] Possible wrong condition

2022-10-04 Thread Muhammad Usama Anjum
Hello, It seems there is some dead or not-needed code. Either the if condition isn't needed or condition is wrong. As this greater-than-or-equal-to-zero comparison of an unsigned value is always true. "version_minor >= 0". Please have a look at it. diff --git

Re: [PATCH 1/1] drm/amdgpu: Set vmbo destroy after pt bo is created

2022-10-04 Thread Christian König
Am 03.10.22 um 19:20 schrieb Philip Yang: Under VRAM usage pression, map to GPU may fail to create pt bo and vmbo->shadow_list is not initialized, then ttm_bo_release calling amdgpu_bo_vm_destroy to access vmbo->shadow_list generates below dmesg and NULL pointer access backtrace: Set vmbo