This can address some reset failures observed on SMU13.0.0.
Signed-off-by: Evan Quan
Reviewed-by: Hawking Zhang
Change-Id: Ieb4e204c49abd405b1dce559c2ff75bb3887b6f9
--
v1->v2:
- revise the code comments(Alex)
- limit this to SMU13.0.0 and 13.0.7
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c |
Fulfill the functionality for cstate control.
Signed-off-by: Evan Quan
Reviewed-by: Hawking Zhang
Change-Id: I3e7ec7d0434d3b34855a9267ab1989a3b85d5206
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/amd/p
Fulfill the functionality for cstate control.
Signed-off-by: Evan Quan
Reviewed-by: Hawking Zhang
Change-Id: I2b7253898503b8051bbf90f429b46221410146b0
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm
Am 11.10.22 um 22:56 schrieb Alex Deucher:
From: Hawking Zhang
more ip instances are available
Signed-off-by: Hawking Zhang
Signed-off-by: Alex Deucher
Acked-by: Christian König for the entire series.
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
1 file changed, 1 insertion(+), 1 d
[AMD Official Use Only - General]
Series is
Reviewed-by: Tim Huang
Best Regards,
Tim Huang
-Original Message-
From: amd-gfx On Behalf Of Yifan Zhang
Sent: Sunday, October 9, 2022 2:40 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Huang, Tim
; Du, Xiaojian ; Zhang, Y
[Public]
This patch is
Reviewed-by: Yifan Zhang
From: Zhang, Jesse(Jie)
Sent: Tuesday, October 11, 2022 1:23 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhang, Yifan
; Kuehling, Felix
Subject: RE: [PATCH] drm/amdkfd: correct the cache info for gfx1036
[AMD Official Use On
[AMD Official Use Only - General]
Hi Bokun
Can you elaborate more on this reenabling SDMA engine during suspend ?
Why VF need the SDMA engine alive there ?
> -
> + /*
> +* Under SRIOV, the VF cannot single-mindedly stop SDMA engine
> +* However, we still need to clean up th
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, October 12, 2022 04:56
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 3/4] drm/amdgpu: convert vega20_ih.c to IP version checks
For consiste
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, October 12, 2022 04:56
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 4/4] drm/amdgpu: convert amdgpu_amdkfd_gpuvm.c to IP version
checks
F
On 2022-10-11 14:11, Rodrigo Siqueira wrote:
> Change commit sequence might impact multiple ASICs; for this reason, it
> is better to run it only on DCN32x for the first set of validation.
> After we get more confident about this change, we should expand it to
> all ASICs.
>
> Cc: Nicholas Kazlaus
On 2022-10-11 14:11, Rodrigo Siqueira wrote:
> From: Aurabindo Pillai
>
> [Why&How]
> With the new commit sequence, we do not want the state to be copied before
> the call to dc_commit_state() since this leaks the phantom streams into
> new state.
>
What are phantom streams? Why are they nee
From: Hawking Zhang
To allow invoking ip specific callbacks
Signed-off-by: Hawking Zhang
Reviewed-by: Le Ma
Signed-off-by: Alex Deucher
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 4 +--
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 28 +--
2 files changed, 16 inse
For consistency with the rest of the code.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpu
For consistency with newer asics.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vega20_ih.c
b/drivers/gpu/drm/amd/amdgpu/vega20_ih.c
index 59dfca093155..1706081d054d 100
From: Hawking Zhang
To match with the definition in psp firmware
Signed-off-by: Hawking Zhang
Reviewed-by: Le Ma
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h
b/drivers/
From: Hawking Zhang
more ip instances are available
Signed-off-by: Hawking Zhang
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
i
[Public]
Hi all,
I tested these patches as well, they were added to the most recent patchset.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
-
On 2022-10-11 14:11, Rodrigo Siqueira wrote:
> Since DCN32, our DC commit become more complex and requires more
> adjustments to work well with some features. This is a preparation work
> for replacing dc_commit_state and dc_commit_updates_for_stream with
> dc_update_planes_and_stream and dc_upda
From: Aurabindo Pillai
[Why&How]
With the new commit sequence, we do not want the state to be copied before
the call to dc_commit_state() since this leaks the phantom streams into
new state.
Fix this by doing the dc state copy right after the dc_commit_state()
call.
Cc: Nicholas Kazlauskas
Cc:
Since DCN32, our DC commit become more complex and requires more
adjustments to work well with some features. This is a preparation work
for replacing dc_commit_state and dc_commit_updates_for_stream with
dc_update_planes_and_stream and dc_update_planes_and_stream
respectively.
Cc: Nicholas Kazlau
Change commit sequence might impact multiple ASICs; for this reason, it
is better to run it only on DCN32x for the first set of validation.
After we get more confident about this change, we should expand it to
all ASICs.
Cc: Nicholas Kazlauskas
Cc: Harry Wentland
Signed-off-by: Rodrigo Siqueira
This patchset introduces the basic infrastructure to change our display
commit sequence to make it more robust and flexible for handling some
display features. Current, amdgpu_dm tries to commit a validation state
directly into update_planes and commit_streams. However, we want to
avoid committing
On Tue, Oct 11, 2022 at 1:32 PM Rodrigo Siqueira
wrote:
>
> From: Aurabindo Pillai
>
> Add the hubp surface flip handler. This fixes some flip timeout issues.
>
> Reviewed-by: Rodrigo Siqueira
> Signed-off-by: Aurabindo Pillai
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/display/dc/dc
On 9/28/22 22:15, Dmitry Osipenko wrote:
> Hello,
>
> This series moves all drivers to a dynamic dma-buf locking specification.
> From now on all dma-buf importers are made responsible for holding
> dma-buf's reservation lock around all operations performed over dma-bufs
> in accordance to the loc
From: Aurabindo Pillai
Add the hubp surface flip handler. This fixes some flip timeout issues.
Reviewed-by: Rodrigo Siqueira
Signed-off-by: Aurabindo Pillai
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc
[Public]
Hi all,
This week this patchset was tested on the following systems:
HP Envy 360, with Ryzen 5 4500U
Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U
Sapphire Pulse RX5700XT
Reference AMD RX6800
Engineering board with Ryzen 9 5900H
These systems were tested on the following displ
Applied. Thanks!
Alex
On Tue, Oct 11, 2022 at 11:27 AM Harry Wentland wrote:
>
> On 2022-10-10 03:38, Yang Li wrote:
> > The result of 'pwr_status == 0' is Boolean, and the question mark
> > expression is redundant.
> >
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2354
> > Reported-
On 2022-10-10 03:38, Yang Li wrote:
> The result of 'pwr_status == 0' is Boolean, and the question mark
> expression is redundant.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2354
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
Reviewed-by: Harry Wentland
Harry
> ---
> driv
On 2022-10-10 10:41, Alex Deucher wrote:
> It's not used outside of virtual_link_hwss.c. Fixes
> a -Wmissing-prototypes warning.
>
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.c | 2 +-
> 1 file changed, 1 i
On 2022-09-19 12:43, Alex Deucher wrote:
> The default argument should be enum TRANSFER_FUNCTION_SRGB rather than
> the current boolean value which improperly maps to
> TRANSFER_FUNCTION_BT709.
>
> Commit 9b3d76527f6e ("drm/amd/display: Revert adding degamma coefficients")
> looks to have improper
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: b9f85101cad3397ef1e509909602a90e257ab9d8 Add linux-next specific
files for 20221011
Error/Warning reports:
https://lore.kernel.org/linux-doc/202209201326.sy9kholm-...@intel.com
https
On 2022-10-10 17:36, Alex Deucher wrote:
> It's MIT.
>
> Fixes: b73353f7f3d434 ("drm/amd/display: Use the same cursor info across
> features")
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/inc/hw/cursor_reg_cache.h | 1 +
> 1 file cha
On 2022-10-06 11:32, Alex Deucher wrote:
> Fixes a warning in dc.c.
>
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/d
Ping?
On Thu, Oct 6, 2022 at 11:32 AM Alex Deucher wrote:
>
> Fixes a warning in dc.c.
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c
> b/dr
On 2022-10-11 09:41, Alex Deucher wrote:
> It's not used outside of dcn32_fpu.c.
>
> Reported-by: kernel test robot
> Fixes: 20dad3813b3c15 ("drm/amd/display: Add a helper to map
> ODM/MPC/Multi-Plane resources")
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drive
On Tue, Oct 11, 2022 at 10:12 AM Jani Nikula wrote:
>
> On Tue, 11 Oct 2022, Harry Wentland wrote:
> > On 2022-10-11 09:49, Jani Nikula wrote:
> >> The connector->override_edid flag is strictly for EDID override debugfs
> >> management, and drivers have no business using it.
> >>
> >> Cc: Alex De
On Tue, 11 Oct 2022, Harry Wentland wrote:
> On 2022-10-11 09:49, Jani Nikula wrote:
>> The connector->override_edid flag is strictly for EDID override debugfs
>> management, and drivers have no business using it.
>>
>> Cc: Alex Deucher
>> Cc: Christian König
>> Cc: Xinhui Pan
>> Cc: amd-gfx@l
On 2022-10-11 09:49, Jani Nikula wrote:
> The connector->override_edid flag is strictly for EDID override debugfs
> management, and drivers have no business using it.
>
> Cc: Alex Deucher
> Cc: Christian König
> Cc: Xinhui Pan
> Cc: amd-gfx@lists.freedesktop.org
> Signed-off-by: Jani Nikula
The connector->override_edid flag is strictly for EDID override debugfs
management, and drivers have no business using it.
Cc: Alex Deucher
Cc: Christian König
Cc: Xinhui Pan
Cc: amd-gfx@lists.freedesktop.org
Signed-off-by: Jani Nikula
---
I really have no idea what the functional impact her
Applied. Thanks.
Alex
On Tue, Oct 11, 2022 at 8:41 AM Yang Yingliang wrote:
>
> dcn20_build_mapped_resource() and dcn20_acquire_dsc() is not defined,
> if CONFIG_DRM_AMD_DC_DCN is disabled.
>
> Fix the following build error on arm64:
>
> ERROR: modpost: "dcn20_build_mapped_resource"
> [drive
It's not used outside of dcn32_fpu.c.
Reported-by: kernel test robot
Fixes: 20dad3813b3c15 ("drm/amd/display: Add a helper to map
ODM/MPC/Multi-Plane resources")
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
[Public]
Acked-by: Alex Deucher
From: Zhang, Jesse(Jie)
Sent: Tuesday, October 11, 2022 1:23 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhang, Yifan
; Kuehling, Felix
Subject: RE: [PATCH] drm/amdkfd: correct the cache info for gfx1036
[AMD
dcn20_build_mapped_resource() and dcn20_acquire_dsc() is not defined,
if CONFIG_DRM_AMD_DC_DCN is disabled.
Fix the following build error on arm64:
ERROR: modpost: "dcn20_build_mapped_resource"
[drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: modpost: "dcn20_acquire_dsc" [drivers/gpu
[removed a lot of people from the list of recipients, as this is mainly
for Guenter]
Hi Guenter!
On 06.10.22 19:23, Guenter Roeck wrote:
> On Wed, Oct 05, 2022 at 11:46:15PM -0700, Guenter Roeck wrote:
>> On Tue, Sep 27, 2022 at 03:12:00PM -0400, Hamza Mahfooz wrote:
>>> Address the following err
Yeah, that's a known issue. Dave already reverted the problematic patch
in drm-next.
But it will probably take a while until the revert propagates down into
the drm-misc-next or whatever you uses.
Regards,
Christian.
Am 11.10.22 um 14:02 schrieb Mikhail Gavrilov:
Hi!
The hungs occurs random
Hi!
The hungs occurs randomly, but I found good reproductive scenario
(This is running the campaign in the game Halo Infinite)
The backtrace is look like this:
[ 147.260971] BUG: kernel NULL pointer dereference, address: 0088
[ 147.260987] [ cut here ]
[ 147.
46 matches
Mail list logo
