[Public]
Reviewed-by: Tim Huang
Best Regards,
Tim Huang
-Original Message-
From: amd-gfx On Behalf Of Yifan Zhang
Sent: Monday, October 24, 2022 12:51 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhang, Yifan
; Wentland, Harry ; Koenig,
Christian ; Chen, Guchun
On 2022-10-24 08:19, Yang Yingliang wrote:
> Inject fault while loading module, kset_register() may fail.
> If it fails, the name allocated by kobject_set_name() which
> is called before kset_register() is leaked, because refcount
> of kobject is hold in kset_init().
>
> As a kset may be embedded
[Public]
-Original Message-
From: Quan, Evan
Sent: Monday, October 24, 2022 2:31 PM
To: Liang, Prike ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Liang, Prike
Subject: RE: [PATCH v2] drm/amdgpu: disallow gfxoff until GC IP blocks complete
s2idle resume
[AMD Official Use
On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote:
> drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable
> dereferenced before check 'state' (see line 583)
Hi Russell, I think the warning is semi-legit. Your commit f392a1846489
("net: phylink: provide
On 2022-10-24 17:06, Luben Tuikov wrote:
> On 2022-10-24 08:19, Yang Yingliang wrote:
>> Inject fault while loading module, kset_register() may fail.
>> If it fails, the name allocated by kobject_set_name() which
>> is called before kset_register() is leaked, because refcount
>> of kobject is hold
On 2022-10-24 08:19, Yang Yingliang wrote:
> Inject fault while loading module, kset_register() may fail.
> If it fails, the name allocated by kobject_set_name() which
> is called before kset_register() is leaked, because refcount
> of kobject is hold in kset_init().
"is hold" --> "was set".
On 2022-10-24 07:26, Ma Jun wrote:
For some GPUs with more CUs, the original sibling_map[32]
in struct crat_subtype_cache is not enough
to save the cache information when create the VCRAT table,
so fill the cache info into struct kfd_cache_properties_ext
directly to fix the problem.
At the
On 2022-10-24 07:26, Ma Jun wrote:
Init and save the base cu processor id for later use
Signed-off-by: Ma Jun
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 24 +
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 28 +
The change of the commit f5c7e7797060 ("Adjust removal control
flow for smu v13_0_2") brought a bug on SRIOV envrionment. It
caused unloading amdgpu failed on Guest VM. The reason is that
the VF FLR was requested while unloading amdgpu driver, but the
VF FLR of SRIOV sequence is wrong
On Mon, Oct 24, 2022 at 4:03 PM Gavin Wan wrote:
>
> Fixes: f5c7e7797060 ("drm/amdgpu: Adjust removal control flow
> for smu v13_0_2")
>
> The change of the commit f5c7e7797060 ("Adjust removal control
> flow for smu v13_0_2") brought a bug on SRIOV envrionment. It
> caused
Fixes: f5c7e7797060 ("drm/amdgpu: Adjust removal control flow
for smu v13_0_2")
The change of the commit f5c7e7797060 ("Adjust removal control
flow for smu v13_0_2") brought a bug on SRIOV envrionment. It
caused unloading amdgpu failed on Guest VM. The reason is that
the VF FLR
On Mon, Oct 24, 2022 at 3:45 PM Gavin Wan wrote:
>
> The change "Adjust removal control flow for smu v13_0_2"
commit f5c7e7797060 ("drm/amdgpu: Adjust removal control flow for smu v13_0_2")
> brought a bug on SRIOV envrionment. It caused unloading
> amdgpu failed on Guest VM. The reason
The change "Adjust removal control flow for smu v13_0_2"
brought a bug on SRIOV envrionment. It caused unloading
amdgpu failed on Guest VM. The reason is that the VF FLR was
requested while unloading amdgpu driver, but VF FLR of SRIOV
sequence is wrong while removing PCI device.
This reverts commit 55eea8ef98641f6e1e1c202bd3a49a57c1dd4059.
This quirk is now handled in the DRM core, so we can drop all of
the internal code that was added to handle it.
Signed-off-by: Hamza Mahfooz
---
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 35 ---
1 file changed,
Since, the quirk is handled in the DRM core now, we can use that value
instead of the internal value.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++
.../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 11 +--
2 files changed, 11
The LG 27GP950 and LG 27GN950 have visible display corruption when
trying to use 10bpc modes. So, to fix this, cap their maximum DSC
target bitrate to 15bpp.
Suggested-by: Roman Li
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/drm_edid.c | 12
include/drm/drm_connector.h | 6
Applied. Thanks!
Alex
On Mon, Oct 24, 2022 at 9:17 AM Joaquín Ignacio Aramendía
wrote:
>
> This file was split in commit 5d945cbcd4b16a29d6470a80dfb19738f9a4319f
> ("drm/amd/display: Create a file dedicated to planes") and the logic in
> dm_plane_format_mod_supported() function got changed by
build htmldocs produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:1275: warning: cannot understand function
prototype: 'struct dc_validation_set '
The word "struct" was left out of the comment.
Fixes: f4a59996c408 ("drm/amd/display: Include surface of unaffected streams")
Reported-by:
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 76cf65d1377f733af1e2a55233e3353ffa577f54 Add linux-next specific
files for 20221024
Warning reports:
https://lore.kernel.org/linux-mm/202210090954.ptr6m6rj-...@intel.com
https
On Mon, Oct 24, 2022 at 3:33 AM Thomas Zimmermann wrote:
>
> Hi
>
> Am 24.10.22 um 08:20 schrieb Quan, Evan:
> > [AMD Official Use Only - General]
> >
> > Reviewed-by: Evan Quan
> >
> >> -Original Message-
> >> From: amd-gfx On Behalf Of Alex
> >> Deucher
> >> Sent: Thursday, October
Applied. Thanks!
Alex
On Mon, Oct 24, 2022 at 11:20 AM Nathan Chancellor wrote:
>
> Clang warns:
>
> drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c:686:3: error: variable 'data' is
> uninitialized when used here [-Werror,-Wuninitialized]
> data |= MM_ATC_L2_MISC_CG__ENABLE_MASK;
Clang warns:
drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c:686:3: error: variable 'data' is
uninitialized when used here [-Werror,-Wuninitialized]
data |= MM_ATC_L2_MISC_CG__ENABLE_MASK;
^~~~
drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c:674:10: note: initialize the
Applied. Thanks!
Alex
On Sat, Oct 22, 2022 at 2:06 AM wangjianli wrote:
>
> Delete the redundant word 'the'.
>
> Signed-off-by: wangjianli
> ---
> drivers/gpu/drm/radeon/radeon_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Sat, Oct 22, 2022 at 2:02 AM wangjianli wrote:
>
> Delete the redundant word 'the'.
>
> Signed-off-by: wangjianli
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On 2022/10/24 22:53, Greg KH wrote:
On Mon, Oct 24, 2022 at 10:39:44PM +0800, Yang Yingliang wrote:
On 2022/10/24 21:52, Greg KH wrote:
On Mon, Oct 24, 2022 at 08:19:10PM +0800, Yang Yingliang wrote:
Inject fault while loading module, kset_register() may fail.
If it fails, the name
On Mon, Oct 24, 2022 at 10:39:44PM +0800, Yang Yingliang wrote:
>
> On 2022/10/24 21:52, Greg KH wrote:
> > On Mon, Oct 24, 2022 at 08:19:10PM +0800, Yang Yingliang wrote:
> > > Inject fault while loading module, kset_register() may fail.
> > > If it fails, the name allocated by
On 2022/10/24 21:52, Greg KH wrote:
On Mon, Oct 24, 2022 at 08:19:10PM +0800, Yang Yingliang wrote:
Inject fault while loading module, kset_register() may fail.
If it fails, the name allocated by kobject_set_name() which
is called before kset_register() is leaked, because refcount
of kobject
On Mon, Oct 24, 2022 at 08:19:10PM +0800, Yang Yingliang wrote:
> Inject fault while loading module, kset_register() may fail.
> If it fails, the name allocated by kobject_set_name() which
> is called before kset_register() is leaked, because refcount
> of kobject is hold in kset_init().
>
> As a
Inject fault while loading module, kset_register() may fail.
If it fails, the name allocated by kobject_set_name() which
is called before kset_register() is leaked, because refcount
of kobject is hold in kset_init().
As a kset may be embedded in a larger structure which needs
be freed in
This file was split in commit 5d945cbcd4b16a29d6470a80dfb19738f9a4319f
("drm/amd/display: Create a file dedicated to planes") and the logic in
dm_plane_format_mod_supported() function got changed by a switch logic.
That change broke drm_plane modifiers setting on series 5000 APUs
(tested on OXP
On Sun, Oct 23, 2022 at 10:23:53AM -0700, Linus Torvalds wrote:
> This was sent to me, but should have gone to other people.
>
> It may already be fixed, but note how the report is about -stable
> kernels, including apparently the current 5.10 stable version (149(.
>
> Linus
>
>
The connector->override_edid flag is strictly for EDID override debugfs
management, and drivers have no business using it.
Cc: Alex Deucher
Cc: Christian König
Cc: Xinhui Pan
Cc: amd-gfx@lists.freedesktop.org
Signed-off-by: Jani Nikula
Reviewed-by: Harry Wentland
Acked-by: Alex Deucher
---
[Public]
-Original Message-
From: Kuehling, Felix
Sent: Saturday, October 22, 2022 4:53 AM
To: Liang, Prike ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhang, Yifan
; Huang, Ray ; Liu, Aaron
Subject: Re: [PATCH 1/2] drm/amdkfd: introduce dummy cache info for property
For some GPUs with more CUs, the original sibling_map[32]
in struct crat_subtype_cache is not enough
to save the cache information when create the VCRAT table,
so fill the cache info into struct kfd_cache_properties_ext
directly to fix the problem.
At the same time, a new directory
Init and save the base cu processor id for later use
Signed-off-by: Ma Jun
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 24 +
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 28 +
drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 3 +++
3 files changed, 32
Initialize the generic fbdev emulation even if it has been disabled
on the kernel command line. The hotplug and mode initialization will
fail accordingly.
The kernel parameter can still be changed at runtime and the emulation
will initialize after hotplugging the connector.
Signed-off-by: Thomas
Move the generic fbdev implementation into its own source and header
file. Adapt drivers. No functonal changes, but some of the internal
helpers have been renamed to fit into the drm_fbdev_ naming scheme.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/Makefile | 2
Implement the fbdev's read/write helpers with the same functions. Use
the generic fbdev's code as template. Convert all drivers.
DRM's fb helpers must implement regular I/O functionality in struct
fb_ops and possibly perform a damage update. Handle all this in the
same functions and convert
Include for of_match_ptr().
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/tve200/tve200_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/tve200/tve200_drv.c
b/drivers/gpu/drm/tve200/tve200_drv.c
index 04db72e3fa9c2..611785e097576 100644
---
Don't set struct drm_driver.output_poll_changed. It's used to restore
the fbdev console. But as rockchip uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See the
functions drm_kms_helper_hotplug_event() and
drm_kms_helper_connector_hotplug_event() in
Include for devm_of_find_backlight().
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index
Pull the test for fb_dirty into the caller to avoid extra work
if no callback has been set. In this case no damage handling is
required and no damage area needs to be computed. Print a warning
if the damage worker runs without getting an fb_dirty callback.
Signed-off-by: Thomas Zimmermann
---
Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as
part of unifying the naming within fbdev helpers. Adapt drivers. No
functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/armada/armada_fbdev.c | 2 +-
drivers/gpu/drm/drm_fb_helper.c| 8
Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info()
as part of unifying the naming within fbdev helpers. Adapt drivers. No
functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/armada/armada_fbdev.c | 2 +-
drivers/gpu/drm/drm_fb_helper.c
Remove include statements for where it is not
required (i.e., most of them). In a few places include other header
files that are required by the source code.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
Only include what we have to.
Signed-off-by: Thomas Zimmermann
---
include/drm/drm_fb_helper.h | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index fddd0d1af6891..e923089522896 100644
---
The fbdev helpers implement a damage worker that forwards fbdev
updates to the DRM driver. The worker's update logic depends on
the generic fbdev emulation. Separate the two via function pointer.
The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty,
a new callback that hides the
Don't set struct drm_driver.output_poll_changed. It's used to restore
the fbdev console. But as ingenic uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See the
functions drm_kms_helper_hotplug_event() and
drm_kms_helper_connector_hotplug_event() in
Don't set struct drm_driver.output_poll_changed. It's used to restore
the fbdev console. But as DCSS uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See the
functions drm_kms_helper_hotplug_event() and
drm_kms_helper_connector_hotplug_event() in
Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the
behavior of fbdev. Fbdev implementations of fb_read and fb_write in
struct fb_ops invoke fb_sync to synchronize with outstanding operations
before I/O. Doing the same in DRM implementations will allow us to use
them throughout DRM
Don't set struct drm_driver.output_poll_changed. It's used to restore
the fbdev console. But as logicvc uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See the
functions drm_kms_helper_hotplug_event() and
drm_kms_helper_connector_hotplug_event() in
Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as vboxvideo uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().
Signed-off-by: Thomas Zimmermann
---
Don't set struct drm_driver.output_poll_changed. It's used to restore
the fbdev console. But as amdgpu uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See the
functions drm_kms_helper_hotplug_event() and
drm_kms_helper_connector_hotplug_event() in
Rename struct drm_fb_helper.fbdev to info. The current name is
misleading as it overlaps with generic fbdev naming conventions.
Adapt to the usual naming in fbdev drivers by calling the field
'info'. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_fb_helper.c
Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as mcde uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().
Signed-off-by: Thomas Zimmermann
---
Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as komeda uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().
Signed-off-by: Thomas Zimmermann
---
Separate generic fbdev emulation from the helper code that is shared
among the various fbdev implementations within DRM. Affects many drivers.
It has become apparent that our fully generic fbdev emulation will
never produce optimal results for all drivers. In its current form,
it is also hard to
Am 23.10.22 um 03:25 schrieb Luben Tuikov:
On 2022-10-14 04:46, Christian König wrote:
[SNIP]
@@ -254,12 +254,10 @@ static struct dma_fence *amdgpu_job_dependency(struct
drm_sched_job *sched_job,
DRM_ERROR("Error adding fence (%d)\n", r);
}
- while (fence ==
Am 21.10.22 um 18:34 schrieb Hamza Mahfooz:
Unfortunately, printk() doesn't currently support the printing of %f
entries. So, print statements that contain "%f" should be removed.
However, since DC is used on other OSes that can still benefit from the
additional debugging information, we should
On 10/17/22 19:22, Dmitry Osipenko wrote:
> Prepare V4L2 memory allocators to the common dynamic dma-buf locking
> convention by starting to use the unlocked versions of dma-buf API
> functions.
>
> Acked-by: Tomasz Figa
Acked-by: Hans Verkuil
Thanks!
Hans
> Acked-by: Christian
On 10/17/22 19:22, Dmitry Osipenko wrote:
> Prepare Tegra video decoder driver to the common dynamic dma-buf
> locking convention by starting to use the unlocked versions of dma-buf
> API functions.
>
> Acked-by: Christian König
Acked-by: Hans Verkuil
Thanks!
Hans
>
Hi
Am 24.10.22 um 08:20 schrieb Quan, Evan:
[AMD Official Use Only - General]
Reviewed-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Alex
Deucher
Sent: Thursday, October 20, 2022 10:36 PM
To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org
Cc: Deucher,
On 2022-10-17 02:27, Christian König wrote:
> Am 17.10.22 um 07:29 schrieb Luben Tuikov:
>> Hi Christian,
>>
>> On 2022-10-14 04:15, Christian König wrote:
>>> Make sure that we always have a CPU round trip to let the submission
>>> code correctly decide if a TLB flush is necessary or not.
>>>
>>>
On 2022-10-14 04:15, Christian König wrote:
> Setting this flag on a scheduler fence prevents pipelining of jobs
> depending on this fence. In other words we always insert a full CPU
> round trip before dependen jobs are pushed to the pipeline.
"dependent"
>
> Signed-off-by: Christian König
>
Hi I am new to kernel dev and am very passionate, even if this fix isn't
formatted correctly, could you please give me specific advice on how to do
so going forward?
Best,
Uros
On Sun, Oct 23, 2022 at 3:32 PM uroshm wrote:
>
> diff --git a/drivers/staging/rts5208/general.c
>
[Note: this mail is primarily send for documentation purposes and/or for
regzbot, my Linux kernel regression tracking bot. That's why I removed
most or all folks from the list of recipients, but left any that looked
like a mailing lists. These mails usually contain '#forregzbot' in the
subject, to
This file was split in commit 5d945cbcd4b16a29d6470a80dfb19738f9a4319f
("drm/amd/display: Create a file dedicated to planes") and the logic in
dm_plane_format_mod_supported() function got changed by a switch logic.
That change broke drm_plane modifiers setting on series 5000 APUs
(tested on OXP
This was sent to me, but should have gone to other people.
It may already be fixed, but note how the report is about -stable
kernels, including apparently the current 5.10 stable version (149(.
Linus
-- Forwarded message -
From: Kevin Torkelson
Date: Thu, Oct 20,
On 2022-10-14 04:46, Christian König wrote:
> Hi guys,
>
> rebased those patches on top of amd-staging-drm-next since the
> amdgpu changes are quite substencial.
>
> Please review and comment,
> Christian.
Hi Christian,
The changes are good and I think asynchronous is the way to go. I'm also
[AMD Official Use Only - General]
> -Original Message-
> From: amd-gfx On Behalf Of
> Prike Liang
> Sent: Friday, October 21, 2022 10:47 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Liang, Prike
>
> Subject: [PATCH v2] drm/amdgpu: disallow gfxoff until GC IP
[AMD Official Use Only - General]
Reviewed-by: Evan Quan
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Thursday, October 20, 2022 10:36 PM
> To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org
> Cc: Deucher, Alexander ; Thomas
> Zimmermann
>
71 matches
Mail list logo
