[PATCH v1] drm/ttm: Clean up page shift operation

2022-11-21 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. v1 -> v2: fix missing page shift to fpfn and lpfn Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- drivers/gpu/drm/ttm/ttm_range_manager.c| 13 ++--

Re: [PATCH] drm/amdgpu: add missing license to some files

2022-11-21 Thread Christian König
Am 21.11.22 um 18:20 schrieb Alex Deucher: The driver is MIT, so add the licenses. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2265 Signed-off-by: Alex Deucher Reviewed-by: Christian König --- .../gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_smu11_driver_if.h | 1 + .../gpu/drm/a

Re: [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start

2022-11-21 Thread Christian König
Am 22.11.22 um 00:42 schrieb Mikhail Gavrilov: On Mon, Nov 14, 2022 at 6:22 PM Christian König wrote: I've found and fixed a few problems around the userptr handling which might explain what you see here. A series of four patches starting with "drm/amdgpu: always register an MMU notifier for u

RE: [PATCH 2/2] drm/amdgpu: enable RAS poison for VCN 2.6

2022-11-21 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Wednesday, November 2, 2022 10:36 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Deucher, Alexander Cc: Zhou1, Tao ; Lazar, Lijo Subject: [PATCH 2/2] drm/amdgp

RE: [PATCH 2/2] drm/amdgpu: enable RAS poison for VCN 2.6

2022-11-21 Thread Zhou1, Tao
[AMD Official Use Only - General] Ping... > -Original Message- > From: Zhou1, Tao > Sent: Wednesday, November 2, 2022 10:36 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Deucher, Alexander > > Cc: Zhou1, Tao ; Lazar, Lijo > Subject: [PATCH 2/2] drm/amdgpu: enable RAS poiso

Re: [PATCH 2/2] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2022-11-21 Thread Arunpravin Paneer Selvam
On 11/22/2022 10:48 AM, Somalapuram, Amaranath wrote: On 11/16/2022 2:50 PM, Arunpravin Paneer Selvam wrote: Hi Amar, On 11/16/2022 2:20 PM, Somalapuram Amaranath wrote: ttm_resource allocate size in bytes i.e less than page size. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/dr

Re: [PATCH] drm/amdgpu: add drv_vram_usage_va for virt data exchange

2022-11-21 Thread Luben Tuikov
On 2022-11-22 00:52, Tong Liu01 wrote: > For vram_usagebyfirmware_v2_2, fw_vram_reserve is not used. So > fw_vram_usage_va is NULL, and cannot do virt data exchange > anymore. Should add drv_vram_usage_va to do virt data exchange > in vram_usagebyfirmware_v2_2 case. And refine some code style > che

[PATCH 19/19] drm/amdgpu: enable PSP IP v13.0.11 support

2022-11-21 Thread Yifan Zhang
From: Tim Huang Enable PSP FW loading for PSP IP v13.0.11 Signed-off-by: Tim Huang Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v13_0.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ps

[PATCH 18/19] drm/amdgpu: Enable pg/cg flags on GC11_0_4 for VCN

2022-11-21 Thread Yifan Zhang
From: Saleemkhan Jamadar This enable VCN PG, CG and JPEG PG, CG Signed-off-by: Saleemkhan Jamadar Reviewed-by: Leo Liu Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/soc21.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21

[PATCH 17/19] drm/amdgpu/discovery: enable nbio support for NBIO v7.7.1

2022-11-21 Thread Yifan Zhang
this patch is to enable nbio support for NBIO v7.7.1. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index ac0f0e09a60c

[PATCH 16/19] drm/amdgpu/pm: use the specific mailbox registers only for SMU IP v13.0.4

2022-11-21 Thread Yifan Zhang
From: Tim Huang The SMU IP v13.0.4 ppt interface is shared by IP v13.0.11, they use the different mailbox register offset. So use the specific mailbox registers offset for v13.0.4. Signed-off-by: Tim Huang Signed-off-by: Yifan Zhang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c| 17 +++

[PATCH 15/19] drm/amdgpu/soc21: add mode2 asic reset for SMU IP v13.0.11

2022-11-21 Thread Yifan Zhang
From: Tim Huang Set the default reset method to mode2 for SMU IP v13.0.11 Signed-off-by: Tim Huang Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/soc21.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c ind

[PATCH 14/19] drm/amdgpu/pm: add GFXOFF control IP version check for SMU IP v13.0.11

2022-11-21 Thread Yifan Zhang
Enable the SMU IP v13.0.11 GFXOFF control Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c index 6a9bdfda4e6f..f5e90e0

[PATCH 13/19] drm/amdgpu: add smu 13 support for smu 13.0.11

2022-11-21 Thread Yifan Zhang
this patch to add smu 13 support for smu 13.0.11. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gp

[PATCH 12/19] drm/amdgpu/pm: enable swsmu for SMU IP v13.0.11

2022-11-21 Thread Yifan Zhang
Add the entry to set the ppt functions for SMU IP v13.0.11. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c index 20e5f66f853f..61ea

[PATCH 10/19] drm/amdgpu: add gmc v11 support for GC 11.0.4

2022-11-21 Thread Yifan Zhang
Add gmc v11 support for GC 11.0.4. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c index 96e52ec0fb69..4326078689cd 100644 --- a/drivers/gpu/

[PATCH 11/19] drm/amdkfd: add GC 11.0.4 KFD support

2022-11-21 Thread Yifan Zhang
Add initial support for GC 11.0.4 in KFD compute driver. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkf

[PATCH 09/19] drm/amdgpu: add soc21 common ip block support for GC 11.0.4

2022-11-21 Thread Yifan Zhang
Add common soc21 ip block support for GC 11.0.4. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/soc21.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c index b258e9aa0558..69dac2aa8151 100644 --- a/driv

[PATCH 08/19] drm/amdgpu: add gfx support for GC 11.0.4

2022-11-21 Thread Yifan Zhang
this patch to add GC 11.0.4 gfx support to gfx11 implementation. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c in

[PATCH 07/19] drm/amdgpu/discovery: set the APU flag for GC 11.0.4

2022-11-21 Thread Yifan Zhang
Set the APU flag appropriately for GC 11.0.4. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index 524e2aa849c0..19dbd7

[PATCH 05/19] drm/amdgpu/discovery: add PSP IP v13.0.11 support

2022-11-21 Thread Yifan Zhang
From: Tim Huang Add PSP IP v13.0.11 ip discovery support. Signed-off-by: Tim Huang Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH] drm/amdgpu: add drv_vram_usage_va for virt data exchange

2022-11-21 Thread Tong Liu01
For vram_usagebyfirmware_v2_2, fw_vram_reserve is not used. So fw_vram_usage_va is NULL, and cannot do virt data exchange anymore. Should add drv_vram_usage_va to do virt data exchange in vram_usagebyfirmware_v2_2 case. And refine some code style checks in pre add vram reservation logic patch Sign

[PATCH 06/19] drm/amdgpu: set GC 11.0.4 family

2022-11-21 Thread Yifan Zhang
this patch is to set GC 11.0.4 family. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index 49ed3c826088..524e2aa849c0

[PATCH 03/19] drm/amdgpu/discovery: enable gfx v11 for GC 11.0.4

2022-11-21 Thread Yifan Zhang
Enable gfx v11 for GC 11.0.4. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index a047db7f8ed5..de8c2d81e09f 100644 --

[PATCH 02/19] drm/amdgpu/discovery: enable gmc v11 for GC 11.0.4

2022-11-21 Thread Yifan Zhang
Enable gmc (graphic memory controller) v11 for GC 11.0.4. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index b8db6184

[PATCH 04/19] drm/amdgpu/discovery: enable mes support for GC v11.0.4

2022-11-21 Thread Yifan Zhang
this patch is to enable mes for GC 11.0.4. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index de8c2d81e09f..45fe805b5

[PATCH 01/19] drm/amdgpu/discovery: enable soc21 common for GC 11.0.4

2022-11-21 Thread Yifan Zhang
Enable soc21 common for GC 11.0.4. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index 2509341df92d..b8db6184dcbd 1006

Re: [PATCH 3/5] drm/amdgpu: Modify unmap_queue format for gfx9 (v4)

2022-11-21 Thread Luben Tuikov
On 2022-10-18 05:08, jiadong@amd.com wrote: > From: "Jiadong.Zhu" > > 1. Modify the unmap_queue package on gfx9. Add trailing fence to track the >preemption done. > 2. Modify emit_ce_meta emit_de_meta functions for the resumed ibs. > > v2: Restyle code not to use ternary operator. > v3:

Re: [PATCH 1/5] drm/amdgpu: Introduce gfx software ring (v8)

2022-11-21 Thread Luben Tuikov
On 2022-10-18 05:08, jiadong@amd.com wrote: > From: "Jiadong.Zhu" > > The software ring is created to support priority context while there is only > one hardware queue for gfx. > > Every software ring has its fence driver and could be used as an ordinary ring > for the GPU scheduler. > Multi

Re: [PATCH 2/2] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2022-11-21 Thread Somalapuram, Amaranath
On 11/16/2022 2:50 PM, Arunpravin Paneer Selvam wrote: Hi Amar, On 11/16/2022 2:20 PM, Somalapuram Amaranath wrote: ttm_resource allocate size in bytes i.e less than page size. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/drm_gem.c | 2 +-   1 file changed, 1 insertion(+), 1 de

Re: [PATCH] drm/amdgpu: add missing license to some files

2022-11-21 Thread Luben Tuikov
Acked-by: Luben Tuikov Regards, Luben On 2022-11-21 12:20, Alex Deucher wrote: > The driver is MIT, so add the licenses. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2265 > Signed-off-by: Alex Deucher > --- > .../gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_smu11_driver_if.h | 1 + >

RE: [PATCH 1/2] drm/amdgpu: use rpm_mode as runtime pm check flag

2022-11-21 Thread Chen, Guchun
[AMD Official Use Only - General] Good point. Let me update it. Regards, Guchun From: Lazar, Lijo Sent: Monday, November 21, 2022 10:26 AM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Quan, Evan Cc: Chen, Guchun Subject: Re: [PATCH 1/2] drm/amdgpu:

Re: [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start

2022-11-21 Thread Mikhail Gavrilov
On Mon, Nov 14, 2022 at 6:22 PM Christian König wrote: > > I've found and fixed a few problems around the userptr handling which > might explain what you see here. > > A series of four patches starting with "drm/amdgpu: always register an > MMU notifier for userptr" is under review now. > > Going

Re: [PATCH] drm/amd/display: trigger timing sync only if TG is running

2022-11-21 Thread Rodrigo Siqueira Jordao
On 11/21/22 17:14, Aurabindo Pillai wrote: [Why&How] If the timing generator isnt running, it does not make sense to trigger a sync on the corresponding OTG. Check this condition before starting. Otherwise, this will cause error like: *ERROR* GSL: Timeout on reset trigger! Fixes: 8c7924bdb0f

[PATCH] drm/amd/display: trigger timing sync only if TG is running

2022-11-21 Thread Aurabindo Pillai
[Why&How] If the timing generator isnt running, it does not make sense to trigger a sync on the corresponding OTG. Check this condition before starting. Otherwise, this will cause error like: *ERROR* GSL: Timeout on reset trigger! Fixes: 8c7924bdb0fe ("drm/amd/display: Disable phantom OTG after e

[linux-next:master] BUILD REGRESSION e4cd8d3ff7f9efeb97330e5e9b99eeb2a68f5cf9

2022-11-21 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: e4cd8d3ff7f9efeb97330e5e9b99eeb2a68f5cf9 Add linux-next specific files for 20221121 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211130053.np70vidn-...@intel.com https

Re: [PATCH] drm/amdgpu: Partially revert "drm/amdgpu: update drm_display_info correctly when the edid is read"

2022-11-21 Thread Luben Tuikov
Acked-by: Luben Tuikov Regards, Luben On 2022-11-21 12:38, Alex Deucher wrote: > This partially reverts 20543be93ca45968f344261c1a997177e51bd7e1. > > Calling drm_connector_update_edid_property() in > amdgpu_connector_free_edid() causes a noticable pause in > the system every 10 seconds on polle

Re: [PATCH] [next] drm/amdgpu: Replace remaining 1-element array with flex-array

2022-11-21 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 21, 2022 at 2:26 AM Paulo Miguel Almeida wrote: > > One-element arrays are deprecated, and we are replacing them with > flexible array members instead. So, replace one-element array with > flexible-array member in struct GOP_VBIOS_CONTENT and refactor the > res

[PATCH] drm/amdgpu: Partially revert "drm/amdgpu: update drm_display_info correctly when the edid is read"

2022-11-21 Thread Alex Deucher
This partially reverts 20543be93ca45968f344261c1a997177e51bd7e1. Calling drm_connector_update_edid_property() in amdgpu_connector_free_edid() causes a noticable pause in the system every 10 seconds on polled outputs so revert this part of the change. Bug: https://gitlab.freedesktop.org/drm/amd/-/

Re: [PATCH] drm/amdgpu: fix unused-function error

2022-11-21 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 21, 2022 at 8:09 AM Ren Zhijie wrote: > > If CONFIG_DRM_AMDGPU=y and CONFIG_DRM_AMD_DC is not set, > gcc complained about unused-function : > > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1705:13: error: > ‘amdgpu_discovery_set_sriov_display’ defined but not

Re: [PATCH] Revert "drm/amd/display: fix dpms_off issue when disabling bios mode"

2022-11-21 Thread Luben Tuikov
Reviewed-by: Luben Tuikov Regards, Luben On 2022-11-21 12:26, Alex Deucher wrote: > Ping? > > On Thu, Nov 17, 2022 at 9:49 AM Alex Deucher > wrote: >> >> This reverts commit 5aa663752ff6f844c6bfc97d89231e98884ae769. >> >> This causes a blank screen on boot on an Asus G513QY / 6800M laptop. >>

Re: [PATCH] drm/amdgpu: Fix minmax warning

2022-11-21 Thread Alex Deucher
On Mon, Nov 21, 2022 at 12:23 PM Luben Tuikov wrote: > > Fix minmax warning by using min_t() macro and > explicitly specifying the assignment type. > > Signed-off-by: Luben Tuikov Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 9 ++--- > 1 file changed,

[PATCH] drm/amdgpu: Fix minmax warning

2022-11-21 Thread Luben Tuikov
Fix minmax warning by using min_t() macro and explicitly specifying the assignment type. Cc: Alex Deucher Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu1

Re: [PATCH] Revert "drm/amd/display: fix dpms_off issue when disabling bios mode"

2022-11-21 Thread Alex Deucher
Ping? On Thu, Nov 17, 2022 at 9:49 AM Alex Deucher wrote: > > This reverts commit 5aa663752ff6f844c6bfc97d89231e98884ae769. > > This causes a blank screen on boot on an Asus G513QY / 6800M laptop. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2259 > Cc: Aric Cyr > Cc: Tom Chung > Cc:

[PATCH] drm/amdgpu: Fix minmax warning

2022-11-21 Thread Luben Tuikov
Fix minmax warning by using min_t() macro and explicitly specifying the assignment type. Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/d

[PATCH] drm/amdgpu: add missing license to some files

2022-11-21 Thread Alex Deucher
The driver is MIT, so add the licenses. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2265 Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_smu11_driver_if.h | 1 + .../gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_smu13_driver_if.h | 1 + drivers/gpu/drm/amd/in

Re: [PATCH] drm/amdgpu: handle gang submit before VMID

2022-11-21 Thread Timur Kristóf
The patch did not make it into rc6 after all. Can you please make sure it goes into rc7? Thanks, Timur On Fri, 2022-11-18 at 17:53 +0100, Christian König wrote: > Pushed to drm-misc-fixes, should be picked up for the next rc. > > Let me know if you run into any more problems with that. > > Than

Re: [PATCH] drm/amdgpu: handle gang submit before VMID

2022-11-21 Thread Deucher, Alexander
[AMD Official Use Only - General] Yes, it has already landed in drm-misc-fixes: https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=b09d6acba1d9a23963fedf96b4191502a4fec25d Alex From: Timur Kristóf Sent: Monday, November 21, 2022 11:36 AM To: Ch

Re: [PATCH] drm/amdgpu: add drv_vram_usage_va for virt data exchange

2022-11-21 Thread Luben Tuikov
On 2022-11-17 21:56, Tong Liu01 wrote: > For vram_usagebyfirmware_v2_2, fw_vram_reserve is not used. So > fw_vram_usage_va is NULL, and cannot do virt data exchange > anymore. Should add drv_vram_usage_va to do virt data exchange > in vram_usagebyfirmware_v2_2 case. And refine some code style > che

Re: [PATCH] drm/amdgpu: fix for suspend/resume kiq fence fallback under sriov

2022-11-21 Thread Deucher, Alexander
[Public] Please add: Fixes: ec4927d463cb ("drm/amdgpu: fix for suspend/resume sequence under sriov") With that: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Shikang Fan Sent: Friday, November 18, 2022 4:51 AM To: amd-gfx@lists.freedesktop.org Cc: Fan,

Re: [PATCH] drm/amdgpu: add drv_vram_usage_va for virt data exchange

2022-11-21 Thread Luben Tuikov
On 2022-11-21 03:24, Christian König wrote: > Am 18.11.22 um 03:56 schrieb Tong Liu01: >> For vram_usagebyfirmware_v2_2, fw_vram_reserve is not used. So >> fw_vram_usage_va is NULL, and cannot do virt data exchange >> anymore. Should add drv_vram_usage_va to do virt data exchange >> in vram_usageby

[PATCH v3] drm/amdgpu: fix stall on CPU when allocate large system memory

2022-11-21 Thread James Zhu
-v2: 1. rename variable to redue confuse 2. optimize the code -v3: move new define out of the middle of the code When applications try to allocate large system (more than > 128GB), "stall cpu" is reported. for such large system memory, walk_page_range takes more than 20s usually. The warning

Re: [PATCH v2] drm/amdgpu: fix stall on CPU when allocate large system memory

2022-11-21 Thread James Zhu
On 2022-11-21 08:18, Christian König wrote: Am 21.11.22 um 14:13 schrieb James Zhu: When applications try to allocate large system (more than > 128GB), "stall cpu" is reported. for such large system memory, walk_page_range takes more than 20s usually. The warning message can be removed wh

[PATCH] drm/amdgpu: fix unused-function error

2022-11-21 Thread Ren Zhijie
If CONFIG_DRM_AMDGPU=y and CONFIG_DRM_AMD_DC is not set, gcc complained about unused-function : drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1705:13: error: ‘amdgpu_discovery_set_sriov_display’ defined but not used [-Werror=unused-function] static void amdgpu_discovery_set_sriov_display(struct

Re: [PATCH] drm/amdkfd: Release the topology_lock in error case

2022-11-21 Thread Felix Kuehling
Am 2022-11-21 um 00:13 schrieb Ma Jun: From: Felix Kuehling Move the topology-locked part of kfd_topology_add_device into a separate function to simlpify error handling and release the topology lock consistently. Reported-by: Dan Carpenter Signed-off-by: Felix Kuehling Signed-off-by: Ma Jun

Re: [PATCH v2] drm/amdgpu: fix stall on CPU when allocate large system memory

2022-11-21 Thread Christian König
Am 21.11.22 um 14:13 schrieb James Zhu: When applications try to allocate large system (more than > 128GB), "stall cpu" is reported. for such large system memory, walk_page_range takes more than 20s usually. The warning message can be removed when splitting hmm range into smaller ones which i

[PATCH v2] drm/amdgpu: fix stall on CPU when allocate large system memory

2022-11-21 Thread James Zhu
When applications try to allocate large system (more than > 128GB), "stall cpu" is reported. for such large system memory, walk_page_range takes more than 20s usually. The warning message can be removed when splitting hmm range into smaller ones which is not more 64GB for each walk_page_range. [

Re: [PATCH AUTOSEL 6.0 38/44] drm/amdgpu: Unlock bo_list_mutex after error handling

2022-11-21 Thread Christian König
Am 21.11.22 um 10:57 schrieb Michel Dänzer: On 11/19/22 03:11, Sasha Levin wrote: From: Philip Yang [ Upstream commit 64f65135c41a75f933d3bca236417ad8e9eb75de ] Get below kernel WARNING backtrace when pressing ctrl-C to kill kfdtest application. If amdgpu_cs_parser_bos returns error after ta

Re: [PATCH AUTOSEL 6.0 38/44] drm/amdgpu: Unlock bo_list_mutex after error handling

2022-11-21 Thread Michel Dänzer
On 11/19/22 03:11, Sasha Levin wrote: > From: Philip Yang > > [ Upstream commit 64f65135c41a75f933d3bca236417ad8e9eb75de ] > > Get below kernel WARNING backtrace when pressing ctrl-C to kill kfdtest > application. > > If amdgpu_cs_parser_bos returns error after taking bo_list_mutex, as > caller

[PATCH] drm/amd/display: rewrite the check for mods

2022-11-21 Thread Jiasheng Jiang
On Thu, 17 Nov 2022 15:56:09 +0800, Simon Ser wrote: >> @@ -638,11 +638,14 @@ static int get_plane_modifiers(struct amdgpu_device >> *adev, unsigned int plane_ty >> return 0; >> >> *mods = kmalloc(capacity * sizeof(uint64_t), GFP_KERNEL); >> +if (!*mods) >> +ret

Re: [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start #forregzbot

2022-11-21 Thread Thorsten Leemhuis
[Note: this mail is primarily send for documentation purposes and/or for regzbot, my Linux kernel regression tracking bot. That's why I removed most or all folks from the list of recipients, but left any that looked like a mailing lists. These mails usually contain '#forregzbot' in the subject, to

[PATCH] [next] drm/amdgpu: Replace remaining 1-element array with flex-array

2022-11-21 Thread Paulo Miguel Almeida
One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in struct GOP_VBIOS_CONTENT and refactor the rest of the code accordingly. Important to mention is that doing a build before/after this patch r

Re: [PATCH] drm/amdgpu: add drv_vram_usage_va for virt data exchange

2022-11-21 Thread Christian König
Am 18.11.22 um 03:56 schrieb Tong Liu01: For vram_usagebyfirmware_v2_2, fw_vram_reserve is not used. So fw_vram_usage_va is NULL, and cannot do virt data exchange anymore. Should add drv_vram_usage_va to do virt data exchange in vram_usagebyfirmware_v2_2 case. And refine some code style checks in

RE: [PATCH] drm/amdgpu: add drv_vram_usage_va for virt data exchange

2022-11-21 Thread Liu01, Tong (Esther)
[AMD Official Use Only - General] Hi, Please review, thanks Kind regards, Esther -Original Message- From: Tong Liu01 Sent: 2022年11月18日星期五 上午10:56 To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan ; Chen, Horace ; Tuikov, Luben ; Koenig, Christian ; Deucher, Alexander ; Xiao, Jack ;