Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-16 Thread Harry Wentland
On 12/15/22 16:02, Alex Hung wrote: > > > On 2022-12-15 08:17, Harry Wentland wrote: >> >> >> On 12/15/22 05:29, Michel Dänzer wrote: >>> On 12/15/22 09:09, Christian König wrote: Am 15.12.22 um 00:33 schrieb Alex Hung: > On 2022-12-14 16:06, Alex Deucher wrote: >> On Wed, Dec

Re: [PATCH] drm/amd/pm: avoid large variable on kernel stack

2022-12-16 Thread Alex Deucher
On Thu, Dec 15, 2022 at 2:46 PM Christophe JAILLET wrote: > > Le 15/12/2022 à 17:36, Arnd Bergmann a écrit : > > From: Arnd Bergmann > > > > The activity_monitor_external[] array is too big to fit on the > > kernel stack, resulting in this warning with clang: > > > >

Re: drm/amdgpu: skip MES for S0ix as well since it's part of GFX

2022-12-16 Thread Limonciello, Mario
On 12/16/2022 10:44, Alex Deucher wrote: It's also part of gfxoff. Signed-off-by: Alex Deucher Reviewed-by: Mario Limonciello Even without the other series this alone has been shown to improve things for the affected ASIC, so it should probably go to stable. Cc: sta...@vger.kernel.org #

Re: [5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-16 Thread Alex Deucher
On Fri, Dec 16, 2022 at 9:35 AM Limonciello, Mario wrote: > > +Tim > > On 12/15/2022 16:10, Alex Deucher wrote: > > SDMA 5.x is part of the GFX block so it's controlled via > > GFXOFF. Skip suspend as it should be handled the same > > as GFX. > > > > v2: drop SDMA 4.x. That requires special

[PATCH] drm/amdgpu: skip MES for S0ix as well since it's part of GFX

2022-12-16 Thread Alex Deucher
It's also part of gfxoff. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 582a80a9850e..e4609b8d574c

[linux-next:master] BUILD REGRESSION ca39c4daa6f7f770b1329ffb46f1e4a6bcc3f291

2022-12-16 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: ca39c4daa6f7f770b1329ffb46f1e4a6bcc3f291 Add linux-next specific files for 20221216 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211180516.dtowileo-...@intel.com https

RE: [PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-16 Thread Russell, Kent
[AMD Official Use Only - General] Probably want to fix that typo from SMDA to SDMA in the subject line before pushing. Kent > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, December 15, 2022 5:11 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher,

Re: [PATCH] drm/amd/pm: correct the fan speed retrieving in PWM for some SMU13 asics

2022-12-16 Thread Alex Deucher
With Christian's comment addressed, the patch is: Acked-by: Alex Deucher On Fri, Dec 16, 2022 at 6:50 AM Christian König wrote: > > Am 16.12.22 um 11:35 schrieb Evan Quan: > > For SMU 13.0.0 and 13.0.7, the output from PMFW is in percent. Driver > > need to convert that into correct PMW(255)

Re: [PATCH] drm/amd/display: fix dp_retrieve_lttpr_cap return code

2022-12-16 Thread Arnd Bergmann
On Thu, Dec 15, 2022, at 18:56, Michel Dänzer wrote: > On 12/15/22 17:37, Arnd Bergmann wrote: /amd/display/dc/core/dc_link_dp.c >> index af9411ee3c74..95dbfa4e996a 100644 >> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >> @@

Re: [5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-16 Thread Limonciello, Mario
+Tim On 12/15/2022 16:10, Alex Deucher wrote: SDMA 5.x is part of the GFX block so it's controlled via GFXOFF. Skip suspend as it should be handled the same as GFX. v2: drop SDMA 4.x. That requires special handling. Acked-by: Rajneesh Bhardwaj Signed-off-by: Alex Deucher ---

Re: [PATCH 0/7 v2] Improve S0ix stability

2022-12-16 Thread Limonciello, Mario
On 12/15/2022 16:10, Alex Deucher wrote: This series improves S0ix stability by avoiding touching registers that should be handled as part of gfxoff. v2: add comments in gmc code to explain why we can skip the vm fault state setting for gfxhub. Alex Deucher (7): drm/amdgpu/gmc9: don't touch

Re: [PATCH V2] drm/plane-helper: Add the missing declaration of drm_atomic_state

2022-12-16 Thread Thomas Zimmermann
Hi Am 16.12.22 um 04:05 schrieb Ma Jun: Add the missing declaration of struct drm_atomic_state to fix the compile error below: error: 'struct drm_atomic_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] Signed-off-by: Ma Jun

RE: [PATCH] drm/amdgpu: Fixed bug on error when uninstalling amdgpu

2022-12-16 Thread Chai, Thomas
[AMD Official Use Only - General] OK, I will update subject line. Thanks! - Best Regards, Thomas -Original Message- From: Christian König Sent: Friday, December 16, 2022 4:50 PM To: Chai, Thomas ; amd-gfx@lists.freedesktop.org; Paneer Selvam, Arunpravin Cc: Zhou1,

[PATCH -next] drm/amd/display: Remove redundant assignment to variable dc

2022-12-16 Thread Yi Yang
Smatch report warning as follows: Line 53679: drivers/gpu/drm/amd/display/dc/core/dc_stream.c:402 dc_stream_set_cursor_position() warn: variable dereferenced before check 'stream' The value of 'dc' has been assigned after check whether 'stream' is NULL. Fix it by remove redundant assignment.

Re: [PATCH] drm/amd/pm: correct the fan speed retrieving in PWM for some SMU13 asics

2022-12-16 Thread Christian König
Am 16.12.22 um 11:35 schrieb Evan Quan: For SMU 13.0.0 and 13.0.7, the output from PMFW is in percent. Driver need to convert that into correct PMW(255) based. Signed-off-by: Evan Quan Change-Id: I7bbeae3c0d81c6cf6e0033aa28ca6d26f5b6d178 --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-16 Thread Michel Dänzer
On 12/15/22 10:07, Michel Dänzer wrote: > On 12/14/22 16:46, Alex Deucher wrote: >> On Wed, Dec 14, 2022 at 4:01 AM Pekka Paalanen wrote: >>> On Tue, 13 Dec 2022 18:20:59 +0100 >>> Michel Dänzer wrote: On 12/12/22 19:21, Harry Wentland wrote: > This will let us pass kms_hdr.bpc_switch.

[PATCH] drm/amd/display: Remove redundant logs from DSC code

2022-12-16 Thread Praful Swarnakar
[Why & How] Remove redundant log in DSC that just add additional blank prints Signed-off-by: Praful Swarnakar --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 1 - drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 1 - 2 files changed, 2 deletions(-) diff --git

[PATCH] drm/amd/pm: correct the fan speed retrieving in PWM for some SMU13 asics

2022-12-16 Thread Evan Quan
For SMU 13.0.0 and 13.0.7, the output from PMFW is in percent. Driver need to convert that into correct PMW(255) based. Signed-off-by: Evan Quan Change-Id: I7bbeae3c0d81c6cf6e0033aa28ca6d26f5b6d178 --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 15 ---

Re: [PATCH] drm/amdgpu: Fixed bug on error when uninstalling amdgpu

2022-12-16 Thread Christian König
Am 16.12.22 um 03:56 schrieb YiPeng Chai: Fixed bug on error when uninstalling amdgpu. The error message is as follows: [ 304.852489] kernel BUG at drivers/gpu/drm/drm_buddy.c:278! [ 304.852503] invalid opcode: [#1] PREEMPT SMP NOPTI [ 304.852510] CPU: 2 PID: 4192 Comm: modprobe Tainted:

Re: [linux-next:master] BUILD REGRESSION 459c73db4069c27c1d4a0e20d055b837396364b8

2022-12-16 Thread Vincent Mailhol
On Tue. 15 Dec. 2022 at 22:57, kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 459c73db4069c27c1d4a0e20d055b837396364b8 Add linux-next > specific files for 20221215 > > Error/Warning reports: (...) >