Re: [RFC 7/7] drm/amdgpu: Secure semaphore for usermode queue

2022-12-27 Thread Arunpravin Paneer Selvam
On 12/25/2022 3:37 PM, Zhang, Yifan wrote: [Public] From: Arunpravin Paneer Selvam This is a WIP patch, which adds an kernel implementation of secure semaphore for the usermode queues. The UAPI for the same is yet to be implemented. The idea is to create a RO page and map it to each proce

[PATCH] drm/radeon: Fix potential null-ptr-deref

2022-12-27 Thread Nikita Zhandarovich
radeon_get_connector_for_encoder() assigns radeon_encoder->enc_priv to mst_enc which is dereferenced later without being checked for NULL beforehand. It is possible for radeon_encoder->enc_priv and therefore mst_enc, to be NULL due to potential lack of memory. This patch adds a sanity NULL-check t

[PATCH] drm/radeon: Fix potential null-ptr-deref

2022-12-27 Thread Nikita Zhandarovich
Due to my rookie mistake this patch isn't necessary anymore in upstream version. The issue was already resolved in a different manner. Apologies for inconvenience.

Re: [PATCH] ALSA: hda/hdmi: Use only dynamic PCM device allocation #forregzbot

2022-12-27 Thread Thorsten Leemhuis
[Note: this mail contains only information for Linux kernel regression tracking. Mails like these contain '#forregzbot' in the subject to make then easy to spot and filter out. The author also tried to remove most or all individuals from the list of recipients to spare them the hassle.] On 25.12.2

Re: Build regressions/improvements in v6.2-rc1

2022-12-27 Thread Geert Uytterhoeven
On Tue, 27 Dec 2022, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v6.2-rc1[1] compared to v6.1[2]. Summarized: - build errors: +11/-13 amd-gfx@lists.freedesktop.org linux-arm-ker...@lists.infradead.org linux-me...@vger.kernel.org linux-wirel..

Re: [PATCH] ALSA: hda/hdmi: Use only dynamic PCM device allocation

2022-12-27 Thread Jaroslav Kysela
On 25. 12. 22 19:52, Takashi Iwai wrote: On Sun, 25 Dec 2022 13:14:28 +0100, Michael Laß wrote: CC'ing amd-gfx as this might be an issue in the amd driver. This change causes a regression in Linux 6.1 at least on some AMD APUs. There are reports from users with Ryzen 4750U, 5800U and 5850U chi

Re: [PATCH 0/2] Recover from failure to probe GPU

2022-12-27 Thread Alex Deucher
On Sun, Dec 25, 2022 at 10:31 AM Christian König wrote: > > Am 24.12.22 um 10:34 schrieb Thomas Zimmermann: > > Hi > > > > Am 22.12.22 um 19:30 schrieb Mario Limonciello: > >> One of the first thing that KMS drivers do during initialization is > >> destroy the system firmware framebuffer by means

Re: [BUG] AMD Radeon Pro 5600M with 8GB of HBM2 memory shows blank screen on Linux

2022-12-27 Thread Alex Deucher
On Mon, Dec 26, 2022 at 8:19 AM Aditya Garg wrote: > > The AMD Radeon Pro 5600M with 8GB of HBM2 memory GPU is found in MacBook Pro > 16 inch, 2019 (MacBookPro16,4). > > The GPU fails to work on Linux, thus a blank black screen gets displayed on > boot. > > If nomodeset is added as a kernel para

Re: [RFC 1/7] drm/amdgpu: UAPI for user queue management

2022-12-27 Thread Alex Deucher
On Sat, Dec 24, 2022 at 3:21 PM Bas Nieuwenhuizen wrote: > > On Fri, Dec 23, 2022 at 8:37 PM Shashank Sharma > wrote: > > > > From: Alex Deucher > > > > This patch intorduces new UAPI/IOCTL for usermode graphics > > queue. The userspace app will fill this structure and request > > the graphics

Re: [PATCH 0/2] Recover from failure to probe GPU

2022-12-27 Thread Alex Deucher
On Tue, Dec 27, 2022 at 10:40 AM Alex Deucher wrote: > > On Sun, Dec 25, 2022 at 10:31 AM Christian König > wrote: > > > > Am 24.12.22 um 10:34 schrieb Thomas Zimmermann: > > > Hi > > > > > > Am 22.12.22 um 19:30 schrieb Mario Limonciello: > > >> One of the first thing that KMS drivers do during

[PATCH] drm/amd/display: drop unnecessary NULL checks in debugfs

2022-12-27 Thread Alexey Kodanev
pipe_ctx pointer cannot be NULL when getting the address of an element of the pipe_ctx array. Moreover, the MAX_PIPES is defined as 6, so pipe_ctx is not NULL after the loop either. Detected using the static analysis tool - Svace. Signed-off-by: Alexey Kodanev --- .../amd/display/amdgpu_dm/amdgp

Re: [BUG] AMD Radeon Pro 5600M with 8GB of HBM2 memory shows blank screen on Linux

2022-12-27 Thread Aditya Garg
> > Can you file a bug report: > https://gitlab.freedesktop.org/drm/amd/-/issues/ https://gitlab.freedesktop.org/drm/amd/-/issues/2318 > > What sort of monitor are you using? It looks to be failing mode validation: > [drm] Mode Validation Warning: Urgent latency failed validation. > Well its

[PATCH] drm/amdkfd: simplify cases

2022-12-27 Thread Alex Deucher
A number of of the gfx8 cases where the same. Clean them up. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c index 091fc2bb8

Re: [PATCH] drm/amdkfd: simplify cases

2022-12-27 Thread Alex Deucher
On Tue, Dec 27, 2022 at 12:10 PM Alex Deucher wrote: > > A number of of the gfx8 cases where the same. Clean them > up. typos here fixed up locally. Alex > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 11 --- > 1 file changed, 11 deletions(-) > > di

Re: [PATCH 1/3] drm/amd/pm/smu11: BACO is supported when it's in BACO state

2022-12-27 Thread Bjorn Helgaas
[+cc Stefan, linux-pci] On Wed, Nov 23, 2022 at 09:43:07AM +0800, Guchun Chen wrote: > Return true early if ASIC is in BACO state already, no need > to talk to SMU. It can fix the issue that driver was not > calling BACO exit at all in runtime pm resume, and a timing > issue leading to a PCI AER e

Re: [PATCH 0/2] Recover from failure to probe GPU

2022-12-27 Thread Javier Martinez Canillas
Hello Alex, On 12/27/22 18:04, Alex Deucher wrote: [...] > > I think something like this would do the trick: > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 2017b3466612..45aee27ab6b1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/a

RE: [PATCH 1/3] drm/amd/pm/smu11: BACO is supported when it's in BACO state

2022-12-27 Thread Chen, Guchun
Hi Bjorn, Thanks for your comments. Exactly, this patch actually fixes an amdgpu driver issue, however it's only exposed by 8795e182b02d. Without it, it was running well over the past. Regarding the question, I will provide a similar change in smu13 later on. Regards, Guchun -Original Mes