On 1/4/23 23:29, Lazar, Lijo wrote:
On 1/5/2023 10:53 AM, Mario Limonciello wrote:
On 1/4/23 23:07, Lazar, Lijo wrote:
On 1/5/2023 9:12 AM, Mario Limonciello wrote:
All microcode runs a basic validation after it's been loaded. Each
IP block as part of init will run both.
Introduce a wrapp
On 1/5/2023 10:53 AM, Mario Limonciello wrote:
On 1/4/23 23:07, Lazar, Lijo wrote:
On 1/5/2023 9:12 AM, Mario Limonciello wrote:
All microcode runs a basic validation after it's been loaded. Each
IP block as part of init will run both.
Introduce a wrapper for request_firmware and amdgpu_u
On 1/4/23 23:07, Lazar, Lijo wrote:
On 1/5/2023 9:12 AM, Mario Limonciello wrote:
All microcode runs a basic validation after it's been loaded. Each
IP block as part of init will run both.
Introduce a wrapper for request_firmware and amdgpu_ucode_validate.
This wrapper will also remap any err
On 1/5/2023 9:12 AM, Mario Limonciello wrote:
All microcode runs a basic validation after it's been loaded. Each
IP block as part of init will run both.
Introduce a wrapper for request_firmware and amdgpu_ucode_validate.
This wrapper will also remap any error codes from request_firmware
to -E
[AMD Official Use Only - General]
Squashed into one patch now.
Thanks Alex.
> -Original Message-
> From: Alex Deucher
> Sent: Thursday, January 5, 2023 11:28 AM
> To: Liu, Aaron
> Cc: amd-gfx@lists.freedesktop.org; Liu, HaoPing (Alan)
> ; Deucher, Alexander ;
> Xiao, Shane
> Subject: R
The `amdgpu_ucode_release` helper is replacing all calls
to release_firmware.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_release argument change
---
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 11 ++-
1 file changed, 2 insertions(+
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/amdgpu_dm/a
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
No consumers outside of amdgpu_ucode.c use amdgpu_ucode_validate
anymore, so make the function static.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 -
2 files changed, 1 insertion(+
The `amdgpu_ucode_release` helper is replacing all calls to
release_firmware.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_release argument change
---
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 3 +--
1 file changed, 1 insertion(+), 2
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
Now that IP version decoding is used, a number of case statements
can be combined.
Reviewed-by: Alex Deucher
Reviewed-by: Christian König
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/driv
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
If DMUB is required for an ASIC, ensure that the microcode is available
and validates during early_init.
Any failures will cause the driver to fail to probe before the firmware
framebuffer has been removed.
Reviewed-by: Alex Deucher
Reviewed-by: Harry Wentland
Signed-off-by: Mario Limonciello
This will ensure that the microcode is available before the firmware
framebuffer has been destroyed.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_release argument change
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +++---
1 file changed, 3 insertions(+), 7 del
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
Simplifies the code so that all PSP versions will get the firmware
name from `amdgpu_ucode_ip_version_decode` and then use this filename
to load microcode as part of the early_init process.
Any failures will cause the driver to fail to probe before the firmware
framebuffer has been removed.
Revie
No need to crash the kernel. AMDGPU will now fail to probe.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/drivers/gpu/drm/amd/
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_relea
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper will provide symmetery on unload.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_r
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unload.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_release
Several IP versions duplicate code and can't use the common helpers.
Move this code into a single function so that the helpers can be used.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Rebase on earlier patches
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 120 +
If GFX11 microcode is required but not available during early init, the
firmware framebuffer will have already been released and the screen will
freeze.
Move the request for GFX11 microcode into the early_init phase
so that if it's not available, driver init will fail.
Reviewed-by: Alex Deucher
Simplifies the code so that GFX10 will get the firmware
name from `amdgpu_ucode_ip_version_decode` and then use this filename
to load microcode as part of the early_init process.
Any failures will cause the driver to fail to probe before the firmware
framebuffer has been removed.
Reviewed-by: Ale
If GFX9 microcode is required but not available during early init, the
firmware framebuffer will have already been released and the screen will
freeze.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 58 +--
1 file c
`amdgpu_mes_init` already sets `adev->mes.adev`, so there is no need
to also set it in the IP specific versions.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 1 -
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 1 -
2 files changed, 2 deletion
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper will provide symmetry on unload.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_re
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper provides symmetry for releasing firmware.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu
Add an early_init phase to MES for fetching and validating microcode
from the filesystem.
If MES microcode is required but not available during early init, the
firmware framebuffer will have already been released and the screen will
freeze.
Move the request for MES microcode into the early_init p
Simplifies the code so that all VCN versions will get the firmware
name from `amdgpu_ucode_ip_version_decode` and then use this filename
to load microcode as part of the early_init process.
Signed-off-by: Mario Limonciello
---
v5->v6:
* Fix whitespace problem in firmware file names
* Adjust for
Simplifies the code so that all SDMA versions will get the firmware
name from `amdgpu_ucode_ip_version_decode`.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 12 --
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 4 +-
drivers/gpu/drm/
When firmware is missing we get failures at every step.
```
[3.855086] amdgpu :04:00.0: Direct firmware load for
amdgpu/green_sardine_sdma.bin failed with error -2
[3.855087] [drm:amdgpu_sdma_init_microcode [amdgpu]] *ERROR* SDMA: Failed
to init firmware "amdgpu/green_sardine_sdma.bin
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_release argument change
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry.
Reviewed-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
v5->v6:
* Adjust for amdgpu_ucode_release argument c
All microcode runs a basic validation after it's been loaded. Each
IP block as part of init will run both.
Introduce a wrapper for request_firmware and amdgpu_ucode_validate.
This wrapper will also remap any error codes from request_firmware
to -ENODEV. This is so that early_init will fail if fir
The special case for the one dGPU has been moved into
`amdgpu_ucode_ip_version_decode`, so simplify this code.
Signed-off-by: Mario Limonciello
Acked-by: Christian König
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 12 ++--
1 file changed, 2 insertions
Remove the special casing from SMU v11 code. No intended functional
changes.
Signed-off-by: Mario Limonciello
Acked-by: Christian König
Reviewed-by: Alex Deucher
---
.../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c| 35 ++-
1 file changed, 3 insertions(+), 32 deletions(-)
diff -
This will allow other parts of the driver that currently special
case firmware file names to before IP version style naming to just
have a single call to `amdgpu_ucode_ip_version_decode`.
Signed-off-by: Mario Limonciello
Acked-by: Christian König
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/a
Removing the firmware framebuffer from the driver means that even
if the driver doesn't support the IP blocks in a GPU it will no
longer be functional after the driver fails to initialize.
This change will ensure that unsupported IP blocks at least cause
the driver to work with the EFI framebuffer
One of the first thing that KMS drivers do during initialization is
destroy the system firmware framebuffer by means of
`drm_aperture_remove_conflicting_pci_framebuffers`
This means that if for any reason the GPU failed to probe the user
will be stuck with at best a screen frozen at the last thing
Hi Dave, Daniel,
Fixes for 6.2.
The following changes since commit c8de526215fdab9f2dd0d9675582cf9f1391a919:
Merge tag 'drm-misc-next-fixes-2023-01-03' of
git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2023-01-03 21:02:57
+0100)
are available in the Git repository at:
https:/
These two patches should be squashed together to avoid breaking the build.
Alex
On Wed, Jan 4, 2023 at 8:04 PM Aaron Liu wrote:
>
> This patch updates securedisplay_cmd to ta_securedisplay_cmd
> starting from amd-ta_securedisplay-v27.00.00.08.
>
> Signed-off-by: Aaron Liu
> ---
> drivers/gpu/d
Due to lack of support from PMFW.
Signed-off-by: Evan Quan
Change-Id: I8439e72b95ad2fdf8cfdf1edc4d9c8af58109dc3
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
b/drivers/gpu/dr
Make the code more clean and readable with no real logics
change.
Signed-off-by: Evan Quan
Change-Id: I2c9e661ed6b855ea6ddd8554dd4f975cd2faa24f
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 329 ++---
1 file changed, 206 insertions(+), 123 deletions(-)
diff --git a/drivers/gp
Due to lack of support from PMFW.
Signed-off-by: Evan Quan
Change-Id: I5d466d3d521b26a484bd837e173b9b289d4020ec
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
b/drivers/gpu/dr
Via this, the logic for adding/dropping the support for some specific
hwmon interface can be greatly simplified.
Signed-off-by: Evan Quan
Change-Id: Ia85082c964d80d1c43dd2d8bf51592aba968e364
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ++-
drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h| 52
Those legacy sysfs interfaces are actually not supported. Their
outputs are confusing.
Signed-off-by: Evan Quan
Change-Id: Iba89f12ae3e79b856d6c0904b371590b6fd0d327
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/d
Via this, the logic for adding/dropping the support for some specific
sysfs interface can be greatly simplified.
Signed-off-by: Evan Quan
Change-Id: Ica470cb8afd5b6cf7cc2a47b8310746b6c3b6f97
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 ++
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 115
Those legacy sysfs interfaces are actually not supported. Their
outputs are confusing.
Signed-off-by: Evan Quan
Change-Id: I95a772911a6f0ec89b0dfed08bef50f0060defad
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/d
Make the code more clean and readable with no real logics
change.
Signed-off-by: Evan Quan
Change-Id: I21c879fa9abad9f6da3b5289adf3124950d2f4eb
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 200 ++---
1 file changed, 98 insertions(+), 102 deletions(-)
diff --git a/drivers/gpu
[AMD Official Use Only - General]
Reviewed-by: Alan Liu
-Original Message-
From: Liu, Aaron
Sent: Thursday, January 5, 2023 9:04 AM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, HaoPing (Alan) ; Deucher, Alexander
; Xiao, Shane ; Liu, Aaron
Subject: [PATCH 1/2] drm/amdgpu: update ta_se
[AMD Official Use Only - General]
Reviewed-by: Alan Liu
-Original Message-
From: Liu, Aaron
Sent: Thursday, January 5, 2023 9:04 AM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, HaoPing (Alan) ; Deucher, Alexander
; Xiao, Shane ; Liu, Aaron
Subject: [PATCH 2/2] drm/amd: update securedi
This patch updates securedisplay_cmd to ta_securedisplay_cmd
starting from amd-ta_securedisplay-v27.00.00.08.
Signed-off-by: Aaron Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 8
drivers/gpu/drm/amd/amdgpu/
1. Rename securedisplay_cmd to ta_securedisplay_cmd.
2. Rename ta_securedisplay_max_phy to ta_securedisplay_phy_ID.
Signed-off-by: Aaron Liu
Signed-off-by: Shane Xiao
---
.../gpu/drm/amd/amdgpu/ta_secureDisplay_if.h | 24 +--
1 file changed, 12 insertions(+), 12 deletions(-)
d
On 12/25/22 10:10, wenyang.li...@foxmail.com wrote:
From: Wen Yang
The following errors occurred when using gcc 7.5.0-3ubuntu1~18.04:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c: In function
‘dc_stream_remove_writeback’:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:5
On 12/16/22 05:35, Praful Swarnakar wrote:
[Why & How]
Remove redundant log in DSC that just add additional blank prints
Signed-off-by: Praful Swarnakar
Applied, thanks!
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 1 -
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 1 -
2
Fix potential NULL dereference, in the case when "man", the resource manager
might be NULL, when/if we print debug information.
Cc: Alex Deucher
Cc: Christian König
Cc: AMD Graphics
Cc: Dan Carpenter
Cc: kernel test robot
Fixes: 7554886daa31ea ("drm/amdgpu: Fix size validation for non-exclusi
Yes, it's meant to be like a spec sheet. We are not interested in the
current bandwidth utilization.
Marek
On Wed, Jan 4, 2023 at 10:33 AM Lazar, Lijo wrote:
> [AMD Official Use Only - General]
>
> To clarify, with DPM in place, the current bandwidth will be changing
> based on the load.
>
> If
When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it
warns:
clang-16: error: argument unused during compilation: '-mhard-float'
[-Werror,-Wunused-command-line-argument]
Similar to commit 84edc2eff827 ("selftest/fpu: avoid clang warning"),
just add this flag to GCC builds. Commit
Hi all,
Clang can emit a few different warnings when it encounters a flag that it
recognizes but does not support internally. These warnings are elevated to
errors within {as,cc}-option via -Werror to catch unsupported flags that should
not be added to KBUILD_{A,C}FLAGS; see commit c3f0d0bc5b01 ("
From: Jiasheng Jiang
[ Upstream commit abfaf0eee97925905e742aa3b0b72e04a918fa9e ]
As the possible failure of the allocation, kmemdup() may return NULL
pointer.
Therefore, it should be better to check the 'props2' in order to prevent
the dereference of NULL pointer.
Fixes: 3a87177eb141 ("drm/amd
From: Jiasheng Jiang
[ Upstream commit abfaf0eee97925905e742aa3b0b72e04a918fa9e ]
As the possible failure of the allocation, kmemdup() may return NULL
pointer.
Therefore, it should be better to check the 'props2' in order to prevent
the dereference of NULL pointer.
Fixes: 3a87177eb141 ("drm/amd
The following commit is needed to fix CVE-2022-3108:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abfaf0eee97925905e742aa3b0b72e04a918fa9e
Jiasheng Jiang (1):
drm/amdkfd: Check for null pointer after calling kmemdup
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++
The following commit is needed to fix CVE-2022-3108:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abfaf0eee97925905e742aa3b0b72e04a918fa9e
Jiasheng Jiang (1):
drm/amdkfd: Check for null pointer after calling kmemdup
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++
On 04.01.2023 16:48, Greg KH wrote:
On Wed, Jan 04, 2023 at 09:35:03AM -0500, Alex Deucher wrote:
On Wed, Jan 4, 2023 at 8:23 AM Christian König wrote:
Am 04.01.23 um 13:41 schrieb Greg KH:
On Tue, Jan 03, 2023 at 08:43:08PM +0200, Dragos-Marian Panait wrote:
From: Jiasheng Jiang
[ Upstr
On 12/27/22 12:04, Alexey Kodanev wrote:
pipe_ctx pointer cannot be NULL when getting the address of
an element of the pipe_ctx array. Moreover, the MAX_PIPES is
defined as 6, so pipe_ctx is not NULL after the loop either.
Detected using the static analysis tool - Svace.
Signed-off-by: Alexey Ko
Other than the patches I commented directly on, this series is:
Reviewed-by: Alex Deucher
On Wed, Jan 4, 2023 at 11:45 AM Mario Limonciello
wrote:
>
> No consumers outside of amdgpu_ucode.c use amdgpu_ucode_validate
> anymore, so make the function static.
>
> Signed-off-by: Mario Limonciello
>
[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Wednesday, January 4, 2023 11:16
> To: Limonciello, Mario
> Cc: Deucher, Alexander ; linux-
> ker...@vger.kernel.org; Pan, Xinhui ; Lazar, Lijo
> ; Javier Martinez Canillas ; dri-
> de...@lists.freedesktop.org; amd-gfx@lists.fr
On Wed, Jan 4, 2023 at 11:42 AM Mario Limonciello
wrote:
>
> Simplifies the code so that all VCN versions will get the firmware
> name from `amdgpu_ucode_ip_version_decode` and then use this filename
> to load microcode as part of the early_init process.
>
> Signed-off-by: Mario Limonciello
> ---
On Wed, Jan 4, 2023 at 11:42 AM Mario Limonciello
wrote:
>
> All microcode runs a basic validation after it's been loaded. Each
> IP block as part of init will run both.
>
> Introduce a wrapper for request_firmware and amdgpu_ucode_validate.
> This wrapper will also remap any error codes from requ
No consumers outside of amdgpu_ucode.c use amdgpu_ucode_validate
anymore, so make the function static.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --g
The `amdgpu_ucode_release` helper is replacing all calls to
release_firmware.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
b/drivers/gp
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 11 ++-
1 file c
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 16 ++--
1 fil
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 ++-
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 16 --
The `amdgpu_ucode_release` helper is replacing all calls
to release_firmware.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
b/drivers/gpu/
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 68 +++
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 14 +++---
1
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 14 +++---
1 file
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 14 +++---
1 fil
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 14 +++---
1 fil
Now that IP version decoding is used, a number of case statements
can be combined.
Reviewed-by: Christian König
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdg
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 94 ++-
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 18 ++
1
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 18 ++
1
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 13 +++--
1 file c
This will ensure that the microcode is available before the firmware
framebuffer has been destroyed.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 13 +++--
1 file c
1 - 100 of 156 matches
Mail list logo
