RE: [PATCH] drm/amd/amdgpu: implement mode2 reset on smu_v13_0_10

2023-02-09 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Kenneth Feng > Sent: Friday, February 10, 2023 1:14 PM > To: amd-gfx@lists.freedesktop.org > Cc: Feng, Kenneth > Subject: [PATCH] drm/amd/amdgpu: implement mode2 reset on > smu_v13_0_10 > > implement

[PATCH] drm/amd/amdgpu: implement mode2 reset on smu_v13_0_10

2023-02-09 Thread Kenneth Feng
implement mode2 reset on smu_v13_0_10 Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 7 + drivers/gpu/drm/amd/amdgpu/smu_v13_0_10.c | 303 ++ drivers/gpu/drm/amd/amdgpu/smu_v13_0_10.h

RE: [PATCH] drm/amdgpu: only WARN freeing buffers when DMA is unavailable

2023-02-09 Thread Quan, Evan
[AMD Official Use Only - General] Hi Jack, Are you trying to fix the call trace popped up on resuming below? It seems mes created some bo for its self test and freed it up later at the final stage of the resuming process. All these happened before the in_suspend flag cleared. And that triggered

RE: gpu_metrics does not provide 'current_gfxclk', 'current_uclk', 'average_cpu_power' & 'temperature_core' on AMD Ryzen 7000 CPU

2023-02-09 Thread Quan, Evan
[AMD Official Use Only - General] For some members, "0" is a valid value. Thus "0x" is used instead to tell the output is invalid/unsupported. BR Evan > -Original Message- > From: amd-gfx On Behalf Of > sfrcorne > Sent: Wednesday, February 8, 2023 7:12 AM > To: Alex Deucher > Cc: a

RE: [PATCH v2] drm/amdkfd: To fix sdma page fault issue for GC 11.x

2023-02-09 Thread Zhang, Yifan
[Public] This patch is : Reviewed-by: Yifan Zhang -Original Message- From: Ji, Ruili Sent: Thursday, February 9, 2023 2:18 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Deucher, Alexander ; Liu, Aaron ; Zhang, Yifan ; Ji, Ruili Subject: [PATCH v2] drm/amdkfd: To fix sd

RE: [PATCH 4/4] Revert "drm/amd/display: disable S/G display on DCN 3.1.5"

2023-02-09 Thread Zhang, Yifan
[Public] This series is Reviewed-by: Yifan Zhang -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, February 9, 2023 10:12 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 4/4] Revert "drm/amd/display: disable S/G display on DCN 3.1

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-09 Thread Ville Syrjälä
On Thu, Feb 09, 2023 at 05:03:19PM +, Simon Ser wrote: > On Thursday, February 9th, 2023 at 17:38, Joshua Ashton > wrote: > > > > I mean, the strings are the uAPI, not the integers, right? > > > > Both are uAPI these days. > > Yes. The integers are uAPI, if you change them you'll break libl

[pull] amdgpu drm-fixes-6.2

2023-02-09 Thread Alex Deucher
Hi Dave, Daniel, A few last minute display fixes. The following changes since commit c6ac406cd8ff610a2d5da298b1d3071acfcde7f0: drm/amdgpu/smu: skip pptable init under sriov (2023-02-08 22:33:37 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git t

Re: [regression][6.0] After commit b261509952bc19d1012cf732f853659be6ebc61e I see WARNING message at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x63/0x70

2023-02-09 Thread Leo Li
Hi Mikhail, seems like your report flew past me, thanks for the ping. This might be a simple issue of not backing off when deadlock was hit. drm_atomic_normalize_zpos() can return an error code, and I ignored it (oops!) Can you give this patch a try? https://gitlab.freedesktop.org/-/snippets/741

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-09 Thread Simon Ser
On Thursday, February 9th, 2023 at 17:38, Joshua Ashton wrote: > > I mean, the strings are the uAPI, not the integers, right? > > Both are uAPI these days. Yes. The integers are uAPI, if you change them you'll break libliftoff users. There is an old thread discussing this somewhere. The tl;dr w

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-09 Thread Joshua Ashton
On 2/8/23 09:30, Pekka Paalanen wrote: On Fri, 3 Feb 2023 02:07:44 + Joshua Ashton wrote: Userspace has no way of controlling or knowing the pixel encoding currently, so there is no way for it to ever get the right values here. When we do add pixel_encoding control from userspace,we c

[linux-next:master] BUILD REGRESSION 20f513df926fac0594a3b65f79d856bd64251861

2023-02-09 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 20f513df926fac0594a3b65f79d856bd64251861 Add linux-next specific files for 20230209 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301302110.metnwkbd-...@intel.com https

Re: [PATCH 1/4] drm/amdgpu: add S/G display parameter

2023-02-09 Thread Harry Wentland
On 2/9/23 09:37, Christian König wrote: > Am 09.02.23 um 15:11 schrieb Alex Deucher: >> Some users have reported flickerng with S/G display.  We've >> tried extensively to reproduce and debug the issue on a wide >> variety of platform configurations (DRAM bandwidth, etc.) and >> a variety of monito

Re: [PATCH 1/4] drm/amdgpu: add S/G display parameter

2023-02-09 Thread Christian König
Am 09.02.23 um 15:11 schrieb Alex Deucher: Some users have reported flickerng with S/G display. We've tried extensively to reproduce and debug the issue on a wide variety of platform configurations (DRAM bandwidth, etc.) and a variety of monitors, but so far have not been able to. We disabled S

Re: [PATCH][next] drm/amd/display: Fix spelling mistakes of function name in error message

2023-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 9, 2023 at 7:53 AM Colin Ian King wrote: > > The function name is being reported as dc_link_contruct when it is > actually dc_link_construct_phy. Fix this by using %s and the __func__ > for the function name. > > Signed-off-by: Colin Ian King > --- > drivers/

Re: [PATCH v2] drm/amd/display: remove duplicate include header

2023-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 9, 2023 at 5:48 AM wrote: > > From: Ye Xingchen > > link_hwss.h is included more than once in link_dpms.c . > > Signed-off-by: Ye Xingchen > --- > v1 -> v2 > Fix the U+00A0 non-breaking space in the subject line. > drivers/gpu/drm/amd/display/dc/link/link_dp

Re: [PATCH] drm/amd/display: fix link_validation build failure

2023-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 9, 2023 at 7:45 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > When CONFIG_DRM_AMD_DC_DCN is disabled, the is_frl member > is not defined: > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_validation.c: In function > 'dp_active_dongle_validate_timin

Re: [PATCH] drm/amd/display: set should_disable_otg storage-class-specifier to static

2023-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 9, 2023 at 8:41 AM Tom Rix wrote: > > smatch reports > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c:90:6: > warning: symbol 'should_disable_otg' was not declared. Should it be static? > > should_disable_otg() is only used in dcn315

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

2023-02-09 Thread Melissa Wen
On 01/31, Pekka Paalanen wrote: > On Mon, 9 Jan 2023 14:38:09 -0100 > Melissa Wen wrote: > > > On 01/09, Melissa Wen wrote: > > > Hi, > > > > > > After collecting comments in different places, here is a second version > > > of the work on adding DRM CRTC 3D LUT support to the current DRM color >

[PATCH 4/4] Revert "drm/amd/display: disable S/G display on DCN 3.1.5"

2023-02-09 Thread Alex Deucher
This reverts commit 3cc67fe1b3aa1ac4720e002f2aa2d08c9199a584. Some users have reported flickerng with S/G display. We've tried extensively to reproduce and debug the issue on a wide variety of platform configurations (DRAM bandwidth, etc.) and a variety of monitors, but so far have not been able

[PATCH 3/4] Revert "drm/amd/display: disable S/G display on DCN 2.1.0"

2023-02-09 Thread Alex Deucher
This reverts commit 2404f9b0ea0153c3fddb0c4d7a43869dc8608f6f. Some users have reported flickerng with S/G display. We've tried extensively to reproduce and debug the issue on a wide variety of platform configurations (DRAM bandwidth, etc.) and a variety of monitors, but so far have not been able

[PATCH 2/4] Revert "drm/amd/display: disable S/G display on DCN 3.1.2/3"

2023-02-09 Thread Alex Deucher
This reverts commit f081cd4ca2658752a8c0e2353d50aec80d07c65f. Some users have reported flickerng with S/G display. We've tried extensively to reproduce and debug the issue on a wide variety of platform configurations (DRAM bandwidth, etc.) and a variety of monitors, but so far have not been able

[PATCH 1/4] drm/amdgpu: add S/G display parameter

2023-02-09 Thread Alex Deucher
Some users have reported flickerng with S/G display. We've tried extensively to reproduce and debug the issue on a wide variety of platform configurations (DRAM bandwidth, etc.) and a variety of monitors, but so far have not been able to. We disabled S/G display on a number of platforms to addres

Re: [PATCH 1/2] drm/amdgpu/gmc11: fix system aperture set when AGP is enabled

2023-02-09 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking From: amd-gfx on behalf of Alex Deucher Date: Thursday, February 9, 2023 at 21:43 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/2] drm/amdgpu/gmc11: fix system aperture set when AGP is

[PATCH] drm/amd/display: set should_disable_otg storage-class-specifier to static

2023-02-09 Thread Tom Rix
smatch reports drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c:90:6: warning: symbol 'should_disable_otg' was not declared. Should it be static? should_disable_otg() is only used in dcn315_clk_mgr.c, so it should be static Signed-off-by: Tom Rix --- drivers/gpu/drm/am

[PATCH 1/2] drm/amdgpu/gmc11: fix system aperture set when AGP is enabled

2023-02-09 Thread Alex Deucher
Need to cover both FB and AGP apertures. v2: fix missed gfxhub_v3_0_3.c Fixes: c6eafee038ed ("Revert "Revert "drm/amdgpu/gmc11: enable AGP aperture""") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0_3.c | 8 d

[PATCH 2/2] drm/amd/display: minor cleanup of vm_setup

2023-02-09 Thread Alex Deucher
Use fb_start/end for consistency with gmc code for non- XGMI systems, they are equivalent to vram_start/end. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amd

[PATCH][next] drm/amd/display: Fix spelling mistakes of function name in error message

2023-02-09 Thread Colin Ian King
The function name is being reported as dc_link_contruct when it is actually dc_link_construct_phy. Fix this by using %s and the __func__ for the function name. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/link/link_factory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH v2] drm/amd/display: remove duplicate include header

2023-02-09 Thread ye.xingchen
From: Ye Xingchen link_hwss.h is included more than once in link_dpms.c . Signed-off-by: Ye Xingchen --- v1 -> v2 Fix the U+00A0 non-breaking space in the subject line. drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/displa

[PATCH] drm/amd/display: fix link_validation build failure

2023-02-09 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_DRM_AMD_DC_DCN is disabled, the is_frl member is not defined: drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_validation.c: In function 'dp_active_dongle_validate_timing': drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_validation.c:126:66: error: 'const s

[PATCH AUTOSEL 5.15 16/17] drm/amd/display: Properly handle additional cases where DCN is not supported

2023-02-09 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 6fc547a5a2ef5ce05b16924106663ab92f8f87a7 ] There could be boards with DCN listed in IP discovery, but no display hardware actually wired up. In this case the vbios display table will not be populated. Detect this case and skip loading DM when we detect it.

[PATCH AUTOSEL 6.1 35/38] drm/amd/display: Properly handle additional cases where DCN is not supported

2023-02-09 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 6fc547a5a2ef5ce05b16924106663ab92f8f87a7 ] There could be boards with DCN listed in IP discovery, but no display hardware actually wired up. In this case the vbios display table will not be populated. Detect this case and skip loading DM when we detect it.

[PATCH AUTOSEL 6.1 34/38] drm/amdgpu: Enable vclk dclk node for gc11.0.3

2023-02-09 Thread Sasha Levin
From: Yiqing Yao [ Upstream commit ac7170082c0e140663f0853d3de733a5341ce7b0 ] These sysfs nodes are tested supported, so enable them. Signed-off-by: Yiqing Yao Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 -

[PATCH AUTOSEL 6.1 33/38] drm/amdgpu: enable HDP SD for gfx 11.0.3

2023-02-09 Thread Sasha Levin
From: Evan Quan [ Upstream commit bb25849c0fa550b26cecc9c476c519a927c66898 ] Enable HDP clock gating control for gfx 11.0.3. Signed-off-by: Evan Quan Reviewed-by: Feifei Xu Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/soc21.c | 3 ++- 1 file changed

[PATCH AUTOSEL 6.1 32/38] drm/amd/display: Reset DMUB mailbox SW state after HW reset

2023-02-09 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 154711aa5759ef9b45903124fa813c4c29ee681c ] [Why] Otherwise we can be out of sync with what's in the hardware, leading to us rerunning every command that's presently in the ringbuffer. [How] Reset software state for the mailboxes in hw_reset callback.

[PATCH AUTOSEL 6.1 31/38] drm/amd/display: Unassign does_plane_fit_in_mall function from dcn3.2

2023-02-09 Thread Sasha Levin
From: George Shen [ Upstream commit 275d8a1db261a1272a818d40ebc61b3b865b60e5 ] [Why] The hwss function does_plane_fit_in_mall not applicable to dcn3.2 asics. Using it with dcn3.2 can result in undefined behaviour. [How] Assign the function pointer to NULL. Reviewed-by: Alvin Lee Acked-by: Ale

[PATCH AUTOSEL 6.1 30/38] drm/amd/display: Adjust downscaling limits for dcn314

2023-02-09 Thread Sasha Levin
From: Daniel Miess [ Upstream commit dd2db2dc4bd298f33dea50c80c3c11bee4e3b0a4 ] [Why] Lower max_downscale_ratio and ARGB888 downscale factor to prevent cases where underflow may occur on dcn314 [How] Set max_downscale_ratio to 400 and ARGB downscale factor to 250 for dcn314 Reviewed-by: Nichol

[PATCH AUTOSEL 6.1 29/38] drm/amd/display: Add missing brackets in calculation

2023-02-09 Thread Sasha Levin
From: Daniel Miess [ Upstream commit ea062fd28f922cb118bfb33229f405b81aff7781 ] [Why] Brackets missing in the calculation for MIN_DST_Y_NEXT_START [How] Add missing brackets for this calculation Reviewed-by: Nicholas Kazlauskas Acked-by: Alex Hung Signed-off-by: Daniel Miess Tested-by: Dani

Re: [PATCH] drm/amdgpu/display: remove duplicate include header in link_dpms.c

2023-02-09 Thread Jani Nikula
On Thu, 09 Feb 2023, wrote: > From: Ye Xingchen > > link_hwss.h is included more than once. You've got U+00A0 non-breaking space in the subject line. BR, Jani. > > Signed-off-by: Ye Xingchen > --- > drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 1 - > 1 file changed, 1 deletion(-) > > di

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-09 Thread Pekka Paalanen
On Wed, 8 Feb 2023 16:49:31 +0200 Ville Syrjälä wrote: > On Wed, Feb 08, 2023 at 11:18:42AM +0200, Pekka Paalanen wrote: > > On Fri, 3 Feb 2023 16:02:51 +0200 > > Ville Syrjälä wrote: > > > > > On Fri, Feb 03, 2023 at 02:52:50PM +0100, Sebastian Wick wrote: > > > > On Fri, Feb 3, 2023 at 2:

Re: [regression][6.0] After commit b261509952bc19d1012cf732f853659be6ebc61e I see WARNING message at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x63/0x70

2023-02-09 Thread Mikhail Gavrilov
Harry, please don't ignore me. This issue still happens in 6.1 and 6.2 Leo you are the author of the problematic commit please don't stand aside. Really nobody is interested in clean logs without warnings and errors? I am 100% sure that reverting commit b261509952bc19d1012cf732f853659be6ebc61e will

[PATCH] drm/amdgpu/display: remove duplicate include header in link_dpms.c

2023-02-09 Thread ye.xingchen
From: Ye Xingchen link_hwss.h is included more than once. Signed-off-by: Ye Xingchen --- drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c index 9

Re: [PATCH 2/2] drm/amd/display: minor cleanup of vm_setup

2023-02-09 Thread Christian König
Am 09.02.23 um 05:46 schrieb Alex Deucher: Use fb_start/end for consistency with gmc code for non- XGMI systems, they are equivalent to vram_start/end. Signed-off-by: Alex Deucher Acked-by: Christian König --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++--- 1 file changed,

Re: [PATCH 1/2] drm/amdgpu/gmc11: fix system aperture set when AGP is enabled

2023-02-09 Thread Christian König
Am 09.02.23 um 05:46 schrieb Alex Deucher: Need to cover both FB and AGP apertures. Fixes: c6eafee038ed ("Revert "Revert "drm/amdgpu/gmc11: enable AGP aperture""") Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c | 4 ++-- drivers/gp