Re: [PATCH 2/2] drm/amdgpu: Synchronize after mapping into a compute VM

2023-02-27 Thread Christian König
Am 25.02.23 um 00:36 schrieb Felix Kuehling: Compute VMs use user mode queues for command submission. They cannot use a CS ioctl to synchronize with pending PTE updates and flush TLBs. Do this synchronization in amdgpu_gem_va_ioctl for compute VMs. Signed-off-by: Felix Kuehling --- drivers/gp

[PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread Yuanzhi Wang
When the laptop is plugged into AC or DC power supply, the brightness obtained ACPI may be smaller than current brightness.As a result the screen becomes dark,this is not what people want. Signed-off-by: Yuanzhi Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 9 - 1 file changed, 8 i

[PATCH v3 1/2] drm/edid: parse DRM VESA dsc bpp target

2023-02-27 Thread Yaroslav Bolyukin
As per DisplayID v2.0 Errata E9 spec "DSC pass-through timing support" VESA vendor-specific data block may contain target DSC bits per pixel fields Signed-off-by: Yaroslav Bolyukin --- drivers/gpu/drm/drm_edid.c | 38 + include/drm/drm_connector.h | 6 ++

[PATCH v3 2/2] drm/amd: use fixed dsc bits-per-pixel from edid

2023-02-27 Thread Yaroslav Bolyukin
VESA vendor header from DisplayID spec may contain fixed bit per pixel rate, it should be respected by drm driver Signed-off-by: Yaroslav Bolyukin Reviewed-by: Wayne Lin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 ++ drivers/gpu/drm/amd/display/dc/core/dc_stream.c

[PATCH v3] drm/edid DSC pass-through timing support

2023-02-27 Thread Yaroslav Bolyukin
VESA DisplayID spec allows the device to force its DSC bits per pixel value. For example, the HTC Vive Pro 2 VR headset uses this value in high-resolution modes (3680x1836@90-120, 4896x2448@90-120), and when the kernel doesn't respect this parameter, the garbage is displayed on HMD instead. I am

[bug report] drm/amd/display: Various logs added

2023-02-27 Thread Dan Carpenter
Hello Leo Chen, This is a semi-automatic email about new static checker warnings. The patch 7ef414375fcc: "drm/amd/display: Various logs added" from Aug 29, 2022, leads to the following Smatch complaint: ./drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c:1862 get_firmware_info_v3_2()

[PATCH] drm/amdgpu: make umc_v8_10_convert_error_address static

2023-02-27 Thread Jiapeng Chong
This symbol is not used outside of umc_v8_10.c, so marks it static. drivers/gpu/drm/amd/amdgpu/umc_v8_10.c:212:6: warning: no previous prototype for function 'umc_v8_10_convert_error_address'. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4230 Signed-off-by: Jiap

Re: [PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread kernel test robot
Hi Yuanzhi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.2 next-20230227] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: amdgpu didn't start with pci=nocrs parameter, get error "Fatal error during GPU init"

2023-02-27 Thread Christian König
Am 24.02.23 um 17:21 schrieb Mikhail Gavrilov: On Fri, Feb 24, 2023 at 8:31 PM Christian König wrote: Sorry I totally missed that you attached the full dmesg to your original mail. Yeah, the driver did fail gracefully. But then X doesn't come up and then gdm just dies. Are you sure that these

Re: [PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread kernel test robot
Hi Yuanzhi, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.2 next-20230227] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

Re: [PATCH 2/6] drm/amdgpu: Implement a new userqueue fence driver

2023-02-27 Thread Christian König
Am 26.02.23 um 17:54 schrieb Arunpravin Paneer Selvam: Developed a userqueue fence driver for the userqueue process shared BO synchronization. Create a dma fence having write pointer as the seqno and allocate a seq64 memory for each user queue process and feed this memory address into the firmwa

Re: [PATCH 4/6] drm/amdgpu: UAPI headers for userqueue Secure semaphore

2023-02-27 Thread Christian König
Am 26.02.23 um 17:54 schrieb Arunpravin Paneer Selvam: - Add UAPI header support for userqueue Secure semaphore v2: (Christian) - Add bo handles,bo flags and padding fields. - Include value/va in a combined array. Signed-off-by: Alex Deucher Signed-off-by: Arunpravin Paneer S

Re: [PATCH 5/6] drm/amdgpu: Implement userqueue signal/wait IOCTL functions

2023-02-27 Thread Christian König
Am 26.02.23 um 17:54 schrieb Arunpravin Paneer Selvam: This patch introduces new IOCTL for userqueue secure semaphore. The signal IOCTL called from userspace application creates a drm syncobj and array of bo GEM handles and passed in as parameter to the driver to install the fence into it. The

Re: [PATCH 5/6] drm/amdgpu: Implement userqueue signal/wait IOCTL functions

2023-02-27 Thread Arunpravin Paneer Selvam
Hi Christian, On 2/27/2023 6:29 PM, Christian König wrote: Am 26.02.23 um 17:54 schrieb Arunpravin Paneer Selvam: This patch introduces new IOCTL for userqueue secure semaphore. The signal IOCTL called from userspace application creates a drm syncobj and array of bo GEM handles and passed in

Re: [PATCH 5/6] drm/amdgpu: Implement userqueue signal/wait IOCTL functions

2023-02-27 Thread Christian König
Hi Arun, Am 27.02.23 um 14:20 schrieb Arunpravin Paneer Selvam: Hi Christian, On 2/27/2023 6:29 PM, Christian König wrote: Am 26.02.23 um 17:54 schrieb Arunpravin Paneer Selvam: This patch introduces new IOCTL for userqueue secure semaphore. The signal IOCTL called from userspace applicatio

Re: [PATCH 5/6] drm/amdgpu: Implement userqueue signal/wait IOCTL functions

2023-02-27 Thread Arunpravin Paneer Selvam
On 2/27/2023 6:53 PM, Christian König wrote: Hi Arun, Am 27.02.23 um 14:20 schrieb Arunpravin Paneer Selvam: Hi Christian, On 2/27/2023 6:29 PM, Christian König wrote: Am 26.02.23 um 17:54 schrieb Arunpravin Paneer Selvam: This patch introduces new IOCTL for userqueue secure semaphore.

Re: [PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread kernel test robot
Hi Yuanzhi, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.2 next-20230227] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

[linux-next:master] BUILD REGRESSION 7f7a8831520f12a3cf894b0627641fad33971221

2023-02-27 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 7f7a8831520f12a3cf894b0627641fad33971221 Add linux-next specific files for 20230227 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202302111601.jty4lkra-...@intel.com https

Re: [PATCH v3 1/2] drm/edid: parse DRM VESA dsc bpp target

2023-02-27 Thread Jani Nikula
On Sun, 26 Feb 2023, Yaroslav Bolyukin wrote: > As per DisplayID v2.0 Errata E9 spec "DSC pass-through timing support" > VESA vendor-specific data block may contain target DSC bits per pixel > fields > > Signed-off-by: Yaroslav Bolyukin > --- > drivers/gpu/drm/drm_edid.c | 38 ++

Re: [PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread Mario Limonciello
On 2/27/23 01:39, Yuanzhi Wang wrote: When the laptop is plugged into AC or DC power supply, the brightness obtained ACPI may be smaller than current brightness.As a result the screen becomes dark,this is not what people want. Do you have a matching bug report with more information included?

[PATCH] drm/amdgpu: fix return value check in kfd

2023-02-27 Thread Shashank Sharma
From: Shashank Sharma This patch fixes a return value check in kfd doorbell handling. This function should return 0(error) only when the ida_simple_get returns < 0(error), return > 0 is a success case. Cc: Felix Kuehling Cc: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd

RE: [PATCH 00/20] DC Patches Feb 27th, 2023

2023-02-27 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x12

Re: [PATCH] drm/amdgpu: fix return value check in kfd

2023-02-27 Thread Christian König
Am 27.02.23 um 15:52 schrieb Shashank Sharma: From: Shashank Sharma This patch fixes a return value check in kfd doorbell handling. This function should return 0(error) only when the ida_simple_get returns < 0(error), return > 0 is a success case. Cc: Felix Kuehling Cc: Alex Deucher Signed-o

Re: [PATCH 2/2] drm/amdgpu: Synchronize after mapping into a compute VM

2023-02-27 Thread Felix Kuehling
On 2023-02-27 04:42, Christian König wrote: Am 25.02.23 um 00:36 schrieb Felix Kuehling: Compute VMs use user mode queues for command submission. They cannot use a CS ioctl to synchronize with pending PTE updates and flush TLBs. Do this synchronization in amdgpu_gem_va_ioctl for compute VMs. Si

Re: [PATCH v3 1/2] drm/edid: parse DRM VESA dsc bpp target

2023-02-27 Thread Harry Wentland
On 2/26/23 09:10, Yaroslav Bolyukin wrote: > As per DisplayID v2.0 Errata E9 spec "DSC pass-through timing support" > VESA vendor-specific data block may contain target DSC bits per pixel > fields > According to the errata this should only apply to VII timings. The way it is currently implemen

Re: [PATCH v3 1/2] drm/edid: parse DRM VESA dsc bpp target

2023-02-27 Thread Jani Nikula
On Mon, 27 Feb 2023, Harry Wentland wrote: > On 2/26/23 09:10, Yaroslav Bolyukin wrote: >> As per DisplayID v2.0 Errata E9 spec "DSC pass-through timing support" >> VESA vendor-specific data block may contain target DSC bits per pixel >> fields >> > > According to the errata this should only appl

Re: [PATCH v3 2/2] drm/amd: use fixed dsc bits-per-pixel from edid

2023-02-27 Thread Harry Wentland
On 2/26/23 09:10, Yaroslav Bolyukin wrote: > VESA vendor header from DisplayID spec may contain fixed bit per pixel > rate, it should be respected by drm driver > This will apply the fixed bpp for all modes. I don't think that's right. It should apply only to VII timings. Harry > Signed-off-by:

Re: [PATCH v3 1/2] drm/edid: parse DRM VESA dsc bpp target

2023-02-27 Thread Harry Wentland
On 2/27/23 12:12, Jani Nikula wrote: > On Mon, 27 Feb 2023, Harry Wentland wrote: >> On 2/26/23 09:10, Yaroslav Bolyukin wrote: >>> As per DisplayID v2.0 Errata E9 spec "DSC pass-through timing support" >>> VESA vendor-specific data block may contain target DSC bits per pixel >>> fields >>> >>

Re: [PATCH] drm/amdgpu: fix return value check in kfd

2023-02-27 Thread Felix Kuehling
On 2023-02-27 09:52, Shashank Sharma wrote: From: Shashank Sharma This patch fixes a return value check in kfd doorbell handling. This function should return 0(error) only when the ida_simple_get returns < 0(error), return > 0 is a success case. Cc: Felix Kuehling Cc: Alex Deucher Signed-off

Re: [PATCH v3 1/2] drm/edid: parse DRM VESA dsc bpp target

2023-02-27 Thread Jani Nikula
On Mon, 27 Feb 2023, Harry Wentland wrote: > On 2/27/23 12:12, Jani Nikula wrote: >> On Mon, 27 Feb 2023, Harry Wentland wrote: >>> On 2/26/23 09:10, Yaroslav Bolyukin wrote: As per DisplayID v2.0 Errata E9 spec "DSC pass-through timing support" VESA vendor-specific data block may conta

[PATCH v2 1/1] drm/doc: Document DRM device reset expectations

2023-02-27 Thread André Almeida
Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Signed-off-by: André Almeida --- Documentation/gpu/drm-uapi.rst | 51 ++ 1 file changed, 51 insertions(+) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentat

[PATCH v2 0/1] drm: Add doc about GPU reset

2023-02-27 Thread André Almeida
Hi, Thanks everyone that gave feedback. v2 Changes: - This new version is a section of drm-uapi instead of a new file - Drop requirement for KMD to kill applications - Drop role of init systems on compositors recover - Drop assumption that robust apps creates new contexts Original cover letter be

Re: [bug][vaapi][h264] The commit 7cbe08a930a132d84b4cf79953b00b074ec7a2a7 on certain video files leads to problems with VAAPI hardware decoding.

2023-02-27 Thread Alex Deucher
+ Felix On Fri, Feb 17, 2023 at 4:50 PM Mikhail Gavrilov wrote: > > On Fri, Feb 17, 2023 at 8:30 PM Alex Deucher wrote: > > > > On Fri, Feb 17, 2023 at 1:10 AM Mikhail Gavrilov > > wrote: > > > > > > On Fri, Dec 9, 2022 at 7:37 PM Leo Liu wrote: > > > > > > > > Please try the latest AMDGPU dr

[PATCH] drm/amdkfd: Cal vram offset in page for each svm_migrate_copy_to_vram

2023-02-27 Thread Xiaogang . Chen
From: Xiaogang Chen svm_migrate_ram_to_vram migrate a prange from sys ram to vram. The prange may cross multiple vma. Need remember current dst vram offset in page for each migration. Signed-off-by: Xiaogang Chen --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 17 ++--- 1 file chan

Re: [PATCH] drm/amdkfd: Cal vram offset in page for each svm_migrate_copy_to_vram

2023-02-27 Thread Felix Kuehling
On 2023-02-27 18:07, Xiaogang.Chen wrote: From: Xiaogang Chen svm_migrate_ram_to_vram migrate a prange from sys ram to vram. The prange may cross multiple vma. Need remember current dst vram offset in page for each migration. Good catch. It's not the offset in the page, but the offset in the

[PATCH v2 0/3] Adjust dGPU handling for BACO

2023-02-27 Thread Mario Limonciello
This series adjusts the handling for dGPUs when the system is going into s2idle. The intent is to match the following truth table below: +---+--+--+-+ | | s2idle (no FADT)

[PATCH v2 1/3] drm/amd: Allow dGPUs that support BACO to use smart suspend

2023-02-27 Thread Mario Limonciello
If a dGPU is already runtime suspended using BACO, there is no point to waking it up to run regular suspend callbacks. Cc: Peter Kopec Signed-off-by: Mario Limonciello --- v1->v2: * Simplify prepare call --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 32 - 1 file changed

[PATCH v2 3/3] drm/amd: Add special handling for system s0ix state w/ dGPUs

2023-02-27 Thread Mario Limonciello
With dGPUs that support BACO or BOCO we want them to go into those states when the system goes to s2idle. Detect that the system will be targeting this state and force the call into runtime suspend. If the runtime suspend call fails for any reason, then fallback to standard suspend flow. Signed-

[PATCH v2 2/3] drm/amd: Don't always set s3 for dGPUs in all sleep modes

2023-02-27 Thread Mario Limonciello
dGPUs that will be using BACO or BOCO shouldn't be put into S3 when the system is being put into s2idle. Cc: Peter Kopec Signed-off-by: Mario Limonciello --- v1->v2: * Whitespace --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --

RE: [PATCH v2 0/3] Adjust dGPU handling for BACO

2023-02-27 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Mario Limonciello > Sent: Tuesday, February 28, 2023 12:43 PM > To: amd-gfx@lists.freedesktop.org > Cc: Peter Kopec ; Limonciello, Mario > > Subject: [PATCH v2 0/3] Adjust dGPU handling for BACO > >

RE: [PATCH v2 3/3] drm/amd: Add special handling for system s0ix state w/ dGPUs

2023-02-27 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Mario Limonciello > Sent: Tuesday, February 28, 2023 12:43 PM > To: amd-gfx@lists.freedesktop.org > Cc: Peter Kopec ; Limonciello, Mario > > Subject: [PATCH v2 3/3] drm/amd: Add special handling for s

Re: [PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread wangyuanzhi
Hello, I have fixed compilation errors. The lenovo ThinkBook 14 G3 ACL notebook bios reports very small brightness value, 3 eg. On 2023/2/27 22:20, Mario Limonciello wrote: On 2/27/23 01:39, Yuanzhi Wang wrote: When the laptop is plugged into AC or DC power supply, the brightness obtained ACPI

[PATCH v2] amdgpu: add a filter condition when set brightness

2023-02-27 Thread Yuanzhi Wang
There is a lenovo ThinkBook 14 G3 ACL notebook, when the laptop is plugged into AC power supply, the brightness obtained ACPI may be smaller than current brightness.As a result the screen becomes dark,this is not what people want. So we should add So we should filter out very small brightness value