Re: [PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-17 Thread Felix Kuehling
On 2023-03-17 16:04, Sider, Graham wrote: [AMD Official Use Only - General] -Original Message- From: Russell, Kent Sent: Friday, March 17, 2023 3:58 PM To: Mahfooz, Hamza ; Sider, Graham ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: RE: [PATCH] drm/amdgpu: add print f

Re: [PATCH 36/37] drm/amd/display/dc/link/link_detection: Demote a couple of kerneldoc abuses

2023-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 17, 2023 at 4:24 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:877: warning: > Function parameter or member 'link' not described in > 'detect_link_and_local_sink' >

Re: [PATCH 35/37] drm/amd/display/dc/dce60/Makefile: Fix previous attempt to silence known override-init warnings

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:21: > note: in expansion of macro ‘mmCRTC1_DCFE_MEM_LIGHT_SLEEP_CNTL’ > drivers/gpu/drm/amd/amdgpu/../

Re: [PATCH 33/37] drm/amd/display/dc/link/protocols/link_dp_capability: Demote non-compliant kerneldoc

2023-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c:2190: > warning: Function parameter or member 'link' not described in > 'dc_link_is_

Re: [PATCH 32/37] drm/amd/display/dc/link/protocols/link_dp_capability: Remove unused variable and mark another as __maybe_unused

2023-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > ‘ds_port’ is clearly not used anywhere and ‘result_write_min_hblank’ is > only utilised when debugging is enabled. The alternative would be to > allocate the variable under the same clause as the debugging code, but > t

Re: [PATCH 30/37] drm/amd/display/dc/link/protocols/link_dp_training: Remove set but unused variable 'result'

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_training.c: > In function ‘perform_link_training_with_retries’: > > drivers/gpu/drm/amd/amdgpu/../display

Re: [PATCH 29/37] drm/amd/display/dc/link/link_detection: Remove unused variable 'status'

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c: In function > ‘query_hdcp_capability’: > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:50

Re: [PATCH 28/37] drm/amd/display/dc/core/dc_stat: Convert a couple of doc headers to kerneldoc format

2023-03-17 Thread Alex Deucher
On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.c:38: warning: Cannot > understand > * > drivers/gpu/drm/

Re: [PATCH 27/37] drm/amd/display/dc/dce/dmub_psr: Demote kerneldoc abuse

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:257: warning: This > comment starts with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/ke

Re: [PATCH 26/37] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef

2023-03-17 Thread Alex Deucher
On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:48:22: > warning: ‘SYNAPTICS_DEVICE_ID’ defined but not used [-Wunused-const-variable=] CONFIG_DRM_AMD_DC_DCN was recentl

Re: [PATCH 20/37] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move defines out to where they are actually used

2023-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h: At top > level: > drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:143:22: >

Re: [PATCH 19/37] drm/amd/pm/swsmu/smu11/vangogh_ppt: Provide a couple of missing parameter descriptions

2023-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:2381: warning: > Function parameter or member 'residency' not described in > 'vangogh_get_gfxoff_residenc

Re: [PATCH 18/37] drm/amd/amdgpu/amdgpu_vce: Provide description for amdgpu_vce_validate_bo()'s 'p' param

2023-03-17 Thread Alex Deucher
Applied with minor modification. Thanks! Alex On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:599: warning: Function parameter or > member 'p' not described in 'amdgpu_vce_validate_bo' > > Cc: Al

Re: [PATCH 17/37] drm/amd/amdgpu/amdgpu_mes: Ensure amdgpu_bo_create_kernel()'s return value is checked

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c: In function > ‘amdgpu_mes_ctx_alloc_meta_data’: > drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c:1099:13: warning: variable ‘r’ set > b

Re: [PATCH 16/37] drm/amd/amdgpu/ih_v6_0: Repair misspelling and provide descriptions for 'ih'

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/ih_v6_0.c:392: warning: Function parameter or > member 'ih' not described in 'ih_v6_0_get_wptr' > drivers/gpu/drm/amd/amdgpu/ih_v6_0.c:432: war

Re: [PATCH 15/37] drm/amd/amdgpu/gmc_v11_0: Provide a few missing param descriptions relating to hubs and flushes

2023-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c:282: warning: Function parameter or > member 'vmhub' not described in 'gmc_v11_0_flush_gpu_tlb' > drivers/gpu/drm/amd/amdgpu/

Re: [PATCH 14/37] drm/amd/amdgpu/amdgpu_vm_pt: Supply description for amdgpu_vm_pt_free_dfs()'s unlocked param

2023-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:683: warning: Function parameter > or member 'unlocked' not described in 'amdgpu_vm_pt_free_dfs' > > Cc: Alex Deucher > Cc

Re: [PATCH 13/37] drm/amd/amdgpu/amdgpu_ucode: Remove unused function ‘amdgpu_ucode_print_imu_hdr’

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:22 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:129:6: warning: no previous > prototype for ‘amdgpu_ucode_print_imu_hdr’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc: "Chri

Re: [PATCH 03/37] drm/amd/amdgpu/amdgpu_device: Provide missing kerneldoc entry for 'reset_context'

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:22 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5152: >warning: Function parameter or member 'reset_context' not described in > 'amdgpu_device_gpu_recover' > > Cc: Alex Deu

Re: [PATCH 01/37] drm/amd/display/dc/dc_hdmi_types: Move string definition to the only file it's used in

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:22 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dc_hdmi_types.h:53:22: >warning: ‘dp_hdmi_dongle_signature_str’ defined but not used > [-Wunused-const-variable=] > > [snipped

RE: [PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-17 Thread Sider, Graham
[AMD Official Use Only - General] > -Original Message- > From: Russell, Kent > Sent: Friday, March 17, 2023 3:58 PM > To: Mahfooz, Hamza ; Sider, Graham > ; amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix > Subject: RE: [PATCH] drm/amdgpu: add print for iommu translation mode > >

RE: [PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-17 Thread Russell, Kent
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Hamza > Mahfooz > Sent: Friday, March 17, 2023 3:58 PM > To: Sider, Graham ; amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix > Subject: Re: [PATCH] drm/amdgpu: add print for iommu translation mode >

Re: [PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-17 Thread Hamza Mahfooz
On 3/17/23 15:47, Graham Sider wrote: Add log to display whether RAM is direct vs DMA mapped. Signed-off-by: Graham Sider If this information is only useful for debugging purposes, please use drm_dbg() instead of pr_info(). --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +- 1 f

[PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-17 Thread Graham Sider
Add log to display whether RAM is direct vs DMA mapped. Signed-off-by: Graham Sider --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c ind

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Ville Syrjälä
On Fri, Mar 17, 2023 at 07:47:52PM +0100, Sebastian Wick wrote: > On Fri, Mar 17, 2023 at 7:38 PM Ville Syrjälä > wrote: > > > > On Fri, Mar 17, 2023 at 06:40:53PM +0100, Sebastian Wick wrote: > > > On Fri, Mar 17, 2023 at 5:34 PM Ville Syrjälä > > > wrote: > > > > > > > > On Fri, Mar 17, 2023 at

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Sebastian Wick
On Fri, Mar 17, 2023 at 7:38 PM Ville Syrjälä wrote: > > On Fri, Mar 17, 2023 at 06:40:53PM +0100, Sebastian Wick wrote: > > On Fri, Mar 17, 2023 at 5:34 PM Ville Syrjälä > > wrote: > > > > > > On Fri, Mar 17, 2023 at 05:37:51PM +0200, Pekka Paalanen wrote: > > > > On Fri, 17 Mar 2023 16:14:38 +0

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Ville Syrjälä
On Fri, Mar 17, 2023 at 06:40:53PM +0100, Sebastian Wick wrote: > On Fri, Mar 17, 2023 at 5:34 PM Ville Syrjälä > wrote: > > > > On Fri, Mar 17, 2023 at 05:37:51PM +0200, Pekka Paalanen wrote: > > > On Fri, 17 Mar 2023 16:14:38 +0200 > > > Ville Syrjälä wrote: > > > > > > > On Fri, Mar 17, 2023 a

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-17 Thread Linus Torvalds
On Wed, Mar 15, 2023 at 5:22 PM Steven Rostedt wrote: > > I hope that this gets in by -rc3, as I want to start basing my next branch > on that tag. My tree should have it now as commit c00133a9e87e ("drm/ttm: drop extra ttm_bo_put in ttm_bo_cleanup_refs"). Linus

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Sebastian Wick
On Fri, Mar 17, 2023 at 5:34 PM Ville Syrjälä wrote: > > On Fri, Mar 17, 2023 at 05:37:51PM +0200, Pekka Paalanen wrote: > > On Fri, 17 Mar 2023 16:14:38 +0200 > > Ville Syrjälä wrote: > > > > > On Fri, Mar 17, 2023 at 03:35:53PM +0200, Pekka Paalanen wrote: > > > > On Fri, 17 Mar 2023 14:50:40 +

[PATCH 10/10] drm/amdgpu: bump driver version number for CP GFX shadow

2023-03-17 Thread Alex Deucher
So UMDs can determine whether the kernel supports this. Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21986 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdg

[PATCH 09/10] drm/amdgpu: add support for new GFX shadow size query

2023-03-17 Thread Alex Deucher
Use the new callback to fetch the data. Return an error if not supported. UMDs should use this query to check whether shadow buffers are supported and if so what size they should be. v2: return an error rather than a zerod structure. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/

[PATCH 08/10] drm/amdgpu: add get_gfx_shadow_info callback for gfx11

2023-03-17 Thread Alex Deucher
XXX: don't apply this until we get the final FW versions Used to get the size and alignment requirements for the gfx shadow buffer for preemption. v2: use FW version check to determine whether to return a valid size here return an error if not supported (Alex) Signed-off-by: Alex Deucher

[PATCH 04/10] drm/amdgpu: add gfx11 emit shadow callback

2023-03-17 Thread Alex Deucher
From: Christian König Add ring callback for gfx to update the CP firmware with the new shadow information before we process the IB. v2: add implementation for new packet (Alex) v3: add current FW version checks (Alex) v4: only initialize shadow on first use Only set IB_VMID when a valid shad

[PATCH 07/10] drm/amdgpu: add gfx shadow callback

2023-03-17 Thread Alex Deucher
To provide IP specific shadow sizes. UMDs will use this to query the kernel driver for the size of the shadow buffers. v2: make callback return an int (Alex) Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 12 1 file changed, 12 insertions(+) diff --git

[PATCH 06/10] drm/amdgpu: don't require a job for cond_exec and shadow

2023-03-17 Thread Alex Deucher
We need to reset the shadow state every time we submit an IB and there needs to be a COND_EXEC packet after the SET_Q_PREEMPTION_MODE packet for it to work properly, so we should emit both of these packets regardless of whether there is a job present or not. Signed-off-by: Alex Deucher --- drive

[PATCH 05/10] drm/amdgpu/gfx11: make job optional in emit_gfx_shadow

2023-03-17 Thread Alex Deucher
We need to emit this packet any time we emit an IB, not just when we have a job. When no job is present just send all 0's to reset to the legacy state. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 34 +- 1 file changed, 23 insertions(+), 11 de

[PATCH 01/10] drm/amdgpu: add UAPI to query GFX shadow sizes

2023-03-17 Thread Alex Deucher
Add UAPI to query the GFX shadow buffer requirements for preemption on GFX11. UMDs need to specify the shadow areas for preemption. Signed-off-by: Alex Deucher --- include/uapi/drm/amdgpu_drm.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/uapi/drm/amdgpu_drm.h b/inclu

[PATCH 02/10] drm/amdgpu/UAPI: add new CS chunk for GFX shadow buffers

2023-03-17 Thread Alex Deucher
For GFX11, the UMD needs to allocate some shadow buffers to be used for preemption. The UMD allocates the buffers and passes the GPU virtual address to the kernel since the kernel will program the packet that specified these addresses as part of its IB submission frame. Signed-off-by: Alex Deuche

[PATCH 03/10] drm/amdgpu: add gfx shadow CS IOCTL support

2023-03-17 Thread Alex Deucher
From: Christian König Add support for submitting the shadow update packet when submitting an IB. Needed for MCBP on GFX11. v2: update API for CSA (Alex) v3: fix ordering; SET_Q_PREEMPTION_MODE most come before COND_EXEC Add missing check for AMDGPU_CHUNK_ID_CP_GFX_SHADOW in amdgpu_cs_pa

[PATCH 00/10] Enable FW assisted shadowing for GFX11

2023-03-17 Thread Alex Deucher
This patch set allows for FW assisted shadowing on supported platforms. A new enough CP FW is required. This feature is required for mid command buffer preemption and proper SR-IOV support. This also simplifies the UMDs by allowing persistent hardware state when the command submission executes.

[pull] amdgpu, amdkfd, radeon, UAPI drm-next-6.4

2023-03-17 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 6.4. The following changes since commit 424b3d7582a2a4a7c45d405225ac70cff97f2e4a: drm/amd/pm: downgrade log level upon SMU IF version mismatch (2023-02-23 17:35:59 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Ville Syrjälä
On Fri, Mar 17, 2023 at 05:37:51PM +0200, Pekka Paalanen wrote: > On Fri, 17 Mar 2023 16:14:38 +0200 > Ville Syrjälä wrote: > > > On Fri, Mar 17, 2023 at 03:35:53PM +0200, Pekka Paalanen wrote: > > > On Fri, 17 Mar 2023 14:50:40 +0200 > > > Ville Syrjälä wrote: > > > > > > > On Fri, Mar 17, 2

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Pekka Paalanen
On Fri, 17 Mar 2023 16:14:38 +0200 Ville Syrjälä wrote: > On Fri, Mar 17, 2023 at 03:35:53PM +0200, Pekka Paalanen wrote: > > On Fri, 17 Mar 2023 14:50:40 +0200 > > Ville Syrjälä wrote: > > > > > On Fri, Mar 17, 2023 at 10:53:35AM +0200, Pekka Paalanen wrote: > > > > On Fri, 17 Mar 2023 01:

[linux-next:master] BUILD REGRESSION 6f08c1de13a9403341c18b66638a05588b2663ce

2023-03-17 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 6f08c1de13a9403341c18b66638a05588b2663ce Add linux-next specific files for 20230317 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202303081807.lblwkmpx-...@intel.com https

Re: [PATCH] drm/amdgpu: Adding CAP firmware initialization

2023-03-17 Thread Alex Deucher
On Thu, Mar 16, 2023 at 4:36 AM Bill Liu wrote: > > Added CAP firmware initialization for PSP v13.0.10 under > psp_init_sriov_microcode > > Signed-off-by: Bill Liu Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-17 Thread Alex Deucher
On Thu, Mar 16, 2023 at 7:09 PM Stefano Stabellini wrote: > > On Thu, 16 Mar 2023, Juergen Gross wrote: > > On 16.03.23 14:53, Alex Deucher wrote: > > > On Thu, Mar 16, 2023 at 9:48 AM Juergen Gross wrote: > > > > > > > > On 16.03.23 14:45, Alex Deucher wrote: > > > > > On Thu, Mar 16, 2023 at 3:

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Ville Syrjälä
On Fri, Mar 17, 2023 at 03:35:53PM +0200, Pekka Paalanen wrote: > On Fri, 17 Mar 2023 14:50:40 +0200 > Ville Syrjälä wrote: > > > On Fri, Mar 17, 2023 at 10:53:35AM +0200, Pekka Paalanen wrote: > > > On Fri, 17 Mar 2023 01:01:38 +0200 > > > Ville Syrjälä wrote: > > > > > > > On Thu, Mar 16, 2

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Joshua Ashton
On 3/17/23 13:35, Pekka Paalanen wrote: On Fri, 17 Mar 2023 14:50:40 +0200 Ville Syrjälä wrote: On Fri, Mar 17, 2023 at 10:53:35AM +0200, Pekka Paalanen wrote: On Fri, 17 Mar 2023 01:01:38 +0200 Ville Syrjälä wrote: On Thu, Mar 16, 2023 at 10:13:54PM +0100, Sebastian Wick wrote: On

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Pekka Paalanen
On Fri, 17 Mar 2023 14:50:40 +0200 Ville Syrjälä wrote: > On Fri, Mar 17, 2023 at 10:53:35AM +0200, Pekka Paalanen wrote: > > On Fri, 17 Mar 2023 01:01:38 +0200 > > Ville Syrjälä wrote: > > > > > On Thu, Mar 16, 2023 at 10:13:54PM +0100, Sebastian Wick wrote: > > > > On Thu, Mar 16, 2023 at

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-17 Thread Roger Pau Monné
On Thu, Mar 16, 2023 at 04:09:44PM -0700, Stefano Stabellini wrote: > On Thu, 16 Mar 2023, Juergen Gross wrote: > > On 16.03.23 14:53, Alex Deucher wrote: > > > On Thu, Mar 16, 2023 at 9:48 AM Juergen Gross wrote: > > > > > > > > On 16.03.23 14:45, Alex Deucher wrote: > > > > > On Thu, Mar 16, 20

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Ville Syrjälä
On Fri, Mar 17, 2023 at 10:53:35AM +0200, Pekka Paalanen wrote: > On Fri, 17 Mar 2023 01:01:38 +0200 > Ville Syrjälä wrote: > > > On Thu, Mar 16, 2023 at 10:13:54PM +0100, Sebastian Wick wrote: > > > On Thu, Mar 16, 2023 at 1:35 PM Ville Syrjälä > > > wrote: > > > > > > > > On Thu, Mar 16, 202

RE: [PATCH] drm/amdgpu: Adding CAP firmware initialization

2023-03-17 Thread Liu, Monk
[AMD Official Use Only - General] Reviewed-by: Monk Liu Thanks --- Monk Liu | Cloud GPU & Virtualization Software | AMD --- -Original Message- From: amd-gfx

Re: [PATCH 00/10] drm/radeon: Convert fbdev to DRM client

2023-03-17 Thread Thomas Zimmermann
Hi Christian Am 17.03.23 um 09:53 schrieb Christian König: Am 16.03.23 um 10:37 schrieb Thomas Zimmermann: Convert radeon's fbdev code to drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. Only build fbdev support if the config option has been set

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Pekka Paalanen
On Fri, 17 Mar 2023 01:01:38 +0200 Ville Syrjälä wrote: > On Thu, Mar 16, 2023 at 10:13:54PM +0100, Sebastian Wick wrote: > > On Thu, Mar 16, 2023 at 1:35 PM Ville Syrjälä > > wrote: > > > > > > On Thu, Mar 16, 2023 at 01:34:49PM +0200, Pekka Paalanen wrote: > > > > On Thu, 16 Mar 2023 12:47

Re: [PATCH 00/10] drm/radeon: Convert fbdev to DRM client

2023-03-17 Thread Christian König
Am 16.03.23 um 10:37 schrieb Thomas Zimmermann: Convert radeon's fbdev code to drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. Only build fbdev support if the config option has been set. I'm torn apart on that. On the one hand it looks like a r

[PATCH 36/37] drm/amd/display/dc/link/link_detection: Demote a couple of kerneldoc abuses

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:877: warning: Function parameter or member 'link' not described in 'detect_link_and_local_sink' drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:877: warning: Function

[PATCH 35/37] drm/amd/display/dc/dce60/Makefile: Fix previous attempt to silence known override-init warnings

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:21: note: in expansion of macro ‘mmCRTC1_DCFE_MEM_LIGHT_SLEEP_CNTL’ drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.h:170:9: note: in expansion of macro ‘SRI’ driver

[PATCH 33/37] drm/amd/display/dc/link/protocols/link_dp_capability: Demote non-compliant kerneldoc

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c:2190: warning: Function parameter or member 'link' not described in 'dc_link_is_dp_sink_present' Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Alex Deucher

[PATCH 32/37] drm/amd/display/dc/link/protocols/link_dp_capability: Remove unused variable and mark another as __maybe_unused

2023-03-17 Thread Lee Jones
‘ds_port’ is clearly not used anywhere and ‘result_write_min_hblank’ is only utilised when debugging is enabled. The alternative would be to allocate the variable under the same clause as the debugging code, but that would become very messy, very quickly. Fixes the following W=1 kernel build warn

[PATCH 29/37] drm/amd/display/dc/link/link_detection: Remove unused variable 'status'

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c: In function ‘query_hdcp_capability’: drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:501:42: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]

[PATCH 30/37] drm/amd/display/dc/link/protocols/link_dp_training: Remove set but unused variable 'result'

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_training.c: In function ‘perform_link_training_with_retries’: drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_training.c:1586:38: warning: variable ‘result’ set but

[PATCH 28/37] drm/amd/display/dc/core/dc_stat: Convert a couple of doc headers to kerneldoc format

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.c:38: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.c:76: warning: Cannot un

[PATCH 27/37] drm/amd/display/dc/dce/dmub_psr: Demote kerneldoc abuse

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:257: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Alex Deu

[PATCH 26/37] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:48:22: warning: ‘SYNAPTICS_DEVICE_ID’ defined but not used [-Wunused-const-variable=] Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Alex Deucher Cc: "Christian König

[PATCH 19/37] drm/amd/pm/swsmu/smu11/vangogh_ppt: Provide a couple of missing parameter descriptions

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:2381: warning: Function parameter or member 'residency' not described in 'vangogh_get_gfxoff_residency' drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:2399: warning: Functio

[PATCH 20/37] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move defines out to where they are actually used

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h: At top level: drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:143:22: warning: ‘SYNAPTICS_DEVICE_ID’ defined but not used [-Wunused-const-variable=] d

[PATCH 18/37] drm/amd/amdgpu/amdgpu_vce: Provide description for amdgpu_vce_validate_bo()'s 'p' param

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:599: warning: Function parameter or member 'p' not described in 'amdgpu_vce_validate_bo' Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc

[PATCH 17/37] drm/amd/amdgpu/amdgpu_mes: Ensure amdgpu_bo_create_kernel()'s return value is checked

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c: In function ‘amdgpu_mes_ctx_alloc_meta_data’: drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c:1099:13: warning: variable ‘r’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König"

[PATCH 16/37] drm/amd/amdgpu/ih_v6_0: Repair misspelling and provide descriptions for 'ih'

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/ih_v6_0.c:392: warning: Function parameter or member 'ih' not described in 'ih_v6_0_get_wptr' drivers/gpu/drm/amd/amdgpu/ih_v6_0.c:432: warning: Function parameter or member 'ih' not described in 'ih_v6_0_irq_rearm' d

[PATCH 14/37] drm/amd/amdgpu/amdgpu_vm_pt: Supply description for amdgpu_vm_pt_free_dfs()'s unlocked param

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:683: warning: Function parameter or member 'unlocked' not described in 'amdgpu_vm_pt_free_dfs' Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Se

[PATCH 15/37] drm/amd/amdgpu/gmc_v11_0: Provide a few missing param descriptions relating to hubs and flushes

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c:282: warning: Function parameter or member 'vmhub' not described in 'gmc_v11_0_flush_gpu_tlb' drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c:282: warning: Function parameter or member 'flush_type' not described in

[PATCH 13/37] drm/amd/amdgpu/amdgpu_ucode: Remove unused function ‘amdgpu_ucode_print_imu_hdr’

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:129:6: warning: no previous prototype for ‘amdgpu_ucode_print_imu_hdr’ [-Wmissing-prototypes] Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@l

[PATCH 03/37] drm/amd/amdgpu/amdgpu_device: Provide missing kerneldoc entry for 'reset_context'

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5152: warning: Function parameter or member 'reset_context' not described in 'amdgpu_device_gpu_recover' Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter

[PATCH 01/37] drm/amd/display/dc/dc_hdmi_types: Move string definition to the only file it's used in

2023-03-17 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dc_hdmi_types.h:53:22: warning: ‘dp_hdmi_dongle_signature_str’ defined but not used [-Wunused-const-variable=] [snipped 400 similar lines for brevity] Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siquei