Re: [PATCH] drm/amd/pm: remove unused num_of_active_display variable

2023-04-08 Thread Nick Desaulniers
On Fri, Mar 31, 2023 at 9:40 AM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:1700:6: error: variable > 'num_of_active_display' set but not used [-Werror,-Wunused-but-set-variable] > int num_of_active_display = 0; > ^ > This v

Re: [PATCH] drm/amd/display: remove unused matching_stream_ptrs variable

2023-04-08 Thread Nick Desaulniers
Jimmy, can you review? The change LGTM; but I'm not sure if there was something else intended here. On Sat, Mar 25, 2023 at 6:45 AM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:625:6: error: > variable 'matching_stream_ptrs' set bu

[PATCH] drm/amd/display: set variables aperture_default_system and context0_default_system storage-class-specifier to static

2023-04-08 Thread Tom Rix
smatch reports drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:758:10: warning: symbol 'aperture_default_system' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:759:10: warning: symbol 'context0_default_system' was not declared. S

[PATCH] drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static

2023-04-08 Thread Tom Rix
smatch reports drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:100:37: warning: symbol 'dcn3_14_soc' was not declared. Should it be static? This variable is only used in one file so should be static. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314

Re: [PATCH] drm/amd/display: remove unused matching_stream_ptrs variable

2023-04-08 Thread Nick Desaulniers
On Fri, Apr 7, 2023 at 10:52 AM Nick Desaulniers wrote: > > Jimmy, can you review? > > The change LGTM; but I'm not sure if there was something else intended here. Nevermind, Jimmy's email address bounced. Reviewed-by: Nick Desaulniers > > On Sat, Mar 25, 2023 at 6:45 AM Tom Rix wrote: > > > >

NULL pointer dereference in drm_dp_add_payload_part2+0xca/0x100

2023-04-08 Thread Jeff Layton
I've hit some repeated crashes in drm_dp_add_payload_part2. Here's one from this morning that occurred not long after booting the machine. I hadn't even logged in yet -- it was still at a gdm prompt: Apr 08 05:34:20 tleilax kernel: amdgpu :30:00.0: [drm] Failed to create MST payload for port