Hi Dave, Daniel,
Fixes for 6.4.
The following changes since commit 7877cb91f1081754a1487c144d85dc0d2e2e7fc4:
Linux 6.4-rc4 (2023-05-28 07:49:00 -0400)
are available in the Git repository at:
https://gitlab.freedesktop.org/agd5f/linux.git
tags/amd-drm-fixes-6.4-2023-05-31
for you to
On Wed, May 31, 2023 at 9:26 AM Alex Deucher wrote:
>
> On Tue, May 30, 2023 at 6:34 PM Mario Limonciello
> wrote:
> >
> > commit cf488dcd0ab7 ("drm/amd: Allow s0ix without BIOS support") showed
> > improvements to power consumption over suspend when s0ix wasn't enabled in
> > BIOS and the
Fulfill the interfaces for OD settings retrieving and setting.
Signed-off-by: Evan Quan
---
.../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 445 --
1 file changed, 402 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
Fulfill the interfaces for OD settings retrieving and setting.
Signed-off-by: Evan Quan
---
.../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 445 --
1 file changed, 402 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
Gfxclk fmin/fmax, Uclk fmin/fmax and Gfx v/f curve voltage offset
OD settings are supported for SMU13.
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c| 26 +++-
.../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 13 +-
.../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c |
Correct the data structures for OD feature support.
Signed-off-by: Evan Quan
---
.../gpu/drm/amd/pm/inc/smu_v13_0_0_pptable.h | 16 +-
.../inc/pmfw_if/smu13_driver_if_v13_0_0.h | 18 +++-
.../inc/pmfw_if/smu13_driver_if_v13_0_7.h | 29 ---
Enable the following OD features support for SMU13:
- Maxinum and minimum gfxclk frequency settings
- Maxinum and minimum uclk frequency settings
- Voltage offset settings for gfxclk v/f curve line
- This is quite different from previous generations/ASICs. For SMU13,
there are six anchor
To acquire the voltage and current info from gpu_metrics interface,
but gpu_metrics_v2_3 doesn't contain them, and to be backward compatible,
add new gpu_metrics_v2_4 structure.
Acked-by: Evan Quan
Signed-off-by: Wenyou Yang
---
.../gpu/drm/amd/include/kgd_pp_interface.h| 69 +++
[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Wednesday, May 31, 2023 2:15 PM
> To: Kuehling, Felix
> Cc: Kim, Jonathan ; amd-
> g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Huang, JinHuiEric
>
> Subject: Re: [PATCH 01/33] drm/amdkfd: add debug and runtime
On Thu, Mar 30, 2023 at 12:04 PM Kim, Jonathan wrote:
>
> [Public]
>
> Hi Felix,
>
> That is correct. The debugger will need sq_int_priv to work.
I'll just apply this for now. We can squash the revert into the
debugger changes once those land.
Alex
>
> Thanks,
>
> Jon
>
> > -Original
Am 2023-05-31 um 14:10 schrieb Srinivasan Shanmugam:
Fixes the following gcc with W=1:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:1841: warning: Function
parameter or member 'event' not described in 'svm_range_evict'
Cc: Felix Kuehling
Cc: Christian König
Cc: Alex Deucher
On Tue, May 30, 2023 at 3:17 PM Felix Kuehling wrote:
>
> Am 2023-05-25 um 13:27 schrieb Jonathan Kim:
> > Introduce the GPU debug operations interface.
> >
> > For ROCm-GDB to extend the GNU Debugger's ability to inspect the AMD GPU
> > instruction set, provide the necessary interface to allow
Reviewed-by: Alex Deucher
On Thu, May 25, 2023 at 1:29 PM Srinivasan Shanmugam
wrote:
>
> Fix these warnings by deleting the deviant arguments.
>
> gcc with W=1
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:799: warning: Excess function
> parameter 'pcie_index' description in
Fixes the following gcc with W=1:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:1841: warning: Function
parameter or member 'event' not described in 'svm_range_evict'
Cc: Felix Kuehling
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
Reviewed-by: Alex Deucher
On Tue, May 30, 2023 at 2:49 PM Srinivasan Shanmugam
wrote:
>
> Fix this warning by adding 'ring' arguments to kdoc.
>
> gcc with W=1
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1128: warning: Function parameter or
> member 'ring' not described in 'sdma_v6_0_ring_pad_ib'
Fixes the following W=1 kernel build warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_resource.c:128:29:
warning: ‘DCN_BASE’ defined but not used [-Wunused-const-variable=]
128 | static const struct IP_BASE DCN_BASE = { { { { 0x0012, 0x00C0,
0x34C0, 0x9000,
On 5/31/23 16:01, Alex Deucher wrote:
> On Mon, May 29, 2023 at 5:45 AM Michel Dänzer wrote:
>>
>> On 4/12/23 03:23, Zhang, Jesse(Jie) wrote:
>>>
>>> Due to raven/raven2 maybe enable sclk slow down,
>>> they cannot get clock count by the RLC at the auto level of dpm
>>> performance.
>>>
This flag was never meant for user mode. Alex ended up implementing it
differently in a way that doesn't need to change the flags exposed to
user mode. See his patch "drm/amdkfd: flag added to handle errors from
svm validate and map". This patch is no longer needed.
Regards,
Felix
Am
Reviewed-by: Aurabindo Pillai
On 5/31/23 05:22, Srinivasan Shanmugam wrote:
> Fixes the following W=1 kernel build warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c:97:
> warning: Cannot understand *
>
Reviewed-by: Aurabindo Pillai
On 5/31/23 01:11, Srinivasan Shanmugam wrote:
> Fixes the following gcc with W=1:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1904:
> warning: Function parameter or member 'dc' not described in
> 'delay_cursor_until_vupdate'
>
Reviewed-by: Aurabindo Pillai
On 5/30/23 23:52, Srinivasan Shanmugam wrote:
> Fixes the following W=1 kernel build warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_hubbub.c:45: warning:
> Cannot understand * @DCN32_CRB_SEGMENT_SIZE_KB: Maximum Configurable Return
> Buffer
This reverts commit f57a74f5b42d1627bd5366f88952d42819e91146.
After talking this over with Christian, the original programming
sequence was correct. The enable bit needs to be set before
programming the rest of the context.
Signed-off-by: Alex Deucher
Cc: Zibin Liu
---
On Wed, May 31, 2023 at 10:20 AM Mario Limonciello
wrote:
>
> On 5/31/23 08:26, Alex Deucher wrote:
> > On Tue, May 30, 2023 at 6:34 PM Mario Limonciello
> > wrote:
> >>
> >> commit cf488dcd0ab7 ("drm/amd: Allow s0ix without BIOS support") showed
> >> improvements to power consumption over
On 5/31/23 08:26, Alex Deucher wrote:
On Tue, May 30, 2023 at 6:34 PM Mario Limonciello
wrote:
commit cf488dcd0ab7 ("drm/amd: Allow s0ix without BIOS support") showed
improvements to power consumption over suspend when s0ix wasn't enabled in
BIOS and the system didn't support S3.
This patch
Reviewed-by: Aurabindo Pillai
On 5/30/23 15:08, Srinivasan Shanmugam wrote:
> Fixes the following W=1 kernel build warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_vba.c:936: warning:
> Cannot understand *
>
[Public]
Where is the userspace code which uses this new interface? Can you add a link
to the relevant branch to the commit message?
Alex
From: amd-gfx on behalf of Alex Sierra
Sent: Monday, May 29, 2023 4:09 PM
To: amd-gfx@lists.freedesktop.org ; Kuehling,
[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Kamal, Asad
Sent: Wednesday, May 31, 2023 21:16
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Lazar, Lijo ;
Ma, Le ; Zhang, Morris ; Wang, Yang(Kevin)
Subject: [PATCH]
On Mon, May 29, 2023 at 5:45 AM Michel Dänzer wrote:
>
> On 4/12/23 03:23, Zhang, Jesse(Jie) wrote:
> >
> > Due to raven/raven2 maybe enable sclk slow down,
> > they cannot get clock count by the RLC at the auto level of dpm
> > performance.
> > So switch to golden tsc register.
>
>
On 5/31/2023 4:45 PM, Christian König wrote:
> Am 31.05.23 um 08:20 schrieb Chen, Guchun:
>> [Public]
>>
>>> -Original Message-
>>> From: amd-gfx On Behalf Of Ma
>>> Jun
>>> Sent: Wednesday, May 31, 2023 1:31 PM
>>> To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;
From: Sukrut Bellary
[ Upstream commit 60ecaaf54886b0642d5c4744f7fbf1ff0d6b3e42 ]
smatch warning -
1) drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:3615 gfx_v9_0_kiq_resume()
warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'.
2) drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:6901
From: Sukrut Bellary
[ Upstream commit 60ecaaf54886b0642d5c4744f7fbf1ff0d6b3e42 ]
smatch warning -
1) drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:3615 gfx_v9_0_kiq_resume()
warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'.
2) drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:6901
From: Sukrut Bellary
[ Upstream commit 60ecaaf54886b0642d5c4744f7fbf1ff0d6b3e42 ]
smatch warning -
1) drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:3615 gfx_v9_0_kiq_resume()
warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'.
2) drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:6901
From: Sukrut Bellary
[ Upstream commit 60ecaaf54886b0642d5c4744f7fbf1ff0d6b3e42 ]
smatch warning -
1) drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:3615 gfx_v9_0_kiq_resume()
warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'.
2) drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:6901
From: Sukrut Bellary
[ Upstream commit 60ecaaf54886b0642d5c4744f7fbf1ff0d6b3e42 ]
smatch warning -
1) drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:3615 gfx_v9_0_kiq_resume()
warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'.
2) drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:6901
Am 20.05.23 um 13:59 schrieb ghostfly233:
In gfxhub_v2_1_setup_vmid_config(), the GCVM_CONTEXT1_CNTL reg is
written before related GCVM_CONTEXT1_PAGE_TABLE_START_ADDR and
GCVM_CONTEXT1_PAGE_TABLE_END_ADDR regs are written, which may
cause undefined behavior.
In which hw documentation did you
On Tue, May 30, 2023 at 6:34 PM Mario Limonciello
wrote:
>
> commit cf488dcd0ab7 ("drm/amd: Allow s0ix without BIOS support") showed
> improvements to power consumption over suspend when s0ix wasn't enabled in
> BIOS and the system didn't support S3.
>
> This patch however was misguided because
From: Yang Wang
add unique serial number support for smu_v13_0_6.
(use aid0 serial number by default)
Signed-off-by: Yang Wang
Signed-off-by: Asad Kamal
Reviewed-by: Lijo Lazar
---
.../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 20 ---
1 file changed, 8 insertions(+), 12
From: Lijo Lazar
Keep throttle status indicator in SMUv13 power context
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h
From: Lijo Lazar
Instead of accumulated counters, PMFW will pass the throttle reason
along with throttle interrupt. Use that context information to report the
exact reason for throttling.
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
.../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c |
From: Lijo Lazar
Update PMFW interface headers to for new metrics table format and
throttling information.
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
.../inc/pmfw_if/smu13_driver_if_v13_0_6.h | 31 ++-
.../pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h | 13
[Public]
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Srinivasan
Shanmugam
Sent: Wednesday, May 31, 2023 5:22 AM
To: Pillai, Aurabindo ; Mahfooz, Hamza
; Siqueira, Rodrigo ;
Wentland, Harry
Cc: SHANMUGAM, SRINIVASAN ;
amd-gfx@lists.freedesktop.org
Am 31.05.23 um 11:34 schrieb Bob Zhou:
uvd ring in uvd_v7_0_sw_init only initializes ring in bare metal case,
so when executing amdgpu_uvd_resume to restore fence seq in SRIOV,
a null pointer dereference will occur. This patch correct this.
Mhm, taking a higher level look at this why isn't the
Reviewed-by: Alex Deucher
On Wed, May 31, 2023 at 8:12 AM Alex Deucher wrote:
>
> Sure. Please go ahead.
>
> Alex
>
> On Wed, May 31, 2023 at 5:54 AM Quan, Evan wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Alex,
> >
> > Can we land this as a temporary solution while we are
+ dri-devel
On Wed, May 31, 2023 at 12:01 AM Wayne Lin wrote:
>
> [Why]
> The sequence for collecting down_reply from source perspective should
> be:
>
> Request_n->repeat (get partial reply of Request_n->clear message ready
> flag to ack DPRX that the message is received) till all partial
>
On 30/05/2023 18:02, Thomas Zimmermann wrote:
Use the regular fbdev helpers for framebuffer I/O instead of DRM's
helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers
are mere wrappers around the fbdev code.
By using fbdev helpers directly within each DRM fbdev emulation,
we can
Sure. Please go ahead.
Alex
On Wed, May 31, 2023 at 5:54 AM Quan, Evan wrote:
>
> [AMD Official Use Only - General]
>
> Hi Alex,
>
> Can we land this as a temporary solution while we are seeking a more proper
> one?
> This is gating our customer and I was pushed for a solution.
>
> BR,
> Evan
[AMD Official Use Only - General]
Hi Alex,
Can we land this as a temporary solution while we are seeking a more proper one?
This is gating our customer and I was pushed for a solution.
BR,
Evan
> -Original Message-
> From: Quan, Evan
> Sent: Friday, April 21, 2023 3:32 PM
> To:
uvd ring in uvd_v7_0_sw_init only initializes ring in bare metal case,
so when executing amdgpu_uvd_resume to restore fence seq in SRIOV,
a null pointer dereference will occur. This patch correct this.
Fixes: 043f2271e2d0 ("drm/amdgpu: mark force completed fences with -ECANCELED")
BUG: kernel
Fixes the following W=1 kernel build warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c:97:
warning: Cannot understand *
**
[AMD Official Use Only - General]
Hi Christian,
Thanks for your suggestion. I will apply it and send out the v2 patch for
review.
Regards,
Bob
-Original Message-
From: Koenig, Christian
Sent: Wednesday, May 31, 2023 4:33 PM
To: Zhou, Bob ; amd-gfx@lists.freedesktop.org; Min, Frank
Am 31.05.23 um 08:20 schrieb Chen, Guchun:
[Public]
-Original Message-
From: amd-gfx On Behalf Of Ma
Jun
Sent: Wednesday, May 31, 2023 1:31 PM
To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Koenig,
Christian
Cc: Ma, Jun
Subject: [PATCH v2] drm/ttm: Remove
Am 31.05.23 um 06:48 schrieb Bob Zhou:
uvd ring in uvd_v7_0_sw_init only initializes ring in bare metal case,
so when executing amdgpu_uvd_resume to restore fence seq in SRIOV,
a null pointer dereference will occur. This patch correct this.
Ah! I was already wondering how this bug reports
On 5/31/2023 2:20 PM, Chen, Guchun wrote:
> [Public]
>
>> -Original Message-
>> From: amd-gfx On Behalf Of Ma
>> Jun
>> Sent: Wednesday, May 31, 2023 1:31 PM
>> To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Koenig,
>> Christian
>> Cc: Ma, Jun
>> Subject: [PATCH
[Public]
Thanks for your review, Christian. I have pushed them to amd-staging-drm-next
branch with Alex's Acked-by last week.
Regards,
Guchun
> -Original Message-
> From: Koenig, Christian
> Sent: Wednesday, May 31, 2023 2:39 PM
> To: Alex Deucher ; Chen, Guchun
>
> Cc:
As far as I know the "no S3 if SMT off" is just an oddity of the
particular BIOS I got on the "B550I AORUS PRO AX".
Also, what has changed that would prevent the same issue I was hitting
before?:
https://gitlab.freedesktop.org/drm/amd/-/issues/2364#note_1735422
Cheers,
Rafael
"Limonciello,
On Sun, May 28, 2023 at 02:26:37PM -0600, Gustavo A. R. Silva wrote:
> Zero-length and one-element arrays are deprecated, and we are moving
> towards adopting C99 flexible-array members, instead.
>
> Use the DECLARE_FLEX_ARRAY() helper macro to transform zero-length
> arrays in a union into
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:1036 kgd2kfd_interrupt()
warn: inconsistent indenting
Signed-off-by: Yang Li
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
If you haven't already pushed it: Reviewed-by: Christian König
for the entire series.
Thanks for looking into that,
Christian.
Am 22.05.23 um 16:47 schrieb Alex Deucher:
Series is:
Acked-by: Alex Deucher
On Thu, May 18, 2023 at 3:04 AM Guchun Chen wrote:
sched.ready is nothing with ring
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
> -Original Message-
> From: Bob Zhou
> Sent: Wednesday, May 31, 2023 12:48 PM
> To: amd-gfx@lists.freedesktop.org; Min, Frank ;
> Koenig, Christian
> Cc: Chen, Guchun ; Zhou, Bob
>
> Subject: [PATCH] drm/amdgpu: skip force complete
[Public]
> -Original Message-
> From: amd-gfx On Behalf Of Ma
> Jun
> Sent: Wednesday, May 31, 2023 1:31 PM
> To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Koenig,
> Christian
> Cc: Ma, Jun
> Subject: [PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields
60 matches
Mail list logo
