[PATCH] drm/amdgpu: expose num_hops and num_links xgmi info through dev attr

2023-06-07 Thread Shiwu Zhang
Add these two dev attrs for xgmi info details which is helpful for developers checking the xgmi topology by catting the sys file directly. Take 4 cards with xgmi connection as an example, get the num_hops for each device or node through xmig_hive_info dir like, cat /sys/bus/pci/devices/:41:00.

[PATCH v2] drm/amd/pm: enable more Pstates profile levels for yellow_carp

2023-06-07 Thread shikaguo
This patch enables following UMD stable Pstates profile levels for power_dpm_force_performance_level interface. - profile_peak - profile_min_mclk - profile_min_sclk - profile_standard Signed-off-by: shikaguo --- .../drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 94 ++- .../drm/am

Re: [PATCH 3/3] drm/amd/pm: enable more Pstates profile levels for SMU v13.0.4

2023-06-07 Thread Zhang, Yifan
[AMD Official Use Only - General] Series is: Reviewed-by: Yifan Zhang From: Huang, Tim Sent: Wednesday, June 7, 2023 4:02 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Liu, Aaron ; Guo, Shikai ; Huang, Tim Subject: [PATCH 3/

RE: [PATCH 2/2] drm/amd: Tighten permissions on VBIOS flashing attributes

2023-06-07 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Wednesday, June 7, 2023 1:53 AM > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario > Subject: [PATCH 2/2] drm/amd: Tighten permissions on VBIOS flashing > attributes > > Non-root users sho

RE: [PATCH v2 06/07] drm/amdgpu: add option params to enforce process isolation between graphics and compute

2023-06-07 Thread Yin, ZhenGuo (Chris)
[AMD Official Use Only - General] Hi Felix Yes. This patch is aiming to avoid concurrent running of kernel graphics queue and kernel compute queue. Previously we might get wrong guilty job if a bad compute job and a good gfx job submitted concurrently. Like Xorg might be crashed if we submitte

RE: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kuehling, Felix > Sent: Wednesday, June 7, 2023 6:23 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Huang, JinHuiEric > Subject: Re: [PATCH] drm/amdkfd: fix and enable debugging for gfx11 > > > On 2023-06-07 16:20, Jonathan Kim wrote: >

Re: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Felix Kuehling
On 2023-06-07 16:20, Jonathan Kim wrote: There are a couple of fixes required to enable gfx11 debugging. First, ADD_QUEUE.trap_en is an inappropriate place to toggle a per-process register so move it to SET_SHADER_DEBUGGER.trap_en. When ADD_QUEUE.skip_process_ctx_clear is set, MES will priorit

[pull] amdgpu, radeon drm-fixes-6.4

2023-06-07 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.4. The following changes since commit 9561de3a55bed6bdd44a12820ba81ec416e705a7: Linux 6.4-rc5 (2023-06-04 14:04:27 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.4-2023-06-07 for you to fetch

[PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Jonathan Kim
There are a couple of fixes required to enable gfx11 debugging. First, ADD_QUEUE.trap_en is an inappropriate place to toggle a per-process register so move it to SET_SHADER_DEBUGGER.trap_en. When ADD_QUEUE.skip_process_ctx_clear is set, MES will prioritize the SET_SHADER_DEBUGGER.trap_en setting.

RE: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kim, Jonathan > Sent: Wednesday, June 7, 2023 3:28 PM > To: Kuehling, Felix ; amd- > g...@lists.freedesktop.org > Cc: Huang, JinHuiEric > Subject: RE: [PATCH] drm/amdkfd: fix and enable debugging for gfx11 > > > > > -Original Message- > > From

[PATCH 2/2] drm/amd: Tighten permissions on VBIOS flashing attributes

2023-06-07 Thread Mario Limonciello
Non-root users shouldn't be able to try to trigger a VBIOS flash or query the flashing status. This should be reserved for users with the appropriate permissions. Fixes: 8424f2ccb3c0 ("drm/amdgpu/psp: Add vbflash sysfs interface support") Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciell

[PATCH 1/2] drm/amd: Make sure image is written to trigger VBIOS image update flow

2023-06-07 Thread Mario Limonciello
The VBIOS image update flow requires userspace to: 1) Write the image to `psp_vbflash` 2) Read `psp_vbflash` 3) Poll `psp_vbflash_status` to check for completion If userspace reads `psp_vbflash` before writing an image, it's possible that it causes problems that can put the dGPU into an invalid st

Re: [PATCH] drm/amdkfd: optimize gfx off enable toggle for debugging

2023-06-07 Thread Felix Kuehling
On 2023-06-07 13:32, Jonathan Kim wrote: Legacy debug devices limited to pinning a single debug VMID for debugging are the only devices that require disabling GFX OFF while accessing debug registers. Debug devices that support multi-process debugging rely on the hardware scheduler to update de

RE: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kuehling, Felix > Sent: Wednesday, June 7, 2023 2:20 PM > To: amd-gfx@lists.freedesktop.org; Kim, Jonathan > Cc: Huang, JinHuiEric > Subject: Re: [PATCH] drm/amdkfd: fix and enable debugging for gfx11 > > > On 2023-06-07 13:26, Jonathan Kim wrote: >

Re: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Felix Kuehling
On 2023-06-07 13:26, Jonathan Kim wrote: There are a few fixes required to enable gfx11 debugging. First, ADD_QUEUE.trap_en is an inappropriate place to toggle a per-process register so move it to SET_SHADER_DEBUGGER.trap_en. When ADD_QUEUE.skip_process_ctx_clear is set, MES will prioritize th

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-07 Thread Alex Deucher
On Wed, Jun 7, 2023 at 4:42 AM Felix Richter wrote: > > Hi Guys, > > so I checked, the kernel I am running has this commit > (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > /commit/?id=08da182175db4c7f80850354849d95f2670e8cd9) applied already! > > https://github.com/ju6ge/lin

Re: [PATCH v2 3/3] drm/amdkfd: don't sleep when event age unmatch

2023-06-07 Thread James Zhu
On 2023-06-07 13:27, Felix Kuehling wrote: On 2023-06-06 12:24, James Zhu wrote: Don't sleep when event age unmatch, and update last_event_age. It is only for KFD_EVENT_TYPE_SIGNAL which is checked by user space. Signed-off-by: James Zhu ---   drivers/gpu/drm/amd/amdkfd/kfd_events.c | 15 +++

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-07 Thread Pillai, Aurabindo
[Public] Thanks Michel. Do you see the issue if you force disable FAMS? The following diff should do: diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c index f4ee4b3df596..475c16aab518 100644 --- a/drivers/gpu/drm/amd/dis

RE: [PATCH] drm/amdkfd: optimize gfx off enable toggle for debugging

2023-06-07 Thread Kim, Jonathan
[Public] + Felix (typo on email) > -Original Message- > From: Kim, Jonathan > Sent: Wednesday, June 7, 2023 1:32 PM > To: amd-gfx@lists.freedesktop.org > Cc: felix.kuel...@amd.com; Huang, JinHuiEric ; > Kim, Jonathan > Subject: [PATCH] drm/amdkfd: optimize gfx off enable toggle for debu

RE: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Kim, Jonathan
[Public] + Felix (typo on email) > -Original Message- > From: Kim, Jonathan > Sent: Wednesday, June 7, 2023 1:27 PM > To: amd-gfx@lists.freedesktop.org > Cc: felix.kuel...@amd.com; Huang, JinHuiEric ; > Kim, Jonathan > Subject: [PATCH] drm/amdkfd: fix and enable debugging for gfx11 > >

[PATCH] drm/amdkfd: optimize gfx off enable toggle for debugging

2023-06-07 Thread Jonathan Kim
Legacy debug devices limited to pinning a single debug VMID for debugging are the only devices that require disabling GFX OFF while accessing debug registers. Debug devices that support multi-process debugging rely on the hardware scheduler to update debug registers and do not run into GFX OFF acc

Re: [PATCH v2 3/3] drm/amdkfd: don't sleep when event age unmatch

2023-06-07 Thread Felix Kuehling
On 2023-06-06 12:24, James Zhu wrote: Don't sleep when event age unmatch, and update last_event_age. It is only for KFD_EVENT_TYPE_SIGNAL which is checked by user space. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 15 +++ 1 file changed, 15 insertions(+

[PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Jonathan Kim
There are a few fixes required to enable gfx11 debugging. First, ADD_QUEUE.trap_en is an inappropriate place to toggle a per-process register so move it to SET_SHADER_DEBUGGER.trap_en. When ADD_QUEUE.skip_process_ctx_clear is set, MES will prioritize the SET_SHADER_DEBUGGER.trap_en setting. Secon

Re: [PATCH v2 1/3] drm/amdkfd: add event age tracking

2023-06-07 Thread James Zhu
On 2023-06-07 13:17, Felix Kuehling wrote: On 2023-06-06 12:24, James Zhu wrote: Add event age tracking Signed-off-by: James Zhu ---   include/uapi/linux/kfd_ioctl.h | 13 +++--   1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/kfd_ioctl.h b/include/

Re: [PATCH v2 1/3] drm/amdkfd: add event age tracking

2023-06-07 Thread Felix Kuehling
On 2023-06-06 12:24, James Zhu wrote: Add event age tracking Signed-off-by: James Zhu --- include/uapi/linux/kfd_ioctl.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux/kfd_ioctl.h index 1781e7669982..eeb2

[PATCH] drm/amdgpu: expand runpm parameter

2023-06-07 Thread Alex Deucher
Allow the user to specify -2 as auto enabled with displays. By default we don't enter runtime suspend when there are displays attached because it does not work well in some desktop environments due to the driver sending hotplug events on resume in case any new displays were attached while the GPU

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-07 Thread Michel Dänzer
On 6/6/23 20:01, Pillai, Aurabindo wrote: > > I'm attaching another DMCUB firmware which has the bug fix for the hang we > saw at our end and some added tracing enabled. Still runs into the newer hang when starting a KDE Plasma Wayland session. Should I try this for starting the game without th

[PATCH] drm/amdgpu/atomfirmware: fix DDR5 width reporting

2023-06-07 Thread Alex Deucher
DDR5 channels are 32 bit rather than 64, report the width properly in the log. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2468 Signed-off-by: Alex Deucher --- .../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 20 +-- 1 file changed, 14 insertions(+), 6 deletions(-) diff

[PATCH] drm/amdgpu/sdma4: set align mask to 255

2023-06-07 Thread Alex Deucher
The wptr needs to be incremented at at least 64 dword intervals, use 256 to align with windows. This should fix potential hangs with unaligned updates. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 4 ++-- 2 files c

Re: [PATCH 3/3] drm/amd/pm: enable more Pstates profile levels for SMU v13.0.4

2023-06-07 Thread Deucher, Alexander
[Public] Series is: Acked-by: Alex Deucher From: Huang, Tim Sent: Wednesday, June 7, 2023 4:02 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Liu, Aaron ; Guo, Shikai ; Huang, Tim Subject: [PATCH 3/3] drm/amd/pm: enable more Psta

Re: [PATCH] drm/amdgpu/mmsch: Correct the definition for mmsch init header

2023-06-07 Thread Deucher, Alexander
[AMD Official Use Only - General] Acked-by: Alex Deucher From: amd-gfx on behalf of Deng, Emily Sent: Tuesday, June 6, 2023 9:16 PM To: Deng, Emily ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu/mmsch: Correct the definition for mmsch init h

Re: [PATCH v6 00/13] Enable Colorspace connector property in amdgpu

2023-06-07 Thread Simon Ser
Thanks! All of the core DRM patches (1-6) are Reviewed-by: Simon Ser

Re: [PATCH] drm/amd/pm: enable more Pstates profile levels for yellow_carp

2023-06-07 Thread Alex Deucher
Acked-by: Alex Deucher On Wed, Jun 7, 2023 at 7:09 AM shikaguo wrote: > > This patch enables following UMD stable Pstates profile levels for > power_dpm_force_performance_level interface. > > - profile_peak > - profile_min_mclk > - profile_min_sclk > - profile_standard > > Signed-off-by: shikag

Re: [PATCH] drm/amdkfd: Fix reserved SDMA queues handling

2023-06-07 Thread Felix Kuehling
On 2023-06-07 11:27, Mukul Joshi wrote: This patch fixes a regression caused by a bad merge where the handling of reserved SDMA queues was accidentally removed. With the fix, the reserved SDMA queues are again correctly marked as unavailable for allocation. Fixes: c27842c84a848 ("drm/amdkfd: U

[PATCH] drm/amdkfd: Fix reserved SDMA queues handling

2023-06-07 Thread Mukul Joshi
This patch fixes a regression caused by a bad merge where the handling of reserved SDMA queues was accidentally removed. With the fix, the reserved SDMA queues are again correctly marked as unavailable for allocation. Fixes: c27842c84a848 ("drm/amdkfd: Update SDMA queue management for GFX9.4.3") S

[PATCH] drm/amdgpu: Raname DRM schedulers in amdgpu TTM

2023-06-07 Thread Mukul Joshi
Rename mman.entity to mman.high_pr to make the distinction clearer that this is a high priority scheduler. Similarly, rename the recently added mman.delayed to mman.low_pr to make it clear it is a low priority scheduler. No functional change in this patch. Signed-off-by: Mukul Joshi --- drivers/

[PATCH v6 12/13] drm/amd/display: Add debugfs for testing output colorspace

2023-06-07 Thread Harry Wentland
In order to IGT test colorspace we'll want to print the currently enabled colorspace on a stream. We add a new debugfs to do so, using the same scheme as current bpc reporting. This might also come in handy when debugging display issues. v4: - Fix function doc comment - Fix sRGB debug print Sign

[PATCH v6 13/13] drm/amd/display: Refactor avi_info_frame colorimetry determination

2023-06-07 Thread Harry Wentland
From: Joshua Ashton Replace the messy two if-else chains here that were on the same value with a switch on the enum. Signed-off-by: Joshua Ashton Signed-off-by: Harry Wentland Reviewed-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc

[PATCH v6 11/13] drm/amd/display: Always set crtcinfo from create_stream_for_sink

2023-06-07 Thread Harry Wentland
From: Joshua Ashton Given that we always pass dm_state into here now, this won't ever trigger anymore. This is needed for we will always fail mode validation with invalid clocks or link bandwidth errors. Signed-off-by: Joshua Ashton Signed-off-by: Harry Wentland Reviewed-by: Harry Wentland

[PATCH v6 10/13] drm/amd/display: Send correct DP colorspace infopacket

2023-06-07 Thread Harry Wentland
Look at connector->colorimetry to determine output colorspace. We don't want to impact current SDR behavior, so DRM_MODE_COLORIMETRY_DEFAULT preserves current behavior. Also add support to explicitly set BT601 and BT709. v4: - Roll support for BT709 and BT601 into this patch - Add default case t

[PATCH v6 07/13] drm/amd/display: Always pass connector_state to stream validation

2023-06-07 Thread Harry Wentland
We need the connector_state for colorspace and scaling information and can get it from connector->state. Signed-off-by: Harry Wentland Reviewed-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc: Simon Ser Cc: Melissa Wen Cc: dri-de...@l

[PATCH v6 05/13] drm/connector: Print connector colorspace in state debugfs

2023-06-07 Thread Harry Wentland
v3: Fix kerneldocs (kernel test robot) v4: Avoid returning NULL from drm_get_colorspace_name Signed-off-by: Harry Wentland Reviewed-by: Sebastian Wick Reviewed-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Ville Syrjälä Cc: Joshua A

[PATCH v6 06/13] drm/connector: Allow drivers to pass list of supported colorspaces

2023-06-07 Thread Harry Wentland
Drivers might not support all colorspaces defined in dp_colorspaces and hdmi_colorspaces. This results in undefined behavior when userspace is setting an unsupported colorspace. Allow drivers to pass the list of supported colorspaces when creating the colorspace property. v2: - Use 0 to indicate

[PATCH v6 09/13] drm/amd/display: Signal mode_changed if colorspace changed

2023-06-07 Thread Harry Wentland
We need to signal mode_changed to make sure we update the output colorspace. v2: No need to call drm_hdmi_avi_infoframe_colorimetry as DC does its own infoframe packing. Signed-off-by: Harry Wentland Reviewed-by: Leo Li Reviewed-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick Cc

[PATCH v6 08/13] drm/amd/display: Register Colorspace property for DP and HDMI

2023-06-07 Thread Harry Wentland
We want compositors to be able to set the output colorspace on DP and HDMI outputs, based on the caps reported from the receiver via EDID. Signed-off-by: Harry Wentland Reviewed-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc: Simon Ser

[PATCH v6 04/13] drm/connector: Use common colorspace_names array

2023-06-07 Thread Harry Wentland
We an use bitfields to track the support ones for HDMI and DP. This allows us to print colorspaces in a consistent manner without needing to know whether we're dealing with DP or HDMI. v4: - Rename _MAX to _COUNT and leave comment to indicate it's not a valid value - Fix misplaced function doc

[PATCH v6 03/13] drm/connector: Pull out common create_colorspace_property code

2023-06-07 Thread Harry Wentland
Signed-off-by: Harry Wentland Reviewed-by: Sebastian Wick Reviewed-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Ville Syrjälä Cc: Joshua Ashton Cc: Jani Nikula Cc: Simon Ser Cc: Ville Syrjälä Cc: Melissa Wen Cc: dri-de...@lists.

[PATCH v6 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-06-07 Thread Harry Wentland
From: Joshua Ashton To match the other enums, and add more information about these values. v2: - Specify where an enum entry comes from - Clarify DEFAULT and NO_DATA behavior - BT.2020 CYCC is "constant luminance" - correct type for BT.601 v4: - drop DP/HDMI clarifications that might create

[PATCH v6 00/13] Enable Colorspace connector property in amdgpu

2023-06-07 Thread Harry Wentland
This patchset is based on Joshua's previous patchset [1], as well as my previous patchset [2]. It is - enabling support for the colorspace property in amdgpu, as well as - allowing drivers to specify the supported set of colorspaces, and Colorspace, Infoframes, and YCbCr matrix --

[PATCH v6 01/13] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2023-06-07 Thread Harry Wentland
This allows us to use strongly typed arguments. v2: - Bring NO_DATA back - Provide explicit enum values v3: - Drop unnecessary '&' from kerneldoc (emersion) v4: - Fix Normal Colorimetry comment Signed-off-by: Harry Wentland Reviewed-by: Simon Ser Reviewed-by: Sebastian Wick Reviewed-by: Pe

RE: [PATCH] drm/amdkfd: fix vmfault signalling with additional data.

2023-06-07 Thread Joshi, Mukul
[AMD Official Use Only - General] Reviewed-by: Mukul Joshi > -Original Message- > From: Kim, Jonathan > Sent: Wednesday, June 7, 2023 10:39 AM > To: amd-gfx@lists.freedesktop.org > Cc: Joshi, Mukul ; Kuehling, Felix > ; Kim, Jonathan ; > Joshi, Mukul > Subject: [PATCH] drm/amdkfd: fix

[PATCH] drm/amdkfd: fix vmfault signalling with additional data.

2023-06-07 Thread Jonathan Kim
Exception handling for vmfaults should be raised with additional data. Reported-by: Mukul Joshi Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 34 +++-- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_

[PATCH] drm/amdgpu: Fix memcpy() in sienna_cichlid_append_powerplay_table function.

2023-06-07 Thread Srinivasan Shanmugam
Fixes the following gcc with W=1: In file included from ./include/linux/string.h:253, from ./include/linux/bitmap.h:11, from ./include/linux/cpumask.h:12, from ./arch/x86/include/asm/cpumask.h:5, from ./arch/x86/include/asm/msr.h:

Re: [PATCH v2 06/07] drm/amdgpu: add option params to enforce process isolation between graphics and compute

2023-06-07 Thread Felix Kuehling
I can't see the other patches in this series, so I'm missing some context. I don't understand what "process isolation between graphics and compute" means here. It seems to be unrelated to KFD compute. This patch seems to be mostly about handling of reserved VMIDs. Maybe you're trying to avoid r

Re: [PATCH] drm/amd/pm: enable more Pstates profile levels for yellow_carp

2023-06-07 Thread Huang, Tim
[AMD Official Use Only - General] Hi Shikai, Comments inline. From: Guo, Shikai Sent: Wednesday, June 7, 2023 7:07 PM To: amd-gfx@lists.freedesktop.org Cc: Liang, Prike ; Liu, Aaron ; Huang, Tim ; Guo, Shikai Subject: [PATCH] drm/amd/pm: enable more Pstates p

Re: [PATCH v2] drm/amdgpu: Increase hmm range get pages timeout

2023-06-07 Thread Felix Kuehling
Am 2023-06-06 um 18:53 schrieb Philip Yang: If hmm_range_fault returns -EBUSY, we should call hmm_range_fault again to validate the remaining pages. On one system with NUMA auto balancing enabled, hmm_range_fault takes 6 seconds for 1GB range because CPU migrate the range one page at a time. To

Re: [PATCH] drm/amdgpu: add missing radeon secondary PCI ID

2023-06-07 Thread Michel Dänzer
On 6/6/23 17:36, Alex Deucher wrote: > 0x5b70 is a missing RV370 secondary id. Add it so > we don't try and probe it with amdgpu. > > Cc: mic...@daenzer.net > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dr

RE: [PATCH] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-06-07 Thread Lin, Wayne
[AMD Official Use Only - General] Hi Lyude, Much appreciated! Will update and send out another version. Thanks, Wayne Lin > -Original Message- > From: Lyude Paul > Sent: Wednesday, June 7, 2023 6:03 AM > To: Lin, Wayne ; amd-gfx@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com;

[PATCH 20/20] drm/amd/display: 3.2.239

2023-06-07 Thread Stylon Wang
From: Aric Cyr This version brings along following fixes: - Improvement on eDP - PSR bug fixes - SubVP bug fixes - Improvements on pipe handling to address potential issues - Freesync bug fix - DPIA bug fix - Fix multi-display issues Acked-by: Stylon Wang Signed-off-by: Aric Cyr --- drivers/g

[PATCH 19/20] drm/amd/display: fix pixel rate update sequence

2023-06-07 Thread Stylon Wang
From: Dmytro Laktyushkin The k1/k2 pixel rate dividers in dccg should only be updated on stream enable and do not actually depend on whether odm combine is active. This removes an on flip update of these and fixes the calculate function to ignore odm status for dp steams. Acked-by: Stylon Wang

[PATCH 18/20] Revert "drm/amd/display: reallocate DET for dual displays with high pixel rate ratio"

2023-06-07 Thread Stylon Wang
From: Samson Tam Revert commit b957de69c4c8 ("drm/amd/display: reallocate DET for dual displays with high pixel rate ratio") [Why] Previously had modified DET allocation algorithm to allocate less DET segments for lower pixel rate display and more DET segments for higher pixel rate display. Bu

[PATCH 17/20] drm/amd/display: limit DPIA link rate to HBR3

2023-06-07 Thread Stylon Wang
From: Peichen Huang [Why] DPIA doesn't support UHBR, driver should not enable UHBR for dp tunneling [How] limit DPIA link rate to HBR3 Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Acked-by: Stylon Wang Signed-off-by: Peichen Huang Reviewed-by: Mustapha Ghaddar --- dri

[PATCH 16/20] drm/amd/display: Include CSC updates in new fast update path

2023-06-07 Thread Stylon Wang
From: Alvin Lee [Description] - Missed color / CSC updates in fast update path which caused Custom Color to break. - Add color / CSC updates to new fast update path to fix custom color Acked-by: Stylon Wang Signed-off-by: Alvin Lee Reviewed-by: Jun Lei --- .../drm/amd/display/dc/core/dc_

[PATCH 15/20] drm/amd/display: Limit Minimum FreeSync Refresh Rate

2023-06-07 Thread Stylon Wang
From: Austin Zheng Why: Some EDIDs report a minimum refresh rate lower than what HW can support How: Add a check to calculate minimum supported refresh rate with current timing and use that as the minimum if a lower one is passed in Acked-by: Stylon Wang Signed-off-by: Austin Zheng Reviewed-b

[PATCH 14/20] drm/amd/display: Bug fix in dcn315_populate_dml_pipes_from_context

2023-06-07 Thread Stylon Wang
From: Artem Grishin [Why] When iterating over all pipes in the loop, the CRB allocation algorithm may potentially skip some of the pipes. Previously, the current pipe index didn't get updated in this case, causing incorrect outcome. [How] Increment the pipe index when skipping over a pipe in the

[PATCH 13/20] Revert "drm/amd/display: Move DCN314 DOMAIN power control to DMCUB"

2023-06-07 Thread Stylon Wang
From: Daniel Miess Revert commit 6c2c207e4a24 ("drm/amd/display: Move DCN314 DOMAIN power control to DMCUB") [Why] Controling hubp power gating using the DMCUB isn't stable so we are reverting this change to move control back into the driver Acked-by: Stylon Wang Signed-off-by: Daniel Miess

[PATCH 12/20] drm/amd/display: Block SubVP + DRR if the DRR is PSR capable

2023-06-07 Thread Stylon Wang
From: Alvin Lee [Description] PSR implementation in FW has inline polling which can poll for up to 1ms. This will interfere with SubVP because SubVP is timing sensitive and can't tolerate up to 1ms worth of delay before handling vertical or VLINE interrupts. Therefore block SubVP + DRR cases if D

[PATCH 11/20] drm/amd/display: Do not disable phantom pipes in driver

2023-06-07 Thread Stylon Wang
From: Saaem Rizvi [Why and How] We should not disable phantom pipes in this sequence, as this should be controlled by FW. Furthermore, the previous programming sequence would have enabled the phantom pipe in driver as well, causing corruption. This change should avoid this from occuring. Cc: Mar

[PATCH 10/20] drm/amd/display: Re-enable SubVP high refresh

2023-06-07 Thread Stylon Wang
From: Alvin Lee Re-enable SubVP high refresh now that it is fixed for displays with high refresh rates. Acked-by: Stylon Wang Signed-off-by: Alvin Lee Reviewed-by: Saaem Rizvi --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn321/dcn321_res

[PATCH 09/20] drm/amd/display: Re-enable DPP/HUBP Power Gating

2023-06-07 Thread Stylon Wang
From: Daniel Miess [Why & How] Bugs preventing DPP/HUBP power gating have been addressed so this should be reenabled on dcn314 for sufficient hardware rev versions Acked-by: Stylon Wang Signed-off-by: Daniel Miess Reviewed-by: Nicholas Kazlauskas --- .../gpu/drm/amd/display/dc/dcn314/dcn314_

[PATCH 08/20] drm/amd/display: SubVP high refresh only if all displays >= 120hz

2023-06-07 Thread Stylon Wang
From: Alvin Lee [Description] - SubVP high refresh should only be enabled if all displays are >= 120hz. We do not want to accidentally enables configs such as 60hz[SubVP] + 120hz[SubVP] - Ensure that the SubVP config generation code does not produce configs such as 60hz[SubVP] + 120hz[SubVP

[PATCH 07/20] drm/amd/display: Fix disbling PSR slow response issue

2023-06-07 Thread Stylon Wang
From: Tom Chung [Why] dmub_psr_get_state() return an invalid PSR state while disable the PSR because convert_psr_state() doesn't recognize the state that return from DMCUB. [How] Add a PSR state to make the dmub_psr_get_state() return a correct PSR state. Acked-by: Stylon Wang Signed-off-by: T

[PATCH 06/20] drm/amd/display: fix the system hang while disable PSR

2023-06-07 Thread Stylon Wang
From: Tom Chung [Why] When the PSR enabled. If you try to adjust the timing parameters, it may cause system hang. Because the timing mismatch with the DMCUB settings. [How] Disable the PSR before adjusting timing parameters. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Ac

[PATCH 05/20] drm/amd/display: Promote DAL to 3.2.238

2023-06-07 Thread Stylon Wang
From: Aric Cyr Acked-by: Stylon Wang Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 7cf3e9510043..5c906b007e4d 100644 --- a/driv

[PATCH 04/20] drm/amd/display: Add Error Code for Dml Validation Failure

2023-06-07 Thread Stylon Wang
From: Fangzhi Zuo Any invalid mode from hw perspective should be given corresponding error code, otherwise it leads to confusing warning message "[drm] Mode Validation Warning: Validation OK failed validation." Acked-by: Stylon Wang Signed-off-by: Fangzhi Zuo Reviewed-by: Dmytro Laktyushkin -

[PATCH 03/20] drm/amd/display: Add DP2 Metrics

2023-06-07 Thread Stylon Wang
From: Austin Zheng Why: Log DP2 data to be used for debugging purposes How: Check the reported link rate of the DP connection and translate it to the DP version. Acked-by: Stylon Wang Signed-off-by: Austin Zheng Reviewed-by: Martin Leung --- drivers/gpu/drm/amd/display/dc/dc.h | 6

[PATCH 02/20] drm/amd/display: add debugfs for allow_edp_hotplug_detection

2023-06-07 Thread Stylon Wang
From: Hersen Wu [Why] within dc_link_detect, edp edid is read only for the first time and saved. edid will not be read after the first time read. to run edp edid read test, need read edp edid for each dc_link_detect. dc->config flag allow_edp_hotplug_detection could be used for edp edid test. [H

[PATCH 01/20] drm/amd/display: edp do not add non-edid timings

2023-06-07 Thread Stylon Wang
From: Hersen Wu [Why] most edp support only timings from edid. applying non-edid timings, especially those timings out of edp bandwidth, may damage edp. [How] do not add non-edid timings for edp. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Acked-by: Stylon Wang Signed-o

[PATCH 00/20] DC Patches June 9, 2023

2023-06-07 Thread Stylon Wang
This DC patchset brings improvements in multiple areas. In summary, we highlight: - Improvement on eDP - PSR bug fixes - SubVP bug fixes - Improvements on pipe handling to address potential issues - Freesync bug fix - DPIA bug fix - Fix multi-display issues Cc: Daniel Wheeler Alvin Lee (4):

Re: [PATCH v2 06/07] drm/amdgpu: add option params to enforce process isolation between graphics and compute

2023-06-07 Thread Christian König
Am 07.06.23 um 12:57 schrieb Chong Li: enforce process isolation between graphics and compute via using the same reserved vmid. v2: remove params "struct amdgpu_vm *vm" from amdgpu_vmid_alloc_reserved and amdgpu_vmid_free_reserved. Signed-off-by: Chong Li Reviewed-by: Christian König

[PATCH] drm/amd/pm: enable more Pstates profile levels for yellow_carp

2023-06-07 Thread shikaguo
This patch enables following UMD stable Pstates profile levels for power_dpm_force_performance_level interface. - profile_peak - profile_min_mclk - profile_min_sclk - profile_standard Signed-off-by: shikaguo --- .../drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 94 ++- .../drm/am

[PATCH v2 06/07] drm/amdgpu: add option params to enforce process isolation between graphics and compute

2023-06-07 Thread Chong Li
enforce process isolation between graphics and compute via using the same reserved vmid. v2: remove params "struct amdgpu_vm *vm" from amdgpu_vmid_alloc_reserved and amdgpu_vmid_free_reserved. Signed-off-by: Chong Li --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/a

Re: [PATCH] drm/amdgpu: display/Kconfig: replace leading spaces with tab

2023-06-07 Thread Sui Jingfeng
Hi, On 2023/6/7 17:09, Chen, Guchun wrote: [Public] It's https://gitlab.freedesktop.org/agd5f/linux/-/tree/amd-staging-drm-next?ref_type=heads. Latest patches including yours's will be pushed to this branch after a while. Now I know,  thanks for your kindness reply. Regards, Guchun

Re: [PATCH v5 04/13] drm/connector: Use common colorspace_names array

2023-06-07 Thread Simon Ser
On Tuesday, June 6th, 2023 at 22:25, Harry Wentland wrote: > + if (supported_colorspaces != 0 && (colorspaces & BIT(i)) == 0) This patch actually also introduces a change in behavior: passing no colorspace will make the function advertise all colorspaces. I have a hard time understa

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-07 Thread Felix Richter
Hi Guys, so I checked, the kernel I am running has this commit (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git /commit/?id=08da182175db4c7f80850354849d95f2670e8cd9) applied already! https://github.com/ju6ge/linux/commit/917680e6056aa288cac288d3afd2745d372beb61u And the bug

Re: [PATCH v5 06/13] drm/connector: Allow drivers to pass list of supported colorspaces

2023-06-07 Thread Simon Ser
On Tuesday, June 6th, 2023 at 22:26, Harry Wentland wrote: > -int drm_mode_create_hdmi_colorspace_property(struct drm_connector *connector) > +int drm_mode_create_hdmi_colorspace_property(struct drm_connector *connector, > + u32 supported_colorspaces) >

Re: [PATCH v5 04/13] drm/connector: Use common colorspace_names array

2023-06-07 Thread Simon Ser
On Tuesday, June 6th, 2023 at 22:25, Harry Wentland wrote: > We an use bitfields to track the support ones for HDMI Typo: "We can"

RE: [PATCH 0/3] Add GPU page fault query interface

2023-06-07 Thread Chen, Guchun
[Public] With the 3 nitpicks fixed in patch 1, the series are: Acked-by: Guchun Chen Regards, Guchun > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Tuesday, June 6, 2023 11:40 PM > To: Deucher, Alexander > Cc: samuel.pitoi...@gmail.com; amd-gfx@lists.freedes

RE: [PATCH 1/3] drm/amdgpu: add cached GPU fault structure to vm struct

2023-06-07 Thread Chen, Guchun
[Public] 3 nitpick comments. > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, May 26, 2023 12:52 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; > samuel.pitoi...@gmail.com > Subject: [PATCH 1/3] drm/amdgpu: add cached GPU fault structure

RE: [PATCH] drm/amdgpu: display/Kconfig: replace leading spaces with tab

2023-06-07 Thread Chen, Guchun
[Public] It's https://gitlab.freedesktop.org/agd5f/linux/-/tree/amd-staging-drm-next?ref_type=heads. Latest patches including yours's will be pushed to this branch after a while. Regards, Guchun > -Original Message- > From: amd-gfx On Behalf Of Sui > Jingfeng > Sent: Wednesday, June 7

[PATCH 2/3] drm/amd/pm: enable vclk and dclk Pstates for SMU v13.0.4

2023-06-07 Thread Tim Huang
Add the ability to control the vclk and dclk frequency by power_dpm_force_performance_level interface. Signed-off-by: Tim Huang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 29 +++ 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_

[PATCH 3/3] drm/amd/pm: enable more Pstates profile levels for SMU v13.0.4

2023-06-07 Thread Tim Huang
This patch enables following UMD stable Pstates profile levels for power_dpm_force_performance_level interface. - profile_peak - profile_min_mclk - profile_min_sclk - profile_standard Signed-off-by: Tim Huang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 54 ++- 1 file cha

[PATCH 1/3] drm/amd/pm: fix vclk setting failed for SMU v13.0.4

2023-06-07 Thread Tim Huang
PMFW use the left-shifted 16 bits argument to set the VCLK DPM frequency for SMU v13.0.4. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 2 ++ drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 11 +-- 2 files changed, 11 insertions(+), 2 deletio

[PATCH] drm/amdgpu: unmap and remove csa_va properly

2023-06-07 Thread Lang Yu
Root PD BO should be reserved before unmap and remove a bo_va from VM otherwise lockdep will complain. v2: check fpriv->csa_va is not NULL instead of amdgpu_mcbp (christian) [14616.936827] WARNING: CPU: 6 PID: 1711 at drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1762 amdgpu_vm_bo_del+0x399/0x3f0 [amd

[PATCH] drm/amdkfd: to fix cwsr hang issue

2023-06-07 Thread Ji, Ruili
From: Ruili Ji Starting from GC_11_0_4, flag trap_en should be enabled for trap handler. Signed-off-by: Ruili Ji Signed-off-by: Aaron Liu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git