RE: [PATCH] drm/amd/pm: Vangogh: Add new gpu_metrics_v2_4 to acquire gpu_metrics

2023-06-10 Thread Yang, WenYou
[AMD Official Use Only - General] Any comments? > -Original Message- > From: Wenyou Yang > Sent: Thursday, June 1, 2023 9:38 AM > To: Deucher, Alexander ; Limonciello, Mario > ; Koenig, Christian ; > Pan, Xinhui ; Quan, Evan > Cc: Yuan, Perry ; Liang, Richard qi > ;

RE: [PATCH] drm/amdgpu: Fix usage of UMC fill record in RAS

2023-06-10 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Tuikov, Luben Sent: Saturday, June 10, 2023 19:36 To: AMD Graphics Cc: Tuikov, Luben ; Zhou1, Tao ; Zhang, Hawking ; Deucher, Alexander Subject: [PATCH] drm/amdgpu: Fix usage of

[PATCH] drm/amdgpu: Fix usage of UMC fill record in RAS

2023-06-10 Thread Luben Tuikov
The fixed commit listed in the Fixes tag below, introduced a bug in amdgpu_ras.c::amdgpu_reserve_page_direct(), in that when introducing the new amdgpu_umc_fill_error_record() and internally in that new function the physical address (argument "uint64_t retired_page"--wrong name) is right-shifted

Re: [PATCH] drm/amdgpu: Wrap -Wunused-but-set-variable in cc-option

2023-06-10 Thread Jani Nikula
On Thu, 08 Jun 2023, Nathan Chancellor wrote: > -Wunused-but-set-variable was only supported in clang starting with > 13.0.0, so earlier versions will emit a warning, which is turned into a > hard error for the kernel to mirror GCC: > > error: unknown warning option '-Wunused-but-set-variable';

Re: [PATCH] drm/amd/amdgpu: enable W=1 for amdgpu

2023-06-10 Thread Jani Nikula
On Sat, 10 Jun 2023, Masahiro Yamada wrote: > On Sat, Jun 10, 2023 at 5:17 AM Nathan Chancellor wrote: >> >> + Masahiro and linux-kbuild >> >> On Fri, Jun 09, 2023 at 12:42:06PM -0400, Hamza Mahfooz wrote: >> > We have a clean build with W=1 as of >> > commit 12a15dd589ac