Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 14:29:23 +0200 Boris Brezillon wrote: > On Mon, 19 Jun 2023 12:44:06 +0200 > Christian König wrote: > > > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > > [SNIP] > > > Note that the drm_exec_until_all_locked() helper I introduced is taking > > > an expression, so in the

Re: [PATCH 06/13] drm/amdgpu: use the new drm_exec object for CS v2

2023-06-19 Thread Tatsuyuki Ishi
On 6/20/23 13:07, Tatsuyuki Ishi wrote: @@ -1296,9 +1271,8 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,    */   r = 0;   amdgpu_bo_list_for_each_userptr_entry(e, p->bo_list) { -    struct amdgpu_bo *bo = ttm_to_amdgpu_bo(e->tv.bo); - -    r |= !amdgpu_ttm_tt_get

Re: [PATCH 06/13] drm/amdgpu: use the new drm_exec object for CS v2

2023-06-19 Thread Tatsuyuki Ishi
+Boris and +Matthew in case you want to take over this patch set. Here are some review / testing comments, including those I posted before to ease tracking. On 5/4/23 20:51, Christian König wrote: Use the new component here as well and remove the old handling. v2: drop dupplicate handling S

[PATCH] drm/amd/pm: add abnormal fan detection for smu 13.0.0

2023-06-19 Thread Kenneth Feng
add abnormal fan detection for smu 13.0.0 Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c index a6

Re: [PATCH v6 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-19 Thread Sui Jingfeng
Hi, On 2023/6/20 02:12, Limonciello, Mario wrote: On 6/12/2023 2:25 PM, Sui Jingfeng wrote: From: Sui Jingfeng Deal only with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function with pci_get_class(). Filter the non-PCI display device(pdev->class != 0x0300) out. T

Re: [PATCH] drm/amdgpu: remove vm sanity check from amdgpu_vm_make_compute

2023-06-19 Thread Felix Kuehling
On 2023-06-19 17:28, Xiaogang.Chen wrote: From: Xiaogang Chen Since we allow kfd and graphic operate on same GPU VM to have interoperation between them GPU VM may have been used by graphic vm operations before kfd turns a GPU VM into a compute VM. Remove vm clean checking at amdgpu_vm_make_comp

[PATCH] drm/amdgpu: remove vm sanity check from amdgpu_vm_make_compute

2023-06-19 Thread Xiaogang . Chen
From: Xiaogang Chen Since we allow kfd and graphic operate on same GPU VM to have interoperation between them GPU VM may have been used by graphic vm operations before kfd turns a GPU VM into a compute VM. Remove vm clean checking at amdgpu_vm_make_compute. Signed-off-by: Xiaogang Chen --- driv

Re: [PATCH] drm/amd: Disable PSR-SU on Parade 0803 TCON

2023-06-19 Thread Hamza Mahfooz
On 6/19/23 16:13, Mario Limonciello wrote: A number of users have reported that there are random hangs occurring caused by PSR-SU specifically on panels that contain the parade 0803 TCON. Users have been able to work around the issue by disabling PSR entirely. To avoid these hangs, disable PSR-

[PATCH] drm/amd: Disable PSR-SU on Parade 0803 TCON

2023-06-19 Thread Mario Limonciello
A number of users have reported that there are random hangs occurring caused by PSR-SU specifically on panels that contain the parade 0803 TCON. Users have been able to work around the issue by disabling PSR entirely. To avoid these hangs, disable PSR-SU when this TCON is found. Cc: Sean Wang C

Re: [PATCH] drm/amdgpu: remove vm sanity check from amdgpu_vm_make_compute

2023-06-19 Thread Felix Kuehling
On 2023-06-19 15:06, Xiaogang.Chen wrote: From: Xiaogang Chen Since we allow kfd and graphic operate on same GPU VM to have interoperation between them GPU VM may have been used by graphic vm operations before kfd turn a GFX VM into a compute VM. Remove vm clean checking at amdgpu_vm_make_com

[PATCH] drm/amdgpu: remove vm sanity check from amdgpu_vm_make_compute

2023-06-19 Thread Xiaogang . Chen
From: Xiaogang Chen Since we allow kfd and graphic operate on same GPU VM to have interoperation between them GPU VM may have been used by graphic vm operations before kfd turn a GFX VM into a compute VM. Remove vm clean checking at amdgpu_vm_make_compute. Signed-off-by: Xiaogang Chen --- drive

Re: [PATCH v6 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-19 Thread Limonciello, Mario
On 6/12/2023 2:25 PM, Sui Jingfeng wrote: From: Sui Jingfeng Deal only with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function with pci_get_class(). Filter the non-PCI display device(pdev->class != 0x0300) out. There no need to process the non-display PCI device.

[PATCHv4] drm/amdgpu: Update invalid PTE flag setting

2023-06-19 Thread Mukul Joshi
Update the invalid PTE flag setting with TF enabled. This is to ensure, in addition to transitioning the retry fault to a no-retry fault, it also causes the wavefront to enter the trap handler. With the current setting, the fault only transitions to a no-retry fault. Additionally, have 2 sets of in

Re: [PATCH V3 4/7] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-06-19 Thread Lazar, Lijo
On 6/16/2023 12:27 PM, Evan Quan wrote: With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7).

Re: [PATCH] drm/amdgpu: Remove struct drm_driver.gem_prime_mmap

2023-06-19 Thread Thomas Zimmermann
Hi Christian Am 19.06.23 um 16:13 schrieb Christian König: Am 19.06.23 um 16:11 schrieb Thomas Zimmermann: The callback struct drm_driver.gem_prime_mmap as been removed in commit 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap"). Do not assign to it. The assigned function, drm_gem

Re: [PATCH] drm/amdgpu: Remove struct drm_driver.gem_prime_mmap

2023-06-19 Thread Christian König
Am 19.06.23 um 16:11 schrieb Thomas Zimmermann: The callback struct drm_driver.gem_prime_mmap as been removed in commit 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap"). Do not assign to it. The assigned function, drm_gem_prime_mmap(), is now the default for the operation, so ther

[PATCH] drm/amdgpu: Remove struct drm_driver.gem_prime_mmap

2023-06-19 Thread Thomas Zimmermann
The callback struct drm_driver.gem_prime_mmap as been removed in commit 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap"). Do not assign to it. The assigned function, drm_gem_prime_mmap(), is now the default for the operation, so there is no change in functionality. Signed-off-by: Thom

Re: Warning appeared after c8b5a95 ("drm/amdgpu: Fix desktop freezed after gpu-reset")

2023-06-19 Thread Alex Deucher
On Mon, Jun 19, 2023 at 9:05 AM Christian Kastner wrote: > > Hi, > > On a Debian 12 ("bookworm") system, I observed a new warning when I > upgraded from kernel 6.1.25 to 6.1.27. This is on a system with an RX > 6800 XT GPU and 3500X processor. > > I've traced it down to commit c8b5a95 ("drm/amdgpu

[PATCH Review V2 1/1] drm/amdgpu: Remove redundant poison consumption handler function

2023-06-19 Thread Stanley . Yang
The function callback handle_poison_consumption and callback function poison_consumption_handler are almost same to handle poison consumption, remove poison_consumption_handler. Changed from V1: Add handle poison consumption function for VCN2.6, VCN4.0, JPEG2.6 and JPEG4.0, return

Requests For Proposals for hosting XDC 2024 are now open

2023-06-19 Thread Ricardo Garcia
Hello everyone! The X.org board is soliciting proposals to host XDC in 2024. Since XDC 2023 is being held in Europe this year, we've decided to host in North America. However, the board is open to other locations, especially if there's an interesting co-location with another conference. If you're

RE: [PATCH] drm/amdgpu/vcn: Need to pause dpg before stop dpg

2023-06-19 Thread Liu, Leo
[AMD Official Use Only - General] Hi Emily, Do you want to pause or un-pause dpg mode based on and change and commit message? With bare metal, before calling the stop, the state of dpg should be un-paused within the call the of amdgpu_vcn_idle_work_handler, is it not the case for SRIOV? Rega

Warning appeared after c8b5a95 ("drm/amdgpu: Fix desktop freezed after gpu-reset")

2023-06-19 Thread Christian Kastner
Hi, On a Debian 12 ("bookworm") system, I observed a new warning when I upgraded from kernel 6.1.25 to 6.1.27. This is on a system with an RX 6800 XT GPU and 3500X processor. I've traced it down to commit c8b5a95 ("drm/amdgpu: Fix desktop freezed after gpu-reset"). Rebuilding the 6.1.27 kernel wi

[PATCH] gpu: drm/amd: Fix traditional comparison using max method

2023-06-19 Thread Li Dong
It would be better to replace the traditional ternary conditional operator with max() Signed-off-by: Li Dong --- drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c

Re: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-19 Thread Johannes Berg
On Sun, 2023-06-18 at 21:17 -0500, Mario Limonciello wrote: > > > --- a/include/net/cfg80211.h > > +++ b/include/net/cfg80211.h > > @@ -920,6 +920,14 @@ const struct cfg80211_chan_def * > > cfg80211_chandef_compatible(const struct cfg80211_chan_def *chandef1, > > const st

[PATCH] drm/amd/pm: Provide energy data in 15.625mJ units

2023-06-19 Thread Lijo Lazar
Publish energy data in 15.625mJ unit for SMU v13.0.6. The same unit is used in Aldebaran also. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 12:44:06 +0200 Christian König wrote: > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > [SNIP] > > Note that the drm_exec_until_all_locked() helper I introduced is taking > > an expression, so in theory, you don't have to define a separate > > function. > > > > drm_exec_

[PATCH] drm/amd/display: Remove else after return statement in 'dm_update_plane_state'

2023-06-19 Thread Srinivasan Shanmugam
Else is not necessary after return statements, hence remove it. Reported by checkpatch: WARNING: else is not generally useful after a break or return drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9776: return -EINVAL; else Cc: Bhawanpreet

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 13:05:02 +0200 Boris Brezillon wrote: > On Mon, 19 Jun 2023 12:44:06 +0200 > Christian König wrote: > > > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > > [SNIP] > > > Note that the drm_exec_until_all_locked() helper I introduced is taking > > > an expression, so in the

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Intel
On 6/19/23 11:48, Christian König wrote: Hi, Am 19.06.23 um 11:33 schrieb Thomas Hellström (Intel): [SNIP] Sometimes you want to just drop the contended lock after the above relaxation. (Eviction would be one example), and not add as prelocked, if the contended object goes out of scope. Evi

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 12:44:06 +0200 Christian König wrote: > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > [SNIP] > > Note that the drm_exec_until_all_locked() helper I introduced is taking > > an expression, so in theory, you don't have to define a separate > > function. > > > > drm_exec_

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Christian König
Am 19.06.23 um 12:12 schrieb Boris Brezillon: [SNIP] Note that the drm_exec_until_all_locked() helper I introduced is taking an expression, so in theory, you don't have to define a separate function. drm_exec_until_all_locked(&exec, { /* inlined-code */ in

RE: [PATCH Review 1/1] drm/amdgpu: Remove redundant poison consumption handler function

2023-06-19 Thread Yang, Stanley
[AMD Official Use Only - General] Please ignore this patch, I will send V2. Regards, Stanley > -Original Message- > From: Stanley.Yang > Sent: Monday, June 19, 2023 4:24 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Zhou1, Tao ; Chai, > Thomas > Cc: Yang, Stanley > Subject

[PATCH] drm/amdgpu/vcn: Need to pause dpg before stop dpg

2023-06-19 Thread Emily Deng
Need to pause dpg first, or it will hit follow error during stop dpg: "[drm] Register(1) [regUVD_POWER_STATUS] failed to reach value 0x0001 != 0xn" Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/d

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 11:20:06 +0200 Christian König wrote: > Hi guys, > > Am 19.06.23 um 10:59 schrieb Thomas Hellström (Intel): > > [SNIP] > > I really need to find some time to work on that anyway. > >> I've been playing with drm_exec for a couple weeks now, and I wanted > >> to s

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
Hello Thomas, On Mon, 19 Jun 2023 10:59:16 +0200 Thomas Hellström (Intel) wrote: > > > +/** > > + * DOC: Overview > > + * > > + * This component mainly abstracts the retry loop necessary for locking > > + * multiple GEM objects while preparing hardware operations

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Christian König
Hi, Am 19.06.23 um 11:33 schrieb Thomas Hellström (Intel): [SNIP] Sometimes you want to just drop the contended lock after the above relaxation. (Eviction would be one example), and not add as prelocked, if the contended object goes out of scope. Eviction would in some situations be one such

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Intel
Hi! On 6/19/23 11:20, Christian König wrote: Hi guys, Am 19.06.23 um 10:59 schrieb Thomas Hellström (Intel): [SNIP] I really need to find some time to work on that anyway. I've been playing with drm_exec for a couple weeks now, and I wanted to share something I hacked to try and make the AP

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Christian König
Hi guys, Am 19.06.23 um 10:59 schrieb Thomas Hellström (Intel): [SNIP] I really need to find some time to work on that anyway. I've been playing with drm_exec for a couple weeks now, and I wanted to share something I hacked to try and make the API simpler and more robust against misuse (see t

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Intel
On 6/17/23 13:54, Boris Brezillon wrote: +Matthew who's been using drm_exec in Xe if I'm correct. Hello Christian, On Wed, 14 Jun 2023 15:02:52 +0200 Boris Brezillon wrote: On Wed, 14 Jun 2023 14:30:53 +0200 Christian König wrote: Am 14.06.23 um 14:23 schrieb Boris Brezillon: Hi Christ

Re: [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-19 Thread Maciej W. Rozycki
On Tue, 13 Jun 2023, Sui Jingfeng wrote: > Deal only with the VGA devcie(pdev->class == 0x0300), so replace the Typo here: s/devcie/device/. > pci_get_subsys() function with pci_get_class(). Filter the non-PCI display > device(pdev->class != 0x0300) out. There no need to process the non-display

[PATCH Review 1/1] drm/amdgpu: Remove redundant poison consumption handler function

2023-06-19 Thread Stanley . Yang
The function callback handle_poison_consumption and callback function poison_consumption_handler are almost same to handle poison consumption, remove poison_consumption_handler. Signed-off-by: Stanley.Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 9 - drivers/gpu/drm/amd/amdgpu/am

[PATCH v2] drm/amdgpu: Modify for_each_inst macro

2023-06-19 Thread Lijo Lazar
Modify it such that it doesn't change the instance mask parameter. Signed-off-by: Lijo Lazar --- v2: Take care of bit-shift beyond width (Victor) drivers/gpu/drm/amd/amdgpu/amdgpu.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/am