Re: [PATCH] drm/amd/amdgpu: Properly tune the size of struct

Hi Su, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.4-rc7 next-20230622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] drm/amd: Don't try to enable secure display TA multiple times

If the securedisplay TA failed to load the first time, it's unlikely to work again after a suspend/resume cycle or reset cycle and it appears to be causing problems in futher attempts. Fixes: e42dfa66d592 ("drm/amdgpu: Add secure display TA load for Renoir") Reported-by: Filip Hejsek Closes:

RE: [PATCH 2/2] drm/amdgpu: Correctly setup TMR region size for GFX9.4.3

[AMD Official Use Only - General] Please ignore this patch. This is not the correct way to fix the TMR region size. Thanks, Mukul > -Original Message- > From: Joshi, Mukul > Sent: Thursday, June 22, 2023 5:29 PM > To: amd-gfx@lists.freedesktop.org > Cc: Lin, Amber ; Joshi, Mukul > >

[PATCH 11/11] drm/amd/display: 3.2.241

From: Aric Cyr This version brings along the following: - Improve debugging mechanism for Gaming FAMS - Add monitor specific edid quirks - Fixes for Phantom pipe - Fixes for Shapper LUT - Clean up asserts Acked-by: Rodrigo Siqueira Signed-off-by: Aric Cyr ---

[PATCH 09/11] drm/amd/display: Create debugging mechanism for Gaming FAMS

From: Gianna Binder [WHY] To enable FAMS even during gaming sessions. [HOW] By leveraging a new dc.debug parameter. Reviewed-by: Felipe Clark Acked-by: Rodrigo Siqueira Signed-off-by: Gianna Binder --- drivers/gpu/drm/amd/display/dc/dc.h | 1 +

[PATCH 10/11] drm/amd/display: Take full update path if number of planes changed

From: Alvin Lee [Description] - A full update is required if the number of planes for a given stream changes - The new fast update path only checked for stream and plane updates, but there could be a plane addition or removal without one of the stream and plane updates triggering a full

[PATCH 07/11] drm/amd/display: For new fast update path, loop through each surface

From: Alvin Lee [Description] - Previous implementation didn't consider multiple surfaces in a flip - Loop through each surface in each flip to ensure the update path is correct Reviewed-by: Samson Tam Acked-by: Rodrigo Siqueira Signed-off-by: Alvin Lee ---

[PATCH 08/11] drm/amd/display: Add monitor specific edid quirk

From: Aurabindo Pillai Disable FAMS on a Samsung Odyssey G9 monitor. Experiments show that this monitor does not work well under some use cases, and is likely implementation specific bug on the monitor's firmware. Cc: sta...@vger.kernel.org Reviewed-by: Rodrigo Siqueira Signed-off-by:

[PATCH 06/11] drm/amd/display: Remove Phantom Pipe Check When Calculating K1 and K2

From: Austin Zheng [Why] K1 and K2 not being setting properly when subVP is active. [How] Have phantom pipes use the same programing as the main pipes without checking the paired stream Cc: sta...@vger.kernel.org Reviewed-by: Alvin Lee Acked-by: Rodrigo Siqueira Signed-off-by: Austin Zheng

[PATCH 05/11] drm/amd/display: Limit new fast update path to addr and gamma / color

From: Alvin Lee [Description] - We want to limit the new fast update path to address and gamma updates only. - Add a check in dc_update_planes_and_stream to only take the new fast update path if we only have the specific fast updates defined. Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira

[PATCH 03/11] drm/amd/display: program DPP shaper and 3D LUT if updated

From: Melissa Wen If shaper and 3D LUT data updates, lut_3d bit in update_flag is updated and we need to call set_input_transfer_func to program DPP shaper and 3D LUTs. Small cleanup of code style in the related if-condition. Reviewed-by: Krunoslav Kovac Acked-by: Rodrigo Siqueira

[PATCH 04/11] drm/amd/display: Fix the delta clamping for shaper LUT

From: Harry Wentland The shaper LUT requires a 10-bit value of the delta between segments. We were using dc_fixpt_clamp_u0d10() to do that but it doesn't do what we want it to do. It will preserve 10-bit precision after the decimal point, but that's not quite what we want. We want 14-bit

[PATCH 02/11] drm/amd/display: Remove asserts

From: Hong-lu Cheng [why] Endless assert caused by LinesInDETChroma=0. [how] Don't floor for LinesInDETChroma=0 Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira Signed-off-by: Hong-lu Cheng --- .../display/dc/dml/dcn20/display_mode_vba_20.c | 16 ++-- 1 file changed, 10

[PATCH 01/11] drm/amd/display: Work around bad DPCD state on link loss

From: Ilya Bakoulin [Why] This display doesn't properly indicate link loss through DPCD bits such as CR_DONE / CHANNEL_EQ_DONE / SYMBOL_LOCKED / INTERLANE_ALIGN_DONE, which all remain set. In addition, DPCD200Eh doesn't match the value of DPCD204h in all cases. For these reasons, we can miss

[PATCH 00/11] DC Patches June 22, 2023

This DC patchset brings improvements in multiple areas. In summary, we highlight: - Improve debugging mechanism for Gaming FAMS - Add monitor-specific edid quirks - Fixes for Phantom pipe - Fixes for Shapper LUT - Clean-up asserts Cc: Daniel Wheeler Alvin Lee (3): drm/amd/display: Limit

[PATCH 2/2] drm/amdgpu: Correctly setup TMR region size for GFX9.4.3

A faulty check was causing TMR region size to be setup incorrectly for GFX9.4.3. Remove the check and setup TMR region size as 280MB for GFX9.4.3. Fixes: b6780d70db5e ("drm/amdgpu: bypass bios dependent operations") Signed-off-by: Mukul Joshi --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-

[PATCH 1/2] drm/amdkfd: Update interrupt handling for GFX 9.4.3

For GFX 9.4.3, interrupt handling needs to be updated for: - Interrupt cookie will have a NodeId field. Each KFD node needs to check the NodeId before processing the interrupt. - For CPX mode, there are additional checks of client ID needed to process the interrupt. - Add NodeId to the

[patch V2] drm/amdkfd: Access gpuvm_export_dmabuf() api

Call KFD api to get Dmabuf instead of calling GEM Prime API Signed-off-by: Ramesh Errabolu --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

On 6/21/2023 8:55 PM, Andrew Lunn wrote: Honestly I'm not sure though we need this complexity right now? I mean, it'd be really easy to replace the calls in mac80211 with some other more generalised calls in the future? You need some really deep platform/hardware level knowledge and

[PATCH 4/4] Revert "drm/amd: Disable PSR-SU on Parade 0803 TCON"

This reverts commit 33eec907ce0eb50a56dca621aa7310f7fa904b93. This is no longer necessary when using newer DMUB F/W. Cc: Sean Wang Cc: Marc Rossi Cc: Hamza Mahfooz Cc: Tsung-hua (Ryan) Lin Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 --

[PATCH 0/4] Add checks for enabling PSR-SU

There have been a number of field reports of hangs tied to PSR-SU specifically to Parade TCONs. These hangs are fixed by changes in DMCUB firmware for both Rembrandt and Phoenix. Add checks to ensure that PSR-SU is only enabled when the newer DMCUB firmware is present. Cc: Sean Wang Cc: Marc

[PATCH 3/4] drm/amd/display: Set minimum requirement for using PSR-SU on Phoenix

The same parade TCON issue can potentially happen on Phoenix, and the same PSR resilience changes have been ported into the DMUB firmware. Don't allow running PSR-SU unless on the newer firmware. Cc: Sean Wang Cc: Marc Rossi Cc: Hamza Mahfooz Cc: Tsung-hua (Ryan) Lin Signed-off-by: Mario

[PATCH 2/4] drm/amd/display: Set minimum requirement for using PSR-SU on Rembrandt

A number of parade TCONs are causing system hangs when utilized with older DMUB firmware and PSR-SU. Some changes have been introduced into DMUB firmware to add resilience against these failures. Don't allow running PSR-SU unless on the newer firmware. Cc: Sean Wang Cc: Marc Rossi Cc: Hamza

[PATCH 1/4] drm/amd/display: Correct `DMUB_FW_VERSION` macro

The `DMUB_FW_VERSION` macro has a mistake in that the revision field is off by one byte. The last byte is typically used for other purposes and not a revision. Cc: Sean Wang Cc: Marc Rossi Cc: Hamza Mahfooz Cc: Tsung-hua (Ryan) Lin Signed-off-by: Mario Limonciello ---

Re: [PATCH] drm/amd/display: Use seq_puts() in 'amdgpu_current_colorspace_show()' & 'edp_ilr_show()'

On 6/22/23 02:58, Srinivasan Shanmugam wrote: Replace seq_printf with seq_puts when there is no argument list. Fix the checkpatch warning: WARNING: Prefer seq_puts to seq_printf Cc: Wayne Lin Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan

Re: [PATCH] drm/amd/display: Remove redundant braces in 'amdgpu_dm_crtc_notify_ta_to_read()'

On 6/22/23 03:38, Srinivasan Shanmugam wrote: Adhere to Linux kernel coding style. Reported by checkpatch: WARNING: braces {} are not necessary for single statement blocks Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam ---

Re: [PATCH] drm/amd/display: Remove spaces before tabs in amdgpu_dm_hdcp.c

On 6/22/23 05:00, Srinivasan Shanmugam wrote: Conform to Linux kernel coding style. Reported by checkpatch: WARNING: please, no space before tabs Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 40

Re: [PATCH] drm/amd/display: Clean up style problems in amdgpu_dm_irq.c

On 6/22/23 08:12, Srinivasan Shanmugam wrote: Fix the following warnings reported by checkpatch: WARNING: Block comments use a trailing */ on a separate line WARNING: Comparisons should place the constant on the right side of the test WARNING: space prohibited between function name and open

[PATCH] drm/amd/display: Clean up style problems in amdgpu_dm_irq.c

Fix the following warnings reported by checkpatch: WARNING: Block comments use a trailing */ on a separate line WARNING: Comparisons should place the constant on the right side of the test WARNING: space prohibited between function name and open parenthesis '(' WARNING: Prefer 'unsigned int' to

Re: [PATCH] drm/amdgpu/vcn: Need to unpause dpg before stop dpg

Reviewed-by: Leo Liu On 2023-06-20 21:29, Emily Deng wrote: Need to unpause dpg first, or it will hit follow error during stop dpg: "[drm] Register(1) [regUVD_POWER_STATUS] failed to reach value 0x0001 != 0xn" Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c

[PATCH] drm/amd/display: Remove spaces before tabs in amdgpu_dm_hdcp.c

Conform to Linux kernel coding style. Reported by checkpatch: WARNING: please, no space before tabs Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 40 +-- 1 file changed, 20 insertions(+), 20

[PATCH] drm/amdgpu: fix building without DEBUG_FS

From: Arnd Bergmann The debugfs file is defined unconditionally, but the registration is hidden in an #ifdef, which causes a warning: drivers/gpu/drm/amd/amdgpu/amdgpu_rap.c:110:37: error: unused variable 'amdgpu_rap_debugfs_ops' [-Werror,-Wunused-const-variable] static const struct

Re: [PATCH] drm/amd/pm: Provide energy data in 15.625mJ units

[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking Get Outlook for iOS From: Lazar, Lijo Sent: Thursday, June 22, 2023 1:44:42 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ;

Re: [RFC PATCH v3 2/4] drm: Create DRM_IOCTL_GET_RESET

Am 22.06.23 um 10:22 schrieb Pekka Paalanen: On Wed, 21 Jun 2023 13:33:56 -0300 André Almeida wrote: Em 21/06/2023 05:09, Pekka Paalanen escreveu: On Tue, 20 Jun 2023 21:57:17 -0300 André Almeida wrote: Create a new DRM ioctl operation to get the numbers of resets for a given context.

[PATCH] drm/amd/display: Remove redundant braces in 'amdgpu_dm_crtc_notify_ta_to_read()'

Adhere to Linux kernel coding style. Reported by checkpatch: WARNING: braces {} are not necessary for single statement blocks Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 6 ++ 1 file changed, 2

[PATCH] drm/amd/display: Remove redundant braces in 'amdgpu_dm_crtc_notify_ta_to_read()'

Adhere to Linux kernel coding style. Reported by checkpatch: WARNING: braces {} are not necessary for single statement blocks Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 6 ++ 1 file changed, 2

[PATCH] drm/amd/display: Use seq_puts() in 'amdgpu_current_colorspace_show()' & 'edp_ilr_show()'

Replace seq_printf with seq_puts when there is no argument list. Fix the checkpatch warning: WARNING: Prefer seq_puts to seq_printf Cc: Wayne Lin Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam ---

Re: [RFC PATCH v3 2/4] drm: Create DRM_IOCTL_GET_RESET

On Wed, 21 Jun 2023 13:33:56 -0300 André Almeida wrote: > Em 21/06/2023 05:09, Pekka Paalanen escreveu: > > On Tue, 20 Jun 2023 21:57:17 -0300 > > André Almeida wrote: > > > >> Create a new DRM ioctl operation to get the numbers of resets for a > >> given context. The numbers reflect just

Re: [RFC PATCH v3 1/4] drm/doc: Document DRM device reset expectations

On Wed, 21 Jun 2023 13:28:34 -0300 André Almeida wrote: > Em 21/06/2023 04:58, Pekka Paalanen escreveu: > > On Tue, 20 Jun 2023 21:57:16 -0300 > > André Almeida wrote: > > > >> Create a section that specifies how to deal with DRM device resets for > >> kernel and userspace drivers. > >> > >>

Re: [RFC PATCH v3 3/4] drm/amdgpu: Implement DRM_IOCTL_GET_RESET

Am 21.06.23 um 18:38 schrieb André Almeida: Em 21/06/2023 04:40, Christian König escreveu: Am 21.06.23 um 02:57 schrieb André Almeida: Implement get_reset ioctl for amdgpu Well that pretty much won't work since the jobs are destroyed much later than the contexts. Why does this prevents

Re: [PATCH] drm/amdgpu: Forbid kfd using cpu to update pt if vm is shared with gfx

I have no problem dropping the AMDGPU_GEM_CREATE_NO_CPU_ACCESS flag from page tables no matter if we have large BAR or not. That should only be necessary when BOs are pinned and since we never pin page tables it shouldn't matter. Just set AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED after switching