RE: [PATCH] drm/amdgpu: Restore HQD persistent state register

2023-07-24 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Tuesday, July 25, 2023 13:46 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad Subject: [PATCH] drm/amdgpu: Restore HQD

[PATCH] drm/amdgpu: Restore HQD persistent state register

2023-07-24 Thread Lijo Lazar
On GFX v9.4.3, compute queue MQD is populated using the values in HQD persistent state register. Hence don't clear the values on module unload, instead restore it to the default reset value so that MQD is initialized correctly during next module load. In particular, preload flag needs to be set on

RE: [PATCH V2] drm/amdgpu: remove redundant variable declaration

2023-07-24 Thread SHANMUGAM, SRINIVASAN
[Public] Reviewed-by: Srinivasan Shanmugam -Original Message- From: amd-gfx On Behalf Of Bob Zhou Sent: Monday, July 24, 2023 2:06 PM To: amd-gfx@lists.freedesktop.org; Pelloux-Prayer, Pierre-Eric Cc: Zhou, Bob ; Chen, Guchun Subject: [PATCH V2] drm/amdgpu: remove redundant variable

RE: [PATCH] drm/amdgpu: Fix ENOSYS means 'invalid syscall nr' in amdgpu_device.c

2023-07-24 Thread Chen, Guchun
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Srinivasan Shanmugam > Sent: Sunday, July 23, 2023 2:16 PM > To: Koenig, Christian ; Deucher, Alexander > > Cc: SHANMUGAM, SRINIVASAN ; > amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: Fix ENOSYS means 'invalid

RE: [PATCH] drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c

2023-07-24 Thread Chen, Guchun
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Srinivasan Shanmugam > Sent: Tuesday, July 25, 2023 12:42 PM > To: Koenig, Christian ; Deucher, Alexander > > Cc: SHANMUGAM, SRINIVASAN ; > amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: Move externs to amdgpu.h

RE: [PATCH] drm/amdgpu: Fix unused variable 'domain' in 'amdgpu_bo_print_info'

2023-07-24 Thread Chen, Guchun
[Public] Thanks for your patch, Srini. This has been fixed by https://patchwork.freedesktop.org/patch/549040/. > -Original Message- > From: amd-gfx On Behalf Of > Srinivasan Shanmugam > Sent: Monday, July 24, 2023 10:41 PM > To: Koenig, Christian ; Deucher, Alexander > > Cc:

[PATCH v2] drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c

2023-07-24 Thread Srinivasan Shanmugam
Fixes the following: WARNING: externs should be avoided in .c files +extern const struct attribute_group amdgpu_vram_mgr_attr_group; WARNING: externs should be avoided in .c files +extern const struct attribute_group amdgpu_gtt_mgr_attr_group; WARNING: externs should be avoided in .c files

[PATCH] drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c

2023-07-24 Thread Srinivasan Shanmugam
WARNING: externs should be avoided in .c files +extern const struct attribute_group amdgpu_vram_mgr_attr_group; WARNING: externs should be avoided in .c files +extern const struct attribute_group amdgpu_gtt_mgr_attr_group; WARNING: externs should be avoided in .c files +extern const struct

RE: [PATCH 2/3] drm/amdgpu: add ih 6.1 support

2023-07-24 Thread Chen, Guchun
[Public] > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Tuesday, July 25, 2023 4:05 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Li, Ben > > Subject: [PATCH 2/3] drm/amdgpu: add ih 6.1 support > > From: benl > > Add initial support for IH

Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-24 Thread André Almeida
Hi everyone, It's not clear what we should do about non-robust OpenGL apps after GPU resets, so I'll try to summarize the topic, show some options and my proposal to move forward on that. Em 27/06/2023 10:23, André Almeida escreveu: +Robustness +-- + +The only way to try to keep an

RE: [PATCH v2] drm/amd/pm: Vangogh: Add new gpu_metrics_v2_4 to acquire gpu_metrics

2023-07-24 Thread Liang, Richard qi
[AMD Official Use Only - General] Hi Wenyou, Could you merge the patch? Thanks, Richard -Original Message- From: Quan, Evan Sent: Tuesday, July 18, 2023 12:03 AM To: Yang, WenYou ; Deucher, Alexander ; Limonciello, Mario ; Koenig, Christian ; Pan, Xinhui Cc: Yuan, Perry ; Liang,

Re: [PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-24 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 24, 2023 at 5:08 AM wrote: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > .../amd/pm/swsmu/inc/smu_v13_0_7_pptable.h| 21 +++ > 1 file changed, 7 insertions(+), 14 deletions(-) > > diff --git

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_1_pmfw.h

2023-07-24 Thread Alex Deucher
This doesn't apply cleanly. Alex On Mon, Jul 24, 2023 at 4:57 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h | 4 ++-- > 1 file changed, 2

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v11_0_7_pptable.h

2023-07-24 Thread Alex Deucher
This one doesn't apply cleanly. Alex On Mon, Jul 24, 2023 at 4:54 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: open brace '{' following function definitions go on the next line

2023-07-24 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 24, 2023 at 4:44 AM wrote: > > ERROR: open brace '{' following function definitions go on the next line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH] drm/amd/pm: that open brace { should be on the previous line

2023-07-24 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 24, 2023 at 4:42 AM wrote: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/inc/smu_11_0_cdr_table.h | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH] drm/amd/pm: Clean up errors in smu11_driver_if_sienna_cichlid.h

2023-07-24 Thread Alex Deucher
This doesn't apply cleanly. Alex On Mon, Jul 24, 2023 at 4:34 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h | 4 ++-- > 1 file changed, 2

Re: [PATCH] drm/amd/pm: Clean up errors in smu11_driver_if_sienna_cichlid.h

2023-07-24 Thread Alex Deucher
This doesn't apply cleanly. Alex On Mon, Jul 24, 2023 at 4:30 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > ERROR: space prohibited before open square bracket '[' > ERROR: space prohibited before that close square bracket ']' > > Signed-off-by:

Re: [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c

2023-07-24 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 24, 2023 at 3:49 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: "foo* bar" should be "foo *bar" > ERROR: spaces required around that '=' (ctx:VxW) > ERROR: space prohibited before that close parenthesis ')' > > Signed-off-by: Ran Sun >

Re: [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c

2023-07-24 Thread Alex Deucher
Applied. thanks! On Mon, Jul 24, 2023 at 3:32 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '=' (ctx:VxW) > ERROR: spaces required around that '>=' (ctx:WxV) > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in navi10_ppt.c

2023-07-24 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 24, 2023 at 3:21 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following function definitions go on the next line > ERROR: space required before the open parenthesis '(' > ERROR: space required after that ',' (ctx:VxV) >

Re: [PATCH] drm/amd/pm: add missing spaces before '('

2023-07-24 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 24, 2023 at 3:02 AM wrote: > > ERROR: space required before the open parenthesis '(' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH] drm/radeon: Move assignment outside if condition

2023-07-24 Thread Alex Deucher
Applied. Thanks! On Sun, Jul 23, 2023 at 11:45 PM wrote: > > Fixes the following checkpatch errors: > > ERROR: do not use assignment in if condition > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/radeon_legacy_tv.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > >

Re: [PATCH] drm/radeon: that open brace { should be on the previous line

2023-07-24 Thread Alex Deucher
Applied. thanks! Alex On Sun, Jul 23, 2023 at 11:40 PM wrote: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/rv770_smc.c | 36 ++ > 1 file changed, 12 insertions(+), 24 deletions(-) > > diff

Re: [PATCH] drm/radeon: that open brace { should be on the previous line

2023-07-24 Thread Alex Deucher
Applied. Thanks! On Sun, Jul 23, 2023 at 11:37 PM wrote: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/clearstate_si.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [PATCH] drm/radeon: add missing spaces after ', ' and else should follow close brace '}'

2023-07-24 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Jul 23, 2023 at 11:30 PM wrote: > > ERROR: else should follow close brace '}' > > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

Re: [PATCH] drm/radeon: that open brace { should be on the previous line

2023-07-24 Thread Alex Deucher
On Sun, Jul 23, 2023 at 11:12 PM wrote: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/ni_dpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/ni_dpm.c >

Re: [PATCH] drm/radeon: add missing spaces before ';'

2023-07-24 Thread Alex Deucher
Applied. Thanks! On Sun, Jul 23, 2023 at 11:00 PM wrote: > > ERROR: space required after that ';' (ctx:BxV) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/radeon_vce.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_vce.c

Re: [PATCH] drm/radeon/si_dpm: open brace '{' following struct go on the same line

2023-07-24 Thread Alex Deucher
Applied. Thanks. Alex On Sun, Jul 23, 2023 at 10:55 PM wrote: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/sislands_smc.h | 51 +-- > 1 file changed, 17 insertions(+), 34 deletions(-) > >

Re: [PATCH] drm/amdgpu: Use seq_puts() instead of seq_printf()

2023-07-24 Thread Alex Deucher
On Sun, Jul 23, 2023 at 2:51 AM Srinivasan Shanmugam wrote: > > For a constant format without additional arguments, use seq_puts() > instead of seq_printf(). Also, it fixes the following warning. > > WARNING: Prefer seq_puts to seq_printf > > And other style fixes: > > WARNING: Prefer 'unsigned

[PATCH 1/3] drm/amdgpu: add ih 6.1 registers

2023-07-24 Thread Alex Deucher
From: benl Add new registers. v2: updates (Alex) Signed-off-by: Ben Li Signed-off-by: Alex Deucher --- .../asic_reg/oss/osssys_6_1_0_offset.h| 279 + .../asic_reg/oss/osssys_6_1_0_sh_mask.h | 1019 + 2 files changed, 1298 insertions(+) create mode 100644

[PATCH 2/3] drm/amdgpu: add ih 6.1 support

2023-07-24 Thread Alex Deucher
From: benl Add initial support for IH 6.1. Signed-off-by: benl Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/ih_v6_1.c | 769 +++ drivers/gpu/drm/amd/amdgpu/ih_v6_1.h | 28 + 3 files changed, 799

[PATCH 3/3] drm/amdgpu/discovery: add ih 6.1.0 support

2023-07-24 Thread Alex Deucher
From: Prike Liang Add to IP discovery table. Signed-off-by: Prike Liang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

Re: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch

2023-07-24 Thread Philip Yang
Hi Michel, Please check if this patch "drm/amdkfd: start_cpsch don't map queues" can fix the driver loading ring test failed issue on your system, I am still not able to repro the issue. Regards, Philip On 2023-07-21 09:30, Philip Yang wrote:

Re: [PATCH] drm/amdkfd: start_cpsch don't map queues

2023-07-24 Thread Felix Kuehling
On 2023-07-24 13:52, Philip Yang wrote: start_cpsch map queues when kfd_init_node have race condition with IOMMUv2 init, and cause the gfx ring test failed later. Remove it from start_cpsch because map queues will be done when creating queues and resume queues. Reported-by: Michel Dänzer

[PATCH] drm/amdgpu/discovery: add hdp 6.1.0 support

2023-07-24 Thread Alex Deucher
From: Prike Liang Add to IP discovery table. Signed-off-by: Prike Liang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

Re: [PATCH] drm/amdgpu: Checkpoint and Restore VRAM BOs without VA

2023-07-24 Thread Felix Kuehling
On 2023-07-24 11:57, Ramesh Errabolu wrote: Extend checkpoint logic to allow inclusion of VRAM BOs that do not have a VA attached Signed-off-by: Ramesh Errabolu --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2] drm/amdgpu/sdma6: initialize sdma 6.1.0

2023-07-24 Thread Alex Deucher
From: Prike Liang Add firmware declaration. Signed-off-by: Prike Liang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c index

[PATCH 2/2] drm/amdgpu/discovery: enable sdma6 for SDMA 6.1.0

2023-07-24 Thread Alex Deucher
From: Prike Liang Add to IP discovery table. Signed-off-by: Prike Liang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

[PATCH] drm/amdgpu/discovery: add smuio 14.0.0 support

2023-07-24 Thread Alex Deucher
From: Prike Liang Add to IP discovery table. Signed-off-by: Prike Liang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

[PATCH 1/2] drm/amdgpu: add PSP 14.0.0 support

2023-07-24 Thread Alex Deucher
From: Li Ma Uses same driver interface as 13.0. Signed-off-by: Li Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v13_0.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

[PATCH 2/2] drm/amdgpu/discovery: enable PSP 14.0.0 support

2023-07-24 Thread Alex Deucher
From: Li Ma Add it to IP discovery. Signed-off-by: Li Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

[PATCH] drm/amdkfd: fix and enable ttmp setup for gfx11

2023-07-24 Thread Jonathan Kim
The MES cached process context must be cleared on adding any queue for the first time. For proper debug support, the MES will clear it's cached process context on the first call to SET_SHADER_DEBUGGER. This allows TTMPs to be pesistently enabled in a safe manner. Signed-off-by: Jonathan Kim

[PATCH] drm/amdkfd: start_cpsch don't map queues

2023-07-24 Thread Philip Yang
start_cpsch map queues when kfd_init_node have race condition with IOMMUv2 init, and cause the gfx ring test failed later. Remove it from start_cpsch because map queues will be done when creating queues and resume queues. Reported-by: Michel Dänzer Signed-off-by: Philip Yang ---

Re: [PATCH] drm/amdgpu: Remove volatile from 'wb' & from 'ptr' in amdgpu.h

2023-07-24 Thread Alex Deucher
On Mon, Jul 24, 2023 at 11:54 AM Srinivasan Shanmugam wrote: > > Fixes the following from checkpatch.pl: > > WARNING: Use of volatile is usually wrong: see > Documentation/process/volatile-considered-harmful.rst > + volatile uint32_t *wb; > > WARNING: Use of volatile is usually

[PATCH] drm/amdgpu: Checkpoint and Restore VRAM BOs without VA

2023-07-24 Thread Ramesh Errabolu
Extend checkpoint logic to allow inclusion of VRAM BOs that do not have a VA attached Signed-off-by: Ramesh Errabolu --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

[PATCH] drm/amdgpu: Remove volatile from 'wb' & from 'ptr' in amdgpu.h

2023-07-24 Thread Srinivasan Shanmugam
Fixes the following from checkpatch.pl: WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst + volatile uint32_t *wb; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst +

[PATCH] drm/amdgpu: Fix unused variable 'domain' in 'amdgpu_bo_print_info'

2023-07-24 Thread Srinivasan Shanmugam
Fixes the following: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function ‘amdgpu_bo_print_info’: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:1581:15: warning: unused variable ‘domain’ [-Wunused-variable] 1581 | unsigned int domain; | ^~ Cc: Christian König Cc: Alex

Re: [PATCH] drm/amdgpu: Update min() to min_t() in 'amdgpu_info_ioctl'

2023-07-24 Thread Alex Deucher
On Sun, Jul 23, 2023 at 3:06 AM Srinivasan Shanmugam wrote: > > Fixes the following: > > WARNING: min() should probably be min_t(size_t, size, sizeof(ip)) > + ret = copy_to_user(out, , min((size_t)size, sizeof(ip))); > > And other style fixes: > > WARNING: Prefer 'unsigned int' to

Re: [PATCH] drm/amdgpu: Add EXT_COHERENCE memory allocation flags

2023-07-24 Thread David Francis
Cover letter got lost, here it is: This is in support of a RCCL change that requires specific coherence behaviour. Corresponding Thunk patch is at https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/pull/88 These flags (for GEM and SVM allocations) allocate memory that allows for

[PATCH] drm/amdgpu: Add EXT_COHERENCE memory allocation flags

2023-07-24 Thread David Francis
These flags (for GEM and SVM allocations) allocate memory that allows for system-scope atomic semantics. On GFX943 these flags cause caches to be avoided on non-local memory. On all other ASICs they are identical in functionality to the equivalent COHERENT flags. Signed-off-by: David Francis

[no subject]

2023-07-24 Thread David Francis
This is in support of a RCCL change that requires specific coherence behaviour. Corresponding Thunk patch is at https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/pull/88

Re: [PATCH] drm/amd/display: Remove else after return in 'dm_vblank_get_counter' & 'amdgpu_dm_backlight_get_level'

2023-07-24 Thread Rodrigo Siqueira
On 7/23/23 05:31, Srinivasan Shanmugam wrote: Expressions under 'else' branch in function 'dm_vblank_get_counter' & 'amdgpu_dm_backlight_get_level' are executed whenever the expression in 'if' is False. Otherwise, return from case occurs. Therefore, there is no need in 'else', and it has been

Re: [PATCH 3/3] drm/amd/display: Implement zpos property

2023-07-24 Thread Rodrigo Siqueira
Hi Joshua, It looks like this patch caused a regression in the following IGT test: kms_atomic@plane-immutable-zpos This issue is causing failures in our CI; we probably need to revert it. Could you check it? Thanks Siqueira On 7/13/23 13:55, Harry Wentland wrote: On 2023-07-08 22:06,

Re: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-07-24 Thread Limonciello, Mario
On 7/24/2023 04:22, Andrew Lunn wrote: @@ -1395,6 +1395,8 @@ int ieee80211_register_hw(struct ieee80211_hw *hw) debugfs_hw_add(local); rate_control_add_debugfs(local); + ieee80211_check_wbrf_support(local); + rtnl_lock(); wiphy_lock(hw->wiphy); +void

Re: [PATCH] drm/amd/pm: Clean up errors in sienna_cichlid_ppt.c

2023-07-24 Thread kernel test robot
Hi, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.5-rc3 next-20230724] [If your

Re: [PATCH v2] drm/amdgpu: Add -ENOMEM error handling when there is no memory

2023-07-24 Thread Alex Deucher
On Sun, Jul 23, 2023 at 8:53 AM Srinivasan Shanmugam wrote: > > Return -ENOMEM, when there is no sufficient dynamically allocated memory > > Cc: Christian König > Cc: Alex Deucher > Signed-off-by: Srinivasan Shanmugam Reviewed-by: Alex Deucher > --- > > v2: > - Added -ENOMEM - when it

[PATCH] drm/radeon: that open brace { should be on the previous line

2023-07-24 Thread sunran001
ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/ni_dpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/ni_dpm.c b/drivers/gpu/drm/radeon/ni_dpm.c index a101ba00ea30..1cf4de4cda23 100644 ---

Re: radeon.ko/i586: BUG: kernel NULL pointer dereference,address:00000004

2023-07-24 Thread Steven Rostedt
On Sat, 22 Jul 2023 11:30:14 +0900 wrote: > >> diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h > >> index 897cf02c20b1..801f4414da3e 100644 > >> --- a/arch/x86/include/asm/ftrace.h > >> +++ b/arch/x86/include/asm/ftrace.h > >> @@ -13,7 +13,7 @@ > >> #ifdef

[PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c

2023-07-24 Thread sunran001
Fix the following errors reported by checkpatch: ERROR: "foo* bar" should be "foo *bar" ERROR: spaces required around that '=' (ctx:VxW) ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 6 +++--- 1 file changed, 3

[PATCH] drm/radeon: that open brace { should be on the previous line

2023-07-24 Thread sunran001
ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/rv770_smc.c | 36 ++ 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/radeon/rv770_smc.c b/drivers/gpu/drm/radeon/rv770_smc.c

[PATCH] drm/amd/pm: Clean up errors in smu_v13_0_1_pmfw.h

2023-07-24 Thread sunran001
Fix the following errors reported by checkpatch: ERROR: trailing whitespace Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in smu_v11_0_7_pptable.h

2023-07-24 Thread sunran001
Fix the following errors reported by checkpatch: ERROR: trailing whitespace ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- .../amd/pm/swsmu/inc/smu_v11_0_7_pptable.h| 41 +-- 1 file changed, 19 insertions(+), 22 deletions(-) diff

[PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-24 Thread sunran001
ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- .../amd/pm/swsmu/inc/smu_v13_0_7_pptable.h| 21 +++ 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0_7_pptable.h

Re: [PATCH AUTOSEL 4.14 1/9] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-07-24 Thread Pavel Machek
Hi! > From: hackyzh002 > > [ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ] > > The type of size is unsigned, if size is 0x4000, there will be an > integer overflow, size will be zero after size *= sizeof(uint32_t), > will cause uninitialized memory to be referenced later I

[PATCH] drm/radeon/si_dpm: open brace '{' following struct go on the same line

2023-07-24 Thread sunran001
ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/sislands_smc.h | 51 +-- 1 file changed, 17 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/radeon/sislands_smc.h

Re: radeon.ko/i586: BUG: kernel NULL pointer dereference, address:00000004

2023-07-24 Thread kkabe
Since the problem with enabling FTRACE_MCOUNT_MAX_OFFSET may be test_for_valid_rec() returning wrong results, I made a small patch to catch the result: patch-test_for_valid_rec-printk.patch diff -up ./kernel/trace/ftrace.c.ft ./kernel/trace/ftrace.c ---

[PATCH] drm/radeon: Move assignment outside if condition

2023-07-24 Thread sunran001
Fixes the following checkpatch errors: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/radeon_legacy_tv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_legacy_tv.c

[PATCH] drm/radeon: that open brace { should be on the previous line

2023-07-24 Thread sunran001
ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/clearstate_si.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/clearstate_si.h b/drivers/gpu/drm/radeon/clearstate_si.h index

Re: radeon.ko/i586: BUG: kernel NULL pointer dereference,address:00000004

2023-07-24 Thread Steven Rostedt
On Sun, 23 Jul 2023 20:55:06 +0900 wrote: > So I tried to trap NULL and return: > > patch-drm_vblank_cancel_pending_works-printk-NULL-ret.patch > diff -up ./drivers/gpu/drm/drm_vblank_work.c.pk2 > ./drivers/gpu/drm/drm_vblank_work.c > ---

[PATCH] drm/amd/pm: open brace '{' following function definitions go on the next line

2023-07-24 Thread sunran001
ERROR: open brace '{' following function definitions go on the next line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c

[PATCH] drm/radeon: add missing spaces after ',' and else should follow close brace '}'

2023-07-24 Thread sunran001
ERROR: else should follow close brace '}' ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/radeon_connectors.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c

[PATCH] drm/amd/pm: Clean up errors in navi10_ppt.c

2023-07-24 Thread sunran001
Fix the following errors reported by checkpatch: ERROR: open brace '{' following function definitions go on the next line ERROR: space required before the open parenthesis '(' ERROR: space required after that ',' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxW) Signed-off-by: Ran Sun

[PATCH] drm/amd/pm: Clean up errors in smu11_driver_if_sienna_cichlid.h

2023-07-24 Thread sunran001
Fix the following errors reported by checkpatch: ERROR: trailing whitespace Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in sienna_cichlid_ppt.c

2023-07-24 Thread sunran001
Fix the following errors reported by checkpatch: ERROR: space required after that ',' (ctx:VxV) ERROR: space required before the open parenthesis '(' ERROR: spaces required around that '=' (ctx:VxW) Signed-off-by: Ran Sun --- .../drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 16

[PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c

2023-07-24 Thread sunran001
Fix the following errors reported by checkpatch: ERROR: spaces required around that '=' (ctx:VxW) ERROR: spaces required around that '>=' (ctx:WxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-07-24 Thread Andrew Lunn
> @@ -1395,6 +1395,8 @@ int ieee80211_register_hw(struct ieee80211_hw *hw) > debugfs_hw_add(local); > rate_control_add_debugfs(local); > > + ieee80211_check_wbrf_support(local); > + > rtnl_lock(); > wiphy_lock(hw->wiphy); > > +void

[PATCH] drm/amd/pm: add missing spaces before '('

2023-07-24 Thread sunran001
ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c

Re: radeon.ko/i586: BUG: kernel NULL pointer dereference, address:00000004

2023-07-24 Thread kabe
rost...@goodmis.org sed in <20230717113623.41878...@gandalf.local.home> >> On Fri, 14 Jul 2023 14:34:04 +0900 >> wrote: >> >> > Patch in >> > https://bugzilla.kernel.org/show_bug.cgi?id=217669#c4 >> > fixed the problem in freedesktop.org kernel 5.18.0-rc2 . >> > This may explain that in

[PATCH] drm/radeon: add missing spaces before ';'

2023-07-24 Thread sunran001
ERROR: space required after that ';' (ctx:BxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/radeon_vce.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c index ca4a36464340..d1871af967d4

[PATCH] drm/amd/pm: Clean up errors in smu11_driver_if_sienna_cichlid.h

2023-07-24 Thread sunran001
Fix the following errors reported by checkpatch: ERROR: trailing whitespace ERROR: space prohibited before open square bracket '[' ERROR: space prohibited before that close square bracket ']' Signed-off-by: Ran Sun --- .../pmfw_if/smu11_driver_if_sienna_cichlid.h | 386 +- 1

[PATCH] drm/amd/pm: that open brace { should be on the previous line

2023-07-24 Thread sunran001
ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_11_0_cdr_table.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/smu_11_0_cdr_table.h

Re: radeon.ko/i586: BUG: kernel NULL pointerdereference, address:00000004

2023-07-24 Thread kkabe
rost...@goodmis.org sed in <20230717112138.1fd48...@gandalf.local.home> >> On Sat, 15 Jul 2023 11:39:11 +0900 >> wrote: >> >> >> > Yes, this is puzzling. That's why I need other people's opinion on this. >> > Does it matter the DUT is a slow machine (Pentium 120MHz)? >> > >> >> Hmm, I wonder

[PATCH] drm/amd/pm:open brace '{' following function definitions go on the next line

2023-07-24 Thread sunran001
ERROR: open brace '{' following function definitions go on the next line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c

Re: [PATCH v3 0/9] PCI/VGA: Improve the default VGA device selection

2023-07-24 Thread suijingfeng
Hi, On 2023/7/20 03:32, Bjorn Helgaas wrote: "drm/loongson: Add an implement for ..." also solves a problem, but it lacks a commit log, so I don't know what the problem is. I have already telling you one yeas ago. I want remove the pci_fixup_vgadev() function in arch/loongarch/pci/pci.c I

Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-24 Thread suijingfeng
Hi, Thanks for you noticed my change. On 2023/7/20 03:32, Bjorn Helgaas wrote: @@ -1509,13 +1543,24 @@ static int pci_notify(struct notifier_block *nb, unsigned long action, * cases of hotplugable vga cards. */ - if (action == BUS_NOTIFY_ADD_DEVICE) + switch

Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-24 Thread suijingfeng
Hi, On 2023/7/20 03:32, Bjorn Helgaas wrote: 2) It does not take the PCI Bar may get relocated into consideration. 3) It is not effective for the PCI device without a dedicated VRAM Bar. 4) It is device-agnostic, thus it has to waste the effort to iterate all of the PCI Bar to find the VRAM

Re: [PATCH] drm/amd/pm: Clean up errors in sienna_cichlid_ppt.c

2023-07-24 Thread kernel test robot
Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.5-rc3 next-20230724

Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-24 Thread suijingfeng
Hi, I was too hurry reply to you. I'm may miss the point for part of your reviews, Sorry. On 2023/7/20 03:32, Bjorn Helgaas wrote: CONFIG_DRM_AST is a tristate. We're talking about identifying the boot-time console device. Yes, my patch will only works *after* the module gets loaded

Re: [PATCH] drm/amd/pm: Clean up errors in sienna_cichlid_ppt.c

2023-07-24 Thread kernel test robot
Hi, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.5-rc3 next-20230724] [If your

Re: [PATCH AUTOSEL 6.1 28/41] Revert "drm/amd/display: Do not set drr on pipe commit"

2023-07-24 Thread Michel Dänzer
On 7/24/23 03:21, Sasha Levin wrote: > From: Michel Dänzer > > [ Upstream commit 8e1b45c578b799510f9a01a9745a737e74f43cb1 ] > > This reverts commit 474f01015ffdb74e01c2eb3584a2822c64e7b2be. The reverted commit is the same as patch 1 in this series... Same issue with the autosel patches for

RE: [PATCH V2] drm/amdgpu: remove redundant variable declaration

2023-07-24 Thread Chen, Guchun
[Public] Reviewed-by: Guchun Chen > -Original Message- > From: Bob Zhou > Sent: Monday, July 24, 2023 4:36 PM > To: amd-gfx@lists.freedesktop.org; Pelloux-Prayer, Pierre-Eric eric.pelloux-pra...@amd.com> > Cc: Chen, Guchun ; Zhou, Bob > > Subject: [PATCH V2] drm/amdgpu: remove

[PATCH V2] drm/amdgpu: remove redundant variable declaration

2023-07-24 Thread Bob Zhou
building with gcc and W=1 reports drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:1618:15: error: unused variable 'domain' [-Werror=unused-variable] unsigned int domain; ^~ The variable domain is repeated, so remove it. Fixes: d769528e4649 ("drm/amdgpu: add VISIBLE info in

RE: [PATCH] drm/amdgpu: remove repeat variable domain

2023-07-24 Thread Chen, Guchun
[Public] Please add a Fixes tag like "Fixes: d769528e4649 ("drm/amdgpu: add VISIBLE info in amdgpu_bo_print_info")" in commit message. Regards, Guchun > -Original Message- > From: Bob Zhou > Sent: Monday, July 24, 2023 2:43 PM > To: amd-gfx@lists.freedesktop.org; Pelloux-Prayer,

RE: [PATCH] drm/amdgpu: Remove else after return in 'is_fru_eeprom_supported'

2023-07-24 Thread Chen, Guchun
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Srinivasan Shanmugam > Sent: Sunday, July 23, 2023 2:38 PM > To: Koenig, Christian ; Deucher, Alexander > > Cc: SHANMUGAM, SRINIVASAN ; > amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: Remove else after return in

[PATCH] drm/amdgpu: remove repeat variable domain

2023-07-24 Thread Bob Zhou
building with gcc and W=1 reports drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:1618:15: error: unused variable 'domain' [-Werror=unused-variable] unsigned int domain; ^~ The variable domain is repeated, so remove it. Signed-off-by: Bob Zhou ---