On 7/26/2023 8:17 AM, Srinivasan Shanmugam wrote:
ENOSYS should be used for nonexistent syscalls only, replace ENOSYS with
ENOTSUPP
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
+ if (r == -ENOSYS)
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
+ if (r
[Public]
Reviewed-by: Guchun Chen
> -Original Message-
> From: amd-gfx On Behalf Of
> Srinivasan Shanmugam
> Sent: Tuesday, July 25, 2023 8:04 PM
> To: Koenig, Christian ; Deucher, Alexander
>
> Cc: SHANMUGAM, SRINIVASAN ;
> amd-gfx@lists.freedesktop.org
> Subject: [PATCH] drm/amdgpu:
ENOSYS should be used for nonexistent syscalls only, replace ENOSYS with
ENOTSUPP
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
+ if (r == -ENOSYS)
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
+ if (r == -ENOSYS)
And other following style fixes in
[AMD Official Use Only - General]
Thanks Alex for the input, yeah it requires check the SDMA firmware version to
resolve the wild release package driver and I will update it in a new patch.
Regards,
--Prike
> -Original Message-
> From: Alex Deucher
> Sent: Tuesday, July 25, 2023 9:16
Am 2023-07-25 um 17:11 schrieb Ramesh Errabolu:
Extend checkpoint logic to allow inclusion of VRAM BOs that
do not have a VA attached
Signed-off-by: Ramesh Errabolu
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
On Mon, Jul 24, 2023 at 08:47:48PM +0800, suijingfeng wrote:
> On 2023/7/20 03:32, Bjorn Helgaas wrote:
> > "drm/loongson: Add an implement for ..." also solves a problem, but it
> > lacks a commit log, so I don't know what the problem is.
>
> I have already telling you one yeas ago.
The patch
On Mon, Jul 24, 2023 at 08:16:18PM +0800, suijingfeng wrote:
> On 2023/7/20 03:32, Bjorn Helgaas wrote:
> > > 2) It does not take the PCI Bar may get relocated into consideration.
> > > 3) It is not effective for the PCI device without a dedicated VRAM Bar.
> > > 4) It is device-agnostic, thus it
Extend checkpoint logic to allow inclusion of VRAM BOs that
do not have a VA attached
Signed-off-by: Ramesh Errabolu
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
On 7/25/23 15:09, Andrew Lunn wrote:
This comes back to the point that was mentioned by Johannes - you need to
have deep design understanding of the hardware to know whether or not you
will have producers that a consumer need to react to.
Yes, this is the policy is keep referring to. I would
> This comes back to the point that was mentioned by Johannes - you need to
> have deep design understanding of the hardware to know whether or not you
> will have producers that a consumer need to react to.
Yes, this is the policy is keep referring to. I would expect that
there is something
Am 2023-07-25 um 16:04 schrieb Errabolu, Ramesh:
[AMD Official Use Only - General]
Responses inline.
-Original Message-
From: Kuehling, Felix
Sent: Monday, July 24, 2023 2:51 PM
To: amd-gfx@lists.freedesktop.org; Errabolu, Ramesh
Subject: Re: [PATCH] drm/amdgpu: Checkpoint and
[AMD Official Use Only - General]
Responses inline.
-Original Message-
From: Kuehling, Felix
Sent: Monday, July 24, 2023 2:51 PM
To: amd-gfx@lists.freedesktop.org; Errabolu, Ramesh
Subject: Re: [PATCH] drm/amdgpu: Checkpoint and Restore VRAM BOs without VA
On 2023-07-24 11:57, Ramesh
[Public]
> -Original Message-
> From: Huang, JinHuiEric
> Sent: Tuesday, July 25, 2023 2:16 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Kim, Jonathan ; Huang, JinHuiEric
>
> Subject: [PATCH] drm/amdgpu: enable trap of each kfd vmid for gfx v9.4.3
>
> To setup ttmp on as default for gfx
> > >> @@ -1395,6 +1395,8 @@ int ieee80211_register_hw(struct
> > ieee80211_hw *hw)
> > >>debugfs_hw_add(local);
> > >>rate_control_add_debugfs(local);
> > >>
> > >> + ieee80211_check_wbrf_support(local);
> > >> +
> > >>rtnl_lock();
> > >>wiphy_lock(hw->wiphy);
> > >>
> > >
> > >>
On 2023-07-24 15:01, Jonathan Kim wrote:
The MES cached process context must be cleared on adding any queue for
the first time.
For proper debug support, the MES will clear it's cached process context
on the first call to SET_SHADER_DEBUGGER.
This allows TTMPs to be pesistently enabled in a
On 7/25/2023 13:57, Andrew Lunn wrote:
@@ -1395,6 +1395,8 @@ int ieee80211_register_hw(struct
ieee80211_hw *hw)
debugfs_hw_add(local);
rate_control_add_debugfs(local);
+ ieee80211_check_wbrf_support(local);
+
rtnl_lock();
wiphy_lock(hw->wiphy);
+void
To setup ttmp on as default for gfx v9.4.3 in IP hw init.
Signed-off-by: Eric Huang
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
index
Already applied the fix for this from Dan.
Thanks!
Alex
On Tue, Jul 25, 2023 at 9:21 AM Yang Yingliang wrote:
>
> Add missing mutex_unlock() in error path in
> dm_handle_mst_sideband_msg_ready_event().
>
> Fixes: 4f6d9e38c4d2 ("drm/amd/display: Add polling method to handle MST reply
>
On 7/24/23 19:52, Philip Yang wrote:
> start_cpsch map queues when kfd_init_node have race condition with
> IOMMUv2 init, and cause the gfx ring test failed later. Remove it
> from start_cpsch because map queues will be done when creating queues
> and resume queues.
>
> Reported-by: Michel Dänzer
On 7/25/23 17:05, Marek Olšák wrote:
> On Tue, Jul 25, 2023 at 4:03 AM Michel Dänzer
> wrote:
>> On 7/25/23 04:55, André Almeida wrote:
>>> Hi everyone,
>>>
>>> It's not clear what we should do about non-robust OpenGL apps after GPU
>>> resets, so I'll try to summarize the topic, show some
Applied. Thanks!
On Tue, Jul 25, 2023 at 3:19 AM wrote:
>
> Fix the error(s):
>
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Yonggang Wu
> ---
> drivers/gpu/drm/radeon/r300.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
I applied the same patch from Ran yesterday.
Thanks!
Alex
On Tue, Jul 25, 2023 at 9:23 AM wrote:
>
> Fix the error(s):
> ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Yonggang Wu
> ---
> drivers/gpu/drm/radeon/atom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
On Tue, Jul 25, 2023 at 4:03 AM Michel Dänzer
wrote:
>
> On 7/25/23 04:55, André Almeida wrote:
> > Hi everyone,
> >
> > It's not clear what we should do about non-robust OpenGL apps after GPU
> > resets, so I'll try to summarize the topic, show some options and my
> > proposal to move forward
add session context buffer to decoder ring test for vcn v1 to v3.
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 33 ++---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 5 +++-
2 files changed, 28
On 7/23/2023 11:45 AM, Srinivasan Shanmugam wrote:
ENOSYS should be used for nonexistent syscalls only, replace ENOSYS with
EINVAL & other style fixes
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
+ if (r == -ENOSYS)
WARNING: ENOSYS means 'invalid syscall nr' and nothing
[Public]
Honestly, just updating the commit message to reflect the one {} change and the
S_IRUGO change should be sufficient.
Kent
> -Original Message-
> From: amd-gfx On Behalf Of Russell,
> Kent
> Sent: Tuesday, July 25, 2023 9:44 AM
> To: Chen, Guchun ; SHANMUGAM, SRINIVASAN
> ;
[AMD Official Use Only - General]
Acked-by: Alex Deucher
From: Lazar, Lijo
Sent: Tuesday, July 25, 2023 9:48 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Deucher, Alexander
Subject: [PATCH] drm/amdgpu: Match against exact bootloader status
On
On PSP v13.x ASICs, boot loader will set only the MSB to 1 and clear the
least significant bits for any command submission. Hence match against
the exact register value, otherwise a register value of all 0xFFs also
could falsely indicate that boot loader is ready. Also, from PSP v13.0.6
and newer,
[Public]
The S_IRUGO stuff be split from the ENOSYS stuff, since they're separate. Also
the S_IRUGO stuff isn't mentioned in the commit message.
Kent
> -Original Message-
> From: amd-gfx On Behalf Of Chen,
> Guchun
> Sent: Tuesday, July 25, 2023 1:06 AM
> To: SHANMUGAM, SRINIVASAN ;
Fix the error(s):
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Yonggang Wu
---
drivers/gpu/drm/radeon/atom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/atom.c
b/drivers/gpu/drm/radeon/atom.c
index 11a1940bb26d..93acb0e42bd6 100644
Add missing mutex_unlock() in error path in
dm_handle_mst_sideband_msg_ready_event().
Fixes: 4f6d9e38c4d2 ("drm/amd/display: Add polling method to handle MST reply
packet")
Signed-off-by: Yang Yingliang
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 1 +
1 file changed, 1
On Mon, Jul 24, 2023 at 11:01 PM Chen, Guchun wrote:
>
> [Public]
>
> > -Original Message-
> > From: amd-gfx On Behalf Of Alex
> > Deucher
> > Sent: Tuesday, July 25, 2023 4:05 AM
> > To: amd-gfx@lists.freedesktop.org
> > Cc: Deucher, Alexander ; Li, Ben
> >
> > Subject: [PATCH 2/3]
Reviewed-by: Alex Deucher
On Tue, Jul 25, 2023 at 8:04 AM Srinivasan Shanmugam
wrote:
>
> Fixes the following:
>
> WARNING: do not add new typedefs
>
> Cc: Christian König
> Cc: Alex Deucher
> Signed-off-by: Srinivasan Shanmugam
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h | 27
Reviewed-by: Alex Deucher
On Tue, Jul 25, 2023 at 9:16 AM Srinivasan Shanmugam
wrote:
>
> Changed from printk to dev_* variants so that
> we get better debug info when there are multiple GPUs
> in the system.
>
> Fixes other style issue:
>
> ERROR: open brace '{' following function definitions
Changed from printk to dev_* variants so that
we get better debug info when there are multiple GPUs
in the system.
Fixes other style issue:
ERROR: open brace '{' following function definitions go on the next line
WARNING: printk() should include KERN_ facility level
Cc: Christian König
Cc:
On Tue, Jul 25, 2023 at 5:20 AM Prike Liang wrote:
>
> Now the SDMA firmware support SDMA MGCG properly,
> so let's enable it from the driver side.
If this is only supported on certain firmware versions, do we need a
version check?
Alex
>
> Signed-off-by: Prike Liang
> ---
>
Hi Michel,
Em 25/07/2023 05:03, Michel Dänzer escreveu:
On 7/25/23 04:55, André Almeida wrote:
Hi everyone,
It's not clear what we should do about non-robust OpenGL apps after GPU resets,
so I'll try to summarize the topic, show some options and my proposal to move
forward on that.
Em
Fixes the following:
WARNING: do not add new typedefs
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h | 27 ++--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git
[AMD Official Use Only - General]
> -Original Message-
> From: Limonciello, Mario
> Sent: Monday, July 24, 2023 9:41 PM
> To: Andrew Lunn ; Quan, Evan
> Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander
> ; Koenig, Christian
> ; Pan, Xinhui ;
> airl...@gmail.com;
[AMD Official Use Only - General]
Reviewed-by: shikaguo
-Original Message-
From: Liang, Prike
Sent: Tuesday, July 25, 2023 5:20 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Guo, Shikai
; Liang, Prike
Subject: [PATCH] drm/amdgpu: enable SDMA MGCG for SDMA 5.2.x
Now
Now the SDMA firmware support SDMA MGCG properly,
so let's enable it from the driver side.
Signed-off-by: Prike Liang
---
drivers/gpu/drm/amd/amdgpu/nv.c| 6 --
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git
On 7/24/23 22:04, Philip Yang wrote:
> Hi Michel,
>
> Please check if this patch "drm/amdkfd: start_cpsch don't map queues" can fix
> the driver loading ring test failed issue on your system, I am still not able
> to repro the issue.
I'm planning to test it this week, thanks for the heads up.
On 7/25/23 04:55, André Almeida wrote:
> Hi everyone,
>
> It's not clear what we should do about non-robust OpenGL apps after GPU
> resets, so I'll try to summarize the topic, show some options and my proposal
> to move forward on that.
>
> Em 27/06/2023 10:23, André Almeida escreveu:
>>
[AMD Official Use Only - General]
Reviewed-by: Asad Kamal
Thanks & Regards
Asad
-Original Message-
From: Zhang, Hawking
Sent: Tuesday, July 25, 2023 11:23 AM
To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Kamal, Asad
Subject: RE: [PATCH] drm/amdgpu: Restore
Fix the error(s):
ERROR: space required before the open parenthesis '('
Signed-off-by: Yonggang Wu
---
drivers/gpu/drm/radeon/r300.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/r300.c
b/drivers/gpu/drm/radeon/r300.c
index
On Tuesday, July 25th, 2023 at 04:55, André Almeida
wrote:
> It's not clear what we should do about non-robust OpenGL apps after GPU
> resets, so I'll try to summarize the topic, show some options and my
> proposal to move forward on that.
>
> Em 27/06/2023 10:23, André Almeida escreveu:
>
>
46 matches
Mail list logo
