RE: [PATCH] drm/amd/pm: Fix SMU v13.0.6 energy reporting

[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Wednesday, August 2, 2023 12:56 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kasiviswanathan, Harish Subject: [PATCH] drm/amd/pm:

Re: [PATCH] drm/amdgpu: Remove volatile from 'wb' & from 'ptr' in amdgpu.h

On 7/24/2023 10:43 PM, Alex Deucher wrote: On Mon, Jul 24, 2023 at 11:54 AM Srinivasan Shanmugam wrote: Fixes the following from checkpatch.pl: WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst + volatile uint32_t *wb;

[PATCH 2/2] drm/amd/pm: correct the logics for retreiving SMU13 OD setting limits

To better meet the growing demainds for more OD features. Signed-off-by: Evan Quan --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 70 +-- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 70 +-- 2 files changed, 64 insertions(+), 76 deletions(-) diff --git

[PATCH 1/2] drm/amd/pm: correct the way for checking custom OD settings

`FeatureCtrlMask` should not be included in those settings interested. Signed-off-by: Evan Quan --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 16 .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 16 2 files changed, 16 insertions(+), 16 deletions(-)

Re: [PATCH 1/3] drm/amdkfd: Sync trap handler binaries with source

On 2023-07-31 16:40, Jay Cornwall wrote: Some changes have been lost during rebases. Rebuild sources. Signed-off-by: Jay Cornwall The series is Reviewed-by: Felix Kuehling --- .../gpu/drm/amd/amdkfd/cwsr_trap_handler.h| 741 +- 1 file changed, 371 insertions(+),

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

On Wed, Aug 02, 2023 at 10:01:19PM +0300, Dmitry Baryshkov wrote: > On 02/08/2023 21:55, Laurent Pinchart wrote: > > Hi Dmitry, > > > > Thank you for the patch. > > > > On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: > >> To properly define the USB-C DP altmode connectors, add

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: > To properly define the USB-C DP altmode connectors, add the USB > subconnector type. > > Suggested-by: Simon Ser > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/drm_connector.c |

Re: [PATCH 1/4] drm: allow specifying default subtype for the DP subconnector property

Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:10AM +0300, Dmitry Baryshkov wrote: > In the embedded usecases the default subtype depends on the bridge > chain, so it is easier to specify the subtype at the proprety attachment s/proprety/property/ > type rather than

Re: [PATCH 2/4] drm/bridge-connector: handle subconnector types

On Wed, Aug 02, 2023 at 12:05:50PM +0300, Dmitry Baryshkov wrote: > On Wed, 2 Aug 2023 at 11:35, Neil Armstrong wrote: > > On 29/07/2023 02:49, Dmitry Baryshkov wrote: > > > If the created connector type supports subconnector type property, > > > create and attach corresponding it. The default

Re: [PATCH] drm/amd/display: Clean up errors in dmub_cmd.h

Hi Ran, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.5-rc4 next-20230802] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH] drm/amd/display: check attr flag before set cursor degamma on DCN3+

Thanks. Change is merged to amd-staging-drm-next. Harry On 2023-08-01 00:07, Alex Hung wrote: > Tested-by: Alex Hung > > On 2023-07-31 02:35, Melissa Wen wrote: >> Don't set predefined degamma curve to cursor plane if the cursor >> attribute flag is not set. Applying a degamma curve to the

Re: [PATCH v5 6/6] drm/doc: Define KMS atomic state set

On Mon, 31 Jul 2023 at 04:01, André Almeida wrote: > > Em 13/07/2023 04:51, Pekka Paalanen escreveu: > > On Tue, 11 Jul 2023 10:57:57 +0200 > > Daniel Vetter wrote: > > > >> On Fri, Jul 07, 2023 at 07:40:59PM -0300, André Almeida wrote: > >>> From: Pekka Paalanen > >>> > >>> Specify how the

Re: [PATCH] drm/amdgpu: Always emit GDS switch when GDS/GWS/OA is used

Gentle ping. Any updates on this yet? Thanks, Friedrich On 20.07.23 23:25, Friedrich Vock wrote: Hi, On 07.07.23 10:21, Christian König wrote: Am 07.07.23 um 09:28 schrieb Friedrich Vock: Hi Christian, On 07.07.23 08:56, Christian König wrote: Am 07.07.23 um 08:28 schrieb Friedrich

Re: [PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h

On Wed, 02 Aug 2023, Bagas Sanjaya wrote: > On 01/08/2023 18:34, Jani Nikula wrote: >> On Tue, 01 Aug 2023, Bagas Sanjaya wrote: >>> And it is unfortunate that you and @208suo.com people doesn't reply to >>> review comments (try searching lore.kernel.org) >> >> Essentially a one-way firehose of

Re: [PATCH 2/4] drm/bridge-connector: handle subconnector types

On 29/07/2023 02:49, Dmitry Baryshkov wrote: If the created connector type supports subconnector type property, create and attach corresponding it. The default subtype value is 0, which maps to the DRM_MODE_SUBCONNECTOR_Unknown type. Signed-off-by: Dmitry Baryshkov ---

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

On 8/2/23 09:38, Marek Olšák wrote: > > The precedent from the CPU land is pretty strong here. There is > SIGSEGV for invalid CPU memory access and SIGILL for invalid CPU > instructions, yet we do nothing for invalid GPU memory access and > invalid GPU instructions. Sending a terminating signal

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

A screen that doesn't update isn't usable. Killing the window system and returning to the login screen is one option. Killing the window system manually from a terminal or over ssh and then returning to the login screen is another option, but 99% of users either hard-reset the machine or do

[PATCH] drm/amd/pm: Clean up errors in smu7_fusion.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/inc/smu7_fusion.h| 42 +++ 1 file changed, 16

[PATCH] drm/amd: Clean up errors in smu7_hwmgr.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 26

[PATCH] drivers/amd/pm: Clean up errors in smu8_smumgr.h

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 48 -- 1 file changed, 17 insertions(+), 31

[PATCH] drm/amd/pm: Clean up errors in r600_dpm.h

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/legacy-dpm/r600_dpm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/r600_dpm.h

[PATCH] drm/amdgpu: Clean up errors in uvd_v7_0.c

Fix the following errors reported by checkpatch: ERROR: spaces required around that ':' (ctx:VxE) that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH] drm/amdgpu: Clean up errors in mxgpu_nv.c

Fix the following errors reported by checkpatch: ERROR: else should follow close brace '}' ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h

On Tue, Aug 01, 2023 at 10:00:24AM +, Ran Sun wrote: > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: trailing whitespace > ERROR: space prohibited before open square bracket '[' > Thanks for fixing up your tooling to

[PATCH] drm/amd/display: Clean up errors in dc_stream.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] drm/amd/display: Clean up errors in display_mode_vba_30.c

Fix the following errors reported by checkpatch: ERROR: else should follow close brace '}' Signed-off-by: Ran Sun --- .../gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH] drm/amdgpu/jpeg: Clean up errors in vcn_v1_0.c

Fix the following errors reported by checkpatch: ERROR: space required before the open parenthesis '(' ERROR: space prohibited after that '~' (ctx:WxW) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in hardwaremanager.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] drm/amdgpu: Clean up errors in vega20_ih.c

Fix the following errors reported by checkpatch: ERROR: trailing statements should be on next line ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in smu71.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu71.h | 22 +++- 1 file changed, 8 insertions(+),

[PATCH] drm/amdgpu: Clean up errors in dce_v10_0.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 30 +- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in hwmgr.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: Use C99 flexible arrays Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in polaris_baco.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/hwmgr/polaris_baco.c | 30 +++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in tonga_baco.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/hwmgr/tonga_baco.c | 30 +++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: trailing whitespace ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/inc/smu73_discrete.h | 73 --- 1

[PATCH] drm/amd/pm: Clean up errors in vega12_hwmgr.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following enum go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] drm/amdgpu: Clean up errors in mmhub_v9_4.c

Fix the following errors reported by checkpatch: ERROR: code indent should use tabs where possible ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in smu8_smumgr.h

Fix the following errors reported by checkpatch: ERROR: Use C99 flexible arrays Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h

[PATCH] gpu: amd: Clean up errors in ppatomfwctrl.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in smu75.h

Fix the following errors reported by checkpatch: ERROR: space prohibited before open square bracket '[' ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] drm/amdgpu: Clean up errors in vce_v3_0.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c

[PATCH] drm/amd/display: Clean up errors in dce_clk_mgr.c

Fix the following errors reported by checkpatch: ERROR: spaces required around that '?' (ctx:VxE) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/dce/dce_clk_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clk_mgr.c

[PATCH] drm/amdgpu: Clean up errors in ih_v6_0.c

Fix the following errors reported by checkpatch: ERROR: trailing statements should be on next line ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] drm/amd/display: Clean up errors in dce110_hw_sequencer.c

Fix the following errors reported by checkpatch: ERROR: space required before the open brace '{' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/amd/dc: Clean up errors in hpd_regs.h

Fix the following errors reported by checkpatch: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/gpio/hpd_regs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH] drm/amd: Clean up errors in pptable_v1_0.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/pptable_v1_0.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] drm/amdgpu: Clean up errors in ppatomctrl.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in amdgpu_pm.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amdgpu: Clean up errors in amdgpu_psp.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: open brace '{' following enum go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 12 1 file changed, 4 insertions(+), 8

[PATCH] drm/amd/display: Clean up errors in dcn316_smu.c

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- .../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 18 -- 1 file changed, 8 insertions(+), 10

[PATCH] drm/amd: Clean up errors in processpptables.c

Fix the following errors reported by checkpatch: ERROR: open brace '{' following function definitions go on the next line ERROR: code indent should use tabs where possible ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun ---

[PATCH -next] drm/amd/pm: Remove many unnecessary NULL values

Ther are many pointers assigned first, which need not to be initialized, so remove the NULL assignment. Signed-off-by: Ruan Jinjie --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 +-

[PATCH] drm/amdgpu/atomfirmware: Clean up errors in amdgpu_atomfirmware.c

Fix the following errors reported by checkpatch: ERROR: spaces required around that '>=' (ctx:WxV) ERROR: spaces required around that '!=' (ctx:WxV) ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 8 1

[PATCH] drm/amd: Clean up errors in amdgpu_cgs.c

Fix the following errors reported by checkpatch: ERROR: switch and case should be at the same indent Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in kv_dpm.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space prohibited before that ',' (ctx:WxW) ERROR: need consistent spacing around '-' (ctx:WxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 48

[PATCH] drm/amdgpu/powerplay: Clean up errors in vega20_hwmgr.c

Fix the following errors reported by checkpatch: ERROR: code indent should use tabs where possible ERROR: space required before the open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Ran Sun --- .../gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c|

[PATCH] drm/amd/pm/powerplay/hwmgr/hwmgr: Clean up errors in hwmgr.c

Fix the following errors reported by checkpatch: ERROR: space prohibited after that '~' (ctx:WxW) ERROR: spaces required around that '||' (ctx:VxW) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] drm/amd/display: Clean up errors in ddc_regs.h

Fix the following errors reported by checkpatch: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun --- .../gpu/drm/amd/display/dc/gpio/ddc_regs.h| 40 +-- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in smu7.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH] drm/amd/display: Clean up errors in bios_parser2.c

Fix the following errors reported by checkpatch: ERROR: switch and case should be at the same indent ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- .../drm/amd/display/dc/bios/bios_parser2.c| 32 +-- 1 file changed, 16 insertions(+), 16

Re: [PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h

On 01/08/2023 18:34, Jani Nikula wrote: > On Tue, 01 Aug 2023, Bagas Sanjaya wrote: >> And it is unfortunate that you and @208suo.com people doesn't reply to >> review comments (try searching lore.kernel.org) > > Essentially a one-way firehose of patches pointed at our general > direction is not

[PATCH] drm/amd/pm: Clean up errors in sislands_smc.h

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- .../gpu/drm/amd/pm/legacy-dpm/sislands_smc.h | 63 +++ 1 file changed, 21 insertions(+), 42 deletions(-) diff --git

[PATCH] drm/amd/display: Clean up errors in color_gamma.c

Fix the following errors reported by checkpatch: ERROR: trailing whitespace ERROR: else should follow close brace '}' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH] drm/amd/display: Clean up errors in dmub_cmd.h

Fix the following errors reported by checkpatch: ERROR: Use C99 flexible arrays Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH] drm/amd/pm: Clean up errors in smu9_driver_if.h

Fix the following errors reported by checkpatch: ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/inc/smu9_driver_if.h | 20 +-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH] drm/amd/display: Clean up errors in dce110_timing_generator.c

Fix the following errors reported by checkpatch: ERROR: spaces required around that '=' (ctx:WxV) Signed-off-by: Ran Sun --- .../gpu/drm/amd/display/dc/dce110/dce110_timing_generator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd/display: Clean up errors in dcn315_smu.c

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- .../display/dc/clk_mgr/dcn315/dcn315_smu.c| 26 +-- 1 file changed, 12 insertions(+), 14

[PATCH] drm/amd/display: Clean up errors in dce112_hw_sequencer.c

Fix the following errors reported by checkpatch: ERROR: space required before the open brace '{' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/dce112/dce112_hw_sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in smu73.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu73.h | 45

[PATCH] drm/amd/pm: Clean up errors in vega10_pptable.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- .../amd/pm/powerplay/hwmgr/vega10_pptable.h| 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in vega20_pptable.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- .../amd/pm/powerplay/hwmgr/vega20_pptable.h | 19 --- 1 file changed, 8 insertions(+),

[PATCH] drm/amd/pm: Clean up errors in pp_thermal.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/pp_thermal.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH] drm/amd: Clean up errors in vega10_processpptables.c

Fix the following errors reported by checkpatch: ERROR: "foo* bar" should be "foo *bar" ERROR: space required before the open brace '{' ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- .../gpu/drm/amd/pm/powerplay/hwmgr/vega10_processpptables.c | 6 +++--- 1

[PATCH 6.1 066/228] drm/amd/display: fix dc/core/dc.c kernel-doc

From: Randy Dunlap [ Upstream commit db4107e92a817502ad19fdd30250f87dcb6f6331 ] Fix all kernel-doc warnings in dc/core/dc.c: dc.c:385: warning: missing initial short description on line: * dc_stream_adjust_vmin_vmax: dc.c:392: warning: contents before sections dc.c:399: warning: No

[PATCH 22/22] drm/amd/display: Promote DAL to 3.2.246

From: Martin Leung This version brings along following fixes: - Fix a regression in blank pixel data caused by coding mistake - Fix a bug when searching for insert_above_mpcc - Fix backlight off cmd for OLED panel - Update add plane to context logic with a new algorithm - Adjust visual confirm

[PATCH 21/22] drm/amd/display: Change HDCP update sequence for DM

From: Bhawanpreet Lakha Refactor the sequence in hdcp_update_display() to use mod_hdcp_update_display(). Previous sequence: - remove()->add() This Sequence was used to update the display, (mod_hdcp_update_display didn't exist at the time). This meant for any hdcp updates (type changes,

[PATCH 20/22] drm/amd/display: Fix backlight off cmd for OLED panel

From: Swapnil Patel [Why] Currently driver fails to send backlight off command while powering down. This is because in dce110_edp_backlight_control, current backlight status isn't being acccessed correctly for OLED panel with AUX control. [How] Add support for accessing current backlight status

[PATCH 19/22] drm/amd/display: rename acquire_idle_pipe_for_layer to acquire_free_pipe_as_sec_dpp_pipe

From: Wenjing Liu [why] Secondary DPP pipes are used for rendering secondary layers of planes. The name "for layer" doesn't make it obvious. The function is acquiring a free pipe as secondary dpp pipe only. We rename it so it is more obvious. In a future follow up change, we want to add

[PATCH 18/22] drm/amd/display: move idle pipe allocation logic into dcn specific layer

From: Wenjing Liu [why] generic dc resource file should not know what an optimal idle pipe is because this is dcn hardware dependent. [how] We move the optimial pipe searching logic in dcn specific layer. Reviewed-by: Jun Lei Acked-by: Tom Chung Signed-off-by: Wenjing Liu ---

[PATCH 17/22] drm/amd/display: Use max memclk variable when setting max memclk

From: Alvin Lee [Description] In overclocking scenarios the max memclk could be higher than the DC mode limit. However, for configs that don't support MCLK switching we need to set the max memclk to the overclocked max instead of the DC mode max or we could result in underflow. Reviewed-by:

[PATCH 15/22] drm/amd/display: Blocking invalid 420 modes on HDMI TMDS for DCN314

From: Leo Chen [Why & How] HDMI TMDS does not have ODM support. Filtering 420 modes that exceed the 4096 FMT limitation on DCN314 will resolve intermittent corruptions issues. Reviewed-by: Nicholas Kazlauskas Acked-by: Tom Chung Signed-off-by: Leo Chen ---

[PATCH 16/22] drm/amd/display: Add vendor Id for reference

From: Mike Hsieh Add a new vendor ID code for reference Reviewed-by: Wenjing Liu Acked-by: Tom Chung Signed-off-by: Mike Hsieh --- drivers/gpu/drm/amd/display/include/ddc_service_types.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 14/22] drm/amd/display: Blocking invalid 420 modes on HDMI TMDS for DCN31

From: Leo Chen [Why & How] HDMI TMDS does not have ODM support. Filtering 420 modes that exceed the 4096 FMT limitation on DCN31 will resolve intermittent corruptions issues. Reviewed-by: Nicholas Kazlauskas Acked-by: Tom Chung Signed-off-by: Leo Chen ---

[PATCH 13/22] drm/amd/display: Revert "dc: read down-spread percentage from lut to adjust dprefclk"

From: Leo Chen [Why & How] Revert commit feb90174e9c6 ("drm/amd/display: Read down-spread percentage from lut to adjust dprefclk.") This change was causing 240hz display to not light up after s0i3. Reviewed-by: Nicholas Kazlauskas Acked-by: Tom Chung Signed-off-by: Leo Chen ---

[PATCH 12/22] drm/amd/display: do not treat clip_rect size change as a scaling change

From: Wenjing Liu [why] With previous ODM + MPO policy we will only allocate pipes when MPO plane has intersection with current ODM slice. With this policy we have to indicate scaling change when plane clip is updated in case plane clip change causes MPO plane to go in or out current ODM slice.

[PATCH 10/22] drm/amd/display: update add plane to context logic with a new algorithm

From: Wenjing Liu [why] Preivous algorithm for finding an optimal idle pipe for a new plane was implemented to handle dynamic pipe allocation when MPO plane moves from one ODM slice to the other. Now pipe allocation is more static so it no longer depends on the MPO plane's position. We are

[PATCH 11/22] drm/amd/display: adjust visual confirm dpp height offset to be 1/240 of v addressable

From: Wenjing Liu [why] For timing with large v addressable visual confirm is just too small. It is difficult to tell visually which DPP we are using. On the other hand with timing with small v addressable visual confirm is too large and covers the UI area. [how] We calculate visual confirm

[PATCH 09/22] drm/amd/display: always acquire MPO pipe for every blending tree

From: Wenjing Liu [why] We only acquire MPO pipe for blending tree where the plane clip will be rendered. If an MPO plane is outside current ODM slice rect, we will skip pipe allocation. With new programming policy we want to allocate pipes for every ODM slice blending tree even for those whose

[PATCH 07/22] drm/amd/display: Use DTBCLK as refclk instead of DPREFCLK

From: Austin Zheng [Why] Flash of corruption observed when UCLK switching after transitioning from DTBCLK to DPREFCLK on subVP(DP) + subVP(HDMI) config Scenario where DPREFCLK is required instead of DTBCLK is not expected [How] Always set the DTBCLK source as DTBCLK0 Reviewed-by: Alvin Lee

[PATCH 08/22] drm/amd/display: support plane clip with zero recout size

From: Wenjing Liu [why] If plane clip is outside current pipe's ODM slice rect, our logic will fail validation because we assume that when a pipe is acquired to support a plane clip, it must blend some portion of the plane on the screen. This assumption needs to be changed. When a pipe is

[PATCH 06/22] drm/amd/display: Set Stream Update Flags in commit_state_no_check

From: Austin Zheng [Why] Front-end would be programmed using the stream update flags set from the previous update and the full update should be triggered whenever commit_state_no_check gets called. [How] Set all stream update flags before programming the front-end Clear all flags that got set

[PATCH 05/22] drm/amd/display: Make mpc32 functions available to future DCNs

From: Wesley Chalmers Make the mpc32 functions available for future DCNs to use Reviewed-by: Jun Lei Acked-by: Tom Chung Signed-off-by: Wesley Chalmers --- .../gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 28 - .../gpu/drm/amd/display/dc/dcn32/dcn32_mpc.h | 61 +++ 2

[PATCH 04/22] drm/amd/display: Fix a bug when searching for insert_above_mpcc

From: Wesley Chalmers [WHY] Currently, when insert_plane is called with insert_above_mpcc parameter that is equal to tree->opp_list, the function returns NULL. [HOW] Instead, the function should insert the plane at the top of the tree. Cc: Mario Limonciello Cc: Alex Deucher Cc:

[PATCH 03/22] drm/amd/display: Enable DPIA trace with DC debug mask

From: Stylon Wang [Why] DPIA traces from DMUB is not enabled by default, which is less convenient to debug DPIA related issues because we have to resort to other means to enable DPIA trace. [How] Reuse existing DC debug mask to enable DPIA trace log from kernel command line. This makes

[PATCH 02/22] drm/amd/display: Add interface to enable DPIA trace

From: Stylon Wang [Why] DPIA traces from DMUB is not enabled by default, which is less convenient to debug DPIA related issues because we have to resort to other debug tools to enable DPIA trace. [How] Exposes interfaces to update trace mask from the DMUB GPING commands. Also provides DC

[PATCH 01/22] drm/amd/display: fix a regression in blank pixel data caused by coding mistake

From: Wenjing Liu [why] There was unfortunately a coding mistake. It gets caught with an ultrawide monitor that requires ODM 4:1 combine. We are blanking or unblanking pixel data we are supposed to enumerate through all ODM pipes and program DPG for each of those pipes. However the coding

[PATCH 00/22] DC Patches Aug 04 2023

This DC patchset brings improvements in multiple areas. In summary, we have: - Fix a regression in blank pixel data caused by coding mistake - Fix a bug when searching for insert_above_mpcc - Fix backlight off cmd for OLED panel - Update add plane to context logic with a new algorithm - Adjust