Re: [PATCH v2] drm/amd/display: ensure async flips are only accepted for fast updates

2023-08-04 Thread Harry Wentland
On 2023-08-04 14:20, Hamza Mahfooz wrote: > We should be checking to see if async flips are supported in > amdgpu_dm_atomic_check() (i.e. not dm_crtc_helper_atomic_check()). Also, > async flipping isn't supported if a plane's framebuffer changes memory > domains during an atomic commit. So, move

[PATCH v2] drm/amd/display: ensure async flips are only accepted for fast updates

2023-08-04 Thread Hamza Mahfooz
We should be checking to see if async flips are supported in amdgpu_dm_atomic_check() (i.e. not dm_crtc_helper_atomic_check()). Also, async flipping isn't supported if a plane's framebuffer changes memory domains during an atomic commit. So, move the check from dm_crtc_helper_atomic_check() to amdg

Re: [PATCH] drm/amd/display: ensure async flips are only accepted for fast updates

2023-08-04 Thread Harry Wentland
On 2023-08-04 11:56, Hamza Mahfooz wrote: > We should be checking to see if async flips are supported in > amdgpu_dm_atomic_check() (i.e. not dm_crtc_helper_atomic_check()). Also, > async flipping isn't supported if a plane's framebuffer changes memory > domains during an atomic commit. So, move

Re: [PATCH] drm/amdkfd: wrap dynamic debug call with CONFIG_DYNAMIC_DEBUG_CORE

2023-08-04 Thread Felix Kuehling
I just applied Arnd Bergmann's patch "drm/amdkfd: fix build failure without CONFIG_DYNAMIC_DEBUG". This patch is no longer needed. Regards,   Felix On 2023-08-04 12:05, Alex Sierra wrote: This causes error compilation if CONFIG_DYNAMIC_DEBUG_CORE is not defined. Signed-off-by: Alex Sierra --

Re: [PATCH] drm/amdkfd: fix build failure without CONFIG_DYNAMIC_DEBUG

2023-08-04 Thread Felix Kuehling
On 2023-08-04 9:29, Arnd Bergmann wrote: From: Arnd Bergmann When CONFIG_DYNAMIC_DEBUG is disabled altogether, calling _dynamic_func_call_no_desc() does not work: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c: In function 'svm_range_set_attr': drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:5

[PATCH] drm/amdkfd: wrap dynamic debug call with CONFIG_DYNAMIC_DEBUG_CORE

2023-08-04 Thread Alex Sierra
This causes error compilation if CONFIG_DYNAMIC_DEBUG_CORE is not defined. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c index a69994ff1c2f..

[PATCH] drm/amd/display: ensure async flips are only accepted for fast updates

2023-08-04 Thread Hamza Mahfooz
We should be checking to see if async flips are supported in amdgpu_dm_atomic_check() (i.e. not dm_crtc_helper_atomic_check()). Also, async flipping isn't supported if a plane's framebuffer changes memory domains during an atomic commit. So, move the check from dm_crtc_helper_atomic_check() to amdg

Re: [PATCH 3/3] drm/mst: adjust the function drm_dp_remove_payload_part2()

2023-08-04 Thread Imre Deak
On Fri, Aug 04, 2023 at 02:20:29PM +0800, Wayne Lin wrote: > [...] > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c > b/drivers/gpu/drm/display/drm_dp_mst_topology.c > index e04f87ff755a..4270178f95f6 100644 > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/

Re: [PATCH] drm/amd/pm: avoid driver getting empty metrics table for the first time

2023-08-04 Thread Lazar, Lijo
[AMD Official Use Only - General] Missed one thing - please replace msleep(1) with usleep_range. Thanks, Lijo From: amd-gfx on behalf of Lazar, Lijo Sent: Friday, August 4, 2023 8:07:11 PM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Kamal, Asad

Re: [PATCH 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-08-04 Thread kernel test robot
Hi Wayne, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm/drm-next linus/master v6.5-rc4 next-20230804] [cannot apply to drm-intel/for-linux-next] [If your patch is applied

Re: [PATCH] drm/amd/pm: avoid driver getting empty metrics table for the first time

2023-08-04 Thread Lazar, Lijo
On 8/4/2023 8:02 PM, Yang Wang wrote: From: Yang Wang add metrics.AccumulationCouter check to avoid driver getting an empty metrics data since metrics table not updated completely in pmfw side. Signed-off-by: Yang Wang Reviewed-by: Asad Kamal Tested-by: Asad Kamal Reviewed-by: Lijo Laz

[PATCH] drm/amd/pm: avoid driver getting empty metrics table for the first time

2023-08-04 Thread Yang Wang
From: Yang Wang add metrics.AccumulationCouter check to avoid driver getting an empty metrics data since metrics table not updated completely in pmfw side. Signed-off-by: Yang Wang Reviewed-by: Asad Kamal Tested-by: Asad Kamal --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 20 ++

[PATCH] drm/amdkfd: fix build failure without CONFIG_DYNAMIC_DEBUG

2023-08-04 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_DYNAMIC_DEBUG is disabled altogether, calling _dynamic_func_call_no_desc() does not work: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c: In function 'svm_range_set_attr': drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:52:9: error: implicit declaration of functi

[PATCH] drm/amdgpu: Add FRU sysfs nodes only if needed

2023-08-04 Thread Lijo Lazar
Create sysfs nodes for FRU data only if FRU data is available. Move the logic to FRU specific file. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 70 +--- .../gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c| 81 +++ .../gpu/drm/amd/amdgpu/am

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-04 Thread Daniel Vetter
On Tue, Jun 27, 2023 at 10:23:23AM -0300, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: > https://lore.kernel.org/lkml/20230626183347.55118-

Re: [PATCH] drm/amd/pm: update smu_v13_0_6 message vf flag

2023-08-04 Thread Lazar, Lijo
On 8/4/2023 3:51 PM, Yang Wang wrote: v1: Enable following message in vf mode. - PPSMC_MSG_GetMinGfxclkFreqquency - PPSMC_MSG_GetMaxGfxclkFreqquency - PPSMC_MSG_GetMinDpmFreq - PPSMC_MSG_GetMaxDpmFreq these message will cause pp_dpm_* device node not work properly. v2: the following message

[PATCH] drm/amd/pm: update smu_v13_0_6 message vf flag

2023-08-04 Thread Yang Wang
v1: Enable following message in vf mode. - PPSMC_MSG_GetMinGfxclkFreqquency - PPSMC_MSG_GetMaxGfxclkFreqquency - PPSMC_MSG_GetMinDpmFreq - PPSMC_MSG_GetMaxDpmFreq these message will cause pp_dpm_* device node not work properly. v2: the following message is disabled in VF mode. (since pmfw 85.69.0

Re: [PATCH 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-08-04 Thread kernel test robot
Hi Wayne, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm/drm-next linus/master v6.5-rc4 next-20230804] [cannot apply to drm-intel/for-linux-next] [If your patch is applied

Re: [pull] amdgpu, amdkfd, radeon drm-next-6.6

2023-08-04 Thread Daniel Vetter
On Fri, Jul 28, 2023 at 05:42:28PM -0400, Alex Deucher wrote: > Hi Dave, Daniel, > > New stuff for 6.6. > > The following changes since commit 6725f33228077902ddac2a05e0ab361dee36e4ba: > > Merge tag 'drm-misc-next-fixes-2023-07-06' of > git://anongit.freedesktop.org/drm/drm-misc into drm-next

RE: [PATCH] Revert "drm/amdgpu: don't modify num_doorbells for mes"

2023-08-04 Thread Sharma, Shashank
[AMD Official Use Only - General] Nack to the revert. This is a whole series of doorbell changes, which has replacement for the patches too. https://patchwork.freedesktop.org/series/115802/ The whole series was pushed to staging branch, but looks like some of the patches did not merge. When th

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-04 Thread Dmitry Baryshkov
On Thu, 3 Aug 2023 at 18:31, Simon Ser wrote: > > On Thursday, August 3rd, 2023 at 17:22, Simon Ser wrote: > > > The KMS docs describe "subconnector" to be defined as "downstream port" for > > DP. > > Can USB-C (or USB) be seen as a DP downstream port? > > To expand on this a bit: I'm wondering

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-04 Thread Dmitry Baryshkov
On Thu, 3 Aug 2023 at 23:47, Simon Ser wrote: > > On Thursday, August 3rd, 2023 at 22:44, Laurent Pinchart > wrote: > > > On Thu, Aug 03, 2023 at 03:31:16PM +, Simon Ser wrote: > > > > > On Thursday, August 3rd, 2023 at 17:22, Simon Ser cont...@emersion.fr > > > wrote: > > > > > > > The KMS

Re: [PATCH v5 05/11] drm/amdgpu: Use RMW accessors for changing LNKCTL

2023-08-04 Thread Ilpo Järvinen
On Fri, 21 Jul 2023, Alex Deucher wrote: > On Fri, Jul 21, 2023 at 4:18 AM Ilpo Järvinen > wrote: > > > > On Thu, 20 Jul 2023, Bjorn Helgaas wrote: > > > > > On Mon, Jul 17, 2023 at 03:04:57PM +0300, Ilpo Järvinen wrote: > > > > Don't assume that only the driver would be accessing LNKCTL. ASPM >

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-04 Thread Dmitry Baryshkov
On Thu, 3 Aug 2023 at 18:43, Simon Ser wrote: > > On Thursday, August 3rd, 2023 at 17:36, Dmitry Baryshkov > wrote: > > > On Thu, 3 Aug 2023 at 18:31, Simon Ser cont...@emersion.fr wrote: > > > > > On Thursday, August 3rd, 2023 at 17:22, Simon Ser cont...@emersion.fr > > > wrote: > > > > > > >

[PATCH -next v2] drm/amdgpu: Remove a lot of unnecessary ternary operators

2023-08-04 Thread Ruan Jinjie
There are many ternary operators, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie --- v2: - add the wrong removed true or false judgement hunk code - Update the commit message, Ther -> There --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c

[PATCH] drm/amd/display: Return value of function

2023-08-04 Thread Denis Arefev
Added return value check hpd_enable Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_

Re: [PATCH] drm/amdgpu: Remove volatile from 'wb' & from 'ptr' in amdgpu.h

2023-08-04 Thread SHANMUGAM, SRINIVASAN
On 8/3/2023 2:12 PM, Christian König wrote: Am 03.08.23 um 07:23 schrieb SHANMUGAM, SRINIVASAN: On 7/24/2023 10:43 PM, Alex Deucher wrote: On Mon, Jul 24, 2023 at 11:54 AM Srinivasan Shanmugam wrote: Fixes the following from checkpatch.pl: WARNING: Use of volatile is usually wrong: see