On Thu, 2023-08-24 at 04:12 +, Lin, Wayne wrote:
> [Public]
>
> Hi Lyude,
>
> I'm afraid that I don't have the permissions to push and would like to have
> your help. Thanks!
Whoops, sorry I only just noticed this message. I set a reminder on my phone
to bug me to push it tomorrow :), sorry
On 2023-08-30 01:29, Jani Nikula wrote:
On Tue, 29 Aug 2023, Alex Hung wrote:
On 2023-08-29 11:03, Jani Nikula wrote:
On Tue, 29 Aug 2023, Jani Nikula wrote:
On Tue, 29 Aug 2023, Alex Deucher wrote:
On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote:
On Wed, 23 Aug 2023, Jani Nikula
On 8/31/2023 3:59 PM, Felix Kuehling wrote:
On 2023-08-31 16:33, Chen, Xiaogang wrote:
That said, I'm not actually sure why we're freeing the DMA
address array after migration to RAM at all. I think we still
need it even when we're using VRAM. We call svm_range_dma_map in
On Thu, Aug 31, 2023 at 5:20 PM Timmy Tsai wrote:
>
> During jpeg init, CPU writes to frame buffer which can be cached by HDP,
> occasionally causing invalid header to be sent to MMSCH. Perform HDP flush
> after writing to frame buffer before continuing with jpeg init sequence.
>
>
During jpeg init, CPU writes to frame buffer which can be cached by HDP,
occasionally causing invalid header to be sent to MMSCH. Perform HDP flush
after writing to frame buffer before continuing with jpeg init sequence.
Signed-off-by: Timmy Tsai
---
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 10
On 2023-08-31 16:33, Chen, Xiaogang wrote:
That said, I'm not actually sure why we're freeing the DMA
address array after migration to RAM at all. I think we still
need it even when we're using VRAM. We call svm_range_dma_map in
svm_range_validate_and_map regardless of whether the range is in
On 8/31/2023 1:00 PM, Felix Kuehling wrote:
On 2023-08-30 19:02, Chen, Xiaogang wrote:
On 8/30/2023 3:56 PM, Felix Kuehling wrote:
On 2023-08-30 15:39, Chen, Xiaogang wrote:
On 8/28/2023 5:37 PM, Felix Kuehling wrote:
On 2023-08-28 16:57, Chen, Xiaogang wrote:
On 8/28/2023 2:06 PM,
On 2023-08-31 15:44, Zuo, Jerry wrote:
> [AMD Official Use Only - General]
>
>
> Series is:
>
> Reviewed-By: Fangzhi Zuo
>
Reviewed-by: Harry Wentland
Harry
>
[AMD Official Use Only - General]
Series is:
Reviewed-By: Fangzhi Zuo
发件人: Mahfooz, Hamza
发送时间: 星期四, 八月 31, 2023 3:39:04 下午
收件人: amd-gfx@lists.freedesktop.org
抄送: Zuo, Jerry ; Mahfooz, Hamza ;
sta...@vger.kernel.org ; Wentland, Harry
; Li, Sun peng (Leo) ;
Applied. Thanks!
Alex
On Thu, Aug 31, 2023 at 12:12 PM Melissa Wen wrote:
>
> For DRM legacy gamma, AMD display manager applies implicit sRGB degamma
> using a pre-defined sRGB transfer function. It works fine for DCN2
> family where degamma ROM and custom curves go to the same color block.
>
Since, calling dcn20_adjust_freesync_v_startup() on DCN3.1+ ASICs
can cause the display to flicker and underflow to occur we shouldn't
call it for them. So, ensure that the DCN version is less than
DCN_VERSION_3_1 before calling dcn20_adjust_freesync_v_startup().
Cc: sta...@vger.kernel.org
This reverts commit 3a31e8b89b7240d9a17ace8a1ed050bdcb560f9e.
We still need to call dcn20_adjust_freesync_v_startup() for older DCN3+
ASICs otherwise it can cause DP to HDMI 2.1 PCONs to fail to light up.
Cc: sta...@vger.kernel.org
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2809
Applied. Thanks!
Alex
On Thu, Aug 31, 2023 at 2:48 PM Harry Wentland wrote:
>
> On 2023-08-30 10:01, Dembskiy Igor wrote:
> > It does not make sense to compare a pointer to array element with NULL.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes:
On 2023-08-29 16:10, Hamza Mahfooz wrote:
> This reverts commit 3a31e8b89b7240d9a17ace8a1ed050bdcb560f9e.
>
This isn't a straight-up revert. Please split it into a revert (git revert),
followed by a patch to limit the revert to < DCN_VERSION_3_1.
Harry
> We still need to call
On Thu, Aug 31, 2023 at 7:01 AM Greg KH wrote:
>
> On Thu, Aug 31, 2023 at 03:26:28PM +0200, Christian König wrote:
> > Am 31.08.23 um 12:56 schrieb Greg KH:
> > > On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote:
> > > > Am 30.08.23 um 20:53 schrieb Chia-I Wu:
> > > > > On Sun,
On 2023-08-30 10:01, Dembskiy Igor wrote:
> It does not make sense to compare a pointer to array element with NULL.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 65d38262b3e8 ("drm/amd/display: fbc state could not reach while enable
> fbc")
> Signed-off-by:
On 2023-08-30 18:08, André Almeida wrote:
Merge all developer debug options available as separated module
parameters in one, making it obvious that are for developers.
Drop the obsolete module options in favor of the new ones.
Signed-off-by: André Almeida
---
v2:
- drop old module params
-
On 2023-08-30 19:02, Chen, Xiaogang wrote:
On 8/30/2023 3:56 PM, Felix Kuehling wrote:
On 2023-08-30 15:39, Chen, Xiaogang wrote:
On 8/28/2023 5:37 PM, Felix Kuehling wrote:
On 2023-08-28 16:57, Chen, Xiaogang wrote:
On 8/28/2023 2:06 PM, Felix Kuehling wrote:
On 2023-08-24 18:08,
For consistency with the other OD interface, we'd probably want an "r"
option to reset each attribute to the default state again.
Alex
On Wed, Aug 30, 2023 at 9:33 AM Alex Deucher wrote:
>
> Series is:
> Reviewed-by: Alex Deucher
>
> On Wed, Aug 30, 2023 at 2:35 AM Evan Quan wrote:
> >
> >
For DRM legacy gamma, AMD display manager applies implicit sRGB degamma
using a pre-defined sRGB transfer function. It works fine for DCN2
family where degamma ROM and custom curves go to the same color block.
But, on DCN3+, degamma is split into two blocks: degamma ROM for
pre-defined TFs and
Create a module option to disable soft recoveries on amdgpu, making
every recovery go through the device reset path. This option makes
easier to force device resets for testing and debugging purposes.
Signed-off-by: André Almeida
Reviewed-by: Christian König
---
Merge all developer debug options available as separated module
parameters in one, making it obvious that are for developers.
Drop the obsolete module options in favor of the new ones.
Signed-off-by: André Almeida
Reviewed-by: Christian König
---
v3:
- move from include/amd_shared.h to
As suggested by Christian at [0], this patchset merges all debug modules
parameters and creates a new one for disabling soft recovery:
> Maybe we can overload the amdgpu_gpu_recovery module option with this.
> Or even better merge all the developer module parameter into a
> amdgpu_debug option.
On Thu, Aug 31, 2023 at 03:26:28PM +0200, Christian König wrote:
> Am 31.08.23 um 12:56 schrieb Greg KH:
> > On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote:
> > > Am 30.08.23 um 20:53 schrieb Chia-I Wu:
> > > > On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote:
> > > > > From:
Hi André,
Thanks for your patches.
On 30/08/2023 19:08, André Almeida wrote:
As suggested by Christian at [0], this patchset merges all debug modules
parameters and creates a new one for disabling soft recovery:
Maybe we can overload the amdgpu_gpu_recovery module option with this.
Or even
Am 31.08.23 um 12:56 schrieb Greg KH:
On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote:
Am 30.08.23 um 20:53 schrieb Chia-I Wu:
On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote:
From: Lang Yu
[ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ]
When using cpu to
On Wed, Aug 30, 2023 at 11:53:29AM -0700, Chia-I Wu wrote:
> On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote:
> >
> > From: Lang Yu
> >
> > [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ]
> >
> > When using cpu to update page tables, vm update fences are unused.
> > Install stub
Initialize number of jpeg ring for gc ip 11_5_0
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c
On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote:
> Am 30.08.23 um 20:53 schrieb Chia-I Wu:
> > On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote:
> > > From: Lang Yu
> > >
> > > [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ]
> > >
> > > When using cpu to update
Am 30.08.23 um 20:53 schrieb Chia-I Wu:
On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote:
From: Lang Yu
[ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ]
When using cpu to update page tables, vm update fences are unused.
Install stub fence into these fence pointers instead of
[AMD Official Use Only - General]
> -Original Message-
> From: Zhang, Yifan
> Sent: Thursday, August 31, 2023 2:27 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Quan, Evan ; Ma, Li ; Zhang,
> Yifan
> Subject: [PATCH v3] drm/amd/pm: only poweron/off vcn/jpeg when they are
> valid.
>
> If
Am 31.08.23 um 00:08 schrieb André Almeida:
Create a module option to disable soft recoveries on amdgpu, making
every recovery go through the device reset path. This option makes
easier to force device resets for testing and debugging purposes.
Signed-off-by: André Almeida
---
Am 31.08.23 um 00:08 schrieb André Almeida:
Merge all developer debug options available as separated module
parameters in one, making it obvious that are for developers.
Drop the obsolete module options in favor of the new ones.
Signed-off-by: André Almeida
---
v2:
- drop old module params
If vcn is disabled in kernel parameters, don't touch vcn,
otherwise it may cause vcn hang.
v2: delete unnecessary logs
v3: move "is_vcn_enabled" check to smu_dpm_setvcn/jpeg_enable (Evan)
Signed-off-by: Yifan Zhang
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 24 +++
1
Fulfill the SMU13.0.7 support for Wifi RFI mitigation feature.
Signed-off-by: Evan Quan
Reviewed-by: Mario Limonciello
--
v10->v11:
- downgrade the prompt level on message failure(Lijo)
---
.../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 59 +++
1 file changed, 59
Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature.
Signed-off-by: Evan Quan
Reviewed-by: Mario Limonciello
--
v10->v11:
- downgrade the prompt level on message failure(Lijo)
---
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 +
drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h |
To protect PMFW from being overloaded.
Signed-off-by: Evan Quan
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 31 +++
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 7 +
2 files changed, 32 insertions(+), 6 deletions(-)
diff --git
With WBRF feature supported, as a driver responding to the frequencies,
amdgpu driver is able to do shadow pstate switching to mitigate possible
interference(between its (G-)DDR memory clocks and local radio module
frequency bands used by Wifi 6/6e/7).
Signed-off-by: Evan Quan
Reviewed-by: Mario
Add those data structures to support Wifi RFI mitigation feature.
Signed-off-by: Evan Quan
Reviewed-by: Mario Limonciello
---
.../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +-
.../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h | 14 +-
To support the WBRF mechanism, Wifi adapters utilized in the system must
register the frequencies in use(or unregister those frequencies no longer
used) via the dedicated calls. So that, other drivers responding to the
frequencies can take proper actions to mitigate possible interference.
The newly added WBRF feature needs this interface for channel
width calculation.
Signed-off-by: Evan Quan
--
v8->v9:
- correct typo(Mhz -> MHz) (Johnson)
---
include/net/cfg80211.h | 8
net/wireless/chan.c| 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git
Due to electrical and mechanical constraints in certain platform designs
there may be likely interference of relatively high-powered harmonics of
the (G-)DDR memory clocks with local radio module frequency bands used
by Wifi 6/6e/7.
To mitigate this, AMD has introduced a mechanism that devices
Due to electrical and mechanical constraints in certain platform designs there
may be likely interference of relatively high-powered harmonics of the (G-)DDR
memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To
mitigate possible RFI interference producers can advertise the
[AMD Official Use Only - General]
> -Original Message-
> From: Zhang, Yifan
> Sent: Thursday, August 31, 2023 2:10 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Quan, Evan ; Ma, Li ; Zhang,
> Yifan
> Subject: [PATCH] drm/amd/pm: only poweron/off vcn/jpeg when they are
> valid.
>
> If vcn
If vcn is disabled in kernel parameters, don't touch vcn,
otherwise it may cause vcn hang.
v2: delete unnecessary logs
Signed-off-by: Yifan Zhang
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 30 ---
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git
If vcn is disabled in kernel parameters, don't touch vcn,
otherwise it may cause vcn hang.
Signed-off-by: Yifan Zhang
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 31 ---
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git
46 matches
Mail list logo