RE: [Patch v2 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-09-03 Thread Lin, Wayne
[Public] Thank you Lyude and Alex! Regards, Wayne > -Original Message- > From: Alex Deucher > Sent: Saturday, September 2, 2023 3:38 AM > To: Lyude Paul > Cc: Lin, Wayne ; dri-de...@lists.freedesktop.org; > amd-gfx@lists.freedesktop.org; jani.nik...@intel.com; imre.d...@intel.com; > Wen

Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs

2023-09-03 Thread Andi Shyti
Hi Jim, On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > By at least strong convention, a print-buffer's trailing newline says > "message complete, send it". The exception (no TNL, followed by a call > to pr_cont) proves the general rule. > > Most DRM.debug calls already comport wit

[PATCH] drm/amd: Fix the flag setting code for interrupt request

2023-09-03 Thread Ma Jun
[1] Remove the irq flags setting code since pci_alloc_irq_vectors() handles these flags. [2] Free the msi vectors in case of error. Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 43 ++--- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/dr

[PATCH] drm/amdgpu: fix incompatible types in conditional expression

2023-09-03 Thread Lang Yu
Fixes: ab041551f4a7 ("drm/amdgpu: add VPE 6.1.0 support") Signed-off-by: Lang Yu Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202309020608.fwp8qmht-...@intel.com --- drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.h | 2 +- drivers/gpu/drm/amd/amdgpu/vpe_v6_1.c | 4 +++- 2

RE: [V3 0/7] A new set of Linux OD interfaces

2023-09-03 Thread Quan, Evan
[AMD Official Use Only - General] Actually, with my original design, there indeed came with an 'r' option support. But I found that brings some confusion. Since per current 'r' option design, it will reset all attributes back to original states. Thus I dropped it. If to support 'r' option per at

Re: [PATCH AUTOSEL 6.1 08/10] drm/amdkfd: ignore crat by default

2023-09-03 Thread Sasha Levin
On Tue, Aug 22, 2023 at 03:41:18PM +, Deucher, Alexander wrote: [Public] -Original Message- From: Sasha Levin Sent: Tuesday, August 22, 2023 7:36 AM To: linux-ker...@vger.kernel.org; sta...@vger.kernel.org Cc: Deucher, Alexander ; Kuehling, Felix ; Koenig, Christian ; Mike Lothian

[PATCH v2 2/6] drm_dbg: add trailing newlines to msgs

2023-09-03 Thread Jim Cromie
By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintaine

[PATCH v2 6/6] drm: use correct ccflags-y syntax

2023-09-03 Thread Jim Cromie
Incorrect CFLAGS- usage failed to add -DDYNAMIC_DEBUG_MODULE, which broke builds with: CONFIG_DRM_USE_DYNAMIC_DEBUG=Y CONFIG_DYNAMIC_DEBUG_CORE=Y, but CONFIG_DYNAMIC_DEBUG=N Also add subdir-ccflags so that all drivers pick up the addition. Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndb

[PATCH v2 3/6] drm_dbg: add trailing newlines to msgs

2023-09-03 Thread Jim Cromie
By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintaine

[PATCH v2 4/6] drm_dbg: add trailing newlines to msgs

2023-09-03 Thread Jim Cromie
By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintaine

[PATCH v2 5/6] drm_dbg: add trailing newlines to msgs

2023-09-03 Thread Jim Cromie
By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintaine

[PATCH v2 1/6] drm_dbg: add trailing newlines to msgs

2023-09-03 Thread Jim Cromie
By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintaine

[PATCH v2 0/6] drm_dbg: add trailing newlines where missing

2023-09-03 Thread Jim Cromie
By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this rule/convention: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainde