With S/G display becomes stable, enable S/G display for recent APUs
by default rather than white list.
Signed-off-by: Yifan Zhang
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 43 +--
1 file changed, 10 insertions(+), 33 deletions(-)
diff --git
I'm still not happy with moving the GART fixed to the end. We abandoned
this for good reasons.
If we really go this way I would prefer to have this as parameter to the
amdgpu_gmc_gart_location() function and not in the gmc structure.
Regards,
Christian.
Am 26.09.23 um 19:30 schrieb Alex
Am 26.09.23 um 18:39 schrieb Alex Deucher:
kfd_topology.c:2082:1: warning: the frame size of 1440 bytes is larger than
1024 bytes
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2866
Cc: Arnd Bergmann
Signed-off-by: Alex Deucher
Acked-by: Christian König for the series, but
Felix
Am 26.09.23 um 15:09 schrieb Harry Wentland:
On 2023-09-26 01:56, Cong Liu wrote:
This patch fixes a null pointer dereference in the error message that is
printed when the Display Core (DC) fails to initialize. The original
message includes the DC version number, which is undefined if the DC
[AMD Official Use Only - General]
Reviewed-by: Jesse Zhang
-Original Message-
From: Xiaogang.Chen
Sent: Wednesday, September 27, 2023 11:00 AM
To: amd-gfx@lists.freedesktop.org
Cc: Yang, Philip ; Kuehling, Felix
; Zhang, Jesse(Jie) ; Sierra
Guiza, Alejandro (Alex) ; Chen, Xiaogang
;
From: Xiaogang Chen
prange->svm_bo unref can happen in both mmu callback and a callback after
migrate to system ram. Both are async call in different tasks. Sync svm_bo
unref operation to avoid random "use-after-free".
Signed-off-by: Xiaogang.Chen
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 9
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 4ae73bba62a367f2314f6ce69e3085a941983d8b Add linux-next specific
files for 20230926
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202308282000.2xnh0k6d-...@intel.com
https
From: "Kim, Sung joon"
[why]
Need a helper function to check idle power is allowed
so that dc doesn't access any registers that are power-gated.
[how]
Implement helper function to check idle power optimization.
Enable a hook to check if detection is allowed.
Signed-off-by: Sung Joon Kim
[Why]
* Rearrange some definitions for consistency
* Drop legacy code
Signed-off-by: Aurabindo Pillai
Reviewed-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/dc/core/dc_stream.c | 17 --
drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 7 ---
drivers/gpu/drm/amd/display/dc/dc_stream.h
From: Aric Cyr
Acked-by: Aurabindo Pillai
Signed-off-by: Aric Cyr
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
b/drivers/gpu/drm/amd/display/dc/dc.h
index 00710f784af3..7d1ce58d493b 100644
---
From: Wenjing Liu
[why]
Clip size increase will increase viewport, which could cause us to
switch to MPC combine.
If we skip full update, we are not able to change to MPC combine in
fast update. This will cause corruption showing on the video plane.
[how]
treat clip size increase of a surface
[Why]
* Add hints about the bits used in the packed struct.
* Update new bitfields for ABM and IPS
Signed-off-by: Aurabindo Pillai
Reviewed-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 31 +--
1 file changed, 28 insertions(+), 3 deletions(-)
diff
[Why]
Make some formatting changes and rearranging of definitions for consistency.
Signed-off-by: Aurabindo Pillai
Reviewed-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 162 +-
1 file changed, 81 insertions(+), 81 deletions(-)
diff --git
From: Aric Cyr
- Fix constness of string parameters
- Fix zero-initialization of structs which cannot take a 0 literal as the
first field, for example enums
Reviewed-by: Dillon Varone
Acked-by: Aurabindo Pillai
Signed-off-by: Aric Cyr
---
From: Ovidiu Bunea
[why]
Driver needs to be compatible with PM FW that doesn't support IPS
[how]
Toggle internal control flag
Reviewed-by: Charlene Liu
Acked-by: Aurabindo Pillai
Signed-off-by: Ovidiu Bunea
---
.../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 28 ---
From: Samson Tam
[Why]
The edge-case DISPCLK WDIVIDER changes call stream_enc functions.
But with MPC pipes, downstream pipes have null stream_enc and will
cause crash.
[How]
Only call stream_enc functions for pipes that are OTG master.
Reviewed-by: Alvin Lee
Cc: Mario Limonciello
Cc: Alex
From: Sherry Wang
[Why]
Current ILR toggle is on/off as a part of panel
config for new function, which breaks original
ILR logic
[How]
Refactor ILR and take panel config into account
Reviewed-by: Anthony Koo
Acked-by: Aurabindo Pillai
Signed-off-by: Sherry Wang
---
From: Chiawen Huang
[Why]
enable_accelerated_mode function is fully to check
whether fastboot support or not.
It is no longer to disable_vbios_mode_if_required.
Reviewed-by: Anthony Koo
Acked-by: Aurabindo Pillai
Signed-off-by: Chiawen Huang
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 59
From: Gabe Teeger
[what and why]
Check whether dpp resource pointer is null in advance and return early
if so.
Reviewed-by: Charlene Liu
Reviewed-by: Martin Leung
Signed-off-by: Gabe Teeger
Cc: Mario Limonciello
Cc: Alex Deucher
Cc: sta...@vger.kernel.org
Acked-by: Aurabindo Pillai
---
From: Muhammad Ahmed
[why]
need to enable dsc_clk regardless dsc_pg
Reviewed-by: Charlene Liu
Cc: Mario Limonciello
Cc: Alex Deucher
Cc: sta...@vger.kernel.org
Acked-by: Aurabindo Pillai
Signed-off-by: Muhammad Ahmed
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 8
From: Wayne Lin
[Why & How]
Fix following problems:
- In abm config, forget to initialize config.ambient_thresholds_lux.
- Adjust the coding style problem
- Restrict to call psr_su_set_dsc_slice_height() under edp only
Reviewed-by: Robin Chen
Signed-off-by: Wayne Lin
---
This DC patchset brings improvements in multiple areas. In summary, we have:
* Stability fixes through null pointer checks, blackscreen fixes on
certain configurations
* Improvements for various functionality like Idle optimization, ILR, DSC, IPS
* Fixes for ILR functionality
* Trivial code
On 9/22/2023 4:37 PM, Philip Yang wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Otherwise kfd flush tlb does nothing if vm update fence callback doesn't
update vm->tlb_seq. H/W will generate retry
On Tue, Sep 26, 2023, at 20:47, Deucher, Alexander wrote:
>> From: Arnd Bergmann
>> Subject: Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info
>>
>> On Tue, Sep 26, 2023, at 18:39, Alex Deucher wrote:
>> > I think this was an abstraction back from when kfd supported both
>> > radeon and amdgpu.
[Public]
> -Original Message-
> From: Arnd Bergmann
> Sent: Tuesday, September 26, 2023 1:49 PM
> To: Deucher, Alexander ; amd-
> g...@lists.freedesktop.org
> Subject: Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info
>
> On Tue, Sep 26, 2023, at 18:39, Alex Deucher wrote:
> > I think
On Tue, Sep 26, 2023, at 18:39, Alex Deucher wrote:
> I think this was an abstraction back from when
> kfd supported both radeon and amdgpu. Since we just
> support amdgpu now, there is no more need for this and
> we can use the amdgpu structures directly.
>
> This also avoids having the
On Tue, Sep 26, 2023, at 18:39, Alex Deucher wrote:
> kfd_topology.c:2082:1: warning: the frame size of 1440 bytes is larger
> than 1024 bytes
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2866
> Cc: Arnd Bergmann
> Signed-off-by: Alex Deucher
Acked-by: Arnd Bergmann
Ping on this series?
On Thu, Sep 21, 2023 at 5:46 PM Alex Deucher wrote:
>
> We normally place GART based on the location of VRAM and the
> available address space around that, but provide an option
> to force a particular location for hardware that needs it.
>
> Signed-off-by: Alex Deucher
>
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> PMF driver sends changing inputs from each subystem to TA for evaluating
> the conditions in the policy binary.
>
> Add initial support of plumbing in the PMF driver for Smart PC to get
> information from other subsystems in the kernel.
>
>
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> PMF Policy binary is a encrypted and signed binary that will be part
> of the BIOS. PMF driver via the ACPI interface checks the existence
> of Smart PC bit. If the advertised bit is found, PMF driver walks
> the acpi namespace to find out the policy
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> AMD PMF driver loads the PMF TA (Trusted Application) into the AMD
> ASP's (AMD Security Processor) TEE (Trusted Execution Environment).
>
> PMF Trusted Application is a secured firmware placed under
> /lib/firmware/amdtee gets loaded only when the
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> amd_pmf_dbgfs_register() needs to be called before amd_pmf_init_features().
Please answer to why? question too here.
> Hence change the sequence.
>
> Reviewed-by: Mario Limonciello
> Signed-off-by: Shyam Sundar S K
> ---
>
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
> PMF TA (Trusted Application) loads via the TEE environment into the
> AMD ASP.
>
> PMF-TA supports two commands:
> 1) Init: Initialize the TA with the PMF Smart PC policy binary and
> start the policy engine. A policy is a combination of inputs and
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
Add () to the function name in the shortlog. "Change signature" is quite
vague, perhaps you could come up something more descriptive.
> Make amd_pmf_set_dram_addr() as non-static so that same function
> can be used across files.
This says nothing
I think this was an abstraction back from when
kfd supported both radeon and amdgpu. Since we just
support amdgpu now, there is no more need for this and
we can use the amdgpu structures directly.
This also avoids having the kfd_cu_info structures on
the stack when inlining which can blow up the
kfd_topology.c:2082:1: warning: the frame size of 1440 bytes is larger than
1024 bytes
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2866
Cc: Arnd Bergmann
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 13 +
1 file changed, 9 insertions(+), 4
[AMD Official Use Only - General]
Reviewed-by: Alex Deucher
From: Limonciello, Mario
Sent: Monday, September 25, 2023 9:44 PM
To: amd-gfx@lists.freedesktop.org
Cc: Limonciello, Mario ; Deucher, Alexander
; Xu, Feifei
Subject: [PATCH] drm/amd: Limit seamless
A hang is reported on DCN 3.2 with seamless boot enabled.
As the benefits come from an eDP setup, limit it to only enabled
by default with APUs.
Suggested-by: alexander.deuc...@amd.com
Reported-by: feifei...@amd.com
Closes:
Hi Christian,
On 9/26/2023 6:47 PM, Christian König wrote:
> Am 26.09.23 um 14:56 schrieb Hans de Goede:
>> Hi,
>>
>> On 9/26/23 13:24, Shyam Sundar S K wrote:
>>> Hi Hans,
>>>
>>> On 9/26/2023 4:05 PM, Hans de Goede wrote:
Hi,
On 9/22/23 19:50, Shyam Sundar S K wrote:
> For
Am 26.09.23 um 14:56 schrieb Hans de Goede:
Hi,
On 9/26/23 13:24, Shyam Sundar S K wrote:
Hi Hans,
On 9/26/2023 4:05 PM, Hans de Goede wrote:
Hi,
On 9/22/23 19:50, Shyam Sundar S K wrote:
For the Smart PC Solution to fully work, it has to enact to the actions
coming from TA. Add the
On 2023-09-26 01:56, Cong Liu wrote:
> This patch fixes a null pointer dereference in the error message that is
> printed when the Display Core (DC) fails to initialize. The original
> message includes the DC version number, which is undefined if the DC is
> not initialized.
>
> Fixes:
On 09/25, Harry Wentland wrote:
>
>
> On 2023-07-21 09:24, Melissa Wen wrote:
> > dc->caps.color.mpc.gamut_remap says there is a post-blending color block
> > for gamut remap matrix for DCN3 HW family and newer versions. However,
> > those drivers still follow DCN10 programming that remap stream
Hi,
On 9/26/23 13:24, Shyam Sundar S K wrote:
> Hi Hans,
>
> On 9/26/2023 4:05 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 9/22/23 19:50, Shyam Sundar S K wrote:
>>> For the Smart PC Solution to fully work, it has to enact to the actions
>>> coming from TA. Add the initial code path for set
Hi,
On 9/22/23 19:50, Shyam Sundar S K wrote:
> For the Smart PC Solution to fully work, it has to enact to the actions
> coming from TA. Add the initial code path for set interface to AMDGPU.
>
> Co-developed-by: Mario Limonciello
> Signed-off-by: Mario Limonciello
> Signed-off-by: Shyam
On 2023-09-26 08:38, Melissa Wen wrote:
> On 09/25, Harry Wentland wrote:
>>
>>
>> On 2023-09-13 12:43, Melissa Wen wrote:
>>> Logging DCN3 MPC state was following DCN1 implementation that doesn't
>>> consider new DCN3 MPC color blocks. Create new elements according to
>>> DCN3 MPC color caps
On 09/25, Harry Wentland wrote:
>
>
> On 2023-09-13 12:43, Melissa Wen wrote:
> > Hi,
> >
> > This is an update of previous RFC [0] improving the data collection of
> > Gamma Correction and Blend Gamma color blocks.
> >
> > As I mentioned in the last version, I'm updating the color state part
On 09/25, Harry Wentland wrote:
>
>
> On 2023-09-13 12:43, Melissa Wen wrote:
> > Color caps changed between HW versions which caused DCN10 color state
> > sections on DTN log no longer fit DCN3.0 versions. Create a
> > DCN3.0-specific color state logging and hook it to drivers of DCN3.0
> >
On 09/25, Harry Wentland wrote:
>
>
> On 2023-09-13 12:43, Melissa Wen wrote:
> > Logging DCN3 MPC state was following DCN1 implementation that doesn't
> > consider new DCN3 MPC color blocks. Create new elements according to
> > DCN3 MPC color caps and a new DCN3-specific function for reading
Hi Hans,
On 9/26/2023 4:05 PM, Hans de Goede wrote:
> Hi,
>
> On 9/22/23 19:50, Shyam Sundar S K wrote:
>> For the Smart PC Solution to fully work, it has to enact to the actions
>> coming from TA. Add the initial code path for set interface to AMDGPU.
>>
>> Co-developed-by: Mario Limonciello
On 9/25/2023 10:00 PM, Mario Limonciello wrote:
> On 9/25/2023 11:27, Deucher, Alexander wrote:
>> [Public]
>>
>>> -Original Message-
>>> From: amd-gfx On Behalf Of
>>> Shyam Sundar S K
>>> Sent: Friday, September 22, 2023 1:51 PM
>>> To: hdego...@redhat.com; markgr...@kernel.org;
On 9/26/2023 4:41 PM, Lazar, Lijo wrote:
On 9/26/2023 4:32 PM, Le Ma wrote:
Pass the correct size to smu_v13_0_6_print_clks, otherwise
the same place in buf will be re-written.
Where is this getting affected? As far as I see, there are no multiple
emits to the same buffer in this code
On 9/25/2023 9:57 PM, Deucher, Alexander wrote:
> [Public]
>
>> -Original Message-
>> From: amd-gfx On Behalf Of
>> Shyam Sundar S K
>> Sent: Friday, September 22, 2023 1:51 PM
>> To: hdego...@redhat.com; markgr...@kernel.org; Natikar, Basavaraj
>> ; ji...@kernel.org;
>>
On 9/26/2023 4:32 PM, Le Ma wrote:
Pass the correct size to smu_v13_0_6_print_clks, otherwise
the same place in buf will be re-written.
Where is this getting affected? As far as I see, there are no multiple
emits to the same buffer in this code path.
Thanks,
Lijo
Change-Id:
Pass the correct size to smu_v13_0_6_print_clks, otherwise
the same place in buf will be re-written.
Change-Id: Ia0e12430d01146a11490204c1bab4b4f06cd17ea
Signed-off-by: Le Ma
---
.../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 24 +--
1 file changed, 12 insertions(+), 12
This patch fixes a smatch warning:
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_0_ppt.c:2868
smu_v13_0_0_check_ecc_table_support() warn: missing error code? 'ret'
This warning is caused by the fact that this function returns the value of
the variable ret. However, the value of ret is
This patch fixes a null pointer dereference in the error message that is
printed when the Display Core (DC) fails to initialize. The original
message includes the DC version number, which is undefined if the DC is
not initialized.
Fixes: 9788d087caff ("drm/amd/display: improve the message printed
upport...-directive-output-truncated-writing-bytes-into-a-region-of-size-between-and
| `--
include-linux-netlink.h:warning:sfc:Unsupported:only-suppo...-directive-output-truncated-writing-bytes-into-a-region-of-size
|-- x86_64-randconfig-073-20230926
| |--
ERROR:ice_cgu_get_pin_freq_supp-dri
57 matches
Mail list logo
