[PATCH] drm/amdkfd: Fix iterator used outside loop in 'kfd_add_peer_prop()'

2023-12-29 Thread Srinivasan Shanmugam
Fix the following about iterator use: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1456 kfd_add_peer_prop() warn: iterator used outside loop: 'iolink3' Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdkfd/kfd_topolo

[PATCH] drm/amdkfd: Prefer kernel data types u8, u16, u32, u64 in amdkfd/kfd_priv.h

2023-12-29 Thread Srinivasan Shanmugam
Fix the following checks reported by checkpatch: CHECK: Prefer kernel type 'u8' over 'uint8_t' CHECK: Prefer kernel type 'u16' over 'uint16_t' CHECK: Prefer kernel type 'u64' over 'uint64_t' CHECK: Prefer kernel type 'u32' over 'uint32_t' Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher

[PATCH] drm/amdgpu: Remove unreachable code in 'atom_skip_src_int()'

2023-12-29 Thread Srinivasan Shanmugam
Fixes the below: drivers/gpu/drm/amd/amdgpu/atom.c:398 atom_skip_src_int() warn: ignoring unreachable code. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/atom.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amd

Re: [PATCH] drm/amdkfd: Fix type of 'dbg_flags' in 'struct kfd_process'

2023-12-29 Thread SRINIVASAN SHANMUGAM
On 12/21/2023 11:30 PM, Felix Kuehling wrote: On 2023-12-21 12:39, Srinivasan Shanmugam wrote: dbg_flags looks to be defined with incorrect data type; to process multiple debug flag options, and hence defined dbg_flags as u32. Fixes the below: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_packet_

[PATCH v2] drm/amdkfd: Prefer kernel data types u8, u16, u32, u64 in amdkfd/kfd_priv.h

2023-12-29 Thread Srinivasan Shanmugam
Fix the following checks reported by checkpatch: CHECK: Prefer kernel type 'u8' over 'uint8_t' CHECK: Prefer kernel type 'u16' over 'uint16_t' CHECK: Prefer kernel type 'u64' over 'uint64_t' CHECK: Prefer kernel type 'u32' over 'uint32_t' Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher

[PATCH v3] drm/amdkfd: Prefer kernel data types u8, u16, u32, u64 in amdkfd/kfd_priv.h

2023-12-29 Thread Srinivasan Shanmugam
Fix the following checks reported by checkpatch: CHECK: Prefer kernel type 'u8' over 'uint8_t' CHECK: Prefer kernel type 'u16' over 'uint16_t' CHECK: Prefer kernel type 'u64' over 'uint64_t' CHECK: Prefer kernel type 'u32' over 'uint32_t' Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher

[PATCH] drm/amdgpu: Drop 'fence' check in 'to_amdgpu_amdkfd_fence()'

2023-12-29 Thread Srinivasan Shanmugam
Return value of container_of(...) can't be null, so null check is not required for 'fence'. Hence drop its NULL check. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c:93 to_amdgpu_amdkfd_fence() warn: can 'fence' even be NULL? Cc: Felix Kuehling Cc: Christian König Cc: Alex D

[RFC PATCH] drm/amd/display: fix bandwidth validation failure on DCN 2.1

2023-12-29 Thread Melissa Wen
IGT `amdgpu/amd_color/crtc-lut-accuracy` fails right at the beginning of the test execution, during atomic check, because DC rejects the bandwidth state for a fb sizing 64x64. The test was previously working with the deprecated dc_commit_state(). Now using dc_validate_with_context() approach, the a

[PATCH 0/7] drm/amd/display: Fix codestyle issues for modules

2023-12-29 Thread Marcelo Mendes Spessoto Junior
This patchset aims to fix most of codestyle issues present in the modules directory Marcelo Mendes Spessoto Junior (7): Fix hdcp1_execution.c codestyle Fix hdcp_psp.c codestyle Fix freesync.c codestyle Fix hdcp_psp.h codestyle Fix hdcp2_execution.c codestyle Fix hdcp_log.h codestyle

[PATCH 1/7] drm/amd/display: Fix hdcp1_execution.c codestyle

2023-12-29 Thread Marcelo Mendes Spessoto Junior
Remove braces from single statement if expression in hdcp1_execution.c file Signed-off-by: Marcelo Mendes Spessoto Junior --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/hdc

[PATCH 2/7] drm/amd/display: Fix hdcp_psp.c codestyle

2023-12-29 Thread Marcelo Mendes Spessoto Junior
Fix identation for hdcp_psp.c file Signed-off-by: Marcelo Mendes Spessoto Junior --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modu

[PATCH 3/7] drm/amd/display: Fix freesync.c codestyle

2023-12-29 Thread Marcelo Mendes Spessoto Junior
Remove braces for single statement if expression for freesync.c file Signed-off-by: Marcelo Mendes Spessoto Junior --- drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/freesync/free

[PATCH 4/7] drm/amd/display: Fix hdcp_psp.h codestyle

2023-12-29 Thread Marcelo Mendes Spessoto Junior
Fix identation inside enum and place expressions in define macros inside () for hdcp_psp.h file Signed-off-by: Marcelo Mendes Spessoto Junior --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 5/7] drm/amd/display: Fix hdcp2_execution.c codestyle

2023-12-29 Thread Marcelo Mendes Spessoto Junior
Remove braces for single statement if expressions and change comparison order for hdcp2_execution.c file Signed-off-by: Marcelo Mendes Spessoto Junior --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp2_execution.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH 6/7] drm/amd/display: Fix hdcp_log.h codestyle

2023-12-29 Thread Marcelo Mendes Spessoto Junior
Place HDCP_EVENT_TRACE(hdcp, event) macro content inside do while loop to avoid if-else issues in hdcp_log.h file Signed-off-by: Marcelo Mendes Spessoto Junior --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/d

[PATCH 7/7] drm/amd/display: Fix power_helpers.c codestyle

2023-12-29 Thread Marcelo Mendes Spessoto Junior
Place define macro expression inside () in power_helpers.c file Signed-off-by: Marcelo Mendes Spessoto Junior --- drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/modules/power/power_helpers.

Re: [PATCH] drm/amdgpu: Check resize bar register when system uses large bar

2023-12-29 Thread Mario Limonciello
On 12/20/2023 19:58, Ma, Jun wrote: Hi Christian, On 12/20/2023 10:10 PM, Christian König wrote: Am 19.12.23 um 06:58 schrieb Ma Jun: Print a warnning message if the system can't access the resize bar register when using large bar. Well pretty clear NAK, we have embedded use cases where thi