Re: [PATCH v2] drm/amdgpu: Fix with right return code '-EIO' in 'amdgpu_gmc_vram_checking()'

Am 05.01.24 um 04:23 schrieb Srinivasan Shanmugam: The amdgpu_gmc_vram_checking() function in emulation checks whether all of the memory range of shared system memory could be accessed by GPU, from this aspect, -EIO is returned for error scenarios. Fixes the below: drivers/gpu/drm/amd/amdgpu/gmc

[PATCH] drm/amd/display: Fix assignment of integer to fixed point pbn_div

Fix the merge conflict resolution in commit 13feae00ee99e0fc8b6f1748fc4c70281a7d6939 Merge: eb284f4b37817 3c064aea46d07 Author: Dave Airlie Date: Fri Jan 5 13:19:40 2024 +1000 Merge remote-tracking branch 'drm/drm-next' into drm-tip # Conflicts: # drivers/gpu/drm/amd/display

[PATCH] drm/amdgpu: Fix unsigned comparison with less than zero in vpe_u1_8_from_fraction()

The variables 'numerator' and 'denominator', are unsigned 16-bit integer types, that can never be less than 0. Thus fixing the below: drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c:62 vpe_u1_8_from_fraction() warn: unsigned 'numerator' is never less than zero. drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c:63

[PATCH] drm/amd/powerplay: Fix kzalloc parameter 'ATOM_Tonga_PPM_Table' in 'get_platform_power_management_table()'

In struct phm_ppm_table *ptr allocation using kzalloc, an incorrect structure type is passed to sizeof() in kzalloc, larger structure types were used, thus using correct type 'struct phm_ppm_table' fixes the below: drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/process_pptables_v1_0.c:203 get_p

回覆: [PATCH] drm/amdgpu: Fix unsigned comparison with less than zero in vpe_u1_8_from_fraction()

[AMD Official Use Only - General] Reviewed-by: Peyton Lee -原始郵件- 寄件者: SHANMUGAM, SRINIVASAN 寄件日期: Friday, January 5, 2024 6:41 PM 收件者: Deucher, Alexander ; Koenig, Christian 副本: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN ; Lee, Peyton ; Yu, Lang 主旨: [PATCH] drm/amdgpu: Fi

[PATCH] drm/amdkfd: Fix variable dereferenced before NULL check in 'kfd_dbg_trap_device_snapshot()'

Fixes the below: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_debug.c:1024 kfd_dbg_trap_device_snapshot() warn: variable dereferenced before check 'entry_size' (see line 1021) Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amd

Re: [PATCH] drm/amdkfd: Fix sparse __rcu annotation warnings

Am 20.12.23 um 17:58 schrieb Felix Kuehling: On 2023-12-11 10:56, Felix Kuehling wrote: On 2023-12-08 05:11, Christian König wrote: Am 07.12.23 um 20:14 schrieb Felix Kuehling: On 2023-12-05 17:20, Felix Kuehling wrote: Properly mark kfd_process->ef as __rcu and consistently access it with

Re: [PATCH] drm/amdgpu: Check resize bar register when system uses large bar

Am 21.12.23 um 02:58 schrieb Ma, Jun: Hi Christian, On 12/20/2023 10:10 PM, Christian König wrote: Am 19.12.23 um 06:58 schrieb Ma Jun: Print a warnning message if the system can't access the resize bar register when using large bar. Well pretty clear NAK, we have embedded use cases where th

[PATCH v4 2/8] drm/radeon: Use RMW accessors for changing LNKCTL2

Don't assume that only the driver would be accessing LNKCTL2. In the case of upstream (parent), the driver does not even own the device it's changing the registers for. Use RMW capability accessors which do proper locking to avoid losing concurrent updates to the register value. This change is als

[bug report] drm/amdgpu/vpe: enable vpe dpm

Hello Peyton Lee, The patch 5f82a0c90cca: "drm/amdgpu/vpe: enable vpe dpm" from Dec 12, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c:62 vpe_u1_8_from_fraction() warn: unsigned 'numerator' is never less than zero. drivers/gpu/drm

[PATCH v4 3/8] drm/amdgpu: Use RMW accessors for changing LNKCTL2

Don't assume that only the driver would be accessing LNKCTL2. In the case of upstream (parent), the driver does not even own the device it's changing the registers for. Use RMW capability accessors which do proper locking to avoid losing concurrent updates to the register value. This change is als

Re: [PATCH 1/4] drm/amdgpu: fix avg vs input power reporting on smu7

Ping on this series? Alex On Wed, Dec 13, 2023 at 4:55 PM Alex Deucher wrote: > > Hawaii, Bonaire, Fiji, and Tonga support average power, the others > support current power. > > Signed-off-by: Alex Deucher > --- > .../gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 17 - > 1 file

Re: [PATCH 2/2] drm/amdgpu/atom: make amdgpu_atomfirmware_allocate_fb parsing consistent

Ping on this series? Alex On Thu, Dec 14, 2023 at 7:55 AM Alex Deucher wrote: > > For 2.1, ATOM_VRAM_BLOCK_SRIOV_MSG_SHARE_RESERVATION is SR-IOV only. > For 2.2, return usage_bytes properly for the non-SR-IOV case. > > Fixes: 4864f2ee9ee2 ("drm/amdgpu: add vram reservation based on > vram_usage

Re: [PATCH] drm/amd/powerplay: Fix kzalloc parameter 'ATOM_Tonga_PPM_Table' in 'get_platform_power_management_table()'

On Fri, Jan 5, 2024 at 6:21 AM Srinivasan Shanmugam wrote: > > In struct phm_ppm_table *ptr allocation using kzalloc, an incorrect > structure type is passed to sizeof() in kzalloc, larger structure types > were used, thus using correct type 'struct phm_ppm_table' fixes the > below: > > drivers/gp

RE: [PATCH 00/10] DC Patches Jan 04, 2024

[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eD

[PATCH] drm/amdgpu: Update irq disable flow during unload

In certain special cases, e.g device reset before module unload, irq gets disabled as part of reset sequence and won't get enabled back. Add special check to cover such scenarios Signed-off-by: Asad Kamal Suggested-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 12 ++-- driv

Re: [PATCH] drm/amdgpu: Check resize bar register when system uses large bar

On Fri, Jan 5, 2024 at 9:16 AM Christian König wrote: > > Am 21.12.23 um 02:58 schrieb Ma, Jun: > > Hi Christian, > > > > > > On 12/20/2023 10:10 PM, Christian König wrote: > >> Am 19.12.23 um 06:58 schrieb Ma Jun: > >>> Print a warnning message if the system can't access > >>> the resize bar regi

Re: [PATCH 0/5] drm/amd: Adjustments for three function implementations

> Date: Tue, 11 Apr 2023 14:36:36 +0200 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5) > amdgpu: Move a variable assignment behind a null pointer check in > amdgpu_ras_interrupt_dispatch() > display: Move three variable assignment

Re: [PATCH] Revert "drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole"

TBA/TMA were relocated to the upper half of the canonical address space. I don't think that qualifies as 32-bit by definition. But maybe you're using a different definition. That said, if Mesa manages its own virtual address space in user mode, and KFD maps the TMA/TBA at an address that Mesa

Re: [PATCH 0/2] fdinfo shared stats

Ping on this series again? Alex On Wed, Dec 13, 2023 at 4:13 PM Alex Deucher wrote: > > On Thu, Dec 7, 2023 at 1:03 PM Alex Deucher wrote: > > > > We had a request to add shared buffer stats to fdinfo for amdgpu and > > while implementing that, Christian mentioned that just looking at > > the G

[PATCH] drm/amd/display: cleanup inconsistent indenting in amdgpu_dm_color

smatch warnings: amdgpu_dm_update_plane_color_mgmt() warn: inconsistent indenting Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202401051643.ppdbmg1u-...@intel.com/ Signed-off-by: Melissa Wen --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 2 +- 1 f

[pull] amdgpu, amdkfd drm-next-6.8

Hi Dave, Sima, Few fixes for 6.8 from the last few weeks. The following changes since commit 669080888691c312cc926322a7b24600121c90fb: drm/amd/display: Revert " drm/amd/display: Use channel_width = 2 for vram table 3.0" (2023-12-15 12:17:19 -0500) are available in the Git repository at: h

[PATCH v2] drm/amdkfd: Fix sparse __rcu annotation warnings

Properly mark kfd_process->ef as __rcu and consistently use the right accessor functions. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312052245.yfpbsgnh-...@intel.com/ Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +-

[PATCH 1/1] Revert "drm/amd/display: fix bandwidth validation failure on DCN 2.1"

From: Ivan Lipski This commit causes dmesg-warn on several IGT tests on DCN 3.1.6: *ERROR* link_enc_cfg_validate: Invalid link encoder assignments - 0x1c Affected IGT tests include: amdgpu/[amd_assr|amd_plane|amd_hotplug] kms_atomic kms_color kms_flip kms_properties kms_universal_plane and some

Re: [PATCH 1/1] Revert "drm/amd/display: fix bandwidth validation failure on DCN 2.1"

[AMD Official Use Only - General] @Siqueira, Rodrigo From: LIPSKI, IVAN Sent: January 5, 2024 7:40 PM To: amd-gfx@lists.freedesktop.org Cc: rodrigo.siqui...@amd.com ; Choi, Nicholas ; Deucher, Alexander ; Koenig, Christian ; Wen

RE: [PATCH 1/4] drm/amdgpu: fix avg vs input power reporting on smu7

Series is Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, January 5, 2024 10:03 PM To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/amdgpu: fix avg vs input power reporting on smu7

RE: [bug report] drm/amdgpu/vpe: enable vpe dpm

[Public] Hi Dan Carpenter, This was fixed in https://patchwork.freedesktop.org/patch/573477/?series=128249&rev=1 Thank you! Regards, Srini -Original Message- From: amd-gfx On Behalf Of Dan Carpenter Sent: Friday, January 5, 2024 7:04 PM To: Lee, Peyton Cc: dri-de...@lists.freedeskto

Re: [PATCH] Revert "drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole"

The 32-bit address space means the high 32 bits are constant and predetermined and it's definitely somewhere in the upper range of the address space. If ROCm or KFD occupy that space, even accidentally, other UMDs that use libdrm for VA allocation won't be able to start. The VA range allocator is i