RE: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
[AMD Official Use Only - General] Ignore this as I have send v3. -Original Message- From: Sunil Khatri Sent: Tuesday, March 19, 2024 8:41 PM To: Deucher, Alexander ; Koenig, Christian ; Sharma, Shashank Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

[PATCH v3] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Sunil Khatri
Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between ioctl, debugfs and devcoredump. Cc: Christian König Cc: Alex Deucher Signed-off-by:

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
Sent a new patch based on discussion with Alex. On 3/19/2024 8:34 PM, Christian König wrote: Am 19.03.24 um 15:59 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 10:56 AM Christian König wrote: Am 19.03.24 um 15:26 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote:

[PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Sunil Khatri
Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between ioctl, debugfs and devcoredump. Cc: Christian König Cc: Alex Deucher Signed-off-by:

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Christian König
Am 19.03.24 um 15:59 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 10:56 AM Christian König wrote: Am 19.03.24 um 15:26 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
On Tue, Mar 19, 2024 at 10:56 AM Christian König wrote: > > Am 19.03.24 um 15:26 schrieb Alex Deucher: > > On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: > >> Refactor the code so debugfs and devcoredump can reuse > >> the common information and avoid unnecessary copy of it. > >> > >>

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Christian König
Am 19.03.24 um 15:26 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used

Re: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Christian König
Am 19.03.24 um 15:44 schrieb Khatri, Sunil: On 3/19/2024 8:07 PM, Christian König wrote: Am 19.03.24 um 15:25 schrieb Sunil Khatri: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right

[linux-next:master] BUILD REGRESSION 226d3c72fcde130a99d760895ebdd20e78e02cb5

2024-03-19 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 226d3c72fcde130a99d760895ebdd20e78e02cb5 Add linux-next specific files for 20240319 Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-gpu-drm-amd

Re: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
On 3/19/2024 8:07 PM, Christian König wrote: Am 19.03.24 um 15:25 schrieb Sunil Khatri: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used

Re: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Christian König
Am 19.03.24 um 15:25 schrieb Sunil Khatri: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between ioctl, debugfs and devcoredump. Ok, taking

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: > > Refactor the code so debugfs and devcoredump can reuse > the common information and avoid unnecessary copy of it. > > created a new file which would be the right place to > hold functions which will be used between sysfs, debugfs > and

[PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Sunil Khatri
Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between ioctl, debugfs and devcoredump. Cc: Christian König Cc: Alex Deucher Signed-off-by:

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
On Tue, Mar 19, 2024 at 10:22 AM Lazar, Lijo wrote: > > > > On 3/19/2024 7:27 PM, Khatri, Sunil wrote: > > > > On 3/19/2024 7:19 PM, Lazar, Lijo wrote: > >> > >> On 3/19/2024 6:02 PM, Sunil Khatri wrote: > >>> Refactor the code so debugfs and devcoredump can reuse > >>> the common information and

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
On 3/19/2024 7:43 PM, Lazar, Lijo wrote: On 3/19/2024 7:27 PM, Khatri, Sunil wrote: On 3/19/2024 7:19 PM, Lazar, Lijo wrote: On 3/19/2024 6:02 PM, Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Lazar, Lijo
On 3/19/2024 7:27 PM, Khatri, Sunil wrote: > > On 3/19/2024 7:19 PM, Lazar, Lijo wrote: >> >> On 3/19/2024 6:02 PM, Sunil Khatri wrote: >>> Refactor the code so debugfs and devcoredump can reuse >>> the common information and avoid unnecessary copy of it. >>> >>> created a new file which would

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
On 3/19/2024 7:19 PM, Lazar, Lijo wrote: On 3/19/2024 6:02 PM, Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/19/2024 7:17 PM, Christian König wrote: Am 19.03.24 um 12:41 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region.

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Lazar, Lijo
On 3/19/2024 6:02 PM, Sunil Khatri wrote: > Refactor the code so debugfs and devcoredump can reuse > the common information and avoid unnecessary copy of it. > > created a new file which would be the right place to > hold functions which will be used between sysfs, debugfs > and devcoredump. >

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Christian König
Am 19.03.24 um 12:41 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian):    - Dont handle clear page as TTM flag since when moving

Re: [PATCH] drm/amdgpu/pm: Don't use OD table on Arcturus

2024-03-19 Thread Alex Deucher
On Tue, Mar 19, 2024 at 6:22 AM Ma Jun wrote: > > OD is not supported on Arcturus, so the OD table > should not be used. > > Signed-off-by: Ma Jun Acked-by: Alex Deucher > --- > .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 33 +++ > 1 file changed, 5 insertions(+), 28

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
Validated the code by using the function in same way as ioctl would use in devcoredump and getting the valid values. Also this would be the container of the information that we need to share between ioctl, debugfs and devcoredump and keep updating this based on information needed. On

[PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Sunil Khatri
Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between sysfs, debugfs and devcoredump. Cc: Christian König Cc: Alex Deucher Signed-off-by:

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian):    - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that.   

Re: [PATCH v9 2/2] drm/amdgpu: sync page table freeing with tlb flush

2024-03-19 Thread Christian König
Am 18.03.24 um 17:11 schrieb Shashank Sharma: The idea behind this patch is to delay the freeing of PT entry objects until the TLB flush is done. This patch: - Adds a tlb_flush_waitlist in amdgpu_vm_update_params which will keep the objects that need to be freed after tlb_flush. - Adds PT

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Christian König
Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian): - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. - Make a specialized version of amdgpu_fill_buffer() which

[PATCH] drm/amdgpu/pm: Don't use OD table on Arcturus

2024-03-19 Thread Ma Jun
OD is not supported on Arcturus, so the OD table should not be used. Signed-off-by: Ma Jun --- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 33 +++ 1 file changed, 5 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Christian König
Am 19.03.24 um 02:55 schrieb Kurt Kartaltepe: On Mon, Mar 18, 2024 at 12:57 PM Alex Deucher wrote: On Mon, Mar 18, 2024 at 3:52 PM Alex Deucher wrote: ... Depends on the platform, but recent ones use VFCT. That said, there should only ever be one IGPU in the system so I think we could just

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Kurt Kartaltepe
On Mon, Mar 18, 2024 at 8:42 AM Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 10:19 AM Kurt Kartaltepe > wrote: > > > > On Mon, Mar 18, 2024 at 6:37 AM Alex Deucher wrote: > > > > > > On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe > > > wrote: > > > > > > > > These checks prevent using

Re: [linux-next:master] BUILD REGRESSION 2e93f143ca010a5013528e1cfdc895f024fe8c21

2024-03-19 Thread Zhihao Cheng
在 2024/3/18 22:33, kernel test robot 写道: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 2e93f143ca010a5013528e1cfdc895f024fe8c21 Add linux-next specific files for 20240318 Error/Warning ids grouped by kconfigs: gcc_recent_errors |--

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Kurt Kartaltepe
On Mon, Mar 18, 2024 at 12:57 PM Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 3:52 PM Alex Deucher wrote: > > ... > > Depends on the platform, but recent ones use VFCT. That said, there > > should only ever be one IGPU in the system so I think we could just > > rely on the VID and DID for

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Kurt Kartaltepe
On Mon, Mar 18, 2024 at 6:37 AM Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe wrote: > > > > These checks prevent using amdgpu with the pcie=assign-busses parameter > > which will re-address devices from their acpi values. > > > > Signed-off-by: Kurt Kartaltepe > >

Re: [PATCH] Revert "drm/amd/amdgpu: Fix potential ioremap() memory leaks in amdgpu_device_init()"

2024-03-19 Thread Ma, Jun
Thanks, I will fix it when push to the next branch Regards, Ma Jun On 3/19/2024 4:22 PM, Christian König wrote: > Am 19.03.24 um 09:07 schrieb Ma Jun: >> This patch causes the following iounmap erorr and calltrace >> iounmap: bad address d0b3631f > >> So just revert it and

Re: [PATCH] Revert "drm/amd/amdgpu: Fix potential ioremap() memory leaks in amdgpu_device_init()"

2024-03-19 Thread Christian König
Am 19.03.24 um 09:07 schrieb Ma Jun: This patch causes the following iounmap erorr and calltrace iounmap: bad address d0b3631f So just revert it and amdgpu_device_fini_sw() will cleanup the rmmio mapping. I think we can improve the wording here. Something like this: The original

[PATCH] Revert "drm/amd/amdgpu: Fix potential ioremap() memory leaks in amdgpu_device_init()"

2024-03-19 Thread Ma Jun
This patch causes the following iounmap erorr and calltrace iounmap: bad address d0b3631f So just revert it and amdgpu_device_fini_sw() will cleanup the rmmio mapping. This reverts commit 923f7a82d2e12a99744a940954f3829ab18a9dc7. --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16

Re: [PATCH] drm/amd/pm set pp_dpm_*clk as read only for SRIOV one VF mode

2024-03-19 Thread JingWen Chen
Acked-by: Jingwen Chen On 2024/3/15 14:31, Lin.Cao wrote: > pp_dpm_*clk should be set as read only for SRIOV one VF mode, remove > S_IWUGO flag and _store function of these debugfs in one VF mode. > > Signed-off-by: Lin.Cao > --- > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 10 +- > 1 file