[AMD Official Use Only - AMD Internal Distribution Only]
Series is
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, May 15, 2024 00:44
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 2/2] d
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Wang, Yang(Kevin)
Sent: Tuesday, May 14, 2024 08:03
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Kamal, Asad
Subject: [PATCH] drm/amdgpu: fix compiler
Remove bo NULL check in amdgpu/gmc_v12_0.c:gmc_v12_0_get_vm_pte() function
to fix smatch warning:
'drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c:518 gmc_v12_0_get_vm_pte()
warn: variable dereferenced before check 'bo' (see line 500)'
Signed-off-by: Sreekant Somasekharan
Suggested-by: Dan Carpenter
---
[AMD Official Use Only - AMD Internal Distribution Only]
Ping...
Best Regards,
Kevin
-Original Message-
From: amd-gfx On Behalf Of Yang Wang
Sent: Tuesday, May 14, 2024 8:03 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Kamal, Asad
Subject: [PATCH] drm/amdgpu: fix compiler
Remove bo NULL check in amdgpu/gmc_v12_0.c:gmc_v12_0_get_vm_pte() function
to fix smatch warning:
'drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c:518 gmc_v12_0_get_vm_pte()
warn: variable dereferenced before check 'bo' (see line 500)'
Signed-off-by: Sreekant Somasekharan
Suggested-by: Dan Carpenter
Rev
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks Alex!
-Original Message-
From: Deucher, Alexander
Sent: Tuesday, May 14, 2024 5:28 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Nirujogi, Pratap
Subject: [PATCH] drm/amdgpu: fix Kconfig for ISP v2
Add new
Ignore this. Better, functional patch sent out.
Alex
On Tue, May 14, 2024 at 5:12 PM Alex Deucher wrote:
>
> Add new config option and set proper dependencies for ISP.
>
> Signed-off-by: Alex Deucher
> Cc: Pratap Nirujogi
> ---
> drivers/gpu/drm/amd/amdgpu/Kconfig | 1 +
> drivers/gpu/drm/
Add new config option and set proper dependencies for ISP.
v2: add missed guards, drop separate Kconfig
Signed-off-by: Alex Deucher
Cc: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/Kconfig| 11 +++
drivers/gpu/drm/amd/amdgpu/Makefile | 2 ++
drivers/gpu/drm/amd
Add new config option and set proper dependencies for ISP.
Signed-off-by: Alex Deucher
Cc: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 1 +
drivers/gpu/drm/amd/amdgpu/Makefile | 2 ++
drivers/gpu/drm/amd/isp/Kconfig | 17 +
3 files changed, 20 insertions(+)
[Public]
Acked, thanks Alex.
-Original Message-
From: Deucher, Alexander
Sent: Tuesday, May 14, 2024 3:23 PM
To: amd-gfx@lists.freedesktop.org; Nirujogi, Pratap
Cc: Stephen Rothwell
Subject: RE: [PATCH] drm/amdgpu: Add documentation for AMD_IP_BLOCK_TYPE_ISP
[Public]
+ Pratap
>
[Public]
+ Pratap
> -Original Message-
> From: Deucher, Alexander
> Sent: Tuesday, May 14, 2024 11:14 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Stephen Rothwell
>
> Subject: [PATCH] drm/amdgpu: Add documentation for
> AMD_IP_BLOCK_TYPE_ISP
>
> Add missing documen
Fix up parameter descriptions.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
index 34e751b9b7003..c12c96f5bbaae 100644
--- a/drivers/
Fix up parameter descriptions.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c
b/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c
index 7db53a96cff0a.
Am 14.05.24 um 17:14 schrieb Tvrtko Ursulin:
On 13/05/2024 14:49, Tvrtko Ursulin wrote:
On 09/05/2024 13:40, Tvrtko Ursulin wrote:
On 08/05/2024 19:09, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Last few days I was looking at the situation with VRAM over
subscription, what
happens versus
Add missing documentation for the IP block.
Fixes: a83048bfa402 ("drm/amd/amdgpu: Add ISP support to amdgpu_discovery")
Reported-by: Stephen Rothwell
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/include/amd_shared.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/
On 13/05/2024 14:49, Tvrtko Ursulin wrote:
On 09/05/2024 13:40, Tvrtko Ursulin wrote:
On 08/05/2024 19:09, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Last few days I was looking at the situation with VRAM over
subscription, what
happens versus what perhaps should happen. Browsing through
Problem statement: During the system boot time, an application request
for the bulk volume of cleared range bias memory when the clear_avail
is zero, we dont fallback into normal allocation method as we had an
unnecessary clear_avail check which prevents the fallback method leads
to fb allocation f
Allocate cleared blocks in the bias range when the DRM
buddy's clear avail is zero. This will validate the bias
range allocation in scenarios like system boot when no
cleared blocks are available and exercise the fallback
path too. The resulting blocks should always be dirty.
v1:(Matthew)
- move
Applied. Thanks!
On Tue, May 14, 2024 at 3:27 AM Christian König
wrote:
>
> Am 14.05.24 um 09:06 schrieb Friedrich Vock:
> > The special case for VM passthrough doesn't check adev->nbio.funcs
> > before dereferencing it. If GPUs that don't have an NBIO block are
> > passed through, this leads to
Acked-by: Alex Deucher
On Tue, May 14, 2024 at 5:07 AM Min, Frank wrote:
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> From: Frank Min
>
> use mc address for wptr in add queue packet
>
> Signed-off-by: Frank Min
> ---
> drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 6 +-
> 1
On SOCs with SMU v13.0.6, allow changing xgmi plpd policy through
pm_policy sysfs interface.
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
v2, v3: No change
v4: Use macro for XGMI policy type name
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 17 ++-
.../drm/amd/pm/swsmu/smu13
Remove unused callback to set PLPD policy and its implementation from
arcturus, aldebaran and SMUv13.0.6 SOCs.
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 6 ---
.../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 22 ---
.../drm
Replace the legacy interface with amdgpu_dpm_set_pm_policy to set XGMI
PLPD mode. Also, xgmi_plpd sysfs node is not used by any client. Remove
that as well.
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
v2: No change
v3: Rebase to remove device_attr_id__xgmi_plpd_policy
drivers/gpu/
Add documentation about the newly added pm_policy node in sysfs.
Signed-off-by: Lijo Lazar
---
Documentation/gpu/amdgpu/thermal.rst | 6
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 48
2 files changed, 54 insertions(+)
diff --git a/Documentation/gpu/amdgpu/thermal.
On arcturus, allow changing xgmi plpd policy through pm_policy sysfs
interface.
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 ++--
.../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 42 +++
2 files changed, 46 insertion
On aldebaran, allow changing xgmi plpd policy through pm_policy sysfs
interface.
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
.../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c| 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/ald
Add support to select pstate policy in SOCs with SMUv13.0.6
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
v2,v3: No change
v4: Use macro for policy type name
.../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 2 +
.../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 71 +++
Add support to set XGMI PLPD policy levels through pm_policy sysfs node.
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
v2, v3: No change
v4: Use a macro for XGMI PLPD policy type
drivers/gpu/drm/amd/include/kgd_pp_interface.h | 1 +
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4
Add PMF message to select a Pstate policy in SOCs with SMU v13.0.6.
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_ppsmc.h | 3 ++-
drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 ++-
2 files changed, 4 insertions(
Add support to set/get information about different DPM policies. The
support is only available on SOCs which use swsmu architecture.
A DPM policy type may be defined with different levels. For example, a
policy may be defined to select Pstate preference and then later a
pstate preference may be ch
This series adds APIs to get the supported PM policies and also set them. A PM
policy type is a predefined policy type supported by an SOC and each policy may
define two or more levels to choose from. A user can select the appropriate
level through amdgpu_dpm_set_pm_policy() or through sysfs node p
This patch looks good to me.
Reviewed-by: Tom Chung
On 5/9/2024 9:55 AM, Mario Limonciello wrote:
The pixel_clock_mhz property is populated in amdgpu_dm when Freesync is setup,
but it is not used anywhere in amdgpu_dm. Remove the dead code.
Cc:chiahsuan.ch...@amd.com
Signed-off-by: Mario Limo
[AMD Official Use Only - AMD Internal Distribution Only]
Series is
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Gao, Likun
Sent: Tuesday, May 14, 2024 16:51
To: amd-gfx list
Subject: [PATCH 1/8] drm/amdgpu: support imu for gc 12_0_0
[AMD O
[AMD Official Use Only - AMD Internal Distribution Only]
Series is
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Lazar, Lijo
Sent: Tuesday, May 14, 2024 16:36
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Deucher, Alexander
; Koenig, Christian ; Ma,
Le
Adding more device information:
a. PCI info
b. VRAM and GTT info
c. GDC config
Also correct the print layout and section information for
in devcoredump.
Signed-off-by: Sunil Khatri
---
.../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 21 +--
1 file changed, 19 insertions(+), 2 de
To avoid warning problems, drop index and
use PPSMC_MSG_GfxDriverReset instead of index for aldebaran.
Signed-off-by: Jesse Zhang
Suggested-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/dri
To avoid warning problems, drop index and use PPSMC_MSG_GfxDriverReset instead
of index.
Signed-off-by: Jesse Zhang
Suggested-by: Lijo Lazar
---
.../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/dr
Am 14.05.24 um 10:13 schrieb Liang, Prike:
[AMD Official Use Only - AMD Internal Distribution Only]
From: Koenig, Christian
Sent: Friday, May 10, 2024 5:31 PM
To: Liang, Prike ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: Re: [PATCH] drm/amdgpu: Use the slab allocator to red
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Lijo
-Original Message-
From: Lazar, Lijo
Sent: Tuesday, May 14, 2024 4:19 PM
To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Koenig, Christian
; Huang, Tim
Subject: Re: [PATCH 2/2 v2] drm/amd/pm
[AMD Official Use Only - AMD Internal Distribution Only]
From: Likun Gao
Switch the default mes to uni mes for gfx v12.
V2: remove uni_mes set for gfx v11.
Signed-off-by: Likun Gao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 --
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
[AMD Official Use Only - AMD Internal Distribution Only]
From: Likun Gao
Enable GFXOFF for GC v12.0.0.
Signed-off-by: Likun Gao
Reviewed-by: Kenneth Feng
---
drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
b/d
[AMD Official Use Only - AMD Internal Distribution Only]
From: Kenneth Feng
add pp_dpm_dcefclk for smu 14.0.2/3
Signed-off-by: Kenneth Feng
Reviewed-by: Jack Gui
---
.../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 24 +++
1 file changed, 24 insertions(+)
diff --git a/drivers
[AMD Official Use Only - AMD Internal Distribution Only]
From: Likun Gao
Enable mmhub and athub cg on gc 12.0.0
Signed-off-by: Likun Gao
Reviewed-by: Hawking Zhang
---
drivers/gpu/drm/amd/amdgpu/soc24.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/
[AMD Official Use Only - AMD Internal Distribution Only]
From: Frank Min
use mc address for wptr in add queue packet
Signed-off-by: Frank Min
---
drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v12_
[AMD Official Use Only - AMD Internal Distribution Only]
From: Likun Gao
Enable 3D cgcg, 3D cgls, sram fgcg, perfcounter mgcg, repeater fgcg for gc
v12.0.0.
Signed-off-by: Likun Gao
Reviewed-by: Hawking Zhang
---
drivers/gpu/drm/amd/amdgpu/soc24.c | 8 +++-
1 file changed, 7 insertions(
[AMD Official Use Only - AMD Internal Distribution Only]
From: Likun Gao
Enable GFX CGCG and CGLS for gfx version 12.0.0.
Signed-off-by: Likun Gao
Reviewed-by: Hawking Zhang
---
drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 1 +
drivers/gpu/drm/amd/amdgpu/soc24.c | 3 ++-
2 files changed, 3 i
[AMD Official Use Only - AMD Internal Distribution Only]
From: Likun Gao
Support IMU for ASIC with GC 12.0.0
Drop some unused function.
Signed-off-by: Likun Gao
---
drivers/gpu/drm/amd/amdgpu/imu_v12_0.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/imu_v12_
[AMD Official Use Only - AMD Internal Distribution Only]
From: Sonny Jiang
Enable PG on JPEG5
Signed-off-by: Sonny Jiang
Reviewed-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/soc24.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc24.c
b/dri
Add GMC API to fetch NPS range information from discovery table. Use NPS
range information in GMC 9.4.3 SOCs when available, otherwise fallback
to software method.
Signed-off-by: Lijo Lazar
Reviewed-by: Le Ma
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 92 +++
drivers/gp
Add support to fetch NPS info table in IP discovery table.
Signed-off-by: Lijo Lazar
Reviewed-by: Le Ma
---
drivers/gpu/drm/amd/include/discovery.h | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/include/discovery.h
b/drivers/gp
Consider the 16M reserved region also before range calculation for GMC
9.4.3 SOCs.
Signed-off-by: Lijo Lazar
Acked-by: Christian König
Reviewed-by: Le Ma
Fixes: a433f1f59484 ("drm/amdgpu: Initialize memory ranges for GC 9.4.3")
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
1 file changed,
On 5/14/2024 12:28 PM, Jesse Zhang wrote:
> To avoid warning problems, drop index and
> use PPSMC_MSG_GfxDriverReset instead of index for aldebaran.
>
> Signed-off-by: Jesse Zhang
> Suggested-by: Lijo Lazar
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 13 +++--
> 1 fi
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Wang, Yang(Kevin)
Sent: Tuesday, May 14, 2024 16:15
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Zhou1, Tao
Subject: [PATCH] drm/amdgpu: add debug fla
Use debug_mask=0x10 (BIT.4) param to help enable RAS ACA driver.
(RAS ACA is disabled by default.)
Signed-off-by: Yang Wang
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ++
3 files changed, 9 i
[AMD Official Use Only - AMD Internal Distribution Only]
> From: Koenig, Christian
> Sent: Friday, May 10, 2024 5:31 PM
> To: Liang, Prike ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: Re: [PATCH] drm/amdgpu: Use the slab allocator to reduce job
> allocation fragmentation
>
Am 14.05.24 um 09:06 schrieb Friedrich Vock:
The special case for VM passthrough doesn't check adev->nbio.funcs
before dereferencing it. If GPUs that don't have an NBIO block are
passed through, this leads to a NULL pointer dereference on startup.
Signed-off-by: Friedrich Vock
Acked-by: Chris
On 5/14/2024 12:37 PM, Wang, Yang(Kevin) wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> -Original Message-
> From: amd-gfx On Behalf Of Lazar, Lijo
> Sent: Tuesday, May 14, 2024 2:07 PM
> To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexan
[AMD Official Use Only - AMD Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Lazar, Lijo
Sent: Tuesday, May 14, 2024 2:07 PM
To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Koenig, Christian
; Huang, Tim
Subject: Re: [PATCH 2/2] d
The special case for VM passthrough doesn't check adev->nbio.funcs
before dereferencing it. If GPUs that don't have an NBIO block are
passed through, this leads to a NULL pointer dereference on startup.
Signed-off-by: Friedrich Vock
Fixes: 1bece222eab ("drm/amdgpu: Clear doorbell interrupt statu
59 matches
Mail list logo