[PATCH] drm/amd/pm: update driver-if interface

2024-05-17 Thread Alex Deucher
From: Kenneth Feng update driver-if interface for smu 14.0.2/3 Signed-off-by: Kenneth Feng Reviewed-by: Yang Wang Signed-off-by: Alex Deucher --- .../swsmu/inc/pmfw_if/smu14_driver_if_v14_0.h | 21 +-- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v14_0.h | 2 +- 2 files changed,

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 1:27 PM Tim Van Patten wrote: > > > Fair enough, but this is also the only gfx9 APU which defaults to > > noretry=1, all of the rest are dGPUs. I'd argue it should align with > > the other GFX9 APUs or they should all enable noretry=1. > > Do you mean we should remove all

[PATCH] drm/amdgpu: Remove wrong fini_data_exchange call

2024-05-17 Thread Victor Skvortsov
This call is already done inside amdgpu_device_pre_asic_reset. If should_recover_gpu is false, then vf2pf worker thread is permanently killed. Signed-off-by: Victor Skvortsov --- drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 2 -- drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c | 2 -- 2 files changed, 4

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Dave, Please help pull this patch into drm-next. This will fix any unnecessary warnings in memory pressure situation. Thanks for the help. Regards, Arun. On 5/17/2024 8:03 PM, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Darrick J. Wong
On Thu, May 16, 2024 at 01:34:54PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.10 and submit it then. Hoping >to keep the conflicts that it will

Re: 6.10/regression/bisected - commit a68c7eaa7a8f cause *ERROR* Trying to clear memory with ring turned off in amdgpu_fill_buffer.

2024-05-17 Thread Mikhail Gavrilov
On Fri, May 17, 2024 at 7:46 PM Paneer Selvam, Arunpravin wrote: > > Please check if the below patch link helps. I am working on Christian's > review > comments. I will post the next version. > > https://patchwork.freedesktop.org/patch/592823/?series=133239=1 > Thanks, Arun. With the patch this

Re: [PATCH] drm/amdkfd: Correct the GFX12 memory type setting

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 11:51 AM Alex Deucher wrote: > > On Fri, May 17, 2024 at 3:07 AM Shane Xiao wrote: > > > > This patch fixes the GFX12 memory type to NC. Since > > the Memory type can be overwritten by the previous > > operations, the GFX12 MTYPE bits need to be clear > > before setting

Re: [PATCH] drm/amdkfd: Correct the GFX12 memory type setting

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 3:07 AM Shane Xiao wrote: > > This patch fixes the GFX12 memory type to NC. Since > the Memory type can be overwritten by the previous > operations, the GFX12 MTYPE bits need to be clear > before setting to NC. > > Signed-off-by: longlyao > Signed-off-by: Shane Xiao >

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 2:35 AM Christian König wrote: > > Am 16.05.24 um 19:57 schrieb Tim Van Patten: > > From: Tim Van Patten > > > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > > 9.3.0: > > > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > >

Re: 6.10/regression/bisected - commit a68c7eaa7a8f cause *ERROR* Trying to clear memory with ring turned off in amdgpu_fill_buffer.

2024-05-17 Thread Paneer Selvam, Arunpravin
On 5/17/2024 6:56 PM, Mikhail Gavrilov wrote: Hi, I am continuing to test unstable kernels. Yesterday at Fedora Rawhide arrived the new kernel 20240516git3c999d1ae3c7 and I spotted in kernel log new error message: [ 13.676117] [drm] Seamless boot condition check passed [ 13.676996]

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
On 5/17/2024 7:30 PM, Matthew Auld wrote: On 17/05/2024 14:50, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge

[PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Arunpravin Paneer Selvam
Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge call. v2:(Matthew) - Move the fallback and block incompatible checks above the contains check.

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Matthew Auld
On 17/05/2024 14:50, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge call. v2:(Matthew) - Move the fallback and

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Matthew, This fixes the problem. Regards, Arun. On 5/17/2024 7:20 PM, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during

[PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Arunpravin Paneer Selvam
Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge call. v2:(Matthew) - Move the fallback and block incompatible checks above the contains check.

Re: [RFC v2 0/2] Discussion around eviction improvements

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 3:41 AM Tvrtko Ursulin wrote: > > > On 16/05/2024 20:21, Alex Deucher wrote: > > On Thu, May 16, 2024 at 8:18 AM Tvrtko Ursulin wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Reduced re-spin of my previous series after Christian corrected a few > >> misconceptions that

Re: [RFC v2 0/2] Discussion around eviction improvements

2024-05-17 Thread Tvrtko Ursulin
On 16/05/2024 20:21, Alex Deucher wrote: On Thu, May 16, 2024 at 8:18 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Reduced re-spin of my previous series after Christian corrected a few misconceptions that I had. So lets see if what remains makes sense or is still misguided. To

[PATCH -next] drm/amd/display: Update optc35_set_odm_combine doc to match kernel-doc spec

2024-05-17 Thread Yang Li
This patch updates the function documentation comment for optc35_set_odm_combine to conform to the kernel-doc specification. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

RE: Request for Information on the current drm radeon Atomic Mode Settings

2024-05-17 Thread Deucher, Alexander
[Public] The radeon driver does not support atomic modesetting. It was largely written before atomic existed. Converting it to atomic would be a substantial undertaking that would potentially regress a lot of really old chips. Radeon supports hardware that is 25+ years old at this point.

Re: [PATCH] drm/buddy: Merge back blocks in bias range function

2024-05-17 Thread Matthew Auld
On 17/05/2024 13:38, Arunpravin Paneer Selvam wrote: In bias range allocation, when we don't find the required blocks (i.e) on returning the -ENOSPC, we should merge back the split blocks. Otherwise, during force_merge we are flooded with warn on's due to block and its buddy are in same clear

Re: [PATCH] drm/buddy: Merge back blocks in bias range function

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Matthew, Could you help review this patch quickly. Hi Dave This patch just fixes the unnecessary warn on's triggered during the force_merge call. Regards, Arun. On 5/17/2024 6:08 PM, Arunpravin Paneer Selvam wrote: In bias range allocation, when we don't find the required blocks (i.e) on

[PATCH] drm/buddy: Merge back blocks in bias range function

2024-05-17 Thread Arunpravin Paneer Selvam
In bias range allocation, when we don't find the required blocks (i.e) on returning the -ENOSPC, we should merge back the split blocks. Otherwise, during force_merge we are flooded with warn on's due to block and its buddy are in same clear state (dirty or clear). Hence, renamed the force_merge

Re: Request for Information on the current drm radeon Atomic Mode Settings

2024-05-17 Thread Mauro Rossi
Cc: correct email address of Lee Jones, just For Your Information Updated [2] link URL because HWC3 in Celadon was moved to project Celadon drm-hwcomposer local branch on yesterday The request for information on drm radeon atomic modesettings is confirmed Mauro On Fri, May 17, 2024 at 8:31 AM

Re: [PATCH 1/3] drm/amdgpu: Add amdgpu_bo_is_vm_bo helper

2024-05-17 Thread Christian König
Am 16.05.24 um 14:21 schrieb Tvrtko Ursulin: Hi Christian, On 08/05/2024 09:26, Tvrtko Ursulin wrote: On 08/05/2024 06:42, Christian König wrote: Am 06.05.24 um 18:26 schrieb Tvrtko Ursulin: On 03/05/2024 10:14, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Help code readability by

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Takashi Iwai
On Thu, 16 May 2024 19:34:54 +0200, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.10 and submit it then. Hoping >to keep the conflicts that it will

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Rafael J. Wysocki
On Thu, May 16, 2024 at 7:35 PM Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.10 and submit it then. Hoping >to keep the conflicts that it will cause

[PATCH v2 6/6] drm/ci: update xfails for the new testlist

2024-05-17 Thread Vignesh Raman
Now the testlist is used from IGT build, so update xfails with the new testlist. Set the timeout of all i915 jobs to 1h30m since some jobs takes more than 1 hour to complete. Signed-off-by: Vignesh Raman --- v2: - Set the timeout of all i915 jobs to 1h30m and updated expectations file. ---

[PATCH v2 5/6] drm/ci: skip driver specific tests

2024-05-17 Thread Vignesh Raman
Skip driver specific tests and skip kms tests for panfrost driver since it is not a kms driver. Signed-off-by: Vignesh Raman --- v2: - Skip xe tests for amdgpu and virtio. --- .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 15 ++- drivers/gpu/drm/ci/xfails/i915-amly-skips.txt

[PATCH v2 4/6] drm/ci: uprev IGT

2024-05-17 Thread Vignesh Raman
test-list.txt and test-list-full.txt are not generated for cross-builds and they are required by drm-ci for testing arm32 targets. This is fixed in igt-gpu-tools. So uprev IGT to include the commit which fixes this issue. Disable building xe driver tests for non-intel platforms. Signed-off-by:

[PATCH v2 3/6] drm/ci: build virtual GPU driver as module

2024-05-17 Thread Vignesh Raman
With latest IGT, the tests tries to load the module and it fails. So build the virtual GPU driver for virtio as module. Signed-off-by: Vignesh Raman --- v2: - No changes. --- drivers/gpu/drm/ci/build.sh | 1 - drivers/gpu/drm/ci/igt_runner.sh | 6 +++---

[PATCH v2 2/6] drm/ci: generate testlist from build

2024-05-17 Thread Vignesh Raman
Stop vendoring the testlist into the kernel. Instead, use the testlist from the IGT build to ensure we do not miss renamed or newly added tests. Signed-off-by: Vignesh Raman --- v2: - Fix testlist generation for arm and arm64 builds. --- drivers/gpu/drm/ci/build-igt.sh | 34 +

[PATCH v2 1/6] drm/ci: uprev mesa version

2024-05-17 Thread Vignesh Raman
zlib.net is not allowing tarball download anymore and results in below error in kernel+rootfs_arm32 container build, urllib.error.HTTPError: HTTP Error 403: Forbidden urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type Uprev mesa to latest version which includes a fix for this issue.

[PATCH v2 0/6] drm/ci: uprev mesa/IGT and generate testlist

2024-05-17 Thread Vignesh Raman
Uprev mesa and IGT to the latest version and stop vendoring the testlist into the kernel. Instead, use the testlist from the IGT build to ensure we do not miss renamed or newly added tests. Update the xfails with the latest testlist run. Also build virtual GPU driver for virtio as module. The

RE: [PATCH 3/3] drm/amdgpu: fix ACA no query result after gpu reset

2024-05-17 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] The series is Reviewed-by: Tao Zhou > -Original Message- > From: Wang, Yang(Kevin) > Sent: Friday, May 17, 2024 11:41 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Chai, Thomas > Subject: [PATCH

RE: [PATCH] drm/amd/swsmu: update Dpmclocks_t for smu v14.0.1

2024-05-17 Thread Zhang, Yifan
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yifan Zhang -Original Message- From: Ma, Li Sent: Friday, May 17, 2024 4:07 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Ma, Li Subject: [PATCH] drm/amd/swsmu: update Dpmclocks_t for

[PATCH] drm/amd/swsmu: update Dpmclocks_t for smu v14.0.1

2024-05-17 Thread Li Ma
MinGfxClk in Dpmclocks_t is wrong. According to pmfw, dropping an uint8_t spare in Dpmclocks_t. Signed-off-by: Li Ma --- .../gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu14_driver_if_v14_0_0.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] drm/amdkfd: Correct the GFX12 memory type setting

2024-05-17 Thread Shane Xiao
This patch fixes the GFX12 memory type to NC. Since the Memory type can be overwritten by the previous operations, the GFX12 MTYPE bits need to be clear before setting to NC. Signed-off-by: longlyao Signed-off-by: Shane Xiao --- drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 3 ++- 1 file changed, 2

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Christian König
Am 16.05.24 um 19:57 schrieb Tim Van Patten: From: Tim Van Patten The following commit updated gmc->noretry from 0 to 1 for GC HW IP 9.3.0: commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") This causes the device to hang when a page fault occurs, until the device is

Request for Information on the current drm radeon Atomic Mode Settings

2024-05-17 Thread Mauro Rossi
Hi all, with Android 14 QPR2 there were substantial changes in graphic stack's Android HAL (Hardware Abstraction Layer), essentially it became mandatory that hwcomposer HAL module supports AIDL Android Interface Definition Language, at the moment drm_hwcomposer does not support AIDL [1] Project