RE: [PATCH] drm/amdgpu: update type of buf size to u32 for eeprom functions

2024-05-19 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] The limit variable in amdgpu_eeprom_xfer is not 0, so the buf_size will be cut into smaller pieces, u16 is enough for __amdgpu_eeprom_xfer. Anyway, use u32 for __amdgpu_eeprom_xfer and make sure the msgs[1].len is less than U16_MAX is bet

Re: [PATCH 1/2] Revert "drm/amd/pm: Use gpu_metrics_v1_6 for SMUv13.0.6"

2024-05-19 Thread Lazar, Lijo
On 5/20/2024 10:31 AM, Asad Kamal wrote: > Remove gpu_metrics_v1_6 usage for SMUv13.0.6 temporarily and use > gpu_metrics_v1_5 until tool support is ready for it. > > This reverts commit e6efb71ae640eada28f44cc97aa79e8ae4901e63. > > Signed-off-by: Asad Kamal Series is Reviewed-by: Li

[PATCH 2/2] Revert "drm/amd/pm: Add gpu_metrics_v1_6"

2024-05-19 Thread Asad Kamal
Remove gpu_metrics_v1_6 temporarily until tool support is ready This reverts commit d24c43b1e3193415e28c4b1f3b2908ff88b28eb3. Signed-off-by: Asad Kamal --- .../gpu/drm/amd/include/kgd_pp_interface.h| 89 --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c| 3 - 2 files chang

[PATCH 1/2] Revert "drm/amd/pm: Use gpu_metrics_v1_6 for SMUv13.0.6"

2024-05-19 Thread Asad Kamal
Remove gpu_metrics_v1_6 usage for SMUv13.0.6 temporarily and use gpu_metrics_v1_5 until tool support is ready for it. This reverts commit e6efb71ae640eada28f44cc97aa79e8ae4901e63. Signed-off-by: Asad Kamal --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 18 -- 1 file change

RE: [PATCH] drm/amdgpu: update type of buf size to u32 for eeprom functions

2024-05-19 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Hmm... but in __amdgpu_eeprom_xfer, the u32 will still be cut to u16. __amdgpu_eeprom_xfer(struct i2c_adapter *i2c_adap, u32 eeprom_addr, u8 *eeprom_buf, u16 buf_size, bool read) Regards, Hawking -Original Message- From: amd-gfx

RE: [PATCH] drm/amdgpu: update type of buf size to u32 for eeprom functions

2024-05-19 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Monday, May 20, 2024 10:46 AM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: update type of b

[PATCH] drm/amdgpu: update type of buf size to u32 for eeprom functions

2024-05-19 Thread Tao Zhou
Avoid overflow issue. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_eeprom.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_eeprom.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_eeprom.c b/drivers/gpu/drm/amd/amdgpu/am

RE: [PATCH 2/2] drm/amdgpu: Queue KFD reset workitem in VF FED

2024-05-19 Thread Luo, Zhigang
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Zhigang Luo -Original Message- From: amd-gfx On Behalf Of Victor Skvortsov Sent: Sunday, May 19, 2024 10:52 AM To: amd-gfx@lists.freedesktop.org Cc: Skvortsov, Victor Subject: [PATCH 2/2] drm/amdgpu: Queue KFD reset

RE: [PATCH 1/2] drm/amdgpu: Extend KIQ reg polling wait for VF

2024-05-19 Thread Luo, Zhigang
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Zhigang Luo -Original Message- From: amd-gfx On Behalf Of Victor Skvortsov Sent: Sunday, May 19, 2024 10:52 AM To: amd-gfx@lists.freedesktop.org Cc: Skvortsov, Victor Subject: [PATCH 1/2] drm/amdgpu: Extend KIQ reg

[PATCH 2/2] drm/amdgpu: Queue KFD reset workitem in VF FED

2024-05-19 Thread Victor Skvortsov
The guest recovery sequence is buggy in Fatal Error when both FLR & KFD reset workitems are queued at the same time. In addition, FLR guest recovery sequence is out of order when PF/VF communication breaks due to a GPU fatal error As a temporary work around, perform a KFD style reset (Initiate res

[PATCH 1/2] drm/amdgpu: Extend KIQ reg polling wait for VF

2024-05-19 Thread Victor Skvortsov
Runtime KIQ interface to read/write registers in VF may take longer than expected for BM environment. Extend the timeout. Signed-off-by: Victor Skvortsov --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/a

[PATCH 2/2] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-05-19 Thread Mario Limonciello
From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to have color accuracy and fidelity instead of power saving. Verify that the sysfs file behaves as expected in this situation. Signed-off-by: Mario Limonciello

[PATCH 0/2] Add support for testing panel power saving DRM property

2024-05-19 Thread Mario Limonciello
During the Display Next hackfest 2024 one of the topics discussed was the need for compositor to be able to relay intention to drivers that color fidelity is preferred over power savings. To accomplish this a new optional DRM property is being introduced called "panel power saving". This property

[PATCH 1/2] tests/amdgpu/amd_abm: Make set_abm_level return type int

2024-05-19 Thread Mario Limonciello
From: Mario Limonciello In order to bubble of cases of expeted errors on set_abm_level() change the return type to int. Signed-off-by: Mario Limonciello --- tests/amdgpu/amd_abm.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/tests/amdg

[PATCH 1/2] drm: Introduce panel_power_saving drm property

2024-05-19 Thread Mario Limonciello
The `panel_power_saving` DRM property is an optional property that can be added to a connector by a driver. This property is for compositors to indicate intent of allowing policy for the driver to use power saving features that may compromise color fidelity. Signed-off-by: Mario Limonciello ---

[PATCH 2/2] drm/amd: Add panel_power_saving drm property to eDP connectors

2024-05-19 Thread Mario Limonciello
When the `panel_power_saving` property is set to "Forbidden" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the property is restored to "Allowed" the previous value of ABM will be restored. Signed-off-by: Mario Limonciello --- drivers/gp

[PATCH 0/2] Add support for Panel Power Savings property

2024-05-19 Thread Mario Limonciello
During the Display Next hackfest 2024 one of the topics discussed was the need for compositor to be able to relay intention to drivers that color fidelity is preferred over power savings. To accomplish this a new optional DRM property is being introduced called "panel power saving". This property

[PATCH] drm/amd/display: Pass errors from amdgpu_dm_init() up

2024-05-19 Thread Mario Limonciello
Errors in amdgpu_dm_init() are silently ignored and dm_hw_init() will succeed. However often these are fatal errors and it would be better to pass them up. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +- 1 file changed, 5 insertions(+), 1 deleti

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-19 Thread Guenter Roeck
On Thu, May 16, 2024 at 01:34:54PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.10 and submit it then. Hoping >to keep the conflicts that it will

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-19 Thread Guenter Roeck
On 5/17/24 10:48, Steven Rostedt wrote: On Fri, 17 May 2024 10:36:37 -0700 Guenter Roeck wrote: Building csky:allmodconfig (and others) ... failed -- Error log: In file included from include/trace/trace_events.h:419, from include/trace/define_trace.h:102,

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-19 Thread Tim Van Patten
> Fair enough, but this is also the only gfx9 APU which defaults to > noretry=1, all of the rest are dGPUs. I'd argue it should align with > the other GFX9 APUs or they should all enable noretry=1. Do you mean we should remove all IP_VERSION(9, X, X) entries from amdgpu_gmc_noretry_set(), leaving

Re: Kernel 5.15.150 black screen with AMD Raven/Picasso GPU

2024-05-19 Thread Armin Wolf
Am 17.05.24 um 03:30 schrieb Barry Kauler: Armin, Yifan, Prike, I will top-post, so you don't have to scroll down. After identifying the commit that causes black screen with my gpu, I posted the result to you guys, on May 9. It is now May 17 and no reply. OK, I have now created a patch that reve

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-19 Thread Steven Rostedt
On Fri, 17 May 2024 10:36:37 -0700 Guenter Roeck wrote: > Building csky:allmodconfig (and others) ... failed > -- > Error log: > In file included from include/trace/trace_events.h:419, > from include/trace/define_trace.h:102, > from drivers/cxl/core/t

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-19 Thread Tim Van Patten
On Fri, May 17, 2024 at 12:35 AM Christian König wrote: > > Am 16.05.24 um 19:57 schrieb Tim Van Patten: > > From: Tim Van Patten > > > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > > 9.3.0: > > > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > >

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-19 Thread Guenter Roeck
On 5/17/24 11:00, Guenter Roeck wrote: On 5/17/24 10:48, Steven Rostedt wrote: On Fri, 17 May 2024 10:36:37 -0700 Guenter Roeck wrote: Building csky:allmodconfig (and others) ... failed -- Error log: In file included from include/trace/trace_events.h:419,   from in