[pull] amdgpu, amdkfd, radeon drm-next-6.11

2024-06-07 Thread Alex Deucher
Hi Dave, Sima, New stuff for 6.11. The following changes since commit b77bef36015c501f1e0f51db72c55e6dcd8bdd48: drm/amd/display: Add some HDCP registers DCN35 list (2024-04-26 17:22:45 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

RE: [PATCH 2/2] Revert "drm/amd/display: Add NULL check for 'afb' before dereferencing in amdgpu_dm_plane_handle_cursor_update"

2024-06-07 Thread Zhang, George
[AMD Official Use Only - AMD Internal Distribution Only] Tested-by: George Zhang Thanks, George -Original Message- From: LIPSKI, IVAN Sent: Friday, June 7, 2024 12:34 PM To: amd-gfx@lists.freedesktop.org Cc: SHANMUGAM, SRINIVASAN ; Li, Sun peng (Leo) ; Wentland, Harry ; Siqueira,

RE: [PATCH 1/2] Revert "drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor"

2024-06-07 Thread Zhang, George
[AMD Official Use Only - AMD Internal Distribution Only] Tested-by: George Zhang Thanks, George -Original Message- From: LIPSKI, IVAN Sent: Friday, June 7, 2024 12:34 PM To: amd-gfx@lists.freedesktop.org Cc: SHANMUGAM, SRINIVASAN ; Li, Sun peng (Leo) ; Wentland, Harry ; Siqueira,

Re: [PATCH] drm/radeon: remove load callback

2024-06-07 Thread Christian König
In general thanks for looking into this, but when you don't have hardware to at least briefly validate your work we probably can't accept that. I can see if I can get anybody looking into this, but the odds that somebody has time and hardware are pretty low. Christian. Am 07.06.24 um 16:15

[linux-next:master] BUILD REGRESSION d35b2284e966c0bef3e2182a5c5ea02177dd32e4

2024-06-07 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d35b2284e966c0bef3e2182a5c5ea02177dd32e4 Add linux-next specific files for 20240607 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202406071624.o81nljmg-...@intel.com https

Re: [PATCH 2/2] Revert "drm/amd/display: Add NULL check for 'afb' before dereferencing in amdgpu_dm_plane_handle_cursor_update"

2024-06-07 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Srinivasan Shanmugam mailto:srinivasan.shanmu...@amd.com>> Get Outlook for Android From: LIPSKI, IVAN Sent: Friday, June 7, 2024 10:03:59 PM To:

Re: [PATCH 1/2] Revert "drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor"

2024-06-07 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Srinivasan Shanmugam mailto:srinivasan.shanmu...@amd.com>> Get Outlook for Android From: LIPSKI, IVAN Sent: Friday, June 7, 2024 10:03:58 PM To:

[PATCH 2/2] Revert "drm/amd/display: Add NULL check for 'afb' before dereferencing in amdgpu_dm_plane_handle_cursor_update"

2024-06-07 Thread ivlipski
From: Ivan Lipski [WHY] This patch is a dupplicate implementation of 14bcf29b, which we are reverting due to a regression with kms_plane_cursor IGT tests. This reverts commit 0d84450ae0db367780c3dd2e208fe4e6fe5565b8. Signed-off-by: Ivan Lipski ---

[PATCH 1/2] Revert "drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor"

2024-06-07 Thread ivlipski
From: Ivan Lipski [WHY] This commit introduced a regression with kms_plane_cursor IGT tests, causing AMD Asics to fail these tests. This reverts commit 14bcf29b706f8ef423b86c9b783055b5b0c2cd35. Signed-off-by: Ivan Lipski --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 16

[PATCH 1/2] Revert "drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor"

2024-06-07 Thread ivlipski
From: Ivan Lipski [WHY] This commit introduced a regression with kms_plane_cursor IGT tests, causing AMD Asics to fail these tests. This reverts commit 14bcf29b706f8ef423b86c9b783055b5b0c2cd35. Signed-off-by: Ivan Lipski --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 16

Re: [PATCH] drm/ttm: Add cgroup memory accounting for GTT memory

2024-06-07 Thread Christian König
Am 07.06.24 um 16:43 schrieb Joshi, Mukul: [AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Koenig, Christian Sent: Friday, June 7, 2024 3:26 AM To: Joshi, Mukul ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Bhardwaj, Rajneesh ; Yang, Philip

RE: [PATCH] drm/ttm: Add cgroup memory accounting for GTT memory

2024-06-07 Thread Joshi, Mukul
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Koenig, Christian > Sent: Friday, June 7, 2024 3:26 AM > To: Joshi, Mukul ; amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Bhardwaj, Rajneesh > ; Yang, Philip > Subject: Re: [PATCH] drm/ttm: Add

Re: [PATCH] drm/amd/display: Set default brightness according to ACPI

2024-06-07 Thread Leo Li
On 2024-06-07 09:49, Alex Deucher wrote: On Fri, Jun 7, 2024 at 3:22 AM Mario Limonciello wrote: Currently, amdgpu will always set up the brightness at 100% when it loads. However this is jarring when the BIOS has it previously programmed to a much lower value. The ACPI ATIF method

RE: [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off.

2024-06-07 Thread Deucher, Alexander
[Public] > -Original Message- > From: Thomas Glanzmann > Sent: Friday, June 7, 2024 12:53 AM > To: Deucher, Alexander ; Koenig, Christian > ; p...@glanzmann.de; Pan, Xinhui > > Cc: amd-gfx@lists.freedesktop.org > Subject: [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory

Re: [PATCH] drm/amd/display: Set default brightness according to ACPI

2024-06-07 Thread Alex Deucher
On Fri, Jun 7, 2024 at 3:22 AM Mario Limonciello wrote: > > Currently, amdgpu will always set up the brightness at 100% when it > loads. However this is jarring when the BIOS has it previously > programmed to a much lower value. > > The ACPI ATIF method includes two members for "ac_level" and

[PATCH] drm/radeon: remove load callback

2024-06-07 Thread wu hoi pok
this patch is to remove the load callback from the kms_driver, following closly to amdgpu, radeon_driver_load_kms and devm_drm_dev_alloc are used, most of the changes here are rdev->ddev to rdev_to_drm, which maps to adev_to_drm in amdgpu. however this patch is not tested on hardware, so if you

[drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off.

2024-06-07 Thread Thomas Glanzmann
Hello, starting with 6.10.0-rc1 I get the following in dmesg: [ 11.025935] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off. [ 11.026037] [ cut here ] [ 11.026038] WARNING: CPU: 10 PID: 659 at

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

2024-06-07 Thread Linux regression tracking (Thorsten Leemhuis)
[CCing the other amd drm maintainers] On 05.06.24 14:04, Mikhail Gavrilov wrote: > On Sun, May 26, 2024 at 7:06 PM Mikhail Gavrilov > wrote: >> >> Day before yesterday I replaced 7900XTX to 6900XT for got clear in >> which kernel first time appeared warning message "DMA-API: amdgpu >>

[syzbot] [mm?] general protection fault in dequeue_hugetlb_folio_nodemask

2024-06-07 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0e1980c40b6e Add linux-next specific files for 20240531 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=166086f298 kernel config: https://syzkaller.appspot.com/x/.config?x=d9c3ca4e54577b88

Re: Page fault storms and IH ring overflow

2024-06-07 Thread svicenty
Amd update Sent from my T-Mobile 5G Device

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

2024-06-07 Thread Alex Deucher
On Sun, May 26, 2024 at 10:12 AM Mikhail Gavrilov wrote: > > Hi, > Day before yesterday I replaced 7900XTX to 6900XT for got clear in > which kernel first time appeared warning message "DMA-API: amdgpu > :0f:00.0: cacheline tracking EEXIST, overlapping mappings aren't > supported". > The

Re: [PATCH] drm/amdkfd: Extend gfx12 trap handler fix to gfx10/11

2024-06-07 Thread Lancelot SIX
On 06/06/2024 00:16, Jay Cornwall wrote: In commit 6d1878882d2d ("drm/amdkfd: gfx12 context save/restore trap handler fixes") the following fix was introduced but incorrectly restricted to gfx12. The same issue and a corresponding fix apply to gfx10 and gfx11. Do not overwrite

Re: [PATCH 2/2] drm/amdgpu: fix dereferencing null pointer warning in ring_test_ib()

2024-06-07 Thread Christian König
Am 07.06.24 um 10:33 schrieb Bob Zhou: To avoid null pointer dereference, Check return value and conduct error handling. That doesn't make much sense. At this point the amdgpu_mes_ctx_get_offs_cpu_addr() shouldn't be able to return NULL in the first place. Regards, Christian.

Re: [PATCH 1/2] drm/amdgpu: fix overflowed constant warning in mmhub_set_clockgating()

2024-06-07 Thread Christian König
Am 07.06.24 um 10:33 schrieb Bob Zhou: To fix potential overflowed constant warning, modify the variables to u32 for getting the return value of RREG32_SOC15(). Signed-off-by: Bob Zhou Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c | 2 +-

[PATCH 2/2] drm/amdgpu: fix dereferencing null pointer warning in ring_test_ib()

2024-06-07 Thread Bob Zhou
To avoid null pointer dereference, Check return value and conduct error handling. Signed-off-by: Bob Zhou --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 4 drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 4

[PATCH 1/2] drm/amdgpu: fix overflowed constant warning in mmhub_set_clockgating()

2024-06-07 Thread Bob Zhou
To fix potential overflowed constant warning, modify the variables to u32 for getting the return value of RREG32_SOC15(). Signed-off-by: Bob Zhou --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c | 2 +- drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 2 +-

Re: [PATCH v2] drm/amdgpu: Fix the BO release clear memory warning

2024-06-07 Thread Christian König
Am 06.06.24 um 22:19 schrieb Mario Limonciello: On 6/6/2024 15:04, Arunpravin Paneer Selvam wrote: This happens when the amdgpu_bo_release_notify running before amdgpu_ttm_set_buffer_funcs_status set the buffer funcs to enabled. check the buffer funcs enablement before calling the fill buffer

Re: [PATCH] drm/radeon: remove load callback

2024-06-07 Thread Christian König
Am 07.06.24 um 03:14 schrieb wu hoi pok: this patch is to remove the load callback from the kms_driver, following closly to amdgpu, radeon_driver_load_kms and devm_drm_dev_alloc are used, most of the changes here are rdev->ddev to rdev_to_drm, which maps to adev_to_drm in amdgpu. however this

Re: [PATCH] drm/ttm: Add cgroup memory accounting for GTT memory

2024-06-07 Thread Christian König
Am 06.06.24 um 21:22 schrieb Mukul Joshi: Make sure we do not overflow the memory limits set for a cgroup when doing GTT memory allocations. NAK, That's intentionally not done like that. Please see the cgroup discussion on memory management on the public mailing list. Regards, Christian.

Re: [PATCH] drm/amdgpu: Move SR-IOV check into amdgpu_gfx_sysfs_compute_init

2024-06-07 Thread Christian König
Am 06.06.24 um 19:28 schrieb Lazar, Lijo: On 6/6/2024 5:35 PM, Srinivasan Shanmugam wrote: Previously, this check was performed in the gfx_v9_4_3_sw_init function, and the amdgpu_gfx_sysfs_compute_init function was only called if the GPU was not a VF in SR-IOV mode. This is because the sysfs

[PATCH] drm/amdgpu: avoid using null object of framebuffer

2024-06-07 Thread Julia Zhang
Instead of using state->fb->obj[0] directly, get object from framebuffer by calling drm_gem_fb_get_obj() and return error code when object is null to avoid using null object of framebuffer. Signed-off-by: Julia Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 17 +++-- 1 file

Re: [PATCH] drm/amdgpu: Move SR-IOV check into amdgpu_gfx_sysfs_compute_init

2024-06-07 Thread Lazar, Lijo
On 6/7/2024 12:31 PM, SRINIVASAN SHANMUGAM wrote: > > On 6/6/2024 10:58 PM, Lazar, Lijo wrote: >> On 6/6/2024 5:35 PM, Srinivasan Shanmugam wrote: >>> Previously, this check was performed in the gfx_v9_4_3_sw_init function, >>> and the amdgpu_gfx_sysfs_compute_init function was only called if

Re: [PATCH] drm/amdgpu: Move SR-IOV check into amdgpu_gfx_sysfs_compute_init

2024-06-07 Thread SRINIVASAN SHANMUGAM
On 6/6/2024 10:58 PM, Lazar, Lijo wrote: On 6/6/2024 5:35 PM, Srinivasan Shanmugam wrote: Previously, this check was performed in the gfx_v9_4_3_sw_init function, and the amdgpu_gfx_sysfs_compute_init function was only called if the GPU was not a VF in SR-IOV mode. This is because the sysfs

[PATCH] drm/amd/display: Set default brightness according to ACPI

2024-06-07 Thread Mario Limonciello
Currently, amdgpu will always set up the brightness at 100% when it loads. However this is jarring when the BIOS has it previously programmed to a much lower value. The ACPI ATIF method includes two members for "ac_level" and "dc_level". These represent the default values that should be used if

RE: [PATCH 2/2] drm/amd/pm: update check condition for SMU mode1 reset

2024-06-07 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Thursday, June 6, 2024 18:06 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 2/2] drm/amd/pm: